On Wed, Jul 15, 2020 at 08:36:48AM +0200, Andrew Jones wrote: > On Tue, Jul 14, 2020 at 04:41:41PM +0200, Igor Mammedov wrote: > > > > In this particular case I'd drop versioning. > > > > So it sounds to me like we have some flexibility in our versioned machine > maintenance. We can choose to forgo the usual compat code when the risk is > deemed low enough. And, if somebody screams, we can always fix it later. > I can live with that. I'll go ahead and respin without the versioning. >
Actually this patch was already merged 2c1fb4d5c011 hw/arm/virt-acpi-build: Only expose flash on older machine types and I don't see much value in posting a patch to remove the compat code. Regarding the result of this discussion, my take is that unless the policy is to always or to never use versioning, then I think we should have guidelines documented which we can follow. Would one of the ACPI maintainers like to submit a document with the reasoning for when and when not to use versioning? And also for what's expected of the commit message justification when versioning is necessary? Thanks, drew
