On 7/14/20 4:56 AM, Havard Skinnemoen wrote: > On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater <c...@kaod.org> wrote: >> >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >>> This allows these NPCM7xx-based boards to boot from a flash image, e.g. >>> one built with OpenBMC. For example like this: >>> >>> IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc >>> qemu-system-arm -machine quanta-gsj -nographic \ >>> -bios ~/qemu/bootrom/npcm7xx_bootrom.bin \ >>> -drive file=${IMAGE},if=mtd,bus=0,unit=0,format=raw,snapshot=on >>> >>> Reviewed-by: Tyrone Ting <kft...@nuvoton.com> >>> Signed-off-by: Havard Skinnemoen <hskinnem...@google.com> >> >> May be we don't need to create the flash object if dinfo is NULL. > > It's soldered on the board, so you can't really boot the board without > it. But if you think it's better to remove it altogether if we don't > have an image to load into it, I can do that. > >> >> Reviewed-by: Cédric Le Goater <c...@kaod.org> >> Tested-by: Cédric Le Goater <c...@kaod.org> >> >> Nice ! >> >> We need a SPI controller model and a network device model now. > > Yeah, and i2c, PWM, GPIO, etc., but if you're referring to the kernel > crash, see below.
We don't need all device models but fixing the crash would be better. >> npcm7xx_bootrom.bin is a bit of a pain. Could we include it in >> the QEMU roms ? > > Yeah, I was planning to include this in v6. Good. It will ease CI. >> spi_master spi0: /ahb/fiu@fb000000/spi-nor@0 has no valid >> 'spi-max-frequency' property (-22) >> spi_master spi0: Failed to create SPI device for /ahb/fiu@fb000000/spi-nor@0 > > This is a device tree bug: > > https://github.com/hskinnemoen/openbmc/commit/99b172f88002f4fac939f85debe1187b9c569871 > >> libphy: Fixed MDIO Bus: probed >> 8<--- cut here --- >> Unable to handle kernel paging request at virtual address fffffffe > > I believe this is a kernel bug: > > https://github.com/hskinnemoen/openbmc/commit/77e9f58ba157eabc976f15fa49892128fe2b2382 > > I needed two additional patches to get all the way to the login prompt: > > https://github.com/hskinnemoen/openbmc/commits/20200711-gsj-qemu-0 Great. So are these for mainline or Joel's openbmc branch ? Thanks, C.