Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 17:39, Vladimir Sementsov-Ogievskiy wrote: It's safer to expand in_flight request to start before enter to coroutine in synchronous wrappers, due to the following (theoretical) problem: Consider write. It's possible, that qemu_coroutine_enter only schedules execution, assume such case

Re: [PATCH v2 04/18] qom: Simplify object_property_get_enum()

2020-05-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/5/20 5:29 PM, Markus Armbruster wrote: >> Reuse object_property_get_str(). Switches from the string to the >> qobject visitor under the hood. >> >> Signed-off-by: Markus Armbruster >> --- >> qom/object.c | 11 ++- >> 1 file changed, 2 insertions(

Re: [PATCH v2 05/18] qom: Drop convenience method object_property_get_uint16List()

2020-05-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/05/20 17:29, Markus Armbruster wrote: >> qom/object.c provides object_property_get_TYPE() and >> object_property_set_TYPE() for a number of common types. These are >> all convenience wrappers around object_property_get_qobject() and >> object_property_set_qobject().

Re: [PATCH v2 00/13] microvm: add acpi support

2020-05-06 Thread Sergio Lopez
On Tue, May 05, 2020 at 04:16:00PM +0200, Philippe Mathieu-Daudé wrote: > On 5/5/20 4:04 PM, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 03:42:52PM +0200, Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > > don't want ACPI this is perf

Re: [PATCH v2 11/13] microvm: add acpi_dsdt_add_virtio() for x86

2020-05-06 Thread Sergio Lopez
On Tue, May 05, 2020 at 03:43:03PM +0200, Gerd Hoffmann wrote: > Makes x86 linux kernel find virtio-mmio devices automatically. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-microvm.c | 51 ++ > 1 file changed, 51 insertions(+) Reviewed-by: Sergio

Re: [PATCH v2 13/13] microvm/acpi: use GSI 16-23 for virtio

2020-05-06 Thread Sergio Lopez
On Tue, May 05, 2020 at 03:43:05PM +0200, Gerd Hoffmann wrote: > With ACPI enabled and IO-APIC being properly declared in the ACPI tables > we can use interrupt lines 16-23 for virtio and avoid shared interrupts. > > With acpi disabled we continue to use lines 8-15. > > Signed-off-by: Gerd Hoffma

Re: [PATCH v2 12/13] microvm: make virtio irq base runtime configurable

2020-05-06 Thread Sergio Lopez
On Tue, May 05, 2020 at 03:43:04PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/microvm.h | 2 +- > hw/i386/acpi-microvm.c| 6 +++--- > hw/i386/microvm.c | 11 +++ > 3 files changed, 11 insertions(+), 8 deletions(-) Reviewed-by: Sergio

[PATCH] icount: fix shift=auto for record/replay

2020-05-06 Thread Pavel Dovgalyuk
This patch fixes shift=auto when record/replay is enabled. Now user does not need to guess the best shift value. Signed-off-by: Pavel Dovgalyuk --- cpus.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 5670c96bcf..dfb9f4717f 100644 --- a/cpus.c ++

Re: [PATCH v23 0/4] implement zstd cluster compression method

2020-05-06 Thread Denis Plotnikov
On 05.05.2020 15:03, Max Reitz wrote: On 05.05.20 12:26, Max Reitz wrote: On 30.04.20 12:19, Denis Plotnikov wrote: v23: Undecided: whether to add zstd(zlib) compression details to the qcow2 spec 03: tighten assertion on zstd decompression [Eric] 04: use _rm_test_i

Re: [PATCH v2 3/4] backup: Make sure that source and target size match

2020-05-06 Thread Kevin Wolf
Am 06.05.2020 um 08:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.05.2020 13:03, Kevin Wolf wrote: > > Am 30.04.2020 um 20:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 30.04.2020 17:27, Kevin Wolf wrote: > > > > Since the introduction of a backup filter node in commit 00e30f05d, t

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-05-06 Thread Andreas Weller
Hi Christian. Just filed bug: #1877052 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses after upgrade to Ubuntu 20.04 Status in QEMU: Invalid Status in qemu package

Re: [PATCH v7 0/7] reference implementation of RSS and hash report

2020-05-06 Thread Yuri Benditovich
I'll send v8 soon Thanks, Yuri On Wed, May 6, 2020 at 8:37 AM Jason Wang wrote: > > On 2020/5/1 下午12:01, Yuri Benditovich wrote: > > Michael/Jason, > > > > As Linux headers was updated in qemu and now include RSC/RSS/Hash > > definitions, please let me know what you prefer: > > 1. You apply thi

Re: [PATCH v1 3/4] .cirrus.yml: bump FreeBSD to the current stable release

2020-05-06 Thread Alex Bennée
Li-Wen Hsu writes: > On Fri, May 1, 2020 at 7:15 PM Alex Bennée wrote: >> >> Hopefully this will un-stick the test which has been broken for a long >> time. >> >> Signed-off-by: Alex Bennée >> --- >> .cirrus.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.cir

[PATCH] replay: synchronize on every virtual timer callback

2020-05-06 Thread Pavel Dovgalyuk
Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual clock. Therefore every callback should be logged to make replay deterministic. This patch creates a checkpoint before every virtual timer callback. With these checkpoints virtual timers processing a

[Bug 1877052] [NEW] KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Andreas Weller
Public bug reported: Hello! Unfortunately the bug has apparently reappeared. I have a Windows 10 running in a VM, which after my today's "apt upgrade" goes into pause mode after a few seconds of running time. Until yesterday it used to work and I was able to boot the VM. During the kernel updat

[Bug 1877052] Re: KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Andreas Weller
** Attachment added: "VM's XML configuration file" https://bugs.launchpad.net/qemu/+bug/1877052/+attachment/5367249/+files/win10.xml ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Bug 1877052] Re: KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Andreas Weller
** Attachment added: "Libvirt Logfile" https://bugs.launchpad.net/qemu/+bug/1877052/+attachment/5367244/+files/win10.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877052 Title: KVM Win 10

Re: [PATCH v2 3/4] backup: Make sure that source and target size match

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2020 11:02, Kevin Wolf wrote: Am 06.05.2020 um 08:07 hat Vladimir Sementsov-Ogievskiy geschrieben: 05.05.2020 13:03, Kevin Wolf wrote: Am 30.04.2020 um 20:21 hat Vladimir Sementsov-Ogievskiy geschrieben: 30.04.2020 17:27, Kevin Wolf wrote: Since the introduction of a backup filter node

[Bug 1877052] Re: KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Andreas Weller
** Attachment added: "History.log from apt" https://bugs.launchpad.net/qemu/+bug/1877052/+attachment/5367245/+files/history.log ** Description changed: - Hello! Unfortunately the bug has apparently reappeared. I have a Windows 10 running in a VM, which after my today's "apt upgrade" goe

[Bug 1877052] Re: KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Andreas Weller
** Attachment added: "Dpkg -l Output" https://bugs.launchpad.net/qemu/+bug/1877052/+attachment/5367247/+files/dpkg-list.txt ** Description changed: Hello! Unfortunately the bug has apparently reappeared. I have a Windows 10 running in a VM, which after my today's "apt upgrade" goes into

Re: [PATCH Kernel v18 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-05-06 Thread Yan Zhao
On Mon, May 04, 2020 at 11:58:56PM +0800, Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy conte

[PATCH v2 1/9] hw/net/xilinx_axienet: Auto-clear PHY Autoneg

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Auto-clear PHY CR Autoneg bits. This makes this model work with recent Linux kernels. Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/net/xilinx_axienet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/xilinx_ax

[PATCH v2 0/9] hw/core: stream: Add end-of-packet flag

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, When modeling pipelines of processing nodes that communicate through streaming interfaces (e.g AXI-Stream), some of these nodes send packets while others may just stream unpacketized data. The purpose of this series is to add an end-of-packet flag, e.g what AXI-Str

[PATCH v2 8/9] hw/dma/xilinx_axidma: s2mm: Support stream fragments

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for stream fragments. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- hw/dma/xilinx_axidma.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index 101d32

[PATCH v2 2/9] hw/net/xilinx_axienet: Cleanup stream->push assignment

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Split the shared stream_class_init function to assign stream->push with better type-safety. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/net/xilinx_axienet.c | 18 -- 1 file changed, 12 inserti

[PATCH v2 3/9] hw/net/xilinx_axienet: Remove unncessary cast

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Remove unncessary cast, buf is already uint8_t *. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/net/xilinx_axienet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

[PATCH v2 9/9] MAINTAINERS: Add myself as streams maintainer

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Since we're missing a maintainer, add myself. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f84e3ae2c..d3663d6c9a 100644 --- a/MAINTAINERS +++

[PATCH v2 5/9] hw/core: stream: Add an end-of-packet flag

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Some stream clients stream an endless stream of data while other clients stream data in packets. Stream interfaces usually have a way to signal the end of a packet or the last beat of a transfer. This adds an end-of-packet flag to the push interface. Reviewed-by: Alist

[PATCH v2 4/9] hw/dma/xilinx_axidma: Add DMA memory-region property

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add DMA memory-region property to externally control what address-space this DMA operates on. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/dma/xilinx_axidma.c | 30 +++--- 1 file change

Re: [PATCH v23 0/4] implement zstd cluster compression method

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2020 11:01, Denis Plotnikov wrote: On 05.05.2020 15:03, Max Reitz wrote: On 05.05.20 12:26, Max Reitz wrote: On 30.04.20 12:19, Denis Plotnikov wrote: v23:     Undecided: whether to add zstd(zlib) compression    details to the qcow2 spec     03: tighten assertion on zstd de

[PATCH v2 6/9] hw/net/xilinx_axienet: Handle fragmented packets from DMA

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for fragmented packets from the DMA. Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/net/xilinx_axienet.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/hw/net/xilinx_axi

[PATCH v2 7/9] hw/dma/xilinx_axidma: mm2s: Stream descriptor by descriptor

2020-05-06 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Stream descriptor by descriptor from memory instead of buffering entire packets before pushing. This enables non-packet streaming clients to work and also lifts the limitation that our internal DMA buffer needs to be able to hold entire packets. Reviewed-by: Alistair Fr

Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

2020-05-06 Thread Gerd Hoffmann
Hi, > > crs = aml_resource_template(); > > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > > - 0x10, 0x02)); > > + 0x10, 0x08)); > > aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); > > -aml_append(crs, aml_

Re: [PATCH 1/2] migration/multifd: fix memleaks in multifd_new_send_channel_async

2020-05-06 Thread Juan Quintela
Pan Nengyuan wrote: > When error happen in multifd_new_send_channel_async, 'sioc' will not be used > to create the multifd_send_thread. Let's free it to avoid a memleak. And also > do error_free after migrate_set_error() to avoid another leak in the same > place. > > The leak stack: > Direct leak

Re: [PATCH 2/2] migration/multifd: Do error_free after migrate_set_error to avoid memleaks

2020-05-06 Thread Juan Quintela
Pan Nengyuan wrote: > When error happen in multifd_send_thread, it use error_copy to set migrate > error in > multifd_send_terminate_threads(). We should call error_free after it. > > Similarly, fix another two places in multifd_recv_thread/multifd_save_cleanup. > > The leak stack: > Direct leak

Re: [PATCH v4 07/13] acpi: move aml builder code for parallel device

2020-05-06 Thread Gerd Hoffmann
> > +static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > > +{ > > +ISAParallelState *isa = ISA_PARALLEL(isadev); > > +int i, uid = 0; > > +Aml *dev; > > +Aml *crs; > > + > > +for (i = 0; i < ARRAY_SIZE(isa_parallel_io); i++) { > > +if (isa->iobase == isa_

Re: [PATCH] s390x: pv: Fix KVM_PV_PREP_RESET command wrapper name

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 08:41:59 -0400 Janosch Frank wrote: > s390_pv_perf_clear_reset() is not a very helpful name since that > function needs to be called for a normal and a clear reset via > diag308. > > Let's instead name it s390_pv_prep_reset() which reflects the purpose > of the function a bit

Re: [PATCH v2 3/5] vhost-user-blk: add mechanism to track the guest notifiers init state

2020-05-06 Thread Dima Stepanov
On Sun, May 03, 2020 at 09:06:38PM -0400, Raphael Norwitz wrote: > Apologies for mixing up patches last time. This looks good from a > vhost-user-blk perspective, but I worry that some of these changes > could impact other vhost device types. > > I agree with adding notifiers_set to struct vhost_d

Re: [PATCH v2 2/5] vhost: introduce wrappers to set guest notifiers for virtio device

2020-05-06 Thread Dima Stepanov
On Sun, May 03, 2020 at 08:36:45PM -0400, Raphael Norwitz wrote: > I’m happy from the vhost, vhost-user-blk and vhost-user-scsi side. For > other device types it looks pretty straightforward, but their maintainers > should probably confirm. > > Since you plan to change the behavior of these helper

Re: [PATCH v2 1/5] char-socket: return -1 in case of disconnect during tcp_chr_write

2020-05-06 Thread Li Feng
Thanks, Feng Li Dima Stepanov 于2020年4月30日周四 下午9:36写道: > > During testing of the vhost-user-blk reconnect functionality the qemu > SIGSEGV was triggered: > start qemu as: > x86_64-softmmu/qemu-system-x86_64 -m 1024M -M q35 \ >-object > memory-backend-file,id=ram-node0,size=1024M,mem-path=/

[PATCH 0/8] drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
Hi all! This is first step to block-status refactoring, and solves most simple problem mentioned in my investigation of block-status described in the thread "backing chain & block status & filters": https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html unallocated_blocks_are_zero

[PATCH 2/8] block/vpc: return ZERO block-status when appropriate

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
In case when get_image_offset() returns -1, we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blo

[PATCH 5/8] block/file-posix: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
raw_co_block_status() in block/file-posix.c never returns 0, so unallocated_blocks_are_zero is useless. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/file-posix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 05e094be29..5c01

[PATCH 4/8] block/iscsi: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
We set bdi->unallocated_blocks_are_zero = iscsilun->lbprz, but iscsi_co_block_status doesn't return 0 in case of iscsilun->lbprz, it returns ZERO when appropriate. So actually unallocated_blocks_are_zero is useless. Drop it now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/iscsi.c | 1 -

[PATCH 1/8] block/vdi: return ZERO block-status when appropriate

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense. Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/vdi.c | 3

[PATCH 8/8] block: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
Currently this field only set by qed and qcow2. But in fact, all backing-supporting formats (parallels, qcow, qcow2, qed, vmdk) share this semantics: on unallocated blocks, if there is no backing file they just memset the buffer with zeroes. So, document this behavior for .supports_backing and dro

[PATCH 3/8] block/crypto: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
It's false by default, no needs to set it. We are going to drop this variable at all, so drop it now here, it doesn't hurt. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/crypto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index e02f343590..7685e618

[PATCH 6/8] block/vhdx: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is always assumed for it. unallocated_blocks_are_zero is useless, drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/vhdx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index aedd7

[PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
qemu-img convert wants to distinguish ZERO which comes from short backing files. unallocated_blocks_are_zero field of bdi is unrelated: space after EOF is always considered to be zero anyway. So, just make post_backing_zero true in case of short backing file. Signed-off-by: Vladimir Sementsov-Ogie

Re: [PATCH v2 1/5] char-socket: return -1 in case of disconnect during tcp_chr_write

2020-05-06 Thread Marc-André Lureau
On Thu, Apr 30, 2020 at 3:37 PM Dima Stepanov wrote: > > During testing of the vhost-user-blk reconnect functionality the qemu > SIGSEGV was triggered: > start qemu as: > x86_64-softmmu/qemu-system-x86_64 -m 1024M -M q35 \ >-object > memory-backend-file,id=ram-node0,size=1024M,mem-path=/dev

[PATCH v1 01/17] exec: Introduce ram_block_discard_set_(unreliable|required)()

2020-05-06 Thread David Hildenbrand
We want to replace qemu_balloon_inhibit() by something more generic. Especially, we want to make sure that technologies that really rely on RAM block discards to work reliably to run mutual exclusive with technologies that break it. E.g., vfio will usually pin all guest memory, turning the virtio-

[PATCH v1 03/17] accel/kvm: Convert to ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
Discarding memory does not work as expected. At the time this is called, we cannot have anyone active that relies on discards to work properly. Cc: Paolo Bonzini Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/accel/

[PATCH v1 02/17] vfio: Convert to ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
VFIO is (except devices without a physical IOMMU or some mediated devices) incompatible ram_block_discard_set_broken. The kernel will pin basically all VM memory. Let's convert to ram_block_discard_set_broke(), which can now fail, in contrast to qemu_balloon_inhibit(). Leave "x-balloon-allowed" na

[PATCH v1 00/17] virtio-mem: Paravirtualized memory hot(un)plug

2020-05-06 Thread David Hildenbrand
This is the very basic, initial version of virtio-mem. More info on virtio-mem in general can be found in the Linux kernel driver posting [1] and in patch #10. "The basic idea of virtio-mem is to provide a flexible, cross-architecture memory hot(un)plug solution that avoids many limitations impose

[PATCH v1 15/17] pc: Support for virtio-mem-pci

2020-05-06 Thread David Hildenbrand
Let's wire it up similar to virtio-pmem. Also disallow unplug, so it's harder for users to shoot themselves into the foot. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: David Hild

[PATCH v1 09/17] linux-headers: update to contain virtio-mem

2020-05-06 Thread David Hildenbrand
To be merged hopefully soon. Then, we can replace this by a proper header sync. Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_mem.h | 208 2 files changed, 209 inserti

[PATCH v1 06/17] target/i386: sev: Use ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
AMD SEV will pin all guest memory, mark discarding of RAM broken. At the time this is called, we cannot have anyone active that relies on discards to work properly. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: David Hildenbrand --- targe

[PATCH v1 17/17] virtio-pci: Send qapi events when the virtio-mem size changes

2020-05-06 Thread David Hildenbrand
Let's register the notifier and trigger the qapi event with the right device id. MEMORY_DEVICE_SIZE_CHANGE is similar to BALLOON_CHANGE, however on a memory device level. Don't unregister the notifier (we neither have finalize() nor unrealize() for VirtIOPCIProxy, so it's not that simple to do it

[PATCH v1 04/17] s390x/pv: Convert to ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
Discarding RAM does not work as expected with protected VMs. Let's switch to ram_block_discard_set_broken() for now, as we want to get rid of qemu_balloon_inhibit(). Note that it will currently never fail, but might fail in the future with new technologies (e.g., virtio-mem). Cc: Richard Henderson

[PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
RDMA will pin all guest memory (as documented in docs/rdma.txt). We want to mark RAM block discards to be broken - however, to keep it simple use ram_block_discard_is_required() instead of inhibiting. Cc: "Michael S. Tsirkin" Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Signed-off-by: David H

[PATCH v1 16/17] virtio-mem: Allow notifiers for size changes

2020-05-06 Thread David Hildenbrand
We want to send qapi events in case the size of a virtio-mem device changes. This allows upper layers to always know how much memory is actually currently consumed via a virtio-mem device. Unfortuantely, we have to report the id of our proxy device. Let's provide an easy way for our proxy device t

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-06 Thread Auger Eric
Hi, On 5/6/20 8:33 AM, Andrew Jones wrote: > On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: >> We plan to build the tpm2 table on ARM too. In order to reuse the >> generation code, let's move build_tpm2() to aml-build.c. >> >> No change in the implementation. >> >> Signed-off-by: Eric

[PATCH v1 08/17] migration/colo: Use ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
COLO will copy all memory in a RAM block, mark discarding of RAM broken. Cc: "Michael S. Tsirkin" Cc: Hailiang Zhang Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Signed-off-by: David Hildenbrand --- include/migration/colo.h | 2 +- migration/migration.c| 8 +++- migration/savevm.

[PATCH v1 05/17] virtio-balloon: Rip out qemu_balloon_inhibit()

2020-05-06 Thread David Hildenbrand
The only remaining special case is postcopy. It cannot handle concurrent discards yet, which would result in requesting already sent pages from the source. Special-case it in virtio-balloon instead. Cc: "Michael S. Tsirkin" Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Signed-off-by: David Hil

[PATCH v1 13/17] hmp: Handle virtio-mem when printing memory device info

2020-05-06 Thread David Hildenbrand
Print the memory device info just like for other memory devices. Cc: "Dr. David Alan Gilbert" Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- monitor/hmp-cmds.c | 16 1 file changed, 16 insertions(+) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 7f6

[PATCH v1 11/17] virtio-pci: Proxy for virtio-mem

2020-05-06 Thread David Hildenbrand
Let's add a proxy for virtio-mem, make it a memory device, and pass-through the properties. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: "Dr. David Alan Gilbert" Cc: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-mem-pci.c | 131 +

[PATCH v1 14/17] numa: Handle virtio-mem in NUMA stats

2020-05-06 Thread David Hildenbrand
Account the memory to the configured nid. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- hw/core/numa.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/core/numa.c b/hw/core/numa.c index 316bc50d75..06960918e7 100644 --- a/h

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-06 Thread Michael S. Tsirkin
On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > I realize this function is just getting moved, but maybe it should get > converted to the build_append* API while being moved? I'd rather refactoring was done in a separate patch - easier to review. -- MST

Re: [PATCH RFC 1/4] migration: Export migration_bitmap_sync_precopy()

2020-05-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Make it usable outside migration. To make it easier to use, remove the > RAMState parameter since after all ram.c has the reference of ram_state > directly from its context. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > includ

RE: [PATCH v2 01/10] net: cadence_gem: Fix debug statements

2020-05-06 Thread Sai Pavan Boddu
Hi Edgar, Below comments will be taken care in V3. Thanks, Sai Pavan > -Original Message- > From: Edgar E. Iglesias > Sent: Monday, May 4, 2020 8:09 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho

[PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug

2020-05-06 Thread David Hildenbrand
This is the very basic/initial version of virtio-mem. An introduction to virtio-mem can be found in the Linux kernel driver [1]. While it can be used in the current state for hotplug of a smaller amount of memory, it will heavily benefit from resizeable memory regions in the future. Each virtio-me

Re: [PATCH 1/5] roms/opensbi: Update to support building bios images for generic platform

2020-05-06 Thread Bin Meng
Hi Alistair, On Tue, May 5, 2020 at 12:00 AM Alistair Francis wrote: > > On Mon, May 4, 2020 at 1:05 AM Bin Meng wrote: > > > > On Mon, May 4, 2020 at 4:00 PM Bin Meng wrote: > > > > > > Hi Anup, > > > > > > On Mon, May 4, 2020 at 3:52 PM Anup Patel wrote: > > > > > > > > On Mon, May 4, 2020 a

[PATCH v1 12/17] MAINTAINERS: Add myself as virtio-mem maintainer

2020-05-06 Thread David Hildenbrand
Let's make sure patches/bug reports find the right person. Cc: "Michael S. Tsirkin" Cc: Peter Maydell Cc: Markus Armbruster Signed-off-by: David Hildenbrand --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f84e3ae2c..09fff9e1bd 10064

Re: [PATCH 2/2] qemu-img: Add --start-offset and --max-length to map

2020-05-06 Thread Eyal Moscovici
Thanks for the review. I will send V2 based on QEMU version 5.0. On 29/04/2020, 18:06, "Eric Blake" wrote: On 3/22/20 4:11 AM, Eyal Moscovici wrote: > The mapping operation of large disks especially ones stored over a > long chain of QCOW2 files can take a long time to finish. >

Re: [PATCH v2 05/13] acpi: move acpi_init_common_fadt_data to acpi-common.c

2020-05-06 Thread Gerd Hoffmann
On Tue, May 05, 2020 at 04:25:55PM +0200, Igor Mammedov wrote: > On Tue, 5 May 2020 15:42:57 +0200 > Gerd Hoffmann wrote: > > the same question like with FACS, why legacy data are needed for with reduced > profile? > it mostly initializes data for fixed-hw model. > > I'd preffer if you drop FA

Re: [PATCH 1/2] qemu-img: refactor dump_map_entry JSON format output

2020-05-06 Thread Eyal Moscovici
On 29/04/2020, 17:58, "Eric Blake" wrote: On 3/22/20 4:11 AM, Eyal Moscovici wrote: > Previously dump_map_entry identified whether we need to start a new JSON > array based on whether start address == 0. In this refactor we remove > this assumption as in following patches we w

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

2020-05-06 Thread Cornelia Huck
On Wed, 6 May 2020 02:38:46 -0400 Yan Zhao wrote: > On Tue, May 05, 2020 at 12:37:26PM +0800, Alex Williamson wrote: > > It's been a long time, but that doesn't seem like what I was asking. > > The sysfs version checking is used to select a target that is likely to > > succeed, but the migration

Re: [PATCH RFC 2/4] migration: Introduce migrate_is_precopy()

2020-05-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Export a helper globally to check whether we're during a precopy. > > Signed-off-by: Peter Xu Can you change this to 'migration_in_precopy' to match the existing 'migration_in_postcopy'. Dave > --- > include/migration/misc.h | 1 + > migration/migration.

Re: [PATCH v5 11/31] qcow2: Add offset_into_subcluster() and size_to_subclusters()

2020-05-06 Thread Alberto Garcia
On Tue 05 May 2020 09:42:08 PM CEST, Eric Blake wrote: > On 5/5/20 12:38 PM, Alberto Garcia wrote: >> Like offset_into_cluster() and size_to_clusters(), but for >> subclusters. >> >> Signed-off-by: Alberto Garcia >> --- >> block/qcow2.h | 10 ++ >> 1 file changed, 10 insertions(+) >>

Re: [PATCH v2 08/13] acpi: generic event device for x86

2020-05-06 Thread Gerd Hoffmann
On Tue, May 05, 2020 at 05:03:16PM +0200, Igor Mammedov wrote: > On Tue, 5 May 2020 15:43:00 +0200 > Gerd Hoffmann wrote: > > > Uses TYPE_ACPI_GED as QOM parent for code reuse. > > Add registers for sleep states and reset. > > Add powerdown notifier for power button events. > registers aren't x8

Re: [PATCH v18 QEMU 16/18] vfio: Add ioctl to get dirty pages bitmap during dma unmap.

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 04:14:51 +0530 Kirti Wankhede wrote: > With vIOMMU, IO virtual address range can get unmapped while in pre-copy > phase of migration. In that case, unmap ioctl should return pages pinned > in that range and QEMU should find its correcponding guest physical > addresses and repor

Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-06 Thread Gerd Hoffmann
> > +/* FIXME: copy & paste */ > > +static void acpi_dsdt_add_power_button(Aml *scope) > > +{ > > +Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > +aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > +aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > +aml_a

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > After the series this patch belongs to, we want to have a common > BdrvChildClass that encompasses all of child_file, child_format, and > child_backing. Such a single class needs a single .inherit_options() > implementation, and this patch introd

RE: [PATCH v2 04/10] net: cadence_gem: Define access permission for interrupt registers

2020-05-06 Thread Sai Pavan Boddu
Hi Edgar, > -Original Message- > From: Edgar E. Iglesias > Sent: Monday, May 4, 2020 8:27 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho ; Ramon Fried > ; qemu-...@nongnu.org; qemu- > de...@nongnu.

Re: [PATCH Kernel v18 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-05-06 Thread Cornelia Huck
On Mon, 4 May 2020 21:28:56 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content of

Re: [PATCH RFC 3/4] vl: Sync dirty bits for system resets during precopy

2020-05-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > System resets will also reset system memory layout. Although the memory > layout > after the reset should probably the same as before the reset, we still need to > do frequent memory section removals and additions during the reset process. > Those operation

RE: [PATCH v2 05/10] net: cadence_gem: Set ISR according to queue in use

2020-05-06 Thread Sai Pavan Boddu
Hi Edgar, > -Original Message- > From: Edgar E. Iglesias > Sent: Monday, May 4, 2020 8:32 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho ; Ramon Fried > ; qemu-...@nongnu.org; qemu- > de...@nongnu.

Re: [PATCH v25 08/10] ACPI: Record Generic Error Status Block(GESB) table

2020-05-06 Thread gengdongjiu
On 2020/5/5 18:44, Igor Mammedov wrote: >> Signed-off-by: Dongjiu Geng >> Signed-off-by: Xiang Zheng > Reviewed-by: Igor Mammedov > > Also we should ratelimit error messages that could be triggered at runtime > from acpi_ghes_record_errors() and functions it's calling. > It could be a patch

Re: [INFO] Some preliminary performance data

2020-05-06 Thread Alex Bennée
Aleksandar Markovic writes: Some preliminary thoughts >> Hi, all. >> >> I just want to share with you some bits and pieces of data that I got >> while doing some preliminary experimentation for the GSoC project "TCG >> Continuous Benchmarking", that Ahmed Karaman, a student of the fourth f

Re: [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes,eaes}-256

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 17:29:17 +0200 Markus Armbruster wrote: > Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and > s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is > "pcc-cmac-eaes-256". The former is obviously a pasto. > > Impact: > > * s390_feat_bitmap_to_ascii() misidentifies S390_FE

Re: [PATCH v2 2/9] hw/net/xilinx_axienet: Cleanup stream->push assignment

2020-05-06 Thread Philippe Mathieu-Daudé
On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Split the shared stream_class_init function to assign stream->push with better type-safety. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-D

Re: [PATCH v2 3/9] hw/net/xilinx_axienet: Remove unncessary cast

2020-05-06 Thread Philippe Mathieu-Daudé
On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Remove unncessary cast, buf is already uint8_t *. Typo "unnecessary" here and in patch subject. Otherwise: Reviewed-by: Philippe Mathieu-Daudé No functional change. Reviewed-by: Alistair Francis Reviewed-by: Francisco

Re: [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes,eaes}-256

2020-05-06 Thread David Hildenbrand
On 05.05.20 17:29, Markus Armbruster wrote: > Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and > s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is > "pcc-cmac-eaes-256". The former is obviously a pasto. > > Impact: > > * s390_feat_bitmap_to_ascii() misidentifies S390_FEAT_PCC_CMAC_AES_25

Re: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-05-06 Thread gengdongjiu
On 2020/4/17 21:32, Peter Maydell wrote: > On Fri, 10 Apr 2020 at 12:46, Dongjiu Geng wrote: >> >> In the ARMv8 platform, the CPU error types includes synchronous external >> abort(SEA) >> and SError Interrupt (SEI). If exception happens in guest, host does not >> know the detailed >> informatio

Re: [PATCH v2 4/9] hw/dma/xilinx_axidma: Add DMA memory-region property

2020-05-06 Thread Philippe Mathieu-Daudé
Hi Edgar, On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add DMA memory-region property to externally control what address-space this DMA operates on. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/dma/xilinx_

Re: [PATCH v2 00/13] microvm: add acpi support

2020-05-06 Thread Gerd Hoffmann
On Tue, May 05, 2020 at 10:04:02AM -0400, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 03:42:52PM +0200, Gerd Hoffmann wrote: > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to

Re: [PATCH v2 00/13] microvm: add acpi support

2020-05-06 Thread Michael S. Tsirkin
On Wed, May 06, 2020 at 01:46:35PM +0200, Gerd Hoffmann wrote: > On Tue, May 05, 2020 at 10:04:02AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 03:42:52PM +0200, Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > > don't want ACP

Re: [PATCH v2 5/9] hw/core: stream: Add an end-of-packet flag

2020-05-06 Thread Philippe Mathieu-Daudé
Hi Edgar, On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Some stream clients stream an endless stream of data while other clients stream data in packets. Stream interfaces usually have a way to signal the end of a packet or the last beat of a transfer. This adds an end

Re: [PATCH v2 9/9] MAINTAINERS: Add myself as streams maintainer

2020-05-06 Thread Philippe Mathieu-Daudé
On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Since we're missing a maintainer, add myself. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f8

[PULL 02/14] .travis.yml: drop MacOSX

2020-05-06 Thread Alex Bennée
This keeps breaking on Travis so lets just fall back to the Cirrus CI builds which seem to be better maintained. Fix up the comments while we are doing this as we never had a windows build. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Message-Id: <2

  1   2   3   >