On Sun, May 03, 2020 at 09:06:38PM -0400, Raphael Norwitz wrote: > Apologies for mixing up patches last time. This looks good from a > vhost-user-blk perspective, but I worry that some of these changes > could impact other vhost device types. > > I agree with adding notifiers_set to struct vhost_dev, and setting it in > vhost_dev_enable/disable notifiers, but is there any reason notifiers_set > can’t be checked inside vhost-user-blk? Thanks for your review. I also have some concerns about changing current API, but my idea was that these issues will be triggered for all vhost-user/reconnect devices. But maybe you are right and first we should fix vhost-user-blk issues. I'll try to modify patch 2 and 3 in my patchset, so new notifiers_set field will be added, but no API change will be made. Will see how it looks.
- Re: [PATCH v2 2/5] vhost: introduce wrappers t... Dima Stepanov
- [PATCH v2 4/5] vhost: check vring address before callin... Dima Stepanov
- Re: [PATCH v2 4/5] vhost: check vring address befo... Raphael Norwitz
- Re: [PATCH v2 4/5] vhost: check vring address befo... Jason Wang
- Re: [PATCH v2 4/5] vhost: check vring address ... Dima Stepanov
- [PATCH v2 1/5] char-socket: return -1 in case of discon... Dima Stepanov
- Re: [PATCH v2 1/5] char-socket: return -1 in case ... Li Feng
- Re: [PATCH v2 1/5] char-socket: return -1 in case ... Marc-André Lureau
- [PATCH v2 3/5] vhost-user-blk: add mechanism to track t... Dima Stepanov
- Re: [PATCH v2 3/5] vhost-user-blk: add mechanism t... Raphael Norwitz
- Re: [PATCH v2 3/5] vhost-user-blk: add mechani... Dima Stepanov
- [PATCH v2 5/5] vhost: add device started check in migra... Dima Stepanov
- Re: [PATCH v2 5/5] vhost: add device started check... Raphael Norwitz
- Re: [PATCH v2 5/5] vhost: add device started c... Michael S. Tsirkin
- Re: [PATCH v2 5/5] vhost: add device started c... Dima Stepanov
- Re: [PATCH v2 5/5] vhost: add device start... Raphael Norwitz
- Re: [PATCH v2 5/5] vhost: add device s... Dima Stepanov
- Re: [PATCH v2 5/5] vhost: add device started check... Jason Wang
- Re: [PATCH v2 5/5] vhost: add device started c... Dima Stepanov