On Tue, 5 May 2020 17:29:17 +0200
Markus Armbruster <arm...@redhat.com> wrote:
> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and
> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is
> "pcc-cmac-eaes-256". The former is obviously a pasto.
>
> Impact:
>
> * s390_feat_bitmap_to_ascii() misidentifies S390_FEAT_PCC_CMAC_AES_256
> as "pcc-cmac-eaes-256". Affects QMP commands query-cpu-definitions,
> query-cpu-model-expansion, query-cpu-model-baseline,
> query-cpu-model-comparison, and the error message when
> s390_realize_cpu_model() fails in check_compatibility().
>
> * s390_cpu_list() also misidentifies it. Affects -cpu help.
>
> * s390_cpu_model_register_props() creates CPU property
> "pcc-cmac-eaes-256" twice. The second one fails, but the error is
> ignored (a later commit will change that). Results in a single
> property "pcc-cmac-eaes-256" with the description for
> S390_FEAT_PCC_CMAC_AES_256, and no property for
> S390_FEAT_PCC_CMAC_EAES_256. CPU properties are visible in CLI -cpu
> and -device, QMP & HMP device_add, QMP device-list-properties, and
> QOM introspection.
>
> Fix by deleting the wayward 'e'.
>
> Fixes: 782417446279717aa85320191a519b51f6d5dd31
I like the more standard
Fixes: 782417446279 ("s390x/cpumodel: introduce CPU features")
for that.
> Cc: Halil Pasic <pa...@linux.ibm.com>
> Cc: Cornelia Huck <coh...@redhat.com>
> Cc: Christian Borntraeger <borntrae...@de.ibm.com>
> Cc: Richard Henderson <r...@twiddle.net>
> Cc: David Hildenbrand <da...@redhat.com>
> Cc: qemu-s3...@nongnu.org
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> Reviewed-by: David Hildenbrand <da...@redhat.com>
> Tested-by: Christian Borntraeger <borntrae...@de.ibm.com>
> ---
> target/s390x/cpu_features_def.inc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <coh...@redhat.com>
I assume you'll take this one together with the rest of the series?
