> > +/* FIXME: copy & paste */
> > +static void acpi_dsdt_add_power_button(Aml *scope)
> > +{
> > + Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> > + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> > + aml_append(scope, dev);
> > +}
>
> could be unified with ARM's version
Yep. Suggestions for a good place? hw/acpi/aml-build.c ?
> > + acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
> > + acpi_align_size(tables->linker->cmd_blob, ACPI_BUILD_ALIGN_SIZE);
> I'd drop these as that was mostly to counter various migration issues on
> legacy
Dropped.
take care,
Gerd
