Re: [PATCH v2 06/10] net: cadence_gem: Add support for jumbo frames

On Mon, May 04, 2020 at 07:36:04PM +0530, Sai Pavan Boddu wrote: > Jumbo frames of size 10240 bytes is added. Hi Sai, I think we should make this a property since it's a design configuration option (10240 being the default). > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 5

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

Cornelia Huck writes: > On Wed, 29 Apr 2020 07:51:04 +0200 > Markus Armbruster wrote: > >> David Hildenbrand writes: >> >> > On 24.04.20 21:20, Markus Armbruster wrote: >> >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API >> >> violations" neglected to change visit_end_

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

On Mon, 4 May 2020 at 16:11, Paolo Bonzini wrote: > > On 04/05/20 16:38, Markus Armbruster wrote: > > makes no progreess because OBJECT(dev)->parent is still null, and > > therefore object_unparent() does nothing. > > > > Possible culprit: qdev_try_create() calls qdev_set_parent_bus(), which > > a

Re: [PATCH v2 07/10] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg

On Mon, May 04, 2020 at 07:36:05PM +0530, Sai Pavan Boddu wrote: > Advertise support of clear-on-read for ISR registers. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/h

Re: [PATCH 02/17] qom: Clean up inconsistent use of gchar * vs. char *

Daniel P. Berrangé writes: > On Sat, May 02, 2020 at 07:06:38AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 4/28/20 11:34 AM, Markus Armbruster wrote: >> >> Uses of gchar * in qom/object.h: >> >> >> > >> > Nice audit. I don't know if we can blindly assume that 'gchar' is a

Re: [PATCH 00/17] qom: Spring cleaning

Paolo Bonzini writes: > On 28/04/20 18:34, Markus Armbruster wrote: >> Includes one actual bug fix for s390x. > > I reviewed everything except patch 8 and it looks good. Thanks very much! May I add Reviewed-by: Paolo Bonzini ?

Re: [PATCH v2 08/10] net: cadence_gem: Update the reset value for interrupt mask register

On Mon, May 04, 2020 at 07:36:06PM +0530, Sai Pavan Boddu wrote: > Mask all interrupt on reset. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c

[PATCH v3 02/12] configure: Avoid building TCG when not needed

Avoid building TCG when building only tools: ./configure --enable-tools --disable-system --disable-user This saves us from running the soft-float tests enabled since commit 76170102508. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- configure | 4 1 file chang

[PATCH v3 00/12] user-mode: Prune build dependencies (part 1)

This is the first part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Part 1 (generic): - reduce user-mode object list - remove some migration code from user-mode - remove cpu_get_crash_info() This se

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

On Mon, 04 May 2020 17:24:59 +0200 Markus Armbruster wrote: > Cornelia Huck writes: > > > On Wed, 29 Apr 2020 07:51:04 +0200 > > Markus Armbruster wrote: > > > >> David Hildenbrand writes: > >> > >> > On 24.04.20 21:20, Markus Armbruster wrote: > >> >> Commit e47970f51d "s390x/cpumod

[PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled

Do not build the virtiofsd helper when configured with --disable-system. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 34275f57c9..e46b6ef5d4 100644 --- a/Makefile +

[PATCH v3 03/12] tests/Makefile: Only display TCG-related tests when TCG is available

Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 03a74b60f6..6bc3d1096b 100644 --- a/tests/Makefile.include ++

Re: [PATCH v1 1/9] hw/net/xilinx_axienet: Auto-clear PHY Autoneg

On [2020 Apr 30] Thu 18:24:31, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Auto-clear PHY CR Autoneg bits. This makes this model > work with recent Linux kernels. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/net/xilinx_axienet.c | 4 ++-- > 1

[PATCH v3 04/12] tests/Makefile: Restrict some softmmu-only tests

In the next commit we are going to remove some objects from the util-obj-y variable (objects which are not used by user-mode, when configured with --disable-system). Then some system-mode tests are going to fail, due to the missing objects: $ make check-unit -k LINKtests/test-iov /usr/

Re: [PATCH v1 2/9] hw/net/xilinx_axienet: Cleanup stream->push assignment

On [2020 Apr 30] Thu 18:24:32, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Split the shared stream_class_init function to assign > stream->push with better type-safety. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/net/xilinx_axienet.c | 18 +++

Re: [PATCH v2 09/10] net: cadence_gem: TX_LAST bit should be set by guest

On Mon, May 04, 2020 at 07:36:07PM +0530, Sai Pavan Boddu wrote: > TX_LAST bit should not be set by hardware, its set by guest to inform > the last bd of the frame. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Edgar E. Iglesias > --- > hw/net/cadence_ge

[PATCH v3 06/12] stubs/Makefile: Reduce the user-mode object list

These stubs are not required when configured with --disable-system. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- stubs/Makefile.objs | 52 ++--- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/stubs/Makefile.obj

[PATCH v3 05/12] util/Makefile: Reduce the user-mode object list

These objects are not required when configured with --disable-system. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- util/Makefile.objs | 59 +- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/util/Makefile.ob

Re: [PATCH v1 3/9] hw/net/xilinx_axienet: Remove unncessary cast

On [2020 Apr 30] Thu 18:24:33, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Remove unncessary cast, buf is already uint8_t *. > No functional change. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/net/xilinx_axienet.c | 2 +- > 1 file changed, 1

[PATCH v3 07/12] target/riscv/cpu: Restrict CPU migration to system-mode

Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 059d71f2c7..6c78337858 100644 --- a/target/riscv/cpu.

[PATCH v3 11/12] target/s390x: Restrict CpuClass::get_crash_info() to system-mode

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index f2ccf0a06a..afb82206c7 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu

Re: [PATCH v1 4/9] hw/dma/xilinx_axidma: Add DMA memory-region property

On [2020 Apr 30] Thu 18:24:34, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add DMA memory-region property to externally control what > address-space this DMA operates on. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/dma/xilinx_axidma.c | 30 ++

[PATCH v3 12/12] hw/core: Restrict CpuClass::get_crash_info() to system-mode

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 7 ++- hw/core/cpu.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 5bf94d28cf..0d1f9e084f 100644 --- a/include/

[PATCH v3 08/12] exec: Assert CPU migration is not used on user-only build

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- exec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 2874bb5088..3a39ffb1eb 100644 --- a/exec.c +++ b/exec.c @@ -946,7 +946,9 @@ void cpu_exec_realizefn(CPUState *cpu, Error **

[PATCH v3 09/12] arch_init: Remove unused 'qapi-commands-misc.h' include

Commit ffaee83bcb2 moved qmp_query_target but forgot to remove this include. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- arch_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index d9eb0ec1dd..8afea47

[PATCH v3 10/12] target/i386: Restrict CpuClass::get_crash_info() to system-mode

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 9c256ab159..eec1ac7cea 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6848,6

[PATCH RFC] target/arm: Implement SVE2 fp multiply-add long

Implements FMLALB, FMLALT, FMLSLB, FMLSLT Signed-off-by: Stephen Long --- target/arm/helper-sve.h| 5 target/arm/sve.decode | 6 target/arm/sve_helper.c| 27 ++ target/arm/translate-sve.c | 58 ++ 4 files changed, 96 in

Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty

On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote: > Since 5.0 QEMU uses hostmem backend for allocating main guest RAM. > The backend however calls mbind() which is typically NOP > in case of default policy/absent host-nodes bitmap. > However when runing in container with black-listed m

Re: [PATCH v2 10/10] net: cadence_gem: Fix RX address filtering

On Mon, May 04, 2020 at 07:36:08PM +0530, Sai Pavan Boddu wrote: > From: Tong Ho > > Two defects are fixed: > > 1/ Detection of multicast frames > 2/ Treating drop of mis-addressed frames as non-error Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Tong Ho > Signed-off-by: Edgar E. Igle

Re: [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

+Keith new email On 5/4/20 11:46 AM, Philippe Mathieu-Daudé wrote: The NVMe device should not use target specific API. Use memory_region_do_writeback() (which was introduced in commit 61c490e25e0, after the NVMe emulated device was added) to replace qemu_ram_writeback(). Signed-off-by: Philippe

Re: [PATCH v3 02/12] configure: Avoid building TCG when not needed

On Mon, May 4, 2020 at 8:29 AM Philippe Mathieu-Daudé wrote: > > Avoid building TCG when building only tools: > > ./configure --enable-tools --disable-system --disable-user > > This saves us from running the soft-float tests enabled since > commit 76170102508. > > Reviewed-by: Richard Henderson

Re: [PATCH v3 08/12] exec: Assert CPU migration is not used on user-only build

On Mon, May 4, 2020 at 8:41 AM Philippe Mathieu-Daudé wrote: > > Reviewed-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > exec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/exec.c b/exec.c > index 2

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

Hi On Mon, May 4, 2020 at 4:27 PM Colin Walters wrote: > > > > On Mon, May 4, 2020, at 10:07 AM, Marc-André Lureau wrote: > > > Now that systemd-nspawn works without privileges, isn't that also a > > solution? One that would fit both system and session level > > permissions, and integration with

Re: [PATCH v5 0/5] vhost-user block device backend implementation

On Mon, Mar 09, 2020 at 06:03:37PM +0800, Coiby Xu wrote: > v5: > * re-use vu_kick_cb in libvhost-user > * keeping processing VhostUserMsg in the same coroutine until there is >detachment/attachment of AIOContext > * Spawn separate coroutine for each VuVirtqElement > * Other changes includi

[PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

After commit f01643fb8b47e8a70c04bbf45e0f12a9e5bc54de when an image is extended and BDRV_REQ_ZERO_WRITE is set then the new clusters are zeroized. The code however does not detect correctly situations when the old and the new end of the image are within the same cluster. The problem can be reprodu

Re: [PATCH v2 00/10] Cadence GEM Fixes

On Mon, May 4, 2020 at 5:14 PM Sai Pavan Boddu wrote: > > Hi, > > Following patch series fixes issues with priority queues, > Adds JUMBO Frame support, > Makes Debug statements compilable & > Fixes related to multicast frames. > > Changes for V2: > Fixed build failure on fedora docker mach

Re: [PATCH 00/17] qom: Spring cleaning

On 04/05/20 17:28, Markus Armbruster wrote: >> I reviewed everything except patch 8 and it looks good. Thanks very much! > May I add Reviewed-by: Paolo Bonzini ? > For those 16 yes. Paolo

[PULL v2 00/19] Trivial branch for 5.1 patches

ch-for-5.1-pull-request for you to fetch changes up to e702fba83108519618046a2a09235a62e3a81595: hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning (202= 0-05-04 14:43:24 +0200) trivial patches (20200504) Sil

[PULL v2 08/19] MAINTAINERS: Update Keith Busch's email address

From: Philippe Mathieu-Daudé keith.bu...@intel.com address is being rejected. Replace by the email address Keith is actively using. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Keith Busch Message-Id: <20200421122236.24867-1-f4...@amsat.org> Signed-off-by: Laurent Vivier --- MAINTAINERS |

[PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write()

From: Chen Qun Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200325025919.21316-2-kuhn.chen...@hua

[PULL v2 06/19] hw/mem/pc-dimm: Fix line over 80 characters warning

From: Wainer dos Santos Moschetta Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20200310180510.19489-3-waine...@redhat.com> Signed-off-by: Laurent Vivier --- hw/mem/pc-dimm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c ind

[PULL v2 13/19] hw/i2c/pm_smbus: Remove dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair F

[PULL v2 04/19] MAINTAINERS: Mark the LatticeMico32 target as orphan

From: Philippe Mathieu-Daudé Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I guess RISC-V is taking over ;

[PULL v2 10/19] Compress lines for immediate return

From: Simran Singhal Compress two lines into a single line if immediate return statement is found. It also remove variables progress, val, data, ret and sock as they are no longer needed. Remove space between function "mixer_load" and '(' to fix the checkpatch.pl error:- ERROR: space prohibited

[PULL v2 02/19] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32()

From: Chen Qun Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>= 5; ^~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200325025919.21316-3-kuhn.chen

[PULL v2 03/19] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()

From: Chen Qun Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~ hw/timer/exynos4210_mct.c:1399:9: warning: Value st

[PULL v2 05/19] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()

From: Wainer dos Santos Moschetta The error report in pc_dimm_pre_plug() now has the slot number printed. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20200310180510.19489-2-waine...@redhat.com> Signed-off-by: Laurent Vivier --- hw/mem/pc-dimm.c | 4 ++-- 1 file changed, 2 insertio

[PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read int set_idx, g_idx = *group_idx; ^ ~~ Reported-by: Clang Static Analy

[PULL v2 07/19] elf_ops: Don't try to g_mapped_file_unref(NULL)

From: Peter Maydell Calling g_mapped_file_unref() on a NULL pointer is not valid, and glib will assert if you try it. $ qemu-system-arm -M virt -display none -device loader,file=/tmp/bad.elf qemu-system-arm: -device loader,file=/tmp/bad.elf: GLib: g_mapped_file_unref: assertion 'file != NULL' f

[PULL v2 09/19] chardev: Add macOS to list of OSes that support -chardev serial

From: Mikhail Gusarov macOS API for dealing with serial ports/ttys is identical to BSDs. Signed-off-by: Mikhail Gusarov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200426210956.17324-1-dotted...@dottedmag.net> Signed-off-by: Laurent Vivier --- charde

[PULL v2 18/19] hw/timer/stm32f2xx_timer: Remove dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never read value = timer_val; ^ ~ Reported-by: Clang Static Analyzer

[PULL v2 19/19] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning

From: Philippe Mathieu-Daudé pxa2xx_timer_tick4() takes an opaque pointer, then calls pxa2xx_timer_update4(), so the static analyzer can not verify that the 'n < 8': 425 static void pxa2xx_timer_tick4(void *opaque) 426 { 427 PXA2xxTimer4 *t = (PXA2xxTimer4 *) opaque; 428 PXA2xxTi

[PULL v2 12/19] blockdev: Remove dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC blockdev.o blockdev.c:2744:5: warning: Value stored to 'ret' is never read ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); ^ ~

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

On 5/4/20 10:52 AM, Alberto Garcia wrote: After commit f01643fb8b47e8a70c04bbf45e0f12a9e5bc54de when an image is extended and BDRV_REQ_ZERO_WRITE is set then the new clusters are zeroized. The code however does not detect correctly situations when the old and the new end of the image are within

[PULL v2 16/19] hw/isa/i82378: Remove dead assignment

From: Philippe Mathieu-Daudé Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa = isa_create_s

[PULL v2 15/19] hw/ide/sii3112: Remove dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Fixes: a9dd6604 Reported-by: Clang Static Analyzer Reviewed-by: BALATON Zolta

[PULL v2 14/19] hw/input/adb-kbd: Remove dead assignment

From: Philippe Mathieu-Daudé Since commit 5a1f49718 the 'olen' variable is not really used. Remove it to fix a warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen = 0; ^ ~

Re: [PATCH 3/5] riscv: Use pre-built bios image of generic platform for virt & sifive_u

On Fri, May 1, 2020 at 8:56 AM Bin Meng wrote: > > From: Bin Meng > > Update virt and sifive_u machines to use the opensbi bios image > built for the generic FDT platform. > > Remove the out-of-date no longer used bios images. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair

Re: [PATCH 4/5] riscv/spike: Change the default bios to use generic platform image

On Fri, May 1, 2020 at 8:51 AM Bin Meng wrote: > > From: Bin Meng > > To keep sync with other RISC-V machines, change the default bios > to use generic platform image. > > While we are here, add some comments to mention that keeping ELF > files here was intentional. > > Signed-off-by: Bin Meng

[PULL v2 11/19] block: Avoid dead assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret = bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~ Fixes: 462

Re: [PATCH v4 00/18] target/arm: sve load/store improvements

On 5/4/20 2:43 AM, Peter Maydell wrote: > I've reviewed patch 13, but I still don't understand why you've > made the size-related changes in patch 4, so I've continued > our conversation in the thread on the v3 version of that patch. I've changed that here in v4. Please have another look at this

Re: [PATCH 1/5] roms/opensbi: Update to support building bios images for generic platform

On Mon, May 4, 2020 at 1:05 AM Bin Meng wrote: > > On Mon, May 4, 2020 at 4:00 PM Bin Meng wrote: > > > > Hi Anup, > > > > On Mon, May 4, 2020 at 3:52 PM Anup Patel wrote: > > > > > > On Mon, May 4, 2020 at 12:46 PM Bin Meng wrote: > > > > > > > > Hi Anup, > > > > > > > > On Sun, May 3, 2020 at

Re: [PATCH v3 10/15] acpi: parallel: don't use _STA method

On Mon, 4 May 2020 15:25:16 +0200 Gerd Hoffmann wrote: > On Thu, Apr 30, 2020 at 06:25:24PM +0200, Igor Mammedov wrote: > > On Wed, 29 Apr 2020 15:59:58 +0200 > > Gerd Hoffmann wrote: > > > > > The _STA method dates back to the days where we had a static DSDT. The > > > device is listed in t

Re: [PATCH 15/17] qdev: Unrealize must not fail

On 4/28/20 6:34 PM, Markus Armbruster wrote: Devices may have component devices and buses. Device realization may fail. Realization is recursive: a device's realize() method realizes its components, and device_set_realized() realizes its buses (which should in turn realize the devices on that b

Re: Configuring onboard devices

On Sun, May 03, 2020 at 11:13:41PM +0100, Mark Cave-Ayland wrote: > On 02/05/2020 06:47, Markus Armbruster wrote: > > > Mark Cave-Ayland writes: > > > >> On 30/04/2020 16:20, Markus Armbruster wrote: > >> > Ah I see now, these aliases are for individual properties rather than > object

Re: [PATCH 09/17] hw/isa/superio: Make the components QOM children

On 4/28/20 6:34 PM, Markus Armbruster wrote: isa_superio_realize() attempts to make isa-parallel and isa-serial QOM children, but this does not work, because it calls object_property_add_child() after realizing with qdev_init_nofail(). Realizing a device without a parent gives it one: it gets put

Re: [PATCH RFC] target/arm: Implement SVE2 fp multiply-add long

On 5/4/20 8:43 AM, Stephen Long wrote: > +for (i = 0; i < opr_sz; i += sizeof(float32)) { > +float32 nn = *(float16 *)(vn + H1_2(i + sel1)); > +float32 mm = *(float16 *)(vm + H1_2(i + sel1)); For integers we could rely on C types for the extension. For floating point, you need

Re: [PATCH 0/8] iotests skipping

Am 30.04.2020 um 14:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > This series adds a bit more support for iotests skipping due to format > whitelisting. Not pretend to be something complete. It just lay in its > folder I don't know how much time, I forgot to send it. > > Still, n

[PATCH Kernel v18 0/7] KABIs to support migration for VFIO devices

Hi, This patch set adds: * IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with respect to IOMMU container rather than per device. All pages pinned by vendor driver through vfio_pin_pages external API has to be marked as dirty during migration. When IOMMU capable device is present in

[PATCH Kernel v18 6/7] vfio iommu: Add migration capability to report supported features

Added migration capability in IOMMU info chain. User application should check IOMMU info chain for migration capability to use dirty page tracking feature provided by kernel module. Signed-off-by: Kirti Wankhede --- drivers/vfio/vfio_iommu_type1.c | 15 +++ include/uapi/linux/vfio.h

[PATCH Kernel v18 3/7] vfio iommu: Add ioctl definition for dirty pages tracking.

IOMMU container maintains a list of all pages pinned by vfio_pin_pages API. All pages pinned by vendor driver through this API should be considered as dirty during migration. When container consists of IOMMU capable device and all pages are pinned and mapped, then all pages are marked dirty. Added

[PATCH Kernel v18 1/7] vfio: UAPI for migration interface for device state

- Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at the 0th offset of migration region to get/set VFIO device related information. Defined members of structure and usage on read/write access. - Defined device states and state tr

[PATCH Kernel v18 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To prevent

[PATCH Kernel v18 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

vfio_pfn.ref_count is always updated while holding iommu->lock, using atomic variable is overkill. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Eric Auger Reviewed-by: Cornelia Huck --- drivers/vfio/vfio_iommu_type1.c | 9 + 1 file changed, 5 insertions(+), 4 deleti

[PATCH Kernel v18 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while guest driver could access those pages, host device or vendor driver can dirty these mapped pages. Such pages s

[PATCH Kernel v18 7/7] vfio: Selective dirty page tracking if IOMMU backed device pins pages

Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the vfio_grou

Re: An first try to improve PPC float simulation, not even compiled. Just ask question.

On 5/3/20 5:41 PM, 罗勇刚(Yonggang Luo) wrote: > > > On Mon, May 4, 2020 at 7:40 AM BALATON Zoltan > wrote: > > Hello, > > On Mon, 4 May 2020, 罗勇刚(Yonggang Luo) wrote: > > Hello Richard, Can you have a look at the following patch, and was that > are > >

Re: [PATCH 1/4] hw/arm/nrf51: Add NRF51_PERIPHERAL_SIZE definition

On 5/4/20 12:28 AM, Philippe Mathieu-Daudé wrote: > On the NRF51 series, all peripherals have a fixed I/O size > of 4KiB. Define NRF51_PERIPHERAL_SIZE and use it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/arm/nrf51.h| 3 +-- > include/hw/i2c/microbit_i2c.h | 2 +- > hw

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote: >> +_supported_fmt qcow2 >> +_supported_proto file > > Do we have to limit it to qcow2 and file? Yes, it's testing a bugfix > for qcow2, but are there other formats that it doesn't hurt to have > the extra testing? It doesn't work with any ot

Re: [PATCH v2 1/1] target/arm: Drop access_el3_aa32ns()

On Mon, May 04, 2020 at 04:21:25PM +0200, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Calling access_el3_aa32ns() works for AArch32 only cores > but it does not handle 32-bit EL2 on top of 64-bit EL3 > for mixed 32/64-bit cores. > > Merge access_el3_aa32ns_aa64any() into access_el3_

[PATCH] target/arm: Implement SVE2 fp multiply-add long

Implements both vectored and indexed FMLALB, FMLALT, FMLSLB, FMLSLT Signed-off-by: Stephen Long --- target/arm/helper-sve.h| 10 + target/arm/sve.decode | 12 ++ target/arm/sve_helper.c| 76 + target/arm/translate-sve.c | 86 ++

Re: [PATCH 3/4] hw/timer/nrf51_timer: Display timer ID in trace events

On 5/4/20 12:28 AM, Philippe Mathieu-Daudé wrote: > The NRF51 series SoC have 3 timer peripherals, each having > 4 counters. To help differentiate which peripheral is accessed, > display the timer ID in the trace events. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/timer/nrf51_ti

RE: [PATCH v2 00/10] Cadence GEM Fixes

Hi Ramon, > -Original Message- > From: Ramon Fried > Sent: Monday, May 4, 2020 9:20 PM > To: Sai Pavan Boddu > Cc: Edgar E. Iglesias ; Alistair Francis > ; Peter Maydell ; > Jason Wang ; Markus Armbruster > ; Philippe Mathieu-Daudé ; > Tong Ho ; open list:Xilinx Zynq a...@nongnu.org>; Q

Re: [PATCH 2/4] hw/arm/nrf51_soc: Mark some peripherals as unimplemented

On 5/4/20 12:28 AM, Philippe Mathieu-Daudé wrote: > Map some peripherals used by Zephyr Project: > > https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/dts/arm/nordic/nrf51822.dtsi > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/arm/nrf51.h | 4 > hw/arm/nrf51_so

Re: [PATCH 4/4] hw/timer/nrf51_timer: Add trace event of counter value update

On 5/4/20 12:28 AM, Philippe Mathieu-Daudé wrote: > Add trace event to display timer's counter value updates. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/nrf51_timer.c | 1 + > hw/timer/trace-events | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 1/3] hw/sh4: Use MemoryRegion typedef

On 5/4/20 1:16 AM, Philippe Mathieu-Daudé wrote: > Use the MemoryRegion type defined in "qemu/typedefs.h", > to keep the repository style consistent. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/sh4/sh.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: R

Re: [PATCH 3/3] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include

On 5/4/20 1:16 AM, Philippe Mathieu-Daudé wrote: > Remove unused "qemu/timer.h" include. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/sh_timer.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 2/3] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h'

On 5/4/20 1:16 AM, Philippe Mathieu-Daudé wrote: > Extract timer definitions to 'hw/timer/tmu012.h'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/sh4/sh.h | 9 - > include/hw/timer/tmu012.h | 23 +++ > hw/sh4/sh7750.c | 1 + > hw/time

Re: [PATCH 2/4] hw/i386/vmport: Remove unused 'hw/input/i8042.h' include

On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote: > Remove unused "hw/input/i8042.h" include. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/vmport.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 1/4] hw/i386/pc: Create 'vmport' device in place

On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/pc.h | 6 -- > hw/i386/pc.c | 2 +- > 2 files changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH v3 5/5] target/arm: Restrict TCG cpus to TCG accel

A KVM-only build won't be able to run TCG cpus. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 634 - target/arm/cpu_tcg.c | 664 +++ target/arm/Makefile.objs | 1 +

[PATCH v3 1/5] target/arm/kvm: Inline set_feature() calls

We want to move the inlined declarations of set_feature() from cpu*.c to cpu.h. To avoid clashing with the KVM declarations, inline the few KVM calls. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/kvm32.c | 13 - target/arm/kvm64.c | 22 ++-

[PATCH v3 3/5] target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]

Use ARRAY_SIZE() to iterate over ARMCPUInfo[]. Since on the aarch64-linux-user build, arm_cpus[] is empty, add the cpu_count variable and only iterate when it is non-zero. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Without using cpu

[PATCH v3 0/5] target/arm: Restrict TCG cpus to TCG accel

These are the uncontroversial patches from "Support disabling TCG on ARM (part 2)" https://www.mail-archive.com/qemu-devel@nongnu.org/msg689168.html The other patches are blocked by the "accel: Allow targets to use Kconfig" series: https://www.mail-archive.com/qemu-devel@nongnu.org/msg689024.html

Re: [PATCH 3/4] hw/i386: Add 'vmport.h' local header

On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote: > Move 'vmport' related declarations in a target-specific header. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/vmport.h | 34 ++ > include/hw/i386/pc.h | 3 --- > hw/i386/pc.c | 1 + > hw/

[PATCH v3 2/5] target/arm: Make set_feature() available for other files

From: Thomas Huth Move the common set_feature() and unset_feature() functions from cpu.c and cpu64.c to cpu.h. Suggested-by: Peter Maydell Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Message-ID: <20190921150420.30743-2-th...@redhat.com> [PMD: Split Thoma

[PATCH v3 4/5] target/arm/cpu: Restrict v8M IDAU interface to Aarch32 CPUs

As IDAU is a v8M feature, restrict it to the Aarch32 CPUs. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index b4d73dd47c..a10f8c4044 100644 --- a/target/arm/cpu.c +++ b/target/ar

Re: [PATCH 1/2] hw/display: Include local 'framebuffer.h'

On 5/4/20 1:20 AM, Philippe Mathieu-Daudé wrote: > The "framebuffer.h" header is not an exported include. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/artist.c | 2 +- > hw/display/next-fb.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henders

Re: [PATCH 4/4] hw/i386: Make vmmouse helpers static

On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote: > +++ b/hw/i386/vmport.c > @@ -23,10 +23,10 @@ > */ > #include "qemu/osdep.h" > #include "hw/isa/isa.h" > -#include "hw/i386/pc.h" > #include "sysemu/hw_accel.h" > #include "qemu/log.h" > #include "vmport.h" > +#include "cpu.h" > #include "tr

Re: [PATCH 2/2] hw/display/edid: Add missing 'qdev-properties.h' header

On 5/4/20 1:20 AM, Philippe Mathieu-Daudé wrote: > +++ b/include/hw/display/edid.h > @@ -2,6 +2,7 @@ > #define EDID_H > > #include "qom/object.h" > +#include "hw/qdev-properties.h" So, are you intending to remove this include from other c files? r~

<    1   2   3   4   5   6   >