[PATCH v9 9/9] qemu-binfmt-conf.sh: add --test

2020-03-09 Thread Unai Martinez-Corral
Signed-off-by: umarcor Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 55224a68e1..21c8f63916 100755 --- a/scripts/qemu-binfmt-con

Re: [PATCH] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

2020-03-09 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > It's been deprecated since QEMU v3.1.0. Time to finally remove it now. > > Signed-off-by: Thomas Huth Queued, via HMP, I've reworked the qemu-deprecated into the new rst world. > --- > hmp-commands.hx | 8 > net/hub.c| 23 ---

Re: [PATCH v9 0/9] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309183521.GA9@669c1c222ef4/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v9 0/9] qemu-binfmt-conf.sh Message-id: 20200309183521.GA9@669c1c222ef4 Type: series === TEST SCRIPT BEGIN ==

Re: [PATCH v5 11/16] target/i386: Load apicid model specific handlers from X86CPUDefinition

2020-03-09 Thread Babu Moger
On 3/9/20 9:49 AM, Igor Mammedov wrote: > On Tue, 03 Mar 2020 13:58:03 -0600 > Babu Moger wrote: > >> Load the model specific handlers if available or else default handlers >> will be loaded. Add the model specific handlers if apicid decoding >> differs from the standard sequential numbering.

Re: [PATCH v5 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-03-09 Thread Babu Moger
On 3/9/20 10:01 AM, Igor Mammedov wrote: > On Tue, 03 Mar 2020 13:58:10 -0600 > Babu Moger wrote: > >> Check and Load the apicid handlers from X86CPUDefinition if available. >> Update the calling convention for the apicid handlers. >> >> Signed-off-by: Babu Moger > > >> --- >> hw/i386/pc.c

Re: [PATCH v5 13/16] target/i386: Add EPYC model specific handlers

2020-03-09 Thread Babu Moger
On 3/9/20 10:03 AM, Igor Mammedov wrote: > On Tue, 03 Mar 2020 13:58:16 -0600 > Babu Moger wrote: > >> Add the new EPYC model specific handlers to fix the apicid decoding. >> >> The APIC ID is decoded based on the sequence sockets->dies->cores->threads. >> This works fine for most standard AMD

[PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread Unai Martinez-Corral
Hi, This series reworks qemu-binfmt-conf.sh: * Argument from option '--systemd' is generalized to , and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. * Option '-r|--clear' is added, which allows to remove an already registered t

Re: [PULL 00/33] Trivial branch patches

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote: > The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-03-09 10:32:53 +) > > are available in the Git repository at:

[PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-09 Thread Unai Martinez-Corral
All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH v9 0/9] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309183521.GA9@669c1c222ef4/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86

[PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Unai Martinez-Corral
Spaces are removed before '; then', for consistency with other scripts in the project. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/scripts

[PATCH v10 03/10] qemu-binfmt-conf.sh: make opts -p and -c boolean

2020-03-09 Thread Unai Martinez-Corral
This patch breaks backward compatibility. Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' or '-c no' are redundant. Overall, accepting an argument might be misleading because options are, indeed, boolean. This patch makes both options boolean in getopt, so if any of them is

[PATCH v10 04/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

2020-03-09 Thread Unai Martinez-Corral
Allow to set options '--persistent' and/or '--credential' through environment variables. If not defined, defaults are used ('no'). Anyway, command-line arguments have priority over environment variables. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-con

[PATCH v10 05/10] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*

2020-03-09 Thread Unai Martinez-Corral
Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 63 +++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 0c28db5ca4..870815fb22 10075

[PATCH v10 07/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

2020-03-09 Thread Unai Martinez-Corral
Allow to set 'path' or 'suffix' through environment variables, consistently with 'persistent' and 'credential'. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/qe

[PATCH v10 06/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options

2020-03-09 Thread Unai Martinez-Corral
This breaks backward compatibility. Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is not present in other option names ('debian', 'systemd', 'persistent', 'credential'...). In order to keep consistency, the prefix is removed. Signed-off-by: Unai Martinez-Corral Reviewed-by

[PATCH v10 09/10] qemu-binfmt-conf.sh: add option --clear

2020-03-09 Thread Unai Martinez-Corral
This is a partial implementation. Allows to remove a single or a list of already registered binfmt interpreters. Valid values are those in qemu_target_list. If TARGETS is empty, all the existing 'qemu-*' interpreters are removed. This is partial because 'debian' and 'systemd' configurations are n

[PATCH v10 10/10] qemu-binfmt-conf.sh: add --test

2020-03-09 Thread Unai Martinez-Corral
Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 55224a68e1..21c8f63916 100755 --- a/scripts/qe

[PATCH v10 08/10] qemu-binfmt-conf.sh: generalize to positional [TARGETS]

2020-03-09 Thread Unai Martinez-Corral
This breaks brackward compatibility. Option '--systemd CPU' allows to register binfmt interpreters for a single target architecture or for 'ALL' (of them). This patch generalizes the approach to support it in any mode (default, '--debian' or '--systemd'). To do so, option 'systemd' is changed to b

Re: [PULL 00/33] Trivial branch patches

2020-03-09 Thread Philippe Mathieu-Daudé
On 3/9/20 8:17 PM, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote: The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +) ar

Re: [PATCH v5 14/16] hw/i386: Move arch_id decode inside x86_cpus_init

2020-03-09 Thread Babu Moger
On 3/9/20 10:21 AM, Igor Mammedov wrote: > On Tue, 03 Mar 2020 13:58:24 -0600 > Babu Moger wrote: > >> Apicid calculation depends on knowing the total number of numa nodes >> for EPYC cpu models. Right now, we are calculating the arch_id while >> parsing the numa(parse_numa). At this time, it

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Eric Blake
On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: Spaces are removed before '; then', for consistency with other scripts in the project. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier Technically, since this change is different than what Laurent previously reviewed, it might h

Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-09 Thread Eric Blake
On 3/9/20 2:19 PM, Unai Martinez-Corral wrote: All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 10 +-

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Unai Martinez Corral
2020/3/9 20:30, Eric Blake: > On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: > > Spaces are removed before '; then', for consistency with other scripts > > in the project. > > > > Signed-off-by: Unai Martinez-Corral > > Reviewed-by: Laurent Vivier > > Technically, since this change is different

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
Hi Alex, On Wed, Mar 4, 2020 at 9:55 PM Niek Linnenbank wrote: > Hello Alex, > > On Wed, Mar 4, 2020 at 11:35 AM Alex Bennée > wrote: > >> >> Niek Linnenbank writes: >> >> > The Xunlong Orange Pi PC machine is a functional ARM machine >> > based on the Allwinner H3 System-on-Chip. It supports

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
Hi Peter, On Mon, Mar 9, 2020 at 12:22 PM Peter Maydell wrote: > On Wed, 4 Mar 2020 at 20:55, Niek Linnenbank > wrote: > > > > Hello Alex, > > > > On Wed, Mar 4, 2020 at 11:35 AM Alex Bennée > wrote: > >> > >> > >> Niek Linnenbank writes: > >> > --- > >> > docs/orangepi.rst | 226 > >> > +++

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 19:38, Niek Linnenbank wrote: > On Mon, Mar 9, 2020 at 12:22 PM Peter Maydell > wrote: >> Yes, this is now the right place to put arm board-specific >> documentation (the rearranging and conversion from texinfo >> is now in master). I should move microvm.rst's contents ther

[PULL 01/12] usb/dev-storage: remove unused include

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200308092440.23564-2-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-s

[PULL 03/12] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Also add block-hmp-cmds.h to contain prototypes of these functions License for block-hmp-cmds.h since it contains the code moved from sysemu.h wh

[PULL 00/12] hmp queue

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) are available in the Git repository at: git://github.com/dagrh/qemu.git tags/pull-hmp-20200309 for yo

[PULL 11/12] monitor/hmp: Move hmp_drive_add_node to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-12-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 30 blockdev.c | 43 +++-

[PULL 06/12] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-7-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 52 ++ include/block/block-hmp-cmds.h | 6

[PULL 07/12] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky hmp_snapshot_blkdev is from GPLv2 version of the hmp-cmds.c thus have to change the licence to GPLv2 Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-8-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block

[PULL 02/12] monitor/hmp: inline add_init_drive

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky This function is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Markus Armbruster Message-Id: <20200308092440.23564-3-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- de

[PULL 04/12] monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-5-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 108 - blockdev.c | 9

[PULL 09/12] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-10-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 140 + include/block/block-hmp-cmds.h |

[PULL 05/12] monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Moved code was added after 2012-01-13, thus under GPLv2+ Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-6-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Fixed commit message --- block/monitor/block-hmp-cm

[PATCH v3 1/3] ide: Make room for flags in PCIIDEState and add one for legacy IRQ routing

2020-03-09 Thread BALATON Zoltan
We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for furhter flags if needed in the future. This patch changes the "secondary" field to "flags" and define the flags for C

[PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has arch specific workarounds for this that are activated on such boards so this needs to be emula

[PULL 08/12] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-9-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 101 + include/block/block-hmp-cmds.h |

[PULL 10/12] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-11-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 389 + include/block/block-hmp-cmds.h |

[PATCH v3 0/3] Implement "non 100% native mode" in via-ide

2020-03-09 Thread BALATON Zoltan
This small series implements "non-100% native mode" of via-ide found at least on pegasos2 where io addresses come from PCI BARs but interrupts are hard coded to legacy IRQ14 and 15. This is needed for guests that expect it and activate work arounds on that platform and don't work unless this is emu

[PULL 12/12] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Thomas Huth It's been deprecated since QEMU v3.1.0. Time to finally remove it now. Signed-off-by: Thomas Huth Message-Id: <20191205104109.18680-1-th...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Reworked Thomas's deprecated.texi to the rst --- docs/system/deprecated.rst | 15 ++

[PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread BALATON Zoltan
The pci_do_device_reset() function (called from pci_device_reset) clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did this without taking wmask into account. We'll have a device model now that needs to set a constant value for this reg and this patch allows to do that without add

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Mark Cave-Ayland
On 09/03/2020 00:42, BALATON Zoltan wrote: > Some machines operate in "non 100% native mode" where interrupts are > fixed at legacy IDE interrupts and some guests expect this behaviour > without checking based on knowledge about hardware. Even Linux has > arch specific workarounds for this that ar

Re: [PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309191200.GA60@669c1c222ef4/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x8

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
On Mon, Mar 9, 2020 at 8:43 PM Peter Maydell wrote: > On Mon, 9 Mar 2020 at 19:38, Niek Linnenbank > wrote: > > On Mon, Mar 9, 2020 at 12:22 PM Peter Maydell > wrote: > >> Yes, this is now the right place to put arm board-specific > >> documentation (the rearranging and conversion from texinfo

Re: [PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309191200.GA60@669c1c222ef4/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v10 0/10] qemu-binfmt-conf.sh Message-id: 20200309191200.GA60@669c1c222ef4 Type: series === TEST SCRIPT BEGI

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:05, Niek Linnenbank wrote: > Ah now I see what is going on here. So the new rst files are ment to > automatically generate > documentation in various formats using the Python sphinx tool, correct? Yep. Assuming you have Sphinx installed, "make" should build the documenta

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Mark Cave-Ayland wrote: On 09/03/2020 00:42, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has arch

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Mark Cave-Ayland wrote: On 09/03/2020 00:42, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has arc

[PATCH v1 3/5] tests/docker: Remove obsolete VirGL --with-glx configure option

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé The GLX configure option has been removed in 71c75f201d [*]. We missed that when updating to v0.7.0 in commit fab3220f97. This silents: configure: creating ./config.status config.status: creating virglrenderer.pc ... configure: WARNING: unrecognized options:

[PATCH v1 5/5] tests/acceptance: disable two more tests while in CI

2020-03-09 Thread Alex Bennée
These keep timing out on Travis. The reason is unknown so add a FIXME for those who want to track down exactly why this is happening. In the meantime you can still run check-acceptance manually without change. Signed-off-by: Alex Bennée --- tests/acceptance/machine_mips_malta.py | 2 ++ tests/a

[PATCH v1 1/5] tests/docker: Install tools to cross-debug and build Linux kernels

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé We often run Linux kernels to test QEMU. We sometimes need to build them manually to use non-default features. We only miss the tiny 'bc' tool. The ncurses library is helpful to run 'make menuconfig'. Finally, gdb-multiarch allow us to debug a TCG guest when its arc

[PATCH v1 0/5] testing updates (docker and acceptance CI tweaks)

2020-03-09 Thread Alex Bennée
Hi, Another week, another testing series. Apart from gathering up some docker tweaks from Phillipe I've also added skips for some MIPS and SPARC acceptance tests that are timing out in CI but not for me locally. Alex Bennée (1): tests/acceptance: disable two more tests while in CI Philippe Mat

[PATCH v1 2/5] tests/docker: Update VirGL git repository URL

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé freedesktop.org is moving to a GitLab instance, use the new url. - https://www.fooishbar.org/blog/gitlab-fdo-introduction/ - https://gitlab.freedesktop.org/freedesktop/freedesktop/-/wikis/home Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Messag

[PATCH v1 4/5] tests/docker: Update VirGL to v0.8.0

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé Building the qemu:debian-amd64 fails when building VirGL: make[2]: Entering directory '/usr/src/virglrenderer/src/gallium/auxiliary' CC cso_cache/cso_cache.lo CC cso_cache/cso_hash.lo CC os/os_misc.lo CC util/u_debug.lo C

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > Some machines operate in "non 100% native mode" where interrupts are > fixed at legacy IDE interrupts and some guests expect this behaviour > without checking based on knowledge about hardware. Even Linux has > arch specific workarou

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > The pci_do_device_reset() function (called from pci_device_reset) > clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did > this without taking wmask into account. We'll have a device model now > that needs to set a

Re: [PULL 00/12] hmp queue

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309194650.160552-1-dgilb...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ex

Re: [PATCH] machine/memory encryption: Disable mem merge

2020-03-09 Thread Eduardo Habkost
On Thu, Jan 30, 2020 at 05:50:46PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When a host is running with memory encryption, the memory isn't visible > to the host kernel; attempts to merge that memory are futile because > what it's really comparing is encrypt

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
On Mon, Mar 9, 2020 at 9:12 PM Peter Maydell wrote: > On Mon, 9 Mar 2020 at 20:05, Niek Linnenbank > wrote: > > Ah now I see what is going on here. So the new rst files are ment to > automatically generate > > documentation in various formats using the Python sphinx tool, correct? > > Yep. Assum

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardwa

Re: [PULL 00/12] hmp queue

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:48, wrote: > > Patchew URL: > https://patchew.org/QEMU/20200309194650.160552-1-dgilb...@redhat.com/ > > > > Hi, > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: The pci_do_device_reset() function (called from pci_device_reset) clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did this without taking wmask into account. We'll hav

[PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Vitaly Chikunov
rlwinm cannot just AND with Mask if shift value is zero on ppc64 when Mask Begin is greater than Mask End and high bits are set to 1. Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and ROTL32 is defined (in 3.3.14) so that rotated value should have two copies of lower word of the s

[PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread Unai Martinez-Corral
Hi, This series reworks qemu-binfmt-conf.sh: * Argument from option '--systemd' is generalized to , and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. * Option '-r|--clear' is added, which allows to remove an already registered t

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Thu, 5 Mar 2020 19:43:24 -0500 Peter Xu wrote: > On Thu, Mar 05, 2020 at 04:58:57PM -0700, Alex Williamson wrote: > > Hi, Alex, > > [...] > > > > +bool kvm_resample_fd_notify(int gsi) > > > +{ > > > +KVMResampleFd *rfd; > > > + > > > +if (!kvm_irqchip_is_split()) { > > > +re

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, BALATON Zoltan wrote: On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour witho

Re: [PATCH v3 0/3] Implement "non 100% native mode" in via-ide

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1583781493.git.bala...@eik.bme.hu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v1 0/5] testing updates (docker and acceptance CI tweaks)

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309202318.3481-1-alex.ben...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

[PATCH 3/5] docs/system/target-arm.rst: Add some introductory text

2020-03-09 Thread Peter Maydell
Now we've moved the various bits of per-board documentation into their own files, the top level document is a little bare. Add some introductory information, including a note that many of the board models we support are currently undocumented. (Most sections of this new text were originally writte

[PATCH 0/5] docs/system: Split target-arm.rst

2020-03-09 Thread Peter Maydell
This patchseries splits the 'target-arm.rst' file in the System manual into one file per board or family of boards. It's not sensible for us to document all 50-odd boards in a single enormous page, and the split will encourage more detailed and useful per-board information. The impetus for doing

[PATCH 4/5] docs: Move arm-cpu-features.rst into the system manual

2020-03-09 Thread Peter Maydell
Now we have somewhere to put arm-specific rst documentation, we can move arm-cpu-features.rst from the docs/ top level directory into docs/system/arm/. Signed-off-by: Peter Maydell --- .../{arm-cpu-features.rst => system/arm/cpu-features.rst} | 8 +--- docs/system/target-arm.rst

[PATCH 1/5] Makefile: Allow for subdirectories in Sphinx manual dependencies

2020-03-09 Thread Peter Maydell
Currently we put 'docs/foo/*.rst' in the Make list of dependencies for the Sphinx 'foo' manual, which means all the files must be in the top level of that manual's directory. We'd like to be able to have subdirectories inside some of the manuals, so add 'docs/foo/*/*.rst' to the dependencies too.

[PATCH 2/5] docs/system: Split target-arm.rst into sub-documents

2020-03-09 Thread Peter Maydell
Currently the documentation for Arm system emulator targets is in a single target-arm.rst. This describes only some of the boards and often in a fairly abbreviated fashion. Restructure it so that each board has its own documentation file in the docs/system/arm/ subdirectory. This will hopefully e

[PATCH 5/5] docs: Be consistent about capitalization of 'Arm'

2020-03-09 Thread Peter Maydell
The company 'Arm' went through a rebranding some years back involving a recapitalization from 'ARM' to 'Arm'. As a result our documentation is a bit inconsistent between the two forms. It's not worth trying to update everywhere in QEMU, but it's easy enough to make docs/ consistent. Note that "ARM

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:12, Peter Maydell wrote: > If you're ready to send out the next version before that, > then leave it with the include:: directive and we can > fix it up to the new structure later. PS: in case you weren't aware, softfreeze for the 5.0 release is 17th March, so if this ser

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Fri, 28 Feb 2020 11:15:02 -0500 Peter Xu wrote: > This is majorly only for X86 because that's the only one that supports > split irqchip for now. > > When the irqchip is split, we face a dilemma that KVM irqfd will be > enabled, however the slow irqchip is still running in the userspace. > It

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309204557.14836-1...@altlinux.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export A

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 16:10:59 -0600 Alex Williamson wrote: > On Fri, 28 Feb 2020 11:15:02 -0500 > Peter Xu wrote: > > > This is majorly only for X86 because that's the only one that supports > > split irqchip for now. > > > > When the irqchip is split, we face a dilemma that KVM irqfd will be >

Re: [PATCH 0/5] docs/system: Split target-arm.rst

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309215818.2021-1-peter.mayd...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Peter Xu
On Mon, Mar 09, 2020 at 04:10:59PM -0600, Alex Williamson wrote: > On Fri, 28 Feb 2020 11:15:02 -0500 > Peter Xu wrote: > > > This is majorly only for X86 because that's the only one that supports > > split irqchip for now. > > > > When the irqchip is split, we face a dilemma that KVM irqfd will

[PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-09 Thread Liran Alon
Instead of hard-coding the VMX version, make it a VMPORT object property. This would allow user to control it's value via "-global vmport.vmx-version=X". Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 01/14] hw/i386/vmport: Propagate IOPort read to vCPU EAX register

2020-03-09 Thread Liran Alon
vmport_ioport_read() returns the value that should propagate to vCPU EAX register when guest reads VMPort IOPort (i.e. By x86 IN instruction). However, because vmport_ioport_read() calls cpu_synchronize_state(), the returned value gets overridden by the value in QEMU vCPU EAX register. i.e. cpu->e

[PATCH 10/14] hw/i386/vmport: Add support for CMD_GET_VCPU_INFO

2020-03-09 Thread Liran Alon
Command currently returns that it is unimplemented by setting the reserved-bit in it's return value. Following patches will return various useful vCPU information to guest. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 13 + include/hw/i386/pc.h

[PATCH 11/14] hw/i386/vmport: Allow x2apic without IR

2020-03-09 Thread Liran Alon
Signal to guest that hypervisor supports x2apic without VT-d/IOMMU Interrupt-Remapping support. This allows guest to use x2apic in case all APIC IDs fits in 8-bit (i.e. Max APIC ID < 255). See Linux kernel commit 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform") and Linux try_t

[PATCH 08/14] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-09 Thread Liran Alon
This command is used by guest to gettimeofday() from host. See usage example in open-vm-tools TimeSyncReadHost() function. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 21 + include/hw/i386/pc.h | 1 + 2 files changed, 22 insertions(+)

[PATCH 02/14] hw/i386/vmport: Set EAX to -1 on failed and unsupported commands

2020-03-09 Thread Liran Alon
This is used as a signal for VMware Tools to know if a command it attempted to invoke, failed or is unsupported. As a result, VMware Tools will either report failure to user or fallback to another backdoor command in attempt to perform some operation. A few examples: * open-vm-tools TimeSyncReadHo

[PATCH 03/14] hw/i386/vmport: Add device properties

2020-03-09 Thread Liran Alon
No functional change. This is done as a preparation for the following patches that will introduce several device properties. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c

[PATCH 12/14] i386/cpu: Store LAPIC bus frequency in CPU structure

2020-03-09 Thread Liran Alon
No functional change. This information will be used by following patches. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- linux-headers/asm-x86/kvm.h | 4 target/i386/cpu.h | 1 + target/i386/kvm.c | 6 +++--- 3 files changed, 8 insertions(+), 3 deletions(-)

[PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-09 Thread Liran Alon
As can be seen from VmCheck_GetVersion() in open-vm-tools code, CMD_GETVERSION should return VMX type in ECX register. Default is to fake host as VMware ESX server. But user can control this value by "-global vmport.vmx-type=X". Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i38

[PATCH 14/14] hw/i386/vmport: Assert vmport initialized before registering commands

2020-03-09 Thread Liran Alon
vmport_register() is also called from other modules such as vmmouse. Therefore, these modules rely that vmport is realized before those call sites. If this is violated, vmport_register() will NULL-deref. To make such issues easier to debug, assert in vmport_register() that vmport is already realiz

[PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
Hi, This series aims to fix several bugs in VMPort and improve it by supporting more VMPort commands and make command results more configurable to user via QEMU command-line. This functionality was proven to be useful to run various VMware VMs when attempting to run them as-is on top of QEMU/KVM.

[PATCH 09/14] hw/i386/vmport: Add support for CMD_GETTIMEFULL

2020-03-09 Thread Liran Alon
Similar to CMD_GETTIME but lacks the 136-year overflow issue, by returning full 64-bit of host uSeconds. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 17 + include/hw/i386/pc.h | 1 + 2 files changed, 18 insertions(+) diff --git a/hw/i386/v

[PATCH 13/14] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-09 Thread Liran Alon
This command returns to guest information on LAPIC bus frequency and TSC frequency. One can see how this interface is used by Linux vmware_platform_setup() introduced in Linux commit 88b094fb8d4f ("x86: Hypervisor detection and get tsc_freq from hypervisor"). Reviewed-by: Nikita Leshenko Signed-

[PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-09 Thread Liran Alon
No functional change. Defining an enum for all VMPort commands have the following advantages: * It gets rid of the error-prone requirement to update VMPORT_ENTRIES when new VMPort commands are added to QEMU. * It makes it clear to know by looking at one place at the source, what are all the VMPort

[PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-09 Thread Liran Alon
This is VMware documented functionallity that some guests rely on. Returns the BIOS UUID of the current virtual machine. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 14 ++ include/hw/i386/pc.h | 1 + 2 files changed, 15 insertions(+) diff --gi

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
On 10/03/2020 2:13, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!IXfneuptZ4caQyQEEgsIN74dLYkkLHJ8XSqL2iGyrzODUx_Jt8Vk-eKN_QQftVU$ Hi, This series seems to have some coding style

<    1   2   3   4   5   6   >