Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' ec54414 hw/i386/vmport: Assert vmport initialized before registering commands 77ea4ed hw/i386/vmport: Add support for CMD_GETHZ b1ed920 i386/cpu: Store LAPIC bus frequency in CPU structure 62d770f hw/i386/vmport: Allow x2apic without IR 5c97d52 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO e4a716d hw/i386/vmport: Add support for CMD_GETTIMEFULL febcb47 hw/i386/vmport: Add support for CMD_GETTIME 25890df hw/i386/vmport: Add support for CMD_GETBIOSUUID 9e6211d hw/i386/vmport: Define enum for all commands fc5f5ec hw/i386/vmport: Report VMX type in CMD_GETVERSION f284754 hw/i386/vmport: Introduce vmx-version property 114bf59 hw/i386/vmport: Add device properties 8acf5a2 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 97c3de7 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 97c3de7b1b98 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 8acf5a2b7630 (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 114bf59021b3 (hw/i386/vmport: Add device properties) 4/14 Checking commit f284754e01a3 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit fc5f5ec6f72f (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 9e6211d4df01 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit 25890df0767b (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: + uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit febcb4730cb2 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit e4a716de3f06 (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 5c97d52c360a (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: + return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 62d770f375b6 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit b1ed920b0bf3 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 77ea4ed42420 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit ec54414bea14 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com