Patchew URL: https://patchew.org/QEMU/20200309191200.GA60@669c1c222ef4/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v10 0/10] qemu-binfmt-conf.sh Message-id: 20200309191200.GA60@669c1c222ef4 Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 6998456 qemu-binfmt-conf.sh: add --test de76b37 qemu-binfmt-conf.sh: add option --clear a8799ef qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS] 2ca95ad qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX f2eb778 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options d224143 qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 8b9b845 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT ccf9eb4 qemu-binfmt-conf.sh: make opts -p and -c boolean ee0df83 qemu-binfmt-conf.sh: enforce safe tests ffea590 qemu-binfmt-conf.sh: enforce style consistency === OUTPUT BEGIN === 1/10 Checking commit ffea590f36f3 (qemu-binfmt-conf.sh: enforce style consistency) 2/10 Checking commit ee0df830faad (qemu-binfmt-conf.sh: enforce safe tests) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:303: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ]; then total: 0 errors, 1 warnings, 33 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit ccf9eb486013 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:331: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 3/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/10 Checking commit 8b9b8451b921 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 5/10 Checking commit d22414312ea8 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:183: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:184: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:186: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:191: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:193: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:210: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 5/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/10 Checking commit f2eb778de91d (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:184: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:337: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 6/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/10 Checking commit 2ca95ad872f1 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:184: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit a8799ef441b1 (qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS]) ERROR: line over 90 characters #78: FILE: scripts/qemu-binfmt-conf.sh:203: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #91: FILE: scripts/qemu-binfmt-conf.sh:215: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #105: FILE: scripts/qemu-binfmt-conf.sh:234: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #147: FILE: scripts/qemu-binfmt-conf.sh:363: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 8/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/10 Checking commit de76b378ab3e (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #34: FILE: scripts/qemu-binfmt-conf.sh:204: + if empty, configure/clear all known targets; ERROR: line over 90 characters #42: FILE: scripts/qemu-binfmt-conf.sh:213: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:381: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 9/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/10 Checking commit 69984567b97d (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #21: FILE: scripts/qemu-binfmt-conf.sh:204: + if empty, configure/clear all known targets. ERROR: line over 90 characters #29: FILE: scripts/qemu-binfmt-conf.sh:214: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:381: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 10/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309191200.GA60@669c1c222ef4/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
