Re: [PATCH v2 13/22] qemu-iotests/199: drop extra constraints

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: We don't need any specific format constraints here. Still keep qcow2 for two reasons: 1. No extra calls of format-unrelated test 2. Add some check around persistent bitmap in future (require qcow2) Signed-off-by: Vladimir Sementsov-Ogie

Re: [PATCH v4 1/3] target/arm: Support SError injection

On Wed, 19 Feb 2020 10:09:39 +1100 Gavin Shan wrote: > Hi Marc, > > On 2/19/20 3:28 AM, Marc Zyngier wrote: > > On 2020-02-18 02:04, Gavin Shan wrote: > >> This supports SError injection, which will be used by "virt" board to > >> simulating the behavior of NMI injection in next patch. As Pete

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

On 18/02/20 20:44, Olaf Hering wrote: > Am Tue, 18 Feb 2020 18:37:09 +0100 > schrieb Paolo Bonzini : > >> On 18/02/20 18:27, Olaf Hering wrote: >>> The approach below (making 'xenfv' an alias of 'pc') does not work: >>> xen_enabled() is false when pc_i440fx_3_1_machine_options runs. >> Don't use

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

Am Wed, 19 Feb 2020 09:05:49 +0100 schrieb Paolo Bonzini : > Has any version of Xen been released with a QEMU version above 3.1? Xen 4.13 has a copy of qemu4. But, Xen can use an external qemu. It is unknown how many supposed-to-be-migrated domUs with qemu4+ are out there. But there is a six di

Re: [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation

On 2/19/20 8:55 AM, Laurent Vivier wrote: Le 19/02/2020 à 02:57, Aleksandar Markovic a écrit : 2:54 AM Sre, 19.02.2020. Aleksandar Markovic mailto:aleksandar.m.m...@gmail.com>> је написао/ла: 2:06 AM Sre, 19.02.2020. Finn Thain > је написао/ла: On Tue, 18

Re: [PATCH 00/22] linux-user: generate syscall_nr.sh

Le 18/02/2020 à 23:48, Alistair Francis a écrit : > On Mon, Feb 17, 2020 at 2:36 PM Laurent Vivier wrote: >> >> This series copies the files syscall.tbl from linux v5.5 and generates >> the file syscall_nr.h from them. >> >> This is done for all the QEMU targets that have a syscall.tbl >> in the l

Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform

Thank you Sunil! On 2/18/20 9:51 PM, Justin Terry (SF) wrote: Looks good to me! Thanks Sunil. Signed-off-by: Justin Terry (VM) Justin, I suppose you meant: Reviewed-by: Justin Terry (VM) -Original Message- From: Sunil Muthuswamy Sent: Tuesday, February 18, 2020 12:39 PM To: Edu

Re: [PATCH v2 fixed 01/16] util: vfio-helpers: Factor out and fix processing of existing ram blocks

On 18.02.20 23:00, Peter Xu wrote: > On Wed, Feb 12, 2020 at 02:42:39PM +0100, David Hildenbrand wrote: >> Factor it out into common code when a new notifier is registered, just >> as done with the memory region notifier. This allows us to have the >> logic about how to process existing ram blocks

Re: [PATCH v2 fixed 03/16] util: vfio-helpers: Remove Error parameter from qemu_vfio_undo_mapping()

On 18.02.20 23:07, Peter Xu wrote: > On Wed, Feb 12, 2020 at 02:42:41PM +0100, David Hildenbrand wrote: >> Everybody discards the error. Let's error_report() instead so this error >> doesn't get lost. >> >> Cc: Richard Henderson >> Cc: Paolo Bonzini >> Cc: Eduardo Habkost >> Cc: Marcel Apfelbaum

Re: [PATCH v3 1/5] target/riscv: add vector unit stride load and store instructions

Hi, Richard Thanks for your informative comments. I'm addressing these comments. And a little confused in some comments. On 2020/2/12 14:38, Richard Henderson wrote: On 2/9/20 11:42 PM, LIU Zhiwei wrote: +/* + * As simd_desc supports at most 256 bytes, and in this implementation, + * the max vec

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

Kevin Wolf writes: > Am 18.02.2020 um 15:12 hat Markus Armbruster geschrieben: >> >> Regarding calling monitor_qmp_requests_pop_any_with_lock(): it needs >> >> @monitor_lock and @mon_list to be valid. We just initialized >> >> @monitor_lock, and @mon_list is empty. >> >> monitor_qmp_requests_pop

Re: [PATCH v2 0/3] vhost-user: Lift Max Ram Slots Limitation

On Mon, Feb 10, 2020 at 11:04:28AM -0500, Michael S. Tsirkin wrote: > > On Sun, Feb 09, 2020 at 12:14:42PM -0500, Raphael Norwitz wrote: > > On Thu, Feb 06, 2020 at 03:33:13AM -0500, Michael S. Tsirkin wrote: > > > > > > On Wed, Jan 15, 2020 at 09:57:03PM -0500, Raphael Norwitz wrote: > > > > >

Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_ioeventfds()

On Tue, Feb 18, 2020 at 9:50 PM Peter Xu wrote: > > On Tue, Feb 18, 2020 at 06:22:26PM +, Stefan Hajnoczi wrote: > > Reallocing the ioeventfds[] array each time an element is added is very > > expensive as the number of ioeventfds increases. Batch allocate instead > > to amortize the cost of

Re: [PATCH 3/3] hw/xtensa/xtfpga:fix leak of fdevice tree blob

Le 18/02/2020 à 10:11, kuhn.chen...@huawei.com a écrit : > From: Chen Qun > > The device tree blob returned by load_device_tree is malloced. > We should free it after cpu_physical_memory_write(). > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > hw/xtensa/xtfpga.c | 1 + > 1 file

[PATCH] migration/savevm: release gslist after dump_vmstate_json

From: Pan Nengyuan 'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's called only once, but seems like a clean code. Fix the leak as follow: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0x

Re: [PATCH 1/3] hw/nios2:fix leak of fdevice tree blob

Le 18/02/2020 à 10:11, kuhn.chen...@huawei.com a écrit : > From: Chen Qun > > The device tree blob returned by load_device_tree is malloced. > We should free it after cpu_physical_memory_write(). > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > hw/nios2/boot.c | 1 + > 1 file ch

Re: [PATCH RFC] target/i386: filter out VMX_PIN_BASED_POSTED_INTR when enabling SynIC

Paolo Bonzini writes: > On 18/02/20 18:08, Vitaly Kuznetsov wrote: >> Paolo Bonzini writes: >> >>> On 18/02/20 15:44, Vitaly Kuznetsov wrote: Signed-off-by: Vitaly Kuznetsov --- RFC: This is somewhat similar to eVMCS breakage and it is likely possible to fix this in KVM. I

Re: [PATCH] migration/savevm: release gslist after dump_vmstate_json

* pannengy...@huawei.com (pannengy...@huawei.com) wrote: > From: Pan Nengyuan > > 'list' forgot to free at the end of dump_vmstate_json_to_file(), although > it's called only once, but seems like a clean code. > > Fix the leak as follow: > Direct leak of 16 byte(s) in 1 object(s) allocated from

[PATCH] util/async: make bh_aio_poll() O(1)

The ctx->first_bh list contains all created BHs, including those that are not scheduled. The list is iterated by the event loop and therefore has O(n) time complexity with respected to the number of created BHs. Rewrite BHs so that only scheduled or deleted BHs are enqueued. Only BHs that actuall

Re: [PATCH v2 0/3] vhost-user: Lift Max Ram Slots Limitation

On Wed, Feb 19, 2020 at 12:33:24AM -0500, Raphael Norwitz wrote: > On Mon, Feb 10, 2020 at 11:04:28AM -0500, Michael S. Tsirkin wrote: > > > > On Sun, Feb 09, 2020 at 12:14:42PM -0500, Raphael Norwitz wrote: > > > On Thu, Feb 06, 2020 at 03:33:13AM -0500, Michael S. Tsirkin wrote: > > > > > > > >

Re: [PATCH 2/5] aio-posix: don't pass ns timeout to epoll_wait()

On Fri, Feb 14, 2020 at 05:17:09PM +, Stefan Hajnoczi wrote: > Don't pass the nanosecond timeout into epoll_wait(), which expects > milliseconds. > > The epoll_wait() timeout value does not matter if qemu_poll_ns() > determined that the poll fd is ready, but passing a value in the wrong > unit

[PULL 06/17] hw/m68k/next-cube: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 956a78118bf Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-7-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/m68k/next-cube.c | 2 +- 1

[PULL 07/17] hw/scsi/esp: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 74d71ea16bc Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-8-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/scsi/esp.c | 2 +- 1 file

[PULL 02/17] Report stringified errno in VFIO related errors

From: Michal Privoznik In a few places we report errno formatted as a negative integer. This is not as user friendly as it can be. Use strerror() and/or error_setg_errno() instead. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko Reviewed-by: Cornelia Huck Reviewed-by: Eric Auger Revie

[PULL 04/17] audio/alsaaudio: Remove superfluous semicolons

From: Philippe Mathieu-Daudé Fixes: 286a5d201e4 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-3-phi...@redhat.com> Signed-off-by: Laurent Vivier --- audio/alsaaudio.c | 4 ++-- 1

[PULL 05/17] hw/arm/xlnx-versal: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 6f16da53ffe Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-6-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/arm/xlnx-versal-virt.c | 2

[PULL 03/17] scripts/checkpatch.pl: Detect superfluous semicolon in C code

From: Philippe Mathieu-Daudé Display error when a commit contains superfluous semicolon: $ git show 6663a0a3376 | scripts/checkpatch.pl -q - ERROR: superfluous trailing semicolon #276: FILE: block/io_uring.c:186: +ret = -ENOSPC;; total: 1 errors, 1 warnings, 485 lines c

[PULL 10/17] target/i386/whpx: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 812d49f2a3e Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-12-phi...@redhat.com> Signed-off-by: Laurent Vivier --- target/i386/whpx-all.c | 2 +

[PULL 00/17] Trivial branch patches

The following changes since commit 6c599282f8ab382fe59f03a6cae755b89561a7b3: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2020-02-15-v2' into staging (2020-02-17 13:32:25 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pu

Re: [PATCH v5 2/5] gpiolib: Add support for GPIO line table lookup

On Tue, Feb 18, 2020 at 4:18 PM Geert Uytterhoeven wrote: > Currently GPIOs can only be referred to by GPIO controller and offset in > GPIO lookup tables. > > Add support for looking them up by line name. > Rename gpiod_lookup.chip_label to gpiod_lookup.key, to make it clear > that this field can

[PULL 11/17] tests/qtest/libqos/qgraph: Remove superfluous semicolons

From: Philippe Mathieu-Daudé Fixes: fc281c80202 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-13-phi...@redhat.com> Signed-off-by: Laurent Vivier --- tests/qtest/libqos/qgraph.c

[PULL 09/17] ui/input-barrier: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 6105683da35 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-11-phi...@redhat.com> Signed-off-by: Laurent Vivier --- ui/input-barrier.c | 2 +- 1

[PULL 01/17] mailmap: Add entry for Yu-Chen Lin

From: Yu-Chen Lin I have two mail address, add entries for showing author and email correctly. Signed-off-by: Yu-Chen Lin Reviewed-by: Philippe Mathieu-Daudé Acked-by: Yu-Chen Lin Message-Id: <20200206125504.7150-1-npes87...@gmail.com> Signed-off-by: Laurent Vivier --- .mailmap | 3 ++- 1 f

[PULL 17/17] hw/xtensa/xtfpga:fix leak of fdevice tree blob

From: Chen Qun The device tree blob returned by load_device_tree is malloced. We should free it after cpu_physical_memory_write(). Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: Max Filippov Reviewed-by: Laurent Vivier Message-Id: <20200218091154.21696-4-kuhn.chen...@huawei.com>

[PULL 15/17] hw/net/rocker: Report unimplemented feature with qemu_log_mask(UNIMP)

From: Philippe Mathieu-Daudé Fix warnings reported by Clang static code analyzer: CC hw/net/rocker/rocker.o hw/net/rocker/rocker.c:213:9: warning: Value stored to 'tx_tso_mss' is never read tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]); ^

[PULL 08/17] hw/vfio/display: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: 8b818e059bf Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-9-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/vfio/display.c | 2 +- 1 f

[PULL 12/17] contrib/rdmacm-mux: Remove superfluous semicolon

From: Philippe Mathieu-Daudé Fixes: a5d2f6f8773 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20200218094402.26625-14-phi...@redhat.com> Signed-off-by: Laurent Vivier --- contrib/rdmacm-mux/main.c |

[PULL 14/17] hw/block/pflash_cfi02: Remove unneeded variable assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC hw/block/pflash_cfi02.o hw/block/pflash_cfi02.c:311:5: warning: Value stored to 'ret' is never read ret = -1; ^ ~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Da

[PULL 13/17] hw/display/qxl: Remove unneeded variable assignment

From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: hw/display/qxl.c:1634:14: warning: Value stored to 'orig_io_port' during its initialization is never read uint32_t orig_io_port = io_port; ^~~~ ~~~ Reported-by: Clang Static An

[PULL 16/17] hw/nios2:fix leak of fdevice tree blob

From: Chen Qun The device tree blob returned by load_device_tree is malloced. We should free it after cpu_physical_memory_write(). Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200218091154.21696-2-kuhn.chen...@huawei.com> Signed-off-by: Laurent V

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

Am 19.02.2020 um 10:03 hat Markus Armbruster geschrieben: > >> >> @@ -246,8 +287,15 @@ void monitor_qmp_bh_dispatcher(void *data) > >> >>} > >> >>qmp_request_free(req_obj); > >> >> > >> >> -/* Reschedule instead of looping so the main loop stays > >> >> responsive

Re: [PATCH] iotests/279: Fix for non-qcow2 formats

On 19.12.19 15:42, Max Reitz wrote: > First, driver=qcow2 will not work so well with non-qcow2 formats (and > this test claims to support qcow, qed, and vmdk). > > Second, vmdk will always report the backing file format to be vmdk. > Filter that out so the output looks like for all other formats.

Re: [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE()

On Fri, Feb 14, 2020 at 05:17:10PM +, Stefan Hajnoczi wrote: > QLIST_REMOVE() assumes the element is in a list. It also leaves the > element's linked list pointers dangling. > > Introduce a safe version of QLIST_REMOVE() and convert open-coded > instances of this pattern. > > Signed-off-by:

Re: [PATCH v2 0/5] block: Generic file creation fallback

On 22.01.20 17:45, Max Reitz wrote: > Hi, > > As version 1, this series adds a fallback path for creating files (on > the protocol layer) if the protocol driver does not support file > creation, but the file already exists. > > > Branch: https://github.com/XanClic/qemu.git skip-proto-create-v2 >

Re: [PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

On 21.01.20 16:59, Max Reitz wrote: > Hi, > > When reviewing David’s series to add --target-is-zero convert, I looked > for a case to show that the current implementation will crash if > -n --target-is-zero is used together with -B. It then turned out that > -B will always crash when combined wit

Re: [PATCH 4/5] aio-posix: make AioHandler deletion O(1)

On Fri, Feb 14, 2020 at 05:17:11PM +, Stefan Hajnoczi wrote: > It is not necessary to scan all AioHandlers for deletion. Keep a list > of deleted handlers instead of scanning the full list of all handlers. > > The AioHandler->deleted field can be dropped. Let's check if the > handler has bee

Re: [PATCH 0/2] block: Fix VM size field width in snapshot dump

On 17.01.20 11:58, Max Reitz wrote: > Hi, > > https://bugs.launchpad.net/qemu/+bug/1859989 reports that fields in > "qemu-img snapshot -l"s output are not always separated by spaces in > 4.1.1. Fix that. > > > Branch: https://github.com/XanClic/qemu.git lp-1859989-v1 > Branch: https://git.xancl

Re: [PATCH v2 0/5] block: Generic file creation fallback

On Wed, 2020-02-19 at 11:38 +0100, Max Reitz wrote: > On 22.01.20 17:45, Max Reitz wrote: > > Hi, > > > > As version 1, this series adds a fallback path for creating files (on > > the protocol layer) if the protocol driver does not support file > > creation, but the file already exists. > > > >

Re: [PATCH v2 0/2] finish qemu-nbd --partition deprecation

On 31.01.20 18:11, Eric Blake wrote: > ping Do you want further review or is Ján’s sufficient for you? Also, I wonder whether it would make a good GSoC/Outreachy/... project to add partition reading support to the raw block driver, or whether that’s a bad idea. O:-) Max signature.asc Descript

Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll

On Fri, Feb 14, 2020 at 05:17:12PM +, Stefan Hajnoczi wrote: > File descriptor monitoring is O(1) with epoll(7), but > aio_dispatch_handlers() still scans all AioHandlers instead of > dispatching just those that are ready. This makes aio_poll() O(n) with > respect to the total number of regist

Re: [PATCH] util/async: make bh_aio_poll() O(1)

Really a great idea, though I have some remarks on the implementation below. On 19/02/20 11:00, Stefan Hajnoczi wrote: > + * Each aio_bh_poll() call carves off a slice of the BH list. This way newly > + * scheduled BHs are not processed until the next aio_bh_poll() call. This > + * concept exten

Re: Cross-project NBD extension proposal: NBD_INFO_INIT_STATE

On 18.02.20 21:55, Eric Blake wrote: > On 2/17/20 9:13 AM, Max Reitz wrote: >> Hi, >> >> It’s my understanding that without some is_zero infrastructure for QEMU, >> it’s impossible to implement this flag in qemu’s NBD server. > > You're right that we may need some more infrastructure before being

Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll

On 14/02/20 18:17, Stefan Hajnoczi wrote: > +while ((node = QLIST_FIRST(ready_list))) { > +QLIST_SAFE_REMOVE(node, node_ready); Why does this need safe remove? Paolo > +progress = aio_dispatch_handler(ctx, node) || progress; > +}

Re: [PATCH v3 02/12] ppc: Remove stub of PPC970 HID4 implementation

On Wed, 19 Feb 2020, David Gibson wrote: The PowerPC 970 CPU was a cut-down POWER4, which had hypervisor capability. However, it can be (and often was) strapped into "Apple mode", where the hypervisor capabilities were disabled (essentially putting it always in hypervisor mode). That's actually

Re: [PATCH v2 fixed 01/16] util: vfio-helpers: Factor out and fix processing of existing ram blocks

On 19.02.20 09:43, David Hildenbrand wrote: > On 18.02.20 23:00, Peter Xu wrote: >> On Wed, Feb 12, 2020 at 02:42:39PM +0100, David Hildenbrand wrote: >>> Factor it out into common code when a new notifier is registered, just >>> as done with the memory region notifier. This allows us to have the >

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

Am Thu, 16 Jan 2020 19:26:39 +0100 schrieb Paolo Bonzini : > On 16/01/20 19:03, Olaf Hering wrote: > [...] > > This patch is wrong; xenfv does not support cross-version migration > compatibility. Even if the migration stream does not change, the > hardware exposed to the guest will. > > My u

Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_ioeventfds()

On 18/02/20 19:22, Stefan Hajnoczi wrote: > + * It is likely that the number of ioeventfds hasn't changed much, so use > + * the previous size as the starting value. > + */ > +ioeventfd_max = as->ioeventfd_nb; > +ioeventfds = g_new(MemoryRegionIoeventfd, ioeventfd_max); This wo

Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_ioeventfds()

On 19/02/20 10:18, Stefan Hajnoczi wrote: >> ... do exponential increase here (max*=2) instead so still easy to >> converge? > I'm happy to tweak the policy. Let's see what Paolo thinks. I included Peter's suggestion in my own tweak. Thanks to both of you! Paolo

[PATCH v2 0/2] This small series does two things:

(1) Convert the original qemu-cpu-models.texi to rST (2) In a separate patch, incorporate the additional new content from this: https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg06455.html ([PATCH v3] qemu-cpu-models: Document -noTSX, mds-no, taa-no, and tsx-ctrl) A Sphi

[PATCH v2 2/2] qemu-cpu-models.rst: Document -noTSX, mds-no, taa-no, and tsx-ctrl

- Add the '-noTSX' variants for CascadeLake and SkyLake. - Document the three MSR bits: 'mds-no', 'taa-no', and 'tsx-ctrl' Two confusing things about 'mds-no' (and the first point applies to the other two MSRs too): (1) The 'mds-no' bit will _not_ show up in the guest's /proc/cpuinfo.

[PATCH v2 1/2] docs: Convert qemu-cpu-models.texi to rST

This doc was originally written by Daniel P. Berrangé , introduced via commit[1]: 2544e9e4aa (docs: add guidance on configuring CPU models for x86, 2018-06-27). This is a 1-1 conversion of Texinfo to rST, besides a couple of minor non-content tweaks that are too trivial to spell out. Further modi

Re: [PATCH v2 0/2] This small series does two things:

Patchew URL: https://patchew.org/QEMU/20200219114607.1855-1-kcham...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

qemu-cpu-models: Convert to rST; document other MSR bits [Was: Re: [PATCH v2 0/2] This small series does two things:]

[Fix the subject line of the cover letter; sorry, it was my first time (mis-)use of `git-publish`.] On Wed, Feb 19, 2020 at 12:46:05PM +0100, Kashyap Chamarthy wrote: > (1) Convert the original qemu-cpu-models.texi to rST > > (2) In a separate patch, incorporate the additional new content from >

Re: [PATCH] pcie_root_port: Add disable_hotplug option

On Wed, Feb 19, 2020 at 4:47 AM Michael S. Tsirkin wrote: > > On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote: > > Also, is there a rhyme/reason for some options having true/false, and some > > being off/on? disable-acs seems to be true/false, but disable-modern is > > on/off. Doesn't

Re: [PATCH v5 79/79] tests:numa-test: use explicit memdev to specify node RAM

On Tue, 18 Feb 2020 18:51:34 +0100 Philippe Mathieu-Daudé wrote: > On 2/17/20 6:34 PM, Igor Mammedov wrote: > > Follow up patches will remove automatic RAM distribution > > between nodes and will make default machine types require > > "memdev" option instead of legacy "mem" option. > > Can we

Re: [PATCH v3 1/4] luks: extract qcrypto_block_calculate_payload_offset()

On 11.02.20 17:03, Stefan Hajnoczi wrote: > The qcow2 .bdrv_measure() code calculates the crypto payload offset. > This logic really belongs in crypto/block.c where it can be reused by > other image formats. > > The "luks" block driver will need this same logic in order to implement > .bdrv_measur

Re: [PATCH v2 1/2] docs: Convert qemu-cpu-models.texi to rST

On Wed, 19 Feb 2020 at 11:46, Kashyap Chamarthy wrote: > > This doc was originally written by Daniel P. Berrangé > , introduced via commit[1]: 2544e9e4aa (docs: add > guidance on configuring CPU models for x86, 2018-06-27). > > This is a 1-1 conversion of Texinfo to rST, besides a couple of minor

Re: [PATCH v2 14/22] qemu-iotests/199: better catch postcopy time

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: The test aims to test _postcopy_ migration, and wants to do some write operations during postcopy time. Test considers migrate status=complete event on source as start of postcopy. This is completely wrong, completion is completion of the

RE: RFC: Split EPT huge pages in advance of dirty logging

Hi Peter, > -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, February 19, 2020 1:43 AM > To: Zhoujian (jay) > Cc: k...@vger.kernel.org; qemu-devel@nongnu.org; pbonz...@redhat.com; > dgilb...@redhat.com; quint...@redhat.com; Liujinsong (Paul) > ; linfeng (M

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

On 18/02/2020 23:57, Eric Blake wrote: On 2/18/20 2:02 PM, Andrey Shinkevich wrote: qemu-iotests:$ ./check -qcow2 PASSED (except always failed 261 and 272) Have you reported those failures on the threads that introduced those tests? Not yet unfortunately. I have not investigated the ca

[PATCH 0/2] block/curl: Improve HTTP header parsing

An HTTP object store of my acquaintance returns "accept-ranges: bytes" (all lower case) as a header, causing the QEMU curl backend to refuse to talk to it. RFC 7230 says that HTTP headers are case insensitive, so update the curl backend accordingly. At the same time, allow for arbitrary white spac

[PATCH 2/2] block/curl: HTTP header field names are case insensitive

RFC 7230 section 3.2 indicates that HTTP header field names are case insensitive. Signed-off-by: David Edmondson --- block/curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index 0cf99a4b31b8..4256659cd85b 100644 --- a/block/curl.c +++ b/b

[PATCH 1/2] block/curl: HTTP header fields allow whitespace around values

RFC 7230 section 3.2 indicates that whitespace is permitted between the field name and field value and after the field value. Signed-off-by: David Edmondson --- block/curl.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/block/curl.c b/block/

Re: [PATCH v2 0/2] finish qemu-nbd --partition deprecation

On 2/19/20 4:53 AM, Max Reitz wrote: On 31.01.20 18:11, Eric Blake wrote: ping Do you want further review or is Ján’s sufficient for you? Commit 0bc16997 has already landed, so no further review will show in git history. But you're always welcome to raise issues that might result in follow

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

On 2/19/20 7:25 AM, Andrey Shinkevich wrote: On 18/02/2020 23:57, Eric Blake wrote: On 2/18/20 2:02 PM, Andrey Shinkevich wrote: qemu-iotests:$ ./check -qcow2 PASSED (except always failed 261 and 272) Have you reported those failures on the threads that introduced those tests? Not yet

Re: [PATCH v5 27/79] arm/palm: use memdev for RAM

On Tue, 18 Feb 2020 18:22:06 +0100 Philippe Mathieu-Daudé wrote: > On 2/17/20 6:34 PM, Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > > replace it with memdev allocated MemoryRegion. The later is > > initialized by generic code, so board only needs to opt

Re: [PATCH v5 11/79] arm/collie: use memdev for RAM

On Tue, 18 Feb 2020 18:16:14 +0100 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 2/17/20 6:33 PM, Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > > replace it with memdev allocated MemoryRegion. The later is > > initialized by generic code, so board only

Re: [PATCH v5 34/79] arm/xilinx_zynq: drop RAM size fixup

On Tue, 18 Feb 2020 18:23:47 +0100 Philippe Mathieu-Daudé wrote: > On 2/17/20 6:34 PM, Igor Mammedov wrote: > > If user provided non-sense RAM size, board will complain and > > continue running with max RAM size supported. > > Also RAM is going to be allocated by generic code, so it won't be > >

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

On 19/02/2020 16:36, Eric Blake wrote: On 2/19/20 7:25 AM, Andrey Shinkevich wrote: On 18/02/2020 23:57, Eric Blake wrote: On 2/18/20 2:02 PM, Andrey Shinkevich wrote: qemu-iotests:$ ./check -qcow2 PASSED (except always failed 261 and 272) Have you reported those failures on the threads

RE: [PATCH 1/3] arm_gic: Mask the un-supported priority bits

Hi Peter, All your suggestions look good, I will send at V2. But I think I have done a mistake in V1, More comments inline below. > -Original Message- > From: Peter Maydell > Sent: Tuesday, February 18, 2020 11:40 PM > To: Sai Pavan Boddu > Cc: Edgar E . Iglesias ; Alistair Francis >

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

On 2/19/20 7:36 AM, Eric Blake wrote: +od: unrecognized option '--endian=big' +Try 'od --help' for more information. +od: invalid -N argument '--endian=big' +qemu-img: Could not open 'TEST_DIR/t.IMGFMT': IMGFMT header exceeds cluster size Which version of od are you using?  I do recall wonder

Re: [PATCH 2/2] block/curl: HTTP header field names are case insensitive

Hi David, On 2/19/20 2:27 PM, David Edmondson wrote: RFC 7230 section 3.2 indicates that HTTP header field names are case insensitive. Signed-off-by: David Edmondson --- block/curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index 0c

Re: [PATCH v5 11/79] arm/collie: use memdev for RAM

On 2/19/20 2:44 PM, Igor Mammedov wrote: On Tue, 18 Feb 2020 18:16:14 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 2/17/20 6:33 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by

Re: [PATCH v5 79/79] tests:numa-test: use explicit memdev to specify node RAM

On 2/19/20 2:00 PM, Igor Mammedov wrote: On Tue, 18 Feb 2020 18:51:34 +0100 Philippe Mathieu-Daudé wrote: On 2/17/20 6:34 PM, Igor Mammedov wrote: Follow up patches will remove automatic RAM distribution between nodes and will make default machine types require "memdev" option instead of lega

Re: [PATCH v5 27/79] arm/palm: use memdev for RAM

On 2/19/20 2:44 PM, Igor Mammedov wrote: On Tue, 18 Feb 2020 18:22:06 +0100 Philippe Mathieu-Daudé wrote: On 2/17/20 6:34 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic co

Re: [PATCH v3 04/12] target/ppc: Introduce ppc_hash64_use_vrma() helper

David Gibson writes: > When running guests under a hypervisor, the hypervisor obviously needs to > be protected from guest accesses even if those are in what the guest > considers real mode (translation off). The POWER hardware provides two > ways of doing that: The old way has guest real mode a

Re: [PATCH v2 0/2] This small series does two things:

On Wed, Feb 19, 2020 at 04:05:56AM -0800, no-re...@patchew.org wrote: [...] > The full log is available at > http://patchew.org/logs/20200219114607.1855-1-kcham...@redhat.com/testing.docker-mingw@fedora/?type=message. Patchew is right -- I forgot the Makefile changes. Hence the failure: ma

Re: [PATCH v5 34/79] arm/xilinx_zynq: drop RAM size fixup

On 2/19/20 2:44 PM, Igor Mammedov wrote: On Tue, 18 Feb 2020 18:23:47 +0100 Philippe Mathieu-Daudé wrote: On 2/17/20 6:34 PM, Igor Mammedov wrote: If user provided non-sense RAM size, board will complain and continue running with max RAM size supported. Also RAM is going to be allocated by ge

Re: [PATCH v3 01/12] ppc: Remove stub support for 32-bit hypervisor mode

David Gibson writes: > a4f30719a8cd, way back in 2007 noted that "PowerPC hypervisor mode is not > fundamentally available only for PowerPC 64" and added a 32-bit version > of the MSR[HV] bit. > > But nothing was ever really done with that; there is no meaningful support > for 32-bit hypervisor m

Re: [PATCH v5 2/4] vl: Initialise main loop earlier

On Tue, Feb 18, 2020 at 04:40:34PM +0100, Kevin Wolf wrote: > We want to be able to use qemu_aio_context in the monitor > initialisation. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-André Lureau > Reviewed-by: Markus Armbruster > --- > vl.c | 10 +- > 1 file changed, 5 insertions

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

Am Wed, 19 Feb 2020 12:35:30 +0100 schrieb Olaf Hering : > Is any of the things done by pc_i440fx_5_0_machine_options and > pc_i440fx_machine_options a desired, or even breaking, change for the > current result of pc_xen_hvm_init? I tried to follow a few of the initialized members: default_nic_m

Re: [PATCH v2 15/22] qemu-iotests/199: improve performance: set bitmap by discard

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Discard dirties dirty-bitmap as well as write, but works faster. Let's use it instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/199 | 31 --- 1 file changed, 20 insertions(+), 11 de

Re: [PATCH v2 03/22] migration/block-dirty-bitmap: rename dirty_bitmap_mig_cleanup

18.02.2020 14:00, Andrey Shinkevich wrote: On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Rename dirty_bitmap_mig_cleanup to dirty_bitmap_do_save_cleanup, to stress that it is on save part. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   migration/block-dirty-bitmap.c | 8

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

Kevin Wolf writes: > Am 19.02.2020 um 10:03 hat Markus Armbruster geschrieben: >> >> >> @@ -246,8 +287,15 @@ void monitor_qmp_bh_dispatcher(void *data) >> >> >>} >> >> >>qmp_request_free(req_obj); >> >> >> >> >> >> -/* Reschedule instead of looping so the main loo

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

Markus Armbruster writes: [...] > If you agree with my proposed tweaks, and nothing else comes up, I can > try to do them in my tree. I'll tweak your v5, of course.

Re: [PATCH v5 79/79] tests:numa-test: use explicit memdev to specify node RAM

On Wed, 19 Feb 2020 15:06:24 +0100 Philippe Mathieu-Daudé wrote: > On 2/19/20 2:00 PM, Igor Mammedov wrote: > > On Tue, 18 Feb 2020 18:51:34 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> On 2/17/20 6:34 PM, Igor Mammedov wrote: > >>> Follow up patches will remove automatic RAM distributi

Race condition in overlayed qcow2?

Hi! I encountered a problem with record/replay of QEMU execution and figured out the following, when QEMU is started with one virtual disk connected to the qcow2 image with applied 'snapshot' option. The patch d710cf575ad5fb3ab329204620de45bfe50caa53 "block/qcow2: introduce parallel subreque

Re: [PATCH v2 16/22] qemu-iotests/199: change discard patterns

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: iotest 40 works too long because of many discard opertion. On the same operations At the same time time, postcopy period is very short, in spite of all these efforts. So, let's use less discards (and with more interesting patterns) to

Re: [PATCH v3 11/12] target/ppc: Streamline construction of VRMA SLB entry

David Gibson writes: Hi, just a nitpick, feel free to ignore. > When in VRMA mode (i.e. a guest thinks it has the MMU off, but the > hypervisor is still applying translation) we use a special SLB entry, > rather than looking up an SLBE by address as we do when guest translation > is on. > > We

[PATCH] iotests: Fix nonportable use of od --endian

Tests 261 and 272 fail on RHEL 7 with coreutils 8.22, since od --endian was not added until coreutils 8.23. Fix this by manually constructing the final value one byte at a time. Fixes: fc8ba423 Reported-by: Andrey Shinkevich Signed-off-by: Eric Blake --- tests/qemu-iotests/common.rc | 22 +

  1   2   3   4   >