Re: [PATCH 1/2] tests/migration: Fail on unexpected migration states

2019-09-24 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > We've got various places where we wait for a migration to enter > a given state; but if we enter an unexpected state we tend to fail > in odd ways; add a mechanism for explicitly testing for any state > which we shouldn't

Re: [PATCH 2/2] tests/migration/postcopy: trim migration bandwidth

2019-09-24 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > On slow hosts with tcg we were sometimes finding that the migration > would complete during precopy and never get into the postcopy test. > Trim back the bandwidth a bit to make that much less likely. > > Signed-off-by: Dr

Re: [PATCH 1/4] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 14:59:49 +1000 David Gibson wrote: > Currently ics_reject(), ics_resend() and ics_eoi() indirect through > class methods. But there's only one implementation of each method, > the one in TYPE_ICS_SIMPLE. TYPE_ICS_BASE has no implementation, but > it's never instantiated, and

Re: [PATCH] migration/postcopy: Recognise the recovery states as 'in_postcopy'

2019-09-24 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Various parts of the migration code do different things when they're > in postcopy mode; prior to this patch this has been 'postcopy-active'. > This patch extends 'in_postcopy' to include 'postcopy-paused' and > 'postcopy-

Re: KVM call for 2019-09-24

2019-09-24 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Summit, we are going to have always open a > KVM call where you

KVM call for 2019-10-08

2019-09-24 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

Re: Debian support lifetime (was Re: [PATCH] docker: move tests from python2 to python3)

2019-09-24 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 04:05:33PM -0300, Eduardo Habkost wrote: > On Mon, Sep 23, 2019 at 01:19:41PM -0400, John Snow wrote: > > On 9/23/19 10:50 AM, Cleber Rosa wrote: > [...] > > >> diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker > > >> b/tests/docker/dockerfiles/debian-xtensa-

Re: [PATCH 2/4] xics: Merge reset and realize hooks

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 14:59:50 +1000 David Gibson wrote: > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and > realize methods, using the standard technique for having the subtype > call the supertype's methods before doing its own thing. > > But TYPE_XICS_SIMPLE is the only s

Re: [PATCH 3/4] xics: Rename misleading ics_simple_*() functions

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 14:59:51 +1000 David Gibson wrote: > There are a number of ics_simple_*() functions that aren't actually > specific to TYPE_XICS_SIMPLE at all, and are equally valid on > TYPE_XICS_BASE. Rename them to ics_*() accordingly. > > Signed-off-by: David Gibson > --- Reviewed-by:

Re: [PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 14:59:52 +1000 David Gibson wrote: > TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever > instantiated, and the only one we're ever likely to want. The > existence of different classes is just a hang over from when we > (misguidedly) had separate subtypes for th

Re: [PATCH] target/riscv: Bugfix reserved bits in PTE for RV64

2019-09-24 Thread Guo Ren
Ok, In fact it's wrong patch, don't try it. pte is destroyed. Sorry for that, I'll send V2. On Tue, Sep 24, 2019 at 1:03 PM Alistair Francis wrote: > > On Mon, Sep 23, 2019 at 10:01 PM wrote: > > > > From: Guo Ren > > > > Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we

Re: [PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > Use this as a compile-time assert that a particular > code path is not reachable. > > Signed-off-by: Richard Henderson > --- > include/qemu/compiler.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/qemu/compiler.h

[PATCH] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes

2019-09-24 Thread Thomas Huth
When I run QEMU with KVM under Valgrind, I currently get this warning: Syscall param ioctl(generic) points to uninitialised byte(s) at 0x95BA45B: ioctl (in /usr/lib64/libc-2.28.so) by 0x429DC3: kvm_ioctl (kvm-all.c:2365) by 0x51B249: kvm_arch_get_supported_msr_feature (kvm.c:469)

Re: [PATCH v4 04/16] cputlb: Use optimize_away in load/store_helpers

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > Increase the current runtime assert to a compile-time assert. > > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > ind

Re: [PATCH v4 05/16] cputlb: Split out load/store_memop

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > We will shortly be using these more than once. > > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 110 +++-- > 1 file changed, 57 insertions(+), 53 deletions(-) > > diff --git a/accel/tcg/cputlb

Re: [Qemu-devel] [PATCH v3 18/22] fuzz: expose fuzz target name

2019-09-24 Thread Darren Kenny
On Wed, Sep 18, 2019 at 11:19:45PM +, Oleinik, Alexander wrote: This is needed for the qos-assisted fuzzers which walk the qos tree and need a way to check if the current path matches the name of the fuzz target. Signed-off-by: Alexander Oleinik --- tests/fuzz/fuzz.c | 3 +++ tests/fuzz/fuzz

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 07:22:51 +0200 Cédric Le Goater wrote: > On 24/09/2019 06:59, David Gibson wrote: > > The XICS interrupt controller device used to have separate subtypes > > for the KVM and non-KVM variant of the device. That was a bad idea, > > because it leaked information that should be e

Re: [RFC v2 7/9] Use auto-propagated errp

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2019 23:30, Eric Blake wrote: > On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> This commit is generated by command >> >> git grep -l 'Error \*\*errp' | while read f; \ >> do spatch --sp-file \ >> scripts/coccinelle/auto-propagated-errp.cocci --in-place $f; done >> > > As mention

[PATCH V2] target/riscv: Bugfix reserved bits in PTE for RV64

2019-09-24 Thread guoren
From: Guo Ren Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we need to ignore them. They can not be a part of ppn. 1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture 4.4 Sv39: Page-Based 39-bit Virtual-Memory System 4.5 Sv48: Page-Based 48-bit

Re: [PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > There is only one caller, tlb_set_page_with_attrs. We cannot > inline the entire function because the AddressSpaceDispatch > structure is private to exec.c, and cannot easily be moved to > include/exec/memory-internal.h. > > Compute is_ram and is_romd

[Bug 1824704] Re: -k tr not working after v20171217! turkish keyboard dont working

2019-09-24 Thread Thomas Huth
I meant which version of QEMU is still working for you? Which version fails? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824704 Title: -k tr

Re: [PATCH V2] target/riscv: Bugfix reserved bits in PTE for RV64

2019-09-24 Thread Guo Ren
I only tested it on qemu-3.1.0, pls have a try before merge. On Tue, Sep 24, 2019 at 4:00 PM wrote: > > From: Guo Ren > > Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we > need to ignore them. They can not be a part of ppn. > > 1: The RISC-V Instruction Set Manual, Volum

Re: [PATCH v4 11/16] cputlb: Merge and move memory_notdirty_write_{prepare,complete}

2019-09-24 Thread David Hildenbrand
[...] > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -33,6 +33,7 @@ > #include "exec/helper-proto.h" > #include "qemu/atomic.h" > #include "qemu/atomic128.h" > +#include "translate-all.h" > > /* DEBUG defines, enable DEBUG_TLB_LOG to log to the CPU_LOG_MMU target */ > /* #define

Re: [PATCH v9 2/3] block/nbd: nbd reconnect

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2019 22:23, Eric Blake wrote: > On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: >> Implement reconnect. To achieve this: >> >> 1. add new modes: >> connecting-wait: means, that reconnecting is in progress, and there >> were small number of reconnect attempts, so all request

Re: [PATCH v4 12/16] cputlb: Handle TLB_NOTDIRTY in probe_access

2019-09-24 Thread David Hildenbrand
On 24.09.19 01:00, Richard Henderson wrote: > We can use notdirty_write for the write and > return a valid host pointer for this case. > > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --g

Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

2019-09-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-cr...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190923134019.8548-1-cr...@redhat.com Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23 Typ

[PATCH v4 0/2] Allow memory_region_register_iommu_notifier() to fail

2019-09-24 Thread Eric Auger
This series allows the memory_region_register_iommu_notifier() to fail. As of now, when a MAP notifier is attempted to be registered along with SMMUv3 or AMD IOMMU, we exit in the IOMMU MR notify_flag_changed() callback. In case of VFIO assigned device hotplug, this could be handled more nicely di

[PATCH v4 1/2] vfio: Turn the container error into an Error handle

2019-09-24 Thread Eric Auger
The container error integer field is currently used to store the first error potentially encountered during any vfio_listener_region_add() call. However this fails to propagate detailed error messages up to the vfio_connect_container caller. Instead of using an integer, let's use an Error handle.

[PATCH v4 2/2] memory: allow memory_region_register_iommu_notifier() to fail

2019-09-24 Thread Eric Auger
Currently, when a notifier is attempted to be registered and its flags are not supported (especially the MAP one) by the IOMMU MR, we generally abruptly exit in the IOMMU code. The failure could be handled more nicely in the caller and especially in the VFIO code. So let's allow memory_region_regi

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2019 22:51, Eric Blake wrote: > On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: >> Add test, which starts backup to nbd target and restarts nbd server >> during backup. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/264| 65 +

Re: [PATCH] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes

2019-09-24 Thread Paolo Bonzini
On 24/09/19 09:47, Thomas Huth wrote: > When I run QEMU with KVM under Valgrind, I currently get this warning: > > Syscall param ioctl(generic) points to uninitialised byte(s) > at 0x95BA45B: ioctl (in /usr/lib64/libc-2.28.so) > by 0x429DC3: kvm_ioctl (kvm-all.c:2365) > by 0x51B249: k

[PATCH 0/2] RTC support for QEMU RISC-V virt machine

2019-09-24 Thread Anup Patel
This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is already available in Linux so we just need to enable it in Kco

[PATCH 2/2] riscv: virt: Use Goldfish RTC device

2019-09-24 Thread Anup Patel
We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel --- hw/riscv/Kconfig| 1 + hw/riscv/virt.c | 15 +++ include/hw/riscv/virt.h

[PATCH 1/2] hw: timer: Add Goldfish RTC device

2019-09-24 Thread Anup Patel
This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM migr

Re: [PATCH] qemu-pr-helper: fix crash in mpath_reconstruct_sense

2019-09-24 Thread Paolo Bonzini
On 24/09/19 01:38, Maxim Levitsky wrote: > The 'r' variable was accidently shadowed, and because of this > we were always passing 0 to mpath_generic_sense, instead of original > return value, which triggers an abort() > > This is an attempt to fix the > https://bugzilla.redhat.com/show_bug.cgi?id=

git format.from (was: 9p: Fix file ID collisions)

2019-09-24 Thread Christian Schoenebeck via
On Dienstag, 24. September 2019 00:24:15 CEST Jeff King wrote: > > On the other hand, considering the already existing --from argument and > > "format.from" config option: > > https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatfro > > m > > > > Wouldn't it make sense to just dr

Re: Debian support lifetime (was Re: [PATCH] docker: move tests from python2 to python3)

2019-09-24 Thread Daniel P . Berrangé
On Tue, Sep 24, 2019 at 08:35:13AM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2019 at 04:05:33PM -0300, Eduardo Habkost wrote: > > On Mon, Sep 23, 2019 at 01:19:41PM -0400, John Snow wrote: > > > On 9/23/19 10:50 AM, Cleber Rosa wrote: > > [...] > > > >> diff --git a/tests/docker/dockerfile

[PATCH v9 4/3] iotests: test nbd reconnect

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Updated test: avoid race conditions + some improvements. - introduce qemu_io_silent_check and use it to wait for NBD server start - use size variable instead o

Re: [Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

2019-09-24 Thread Christian Schoenebeck via
On Montag, 23. September 2019 18:50:12 CEST Greg Kurz wrote: > > > > If yes, and since that would mean I was the only person ever having > > > > tested > > > > the actual fix, shouldn't --multidevs=remap|forbid better be marked as > > > > experimental (docs and runtime warning) for now? Maybe that

Re: illegal hardware instruction during MIPS-I ELF linux useremulation

2019-09-24 Thread Peter Maydell
On Tue, 24 Sep 2019 at 02:10, Libo Zhou wrote: > > > Can you run QEMU with some debugging options: > > > qemu-mipsel -d in_asm,exec,cpu,unimp,guest_errors,nochain -D debug.log > > -singlestep test > > > and then put the resulting debug.log somewhere we can get it? > > (it'll probably be quite larg

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/23/19 11:46 PM, Peter Maydell wrote: > On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: >> On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: >>> I don't think we should mirror what is used on ARM virt board to >>> create 2 flash for sifive_u. For ARM virt, there are 2 flashes because >>>

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-24 Thread Peter Maydell
On Tue, 24 Sep 2019 at 05:44, Thomas Huth wrote: > > On 23/09/2019 20.50, Peter Maydell wrote: > > On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote: > >> Just try to change "obj-$(CONFIG_ARM_V7M) += armv7m_nvic.o" into > >> "obj-y += armv7m_nvic.o" in hw/int/Makefile.objs, and you'll see it break:

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-24 Thread Auger Eric
Hi Alex, On 9/24/19 1:05 AM, Alex Williamson wrote: > On Mon, 23 Sep 2019 08:55:51 +0200 > Eric Auger wrote: > >> The container error integer field is currently used to store >> the first error potentially encountered during any >> vfio_listener_region_add() call. However this fails to propagate

Re: [PATCH 2/4] xics: Merge reset and realize hooks

2019-09-24 Thread Philippe Mathieu-Daudé
Hi David, On 9/24/19 6:59 AM, David Gibson wrote: > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and > realize methods, using the standard technique for having the subtype > call the supertype's methods before doing its own thing. > > But TYPE_XICS_SIMPLE is the only subtype

Re: [PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/24/19 6:59 AM, David Gibson wrote: > TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever > instantiated, and the only one we're ever likely to want. The > existence of different classes is just a hang over from when we > (misguidedly) had separate subtypes for the KVM and non-KVM

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/24/19 6:59 AM, David Gibson wrote: > The XICS interrupt controller device used to have separate subtypes > for the KVM and non-KVM variant of the device. That was a bad idea, > because it leaked information that should be entirely host-side > implementation specific to the kinda-sorta guest v

Re: [PATCH v4 01/10] block: switch reopen queue from QSIMPLEQ to QTAILQ

2019-09-24 Thread Max Reitz
On 07.08.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > We'll need reverse-foreach in the following commit, QTAILQ support it, > so move to QTAILQ. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block.h | 2 +- > block.c | 22 +++--- > 2 fil

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-24 Thread Thomas Huth
On 24/09/2019 11.42, Peter Maydell wrote: > On Tue, 24 Sep 2019 at 05:44, Thomas Huth wrote: >> >> On 23/09/2019 20.50, Peter Maydell wrote: >>> On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote: Just try to change "obj-$(CONFIG_ARM_V7M) += armv7m_nvic.o" into "obj-y += armv7m_nvic.o" in

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/23/19 4:34 PM, Peter Maydell wrote: > On Sat, 21 Sep 2019 at 16:04, Thomas Huth wrote: >> >> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >> CPUs should only be created if the switch is enabled. This can best >> be done if the code resides in a separate file, thus mov

Re: [PATCH 1/2] hw: timer: Add Goldfish RTC device

2019-09-24 Thread Peter Maydell
On Tue, 24 Sep 2019 at 09:45, Anup Patel wrote: > > This patch adds model for Google Goldfish virtual platform RTC device. > > We will be adding Goldfish RTC device to the QEMU RISC-V virt machine > for providing real date-time to Guest Linux. The corresponding Linux > driver for Goldfish RTC devi

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Cédric Le Goater
On 24/09/2019 09:52, Greg Kurz wrote: > On Tue, 24 Sep 2019 07:22:51 +0200 > Cédric Le Goater wrote: > >> On 24/09/2019 06:59, David Gibson wrote: >>> The XICS interrupt controller device used to have separate subtypes >>> for the KVM and non-KVM variant of the device. That was a bad idea, >>> b

Re: [PATCH 1/3] migration/postcopy: not necessary to do discard when canonicalizing bitmap

2019-09-24 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > All pages, either partially sent or partially dirty, will be discarded in > postcopy_send_discard_bm_ram(), since we update the unsentmap to be > unsentmap = unsentmap | dirty in ram_postcopy_send_discard_bitmap(). > > This is not necessary to do

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Philippe Mathieu-Daudé
Hi Cédric, On 9/24/19 11:55 AM, Cédric Le Goater wrote: > On 24/09/2019 09:52, Greg Kurz wrote: >> On Tue, 24 Sep 2019 07:22:51 +0200 >> Cédric Le Goater wrote: >> >>> On 24/09/2019 06:59, David Gibson wrote: The XICS interrupt controller device used to have separate subtypes for the KV

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/24/19 11:48 AM, Thomas Huth wrote: > On 24/09/2019 11.42, Peter Maydell wrote: >> On Tue, 24 Sep 2019 at 05:44, Thomas Huth wrote: >>> >>> On 23/09/2019 20.50, Peter Maydell wrote: On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote: > Just try to change "obj-$(CONFIG_ARM_V7M) += armv7m

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Greg Kurz
On Tue, 24 Sep 2019 11:47:51 +0200 Philippe Mathieu-Daudé wrote: > On 9/24/19 6:59 AM, David Gibson wrote: > > The XICS interrupt controller device used to have separate subtypes > > for the KVM and non-KVM variant of the device. That was a bad idea, > > because it leaked information that should

Re: [PATCH v4 02/10] block: reverse order for reopen commits

2019-09-24 Thread Max Reitz
On 07.08.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > It's needed to fix reopening qcow2 with bitmaps to RW. Currently it > can't work, as qcow2 needs write access to file child, to mark bitmaps > in-image with IN_USE flag. But usually children goes after parents in > reopen queue and file child

Re: [PULL 11/48] riscv: Resolve full path of the given bios image

2019-09-24 Thread Peter Maydell
On Wed, 18 Sep 2019 at 16:35, Palmer Dabbelt wrote: > > From: Bin Meng > > At present when "-bios image" is supplied, we just use the straight > path without searching for the configured data directories. Like > "-bios default", we add the same logic so that "-L" actually works. > > Signed-off-by

Re: [PATCH 2/3] migration/postcopy: unsentmap is not necessary for postcopy

2019-09-24 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Commit f3f491fcd6dd594ba695 ('Postcopy: Maintain unsentmap') introduced > unsentmap to track not yet sent pages. > > This is not necessary since: > > * unsentmap is a sub-set of bmap before postcopy start > * unsentmap is the summation o

Re: [PATCH 3/3] migration: remove sent parameter in get_queued_page_not_dirty

2019-09-24 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > This is a cleanup for previous removal of unsentmap. > > The sent parameter is not necessary now. > > Signed-off-by: Wei Yang OK, you did... Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c| 2 +- > migration/trace-event

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/24/19 12:06 PM, Greg Kurz wrote: > On Tue, 24 Sep 2019 11:47:51 +0200 > Philippe Mathieu-Daudé wrote: > >> On 9/24/19 6:59 AM, David Gibson wrote: >>> The XICS interrupt controller device used to have separate subtypes >>> for the KVM and non-KVM variant of the device. That was a bad idea,

Re: [RFC v2 6/9] scripts: add coccinelle script to use auto propagated errp

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2019 0:29, Eric Blake wrote: > On 9/23/19 3:05 PM, Eric Blake wrote: > >> Does running this Coccinelle script 2 times in a row add a second >> ERRP_FUNCTION_BEGIN() line? We want it to be idempotent (no changes on >> a second run). (Admittedly, I did not actually test that yet). Also, I >

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-24 Thread Cédric Le Goater
On 24/09/2019 12:04, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 9/24/19 11:55 AM, Cédric Le Goater wrote: >> On 24/09/2019 09:52, Greg Kurz wrote: >>> On Tue, 24 Sep 2019 07:22:51 +0200 >>> Cédric Le Goater wrote: >>> On 24/09/2019 06:59, David Gibson wrote: > The XICS interrupt c

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Auger Eric
Hi Thomas, On 9/23/19 8:09 PM, Thomas Huth wrote: > On 23/09/2019 16.31, Auger Eric wrote: >> Hi Thomas, >> >> On 9/21/19 5:04 PM, Thomas Huth wrote: >>> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >>> CPUs should only be created if the switch is enabled. This can best >>

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Thomas Huth
On 24/09/2019 13.02, Auger Eric wrote: > Hi Thomas, > > On 9/23/19 8:09 PM, Thomas Huth wrote: >> On 23/09/2019 16.31, Auger Eric wrote: >>> Hi Thomas, >>> >>> On 9/21/19 5:04 PM, Thomas Huth wrote: We are going to make CONFIG_ARM_V7M optional, so the related cortex-m CPUs should only be

Re: [PATCH] ui: fix keymap file search in input-barrier object

2019-09-24 Thread Anthony PERARD
On Tue, Sep 24, 2019 at 12:06:58AM +0200, Laurent Vivier wrote: > If we try to start QEMU with "-k en-us", qemu prints a message and exits > with: > > qemu-system-i386: could not read keymap file: 'en-us' > > It's because this function is called way too early, before > qemu_add_data_dir() is

[Bug 1824704] Re: -k tr not working after v20171217! turkish keyboard dont working

2019-09-24 Thread Gerd Hoffmann
What does "localectl" print (both host and guest please)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824704 Title: -k tr not working after v20171217! turkish keyboard dont working Status in QE

RE: [PATCH 1/2] hw: timer: Add Goldfish RTC device

2019-09-24 Thread Anup Patel
> -Original Message- > From: Peter Maydell > Sent: Tuesday, September 24, 2019 3:21 PM > To: Anup Patel > Cc: Palmer Dabbelt ; Alistair Francis > ; Sagar Karandikar ; > Bastian Koppelmann ; Atish Patra > ; qemu-ri...@nongnu.org; qemu- > de...@nongnu.org; Anup Patel > Subject: Re: [PATC

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-24 Thread Igor Mammedov
On Mon, 23 Sep 2019 20:35:02 +0200 "Laszlo Ersek" wrote: > On 09/20/19 11:28, Laszlo Ersek wrote: > > On 09/20/19 10:28, Igor Mammedov wrote: > >> On Thu, 19 Sep 2019 19:02:07 +0200 > >> "Laszlo Ersek" wrote: > >> > >>> Hi Igor, > >>> > >>> (+Brijesh) > >>> > >>> long-ish pondering ahead, wi

Re: [PATCH v4 02/10] hw/core: create Resettable QOM interface

2019-09-24 Thread Damien Hedde
Hi All, Do you think I should respin with the sugestions made by David so far ? + reset type removal + s/init/enter/ for the phases terminology + handling of parent changes during reset On 9/18/19 11:11 AM, David Gibson wrote: > On Wed, Sep 11, 2019 at 04:56:13PM +0200, Damien Hedde wrote: >> >>

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Auger Eric
Hi Thomas, On 9/24/19 1:06 PM, Thomas Huth wrote: > On 24/09/2019 13.02, Auger Eric wrote: >> Hi Thomas, >> >> On 9/23/19 8:09 PM, Thomas Huth wrote: >>> On 23/09/2019 16.31, Auger Eric wrote: Hi Thomas, On 9/21/19 5:04 PM, Thomas Huth wrote: > We are going to make CONFIG_ARM_V7

[PULL 0/7] xen queue 2019-09-24

2019-09-24 Thread Anthony PERARD
le/aperard/qemu-dm.git tags/pull-xen-20190924 for you to fetch changes up to 6bd6b955c0b2666263700d39db153ab43c5e0c9e: xen-bus: only set the xen device frontend state if it is missing (2019-09-24 12:21:29 +0100) Xen queue *

[PULL 4/7] xen: perform XenDevice clean-up in XenBus watch handler

2019-09-24 Thread Anthony PERARD
From: Paul Durrant Cleaning up offline XenDevice objects directly in xen_device_backend_changed() is dangerous as xen_device_unrealize() will modify the watch list that is being walked. Even the QLIST_FOREACH_SAFE() used in notifier_list_notify() is insufficient as *two* notifiers (for the fronte

[PULL 1/7] xen-bus: check whether the frontend is active during device reset...

2019-09-24 Thread Anthony PERARD
From: Paul Durrant ...not the backend Commit cb323146 "xen-bus: Fix backend state transition on device reset" contained a subtle mistake. The hunk @@ -539,11 +556,11 @@ static void xen_device_backend_changed(void *opaque) /* * If the toolstack (or unplug request callback) has set th

[PATCH v4 3/9] target/arm: Allow SVE to be disabled via a CPU property

2019-09-24 Thread Andrew Jones
Since 97a28b0eeac14 ("target/arm: Allow VFP and Neon to be disabled via a CPU property") we can disable the 'max' cpu model's VFP and neon features, but there's no way to disable SVE. Add the 'sve=on|off' property to give it that flexibility. We also rename cpu_max_get/set_sve_vq to cpu_max_get/set

[PULL 2/7] xen / notify: introduce a new XenWatchList abstraction

2019-09-24 Thread Anthony PERARD
From: Paul Durrant Xenstore watch call-backs are already abstracted away from XenBus using the XenWatch data structure but the associated NotifierList manipulation and file handle registration is still open coded in various xen_bus_...() functions. This patch creates a new XenWatchList data struc

[PATCH v4 0/9] target/arm/kvm: enable SVE in guests

2019-09-24 Thread Andrew Jones
Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. This series provides the QEMU bits for that enablement. First, we select existing CPU properties representing features we want to advertise in addition to the SVE vector lengths and prepare them for a qmp query. Then we introdu

[PATCH v4 4/9] target/arm/cpu64: max cpu: Introduce sve properties

2019-09-24 Thread Andrew Jones
Introduce cpu properties to give fine control over SVE vector lengths. We introduce a property for each valid length up to the current maximum supported, which is 2048-bits. The properties are named, e.g. sve128, sve256, sve384, sve512, ..., where the number is the number of bits. See the updates t

[PULL 7/7] xen-bus: only set the xen device frontend state if it is missing

2019-09-24 Thread Anthony PERARD
From: Mark Syms Some toolstack implementations will set the frontend xenstore keys to Initialising which will then trigger the in guest PV drivers to begin initialising and some implementations will then set their state to Closing. If this has occurred then device realize must not overwrite the f

[PULL 3/7] xen: introduce separate XenWatchList for XenDevice objects

2019-09-24 Thread Anthony PERARD
From: Paul Durrant This patch uses the XenWatchList abstraction to add a separate watch list for each device. This is more scalable than walking a single notifier list for all watches and is also necessary to implement a bug-fix in a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: An

[PATCH v4 6/9] target/arm/kvm64: max cpu: Enable SVE when available

2019-09-24 Thread Andrew Jones
Enable SVE in the KVM guest when the 'max' cpu type is configured and KVM supports it. KVM SVE requires use of the new finalize vcpu ioctl, so we add that now too. For starters SVE can only be turned on or off, getting all vector lengths the host CPU supports when on. We'll add the other SVE CPU pr

[PULL 5/7] MAINTAINERS: update my email address

2019-09-24 Thread Anthony PERARD
From: Paul Durrant My Citrix email address will expire shortly. Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20190913122418.848-1-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PULL 6/7] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-24 Thread Anthony PERARD
From: Paul Durrant When a frontend gracefully disconnects from an offline backend, it will set its own state to XenbusStateClosed. The code in xen-block.c correctly deals with this and sets the backend into XenbusStateClosed. Unfortunately it is possible for toolstack to actually delete the front

[PATCH v4 7/9] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features

2019-09-24 Thread Andrew Jones
kvm_arm_create_scratch_host_vcpu() takes a struct kvm_vcpu_init parameter. Rather than just using it as an output parameter to pass back the preferred target, use it also as an input parameter, allowing a caller to pass a selected target if they wish and to also pass cpu features. If the caller doe

[PATCH v4 9/9] target/arm/kvm: host cpu: Add support for sve properties

2019-09-24 Thread Andrew Jones
Allow cpu 'host' to enable SVE when it's available, unless the user chooses to disable it with the added 'sve=off' cpu property. Also give the user the ability to select vector lengths with the sve properties. We don't adopt 'max' cpu's other sve property, sve-max-vq, because that property is diffi

[PATCH v4 2/9] tests: arm: Introduce cpu feature tests

2019-09-24 Thread Andrew Jones
Now that Arm CPUs have advertised features lets add tests to ensure we maintain their expected availability with and without KVM. Signed-off-by: Andrew Jones Reviewed-by: Eric Auger --- tests/Makefile.include | 5 +- tests/arm-cpu-features.c | 242 +++ 2

[PATCH v4 8/9] target/arm/cpu64: max cpu: Support sve properties with KVM

2019-09-24 Thread Andrew Jones
Extend the SVE vq map initialization and validation with KVM's supported vector lengths when KVM is enabled. In order to determine and select supported lengths we add two new KVM functions for getting and setting the KVM_REG_ARM64_SVE_VLS pseudo-register. This patch has been co-authored with Richa

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-24 Thread Paolo Bonzini
On 20/09/19 11:28, Laszlo Ersek wrote: >> On QEMU side, we can drop black-hole approach and allocate >> dedicated SMRAM region, which explicitly gets mapped into >> RAM address space and after SMI hanlder initialization, gets >> unmapped (locked). So that SMRAM would be accessible only >> from SMM

[PATCH v4 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-09-24 Thread Andrew Jones
Add support for the query-cpu-model-expansion QMP command to Arm. We do this selectively, only exposing CPU properties which represent optional CPU features which the user may want to enable/disable. Additionally we restrict the list of queryable cpu models to 'max', 'host', or the current type whe

Re: [PATCH 1/2] hw: timer: Add Goldfish RTC device

2019-09-24 Thread Peter Maydell
On Tue, 24 Sep 2019 at 12:17, Anup Patel wrote: > > > > > -Original Message- > > From: Peter Maydell > > Sent: Tuesday, September 24, 2019 3:21 PM > > To: Anup Patel > > Cc: Palmer Dabbelt ; Alistair Francis > > ; Sagar Karandikar ; > > Bastian Koppelmann ; Atish Patra > > ; qemu-ri...@n

[PATCH v4 5/9] target/arm/kvm64: Add kvm_arch_get/put_sve

2019-09-24 Thread Andrew Jones
These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the swabbing is different than it is for fpsmid because the vector format is a little-endian stream of words. Signed-off-by: Andrew Jones Reviewed-by: Richard Henderson --- target/arm/kvm64.c | 137 +

RE: [PATCH 1/2] hw: timer: Add Goldfish RTC device

2019-09-24 Thread Anup Patel
> -Original Message- > From: Peter Maydell > Sent: Tuesday, September 24, 2019 5:02 PM > To: Anup Patel > Cc: Palmer Dabbelt ; Alistair Francis > ; Sagar Karandikar ; > Bastian Koppelmann ; Atish Patra > ; qemu-ri...@nongnu.org; qemu- > de...@nongnu.org; Anup Patel > Subject: Re: [PATC

[PULL 04/37] qapi: Drop check_type()'s redundant parameter @allow_optional

2019-09-24 Thread Markus Armbruster
check_type() uses @allow_optional only when @value is a dictionary and @allow_dict is True. All callers that pass allow_dict=True also pass allow_optional=True. Therefore, @allow_optional is always True when check_type() uses it. Drop the redundant parameter. Signed-off-by: Markus Armbruster Re

[PULL 01/37] qapi: Make visit_next_list()'s comment less confusing

2019-09-24 Thread Markus Armbruster
visit_next_list() returns non-null on success, null on failure. The comment's phrasing "until NULL return or error occurs" is needlessly confusing. Scratch the "or error occurs" part. Signed-off-by: Markus Armbruster Message-Id: <20190802122325.16520-1-arm...@redhat.com> Reviewed-by: Eric Blake

[PULL 02/37] make check-unit: use after free in test-opts-visitor

2019-09-24 Thread Markus Armbruster
From: Andrey Shinkevich In the struct OptsVisitor, the 'repeated_opts' member points to a list in the 'unprocessed_opts' hash table after the list has been destroyed. A subsequent call to visit_type_int() references the deleted list. It results in use-after-free issue reproduced by running the te

[PULL 06/37] docs/devel/qapi-code-gen: Minor specification fixes

2019-09-24 Thread Markus Armbruster
The specification claims "Each expression that isn't an include directive may be preceded by a documentation block", but the code also rejects them for pragma directives. The code is correct. Fix the specification. The specification reserves member names starting with 'has_', but the code also r

[PULL 00/37] QAPI patches for 2019-09-24

2019-09-24 Thread Markus Armbruster
The following changes since commit 2f93a3ecdd3bb060bd04f698ccafe66efd98563a: Merge remote-tracking branch 'remotes/davidhildenbrand/tags/s390x-tcg-2019-09-23' into staging (2019-09-23 15:44:52 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-20

[PULL 29/37] qapi: Reject blank 'if' conditions in addition to empty ones

2019-09-24 Thread Markus Armbruster
"'if': 'COND'" generates "#if COND". We reject empty COND because it won't compile. Blank COND won't compile any better, so reject that, too. Signed-off-by: Markus Armbruster Message-Id: <20190914153506.2151-12-arm...@redhat.com> Reviewed-by: Eric Blake --- scripts/qapi/common.py

[PULL 26/37] qapi: Improve reporting of lexical errors

2019-09-24 Thread Markus Armbruster
Show text up to next structural character, whitespace, or quote character instead of just the first character. Forgotten quotes now get reported like "Stray 'command'" instead of "Stray 'c'". Signed-off-by: Markus Armbruster Message-Id: <20190914153506.2151-9-arm...@redhat.com> Reviewed-by: Eric

[PULL 07/37] tests/qapi-schema: Demonstrate bad reporting of funny characters

2019-09-24 Thread Markus Armbruster
Invalid name 'not\\possible' is reported as 'not\possible'. Control characters (quoted or not) are even more confusing. Mark FIXME. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20190913201349.24332-6-arm...@redhat.com> --- tests/qapi-schema/enum-bad-name.err | 2 +-

[PULL 11/37] qapi: Permit alternates with just one branch

2019-09-24 Thread Markus Armbruster
A union or alternate without branches makes no sense and doesn't work: it can't be instantiated. A union or alternate with just one branch works, but is degenerate. We accept the former, but reject the latter. Weird. docs/devel/qapi-code-gen.txt doesn't mention the difference. It claims an alt

  1   2   3   4   5   >