Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-15 Thread Pankaj Gupta
> > On 12.07.19 09:35, Pankaj Gupta wrote: > > Remove transactional & non transactional device info > > for virtio pmem. > > Can you explain and add *why* ? As per upstream suggestion by Cornelia & MST, transactional devices are for legacy purpose. So, does not make sense for virtio-pmem. Tha

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-15 Thread David Hildenbrand
On 15.07.19 09:22, Pankaj Gupta wrote: > >> >> On 12.07.19 09:35, Pankaj Gupta wrote: >>> Remove transactional & non transactional device info >>> for virtio pmem. >> >> Can you explain and add *why* ? > > As per upstream suggestion by Cornelia & MST, transactional devices are for > legacy purpos

Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-15 Thread Zhang, Chen
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, July 11, 2019 4:18 AM > To: Zhang, Chen ; Li Zhijian ; > Peter Maydell ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen > Subject: Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak > and cod

Re: [Qemu-devel] [Qemu-block] [PATCH] doc: Preallocation does not require writing zeroes

2019-07-15 Thread Stefano Garzarella
On Fri, Jul 12, 2019 at 08:33:14PM +0200, Max Reitz wrote: > On 12.07.19 12:27, Stefano Garzarella wrote: > > On Thu, Jul 11, 2019 at 03:29:35PM +0200, Max Reitz wrote: > >> When preallocating an encrypted qcow2 image, it just lets the protocol > >> driver write data and then does not mark the clus

[Qemu-devel] [PATCH] migration/postcopy: remove redundant cpu_synchronize_all_post_init

2019-07-15 Thread Wei Yang
cpu_synchronize_all_post_init() is called twice in loadvm_postcopy_handle_run_bh(), so remove one redundant call. Signed-off-by: Wei Yang --- migration/savevm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 1d4fe7544d..863f5416ac 100644 --- a/mi

Re: [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical)

2019-07-15 Thread Richard Henderson
On 7/14/19 5:30 PM, Peter Maydell wrote: > I had a look at some of these before, but mostly I came > to the conclusion that it wasn't worth trying to put the > effort into keeping up with the site because they didn't > seem to provide any useful way to mark things as false > positives. Coverity has

Re: [Qemu-devel] [PATCH] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object

2019-07-15 Thread Stefano Garzarella
On Fri, Jul 12, 2019 at 08:35:12PM +0200, Max Reitz wrote: > On 12.07.19 12:46, Stefano Garzarella wrote: > > When the backing_file is specified as a JSON object, the > > qemu_gluster_reopen_prepare() fails with this message: > > invalid URI json:{"server.0.host": ...} > > > > In this case, we

Re: [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical)

2019-07-15 Thread Kevin Wolf
Am 14.07.2019 um 15:28 hat Stefan Weil geschrieben: > Am 13.07.2019 um 21:42 schrieb Paolo Bonzini: > > On 13/07/19 19:46, Stefan Weil wrote: > >> LGTM reports 16 errors, 81 warnings and 119 recommendations: > >> https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=list. > >> > >> Some of them are al

Re: [Qemu-devel] [Qemu-block] [PATCH v3] LUKS: support preallocation

2019-07-15 Thread Stefano Garzarella
On Sun, Jul 14, 2019 at 05:51:51PM +0300, Maxim Levitsky wrote: > On Thu, 2019-07-11 at 18:27 +0200, Stefano Garzarella wrote: > > On Thu, Jul 11, 2019 at 06:09:40PM +0300, Maxim Levitsky wrote: > > > preallocation=off and preallocation=metadata > > > both allocate luks header only, and preallocati

Re: [Qemu-devel] [Qemu-block] [PATCH v3] LUKS: support preallocation

2019-07-15 Thread Maxim Levitsky
On Mon, 2019-07-15 at 10:30 +0200, Stefano Garzarella wrote: > On Sun, Jul 14, 2019 at 05:51:51PM +0300, Maxim Levitsky wrote: > > On Thu, 2019-07-11 at 18:27 +0200, Stefano Garzarella wrote: > > > On Thu, Jul 11, 2019 at 06:09:40PM +0300, Maxim Levitsky wrote: > > > > preallocation=off and preallo

Re: [Qemu-devel] [Qemu-block] [PATCH v3] LUKS: support preallocation

2019-07-15 Thread Max Reitz
On 15.07.19 10:30, Stefano Garzarella wrote: > On Sun, Jul 14, 2019 at 05:51:51PM +0300, Maxim Levitsky wrote: >> On Thu, 2019-07-11 at 18:27 +0200, Stefano Garzarella wrote: >>> On Thu, Jul 11, 2019 at 06:09:40PM +0300, Maxim Levitsky wrote: preallocation=off and preallocation=metadata b

Re: [Qemu-devel] [PULL 0/8] virtio, pc, pci: fixes, cleanups, tests

2019-07-15 Thread Peter Maydell
On Fri, 12 Jul 2019 at 16:36, Michael S. Tsirkin wrote: > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' > into staging (2019-07-12 11:06:48 +0100) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH for-4.1 2/2] qemu-tech: Fix dangling @menu entries

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 06:57, Markus Armbruster wrote: > > Recent commit 2f2c4e4731 "Convert "translator internals" docs to RST, > move to devel manual" and commit 282d36b5e2 "qemu-tech.texi: Remove > "QEMU compared to other emulators" section" removed @node, but left > their @menu entries behind.

[Qemu-devel] [Bug 1836501] Re: cpu_address_space_init fails with assertion

2019-07-15 Thread Peter Maydell
2.6 is now very old -- can you check whether this is still a problem with a more recent QEMU version, please? The command line you're using should in theory work, but vexpress-a15 + KVM is a bit of an obscure combination -- most people who want to use virtualization use the 'virt' machine, which s

Re: [Qemu-devel] [PATCH for-4.1 0/2] qemu-doc build fixes

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 7:57 AM, Markus Armbruster wrote: > Markus Armbruster (2): > Makefile: Fix missing dependency of on qemu-tech.texi > qemu-tech: Fix dangling @menu entries > > Makefile | 3 ++- > qemu-tech.texi | 3 --- > 2 files changed, 2 insertions(+), 4 deletions(-) Series: Reviewed-by:

[Qemu-devel] [Bug 1836537] [NEW] Kconfig-related options not shown in ./configure --help

2019-07-15 Thread Philippe Mathieu-Daudé
Public bug reported: tag: v4.1.0-rc0 I notice these options not documented by '--help': --with-default-devices) default_devices="yes" --without-default-devices) default_devices="no" We might have other options not documented too. ** Affects: qemu Importance: Undecided Status:

Re: [Qemu-devel] [PATCH v2] migration/postcopy: fix document of postcopy_send_discard_bm_ram()

2019-07-15 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the > parameter of postcopy_send_discard_bm_ram(), while left the document > part untouched. > > This patch correct the document and fix two typo by hand. > > Signed-off-by: Wei

Re: [Qemu-devel] [RFC] memory-backend-file/nvdimm: support read-only files as memory-backends

2019-07-15 Thread Stefan Hajnoczi
On Tue, Jul 09, 2019 at 12:53:45PM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing Igor & Xiao. > > On 7/8/19 11:19 PM, Julio Montes wrote: > > Currently is not possible to use a file that is part of a read-only > > filesystem as memory backend for nvdimm devices, even if this is not > > modified >

[Qemu-devel] [PATCH v2] tests/boot_linux_console: add a test for riscv64 + virt

2019-07-15 Thread Chih-Min Chao
Similar to the mips + malta test, it boots a Linux kernel on a virt board and verify the serial is working. Also, it relies on the serial device set by the machine itself. If riscv64 is a target being built, "make check-acceptance" will automatically include this test by the use of the "arch:risc

[Qemu-devel] [Bug 1836501] Re: cpu_address_space_init fails with assertion

2019-07-15 Thread Peter Maydell
Oh, I've just noticed -- we default to enabling EL3 on this board (like the hardware), which won't work with KVM, so if you want KVM you need to disable EL3 with the command line option -machine secure=off -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v2] tests/boot_linux_console: add a test for riscv64 + virt

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 11:08 AM, Chih-Min Chao wrote: > Similar to the mips + malta test, it boots a Linux kernel on a virt > board and verify the serial is working. Also, it relies on the serial > device set by the machine itself. > > If riscv64 is a target being built, "make check-acceptance" will > automa

[Qemu-devel] [Bug 1836501] Re: cpu_address_space_init fails with assertion

2019-07-15 Thread Peter Maydell
We do check for the incompatible option combination in hw/arm/virt.c: if (vms->secure) { if (kvm_enabled()) { error_report("mach-virt: KVM does not support Security extensions"); exit(1); } we just don't have anything equivalent in vexpress.c. We should

Re: [Qemu-devel] [PATCH 4/4] target/i386: kvm: Demand nested migration kernel capabilities only when vCPU may have enabled VMX

2019-07-15 Thread Liran Alon
Gentle ping. Should this be considered to be merged into QEMU even though QEMU is now in hard freeze? As it touches a mechanism which is already merged but too restricted. Anyway, I would like this to be reviewed even if it’s merged is delayed for early feedback. Thanks, -Liran > On 6 Jul 201

Re: [Qemu-devel] [patch QEMU] kvm: i386: halt poll control MSR support

2019-07-15 Thread Paolo Bonzini
On 04/06/19 01:04, Marcelo Tosatti wrote: > (CC'ing qemu devel) > > Add support for halt poll control MSR: save/restore, migration > and new feature name. > > The purpose of this MSR is to allow the guest to disable > host halt poll. > > Signed-off-by: Marcelo Tosatti > > diff --git a/include/

Re: [Qemu-devel] [PATCH RESEND] i386/kvm: support guest access CORE cstate

2019-07-15 Thread Wanpeng Li
On Mon, 15 Jul 2019 at 17:16, Paolo Bonzini wrote: > > On 15/07/19 03:28, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Allow guest reads CORE cstate when exposing host CPU power management > > capabilities > > to the guest. PKG cstate is restricted to avoid a guest to get the whole > > packag

Re: [Qemu-devel] [PATCH 4/4] target/i386: kvm: Demand nested migration kernel capabilities only when vCPU may have enabled VMX

2019-07-15 Thread Paolo Bonzini
On 15/07/19 11:20, Liran Alon wrote: > Gentle ping. > > Should this be considered to be merged into QEMU even though QEMU is now in > hard freeze? > As it touches a mechanism which is already merged but too restricted. Yes, I have it queued and will send the pull request later today. Paolo > A

Re: [Qemu-devel] [PATCH 7/7] iotests: Add test for image creation fallback

2019-07-15 Thread Thomas Huth
On 12/07/2019 19.36, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/259 | 61 ++ > tests/qemu-iotests/259.out | 14 + > tests/qemu-iotests/group | 1 + > 3 files changed, 76 insertions(+) > create mode 100755 tests/qemu-i

Re: [Qemu-devel] [PATCH v3 4/6] tests: specify the address family when checking bind

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:09PM +0400, Marc-André Lureau wrote: > getaddrinfo() may succeed with PF_UNSPEC, but fail when more specific. > > (this allows to skip some tests that would fail under podman) > > Signed-off-by: Marc-André Lureau > --- > tests/socket-helpers.c | 17 +---

Re: [Qemu-devel] [PATCH v3 5/6] test-char: skip tcp tests if ipv4 check failed

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:10PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > tests/Makefile.include | 2 +- > tests/test-char.c | 17 + > 2 files changed, 14 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel --

Re: [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 for new migration

2019-07-15 Thread Dr. David Alan Gilbert
* Ivan Ren (reny...@gmail.com) wrote: > Reproduce the problem: > migrate > migrate_cancel > migrate > > Error happen for memory migration Can we fix this by just reverting 03158519384 ? Dave > The reason as follows: > 1. qemu start, ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] all set to >

Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Yury Kotov
Hi, 10.07.2019, 12:26, "Yury Kotov" : > Throttling thread sleeps in VCPU thread. For high throttle percentage > this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. > vm_stop() kicks all VCPUs and waits for them. It's called at the end of > migration and because of the long sleep th

Re: [Qemu-devel] [PATCH v3 6/6] test: skip tests if socket_check_protocol_support() failed

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:11PM +0400, Marc-André Lureau wrote: > Skip the tests if socket_check_protocol_support() failed, but do run > g_test_run() to keep TAP harness happy. Did you actually find a scenario in which it failed, or is this just doing the change for the sake of strict correctne

Re: [Qemu-devel] [PULL for-4.1 0/7] tcg patch queue

2019-07-15 Thread Peter Maydell
On Sun, 14 Jul 2019 at 12:12, Richard Henderson wrote: > > > The following changes since commit 1316b1ddc8a05e418c8134243f8bff8cccbbccb1: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-07-12 15:38:22 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:08PM +0400, Marc-André Lureau wrote: > Allow to specify the container engine to run with ENGINE variable. > > By default, ENGINE=auto and will select either podman or docker. > > Signed-off-by: Marc-André Lureau > --- > Makefile | 2 +- > tests

Re: [Qemu-devel] [PATCH 7/7] iotests: Add test for image creation fallback

2019-07-15 Thread Max Reitz
On 15.07.19 11:31, Thomas Huth wrote: > On 12/07/2019 19.36, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/259 | 61 ++ >> tests/qemu-iotests/259.out | 14 + >> tests/qemu-iotests/group | 1 + >> 3 files changed, 76 in

Re: [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 for new migration

2019-07-15 Thread Dr. David Alan Gilbert
* Peter Xu (zh...@redhat.com) wrote: > On Sun, Jul 14, 2019 at 10:51:19PM +0800, Ivan Ren wrote: > > Reproduce the problem: > > migrate > > migrate_cancel > > migrate > > > > Error happen for memory migration > > Can mention "this mostly revert 0315851938 but with comments kept" > when merge... >

[Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread Philippe Mathieu-Daudé
The USB_EHCI entry currently include PCI code. Since the EHCI implementation is already split in sysbus/PCI, add a new USB_EHCI_PCI. There are no logical changes, but the Kconfig dependencies tree is cleaner. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/Kconfig | 9 ++--- hw/usb/Ma

[Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes

2019-07-15 Thread Philippe Mathieu-Daudé
I actually wanted to clean the USB devices (i.e. to not have USB3 devices appear on OHCI buses) but this is too late for the next release, so let's post the patches accumulated. Philippe Mathieu-Daudé (3): hw/Kconfig: PCI bus implies PCI_DEVICES hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI hw/usb

[Qemu-devel] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI

2019-07-15 Thread Philippe Mathieu-Daudé
TYPE_NEC_XHCI is child of TYPE_XHCI. Add the missing Kconfig dependency. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 495c6f2d48..555e09377b 100644 --- a/hw/usb/Kconfig +++ b/hw/

[Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Philippe Mathieu-Daudé
If a controller device provides a PCI bus, we can plug any PCI daughter card on it. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/kconfig.rst | 1 - hw/alpha/Kconfig | 1 - hw/arm/Kconfig | 4 hw/hppa/Kconfig| 1 - hw/i386/Kconfig| 1 - hw/pci/Kconfig

Re: [Qemu-devel] [PATCH v3 1/6] docker.py: add --run-as-current-user

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:06PM +0400, Marc-André Lureau wrote: > Podman will need further tweaks. > > Suggested-by: Paolo Bonzini > Signed-off-by: Marc-André Lureau > --- > tests/docker/Makefile.include | 2 +- > tests/docker/docker.py| 5 + > 2 files changed, 6 insertions(+), 1

[Qemu-devel] 回复: 答复: migrate_set_speed has no effect if the guest is using hugepages.

2019-07-15 Thread Lin Ma
> -邮件原件- > 发件人: Dr. David Alan Gilbert > 发送时间: 2019年7月12日 20:34 > 收件人: Lin Ma > 抄送: qemu-devel@nongnu.org > 主题: Re: 答复: [Qemu-devel] migrate_set_speed has no effect if the guest is > using hugepages. > > * Lin Ma (l...@suse.com) wrote: > > > > > > > -邮件原件- > > > 发件人: Dr. David

Re: [Qemu-devel] [PATCH v3 2/6] docker.py: add podman support

2019-07-15 Thread Daniel P . Berrangé
On Sat, Jul 13, 2019 at 06:33:07PM +0400, Marc-André Lureau wrote: > Add a --engine option to select either docker, podman or auto. > > Among other advantages, podman allows to run rootless & daemonless > containers, fortunately sharing compatible CLI with docker. > > With current podman, we have

[Qemu-devel] [Bug 1836501] Re: cpu_address_space_init fails with assertion

2019-07-15 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836501 Title: cpu_address_space_init fails with assertion Status in QEMU: Confirmed Bug description: qemu-system-arm does not

Re: [Qemu-devel] [RISU PATCH v3 00/18] Support for generating x86 SIMD test images

2019-07-15 Thread Alex Bennée
Jan Bobek writes: > On 7/12/19 9:34 AM, Alex Bennée wrote: >> >> Jan Bobek writes: >> >>> This is v3 of the patch series posted in [1] and [2]. Note that this >>> is the first fully-featured patch series implementing all desired >>> functionality, including (V)LDMXCSR and VSIB-based instructio

Re: [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Thomas Huth
On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > If a controller device provides a PCI bus, we can plug any PCI > daughter card on it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/devel/kconfig.rst | 1 - > hw/alpha/Kconfig | 1 - > hw/arm/Kconfig | 4 > hw/hppa/

Re: [Qemu-devel] [Qemu-ppc] [PULL 41/44] spapr: change default interrupt mode to 'dual'

2019-07-15 Thread Cédric Le Goater
On 11/07/2019 03:26, David Gibson wrote: > On Wed, Jul 10, 2019 at 06:26:09PM +0200, Laurent Vivier wrote: >> On 29/05/2019 08:50, David Gibson wrote: >>> From: Cédric Le Goater >>> >>> Now that XIVE support is complete (QEMU emulated and KVM devices), >>> change the pseries machine to advertise b

Re: [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > > On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > > If a controller device provides a PCI bus, we can plug any PCI > > daughter card on it. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > diff --git a/hw/pci/Kconfig b/hw/pci/Kconf

[Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

2019-07-15 Thread Philippe Mathieu-Daudé
Missed during the QOM convertion in 9af21dbee14. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 1dc1466332..ec8ded7252 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -1611,7 +

[Qemu-devel] [PATCH 1/2] vhost-scsi: Call virtio_scsi_common_unrealize() when device realize failed

2019-07-15 Thread elohimes
From: Xie Yongji This avoids memory leak when device hotplug is failed. Signed-off-by: Xie Yongji --- hw/scsi/vhost-scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 4090f99ee4..db4a090576 100644 --- a/hw/scsi/vhost-

[Qemu-devel] [PATCH 2/2] vhost-user-scsi: Call virtio_scsi_common_unrealize() when device realize failed

2019-07-15 Thread elohimes
From: Xie Yongji This avoids memory leak when device hotplug is failed. Signed-off-by: Xie Yongji --- hw/scsi/vhost-user-scsi.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index a9fd8ea305..a79653df46

[Qemu-devel] [Bug 1836558] [NEW] Qemu-ppc Memory leak creating threads

2019-07-15 Thread Daan Scherft
Public bug reported: When creating c++ threads (with c++ std::thread), the resulting binary has memory leaks when running with qemu-ppc. Eg the following c++ program, when compiled with gcc, consumes more and more memory while running at qemu-ppc. (does not have memory leaks when compiling for In

Re: [Qemu-devel] [PATCH v3 6/6] test: skip tests if socket_check_protocol_support() failed

2019-07-15 Thread Marc-André Lureau
Hi On Mon, Jul 15, 2019 at 1:40 PM Daniel P. Berrangé wrote: > > On Sat, Jul 13, 2019 at 06:33:11PM +0400, Marc-André Lureau wrote: > > Skip the tests if socket_check_protocol_support() failed, but do run > > g_test_run() to keep TAP harness happy. > > Did you actually find a scenario in which it

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-07-15 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 6/26/19 6:49 PM, Stefano Garzarella wrote: > > On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: > >> In hmp_change(), the variable hmp_mon is only used > >> by code under #ifdef CONFIG_VNC. This results in a build > >>

Re: [Qemu-devel] [PATCH v3 6/6] test: skip tests if socket_check_protocol_support() failed

2019-07-15 Thread Daniel P . Berrangé
On Mon, Jul 15, 2019 at 02:25:03PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jul 15, 2019 at 1:40 PM Daniel P. Berrangé > wrote: > > > > On Sat, Jul 13, 2019 at 06:33:11PM +0400, Marc-André Lureau wrote: > > > Skip the tests if socket_check_protocol_support() failed, but do run > > > g_te

[Qemu-devel] [Bug 1836501] Re: cpu_address_space_init fails with assertion

2019-07-15 Thread Lutz
Thank you for the quick and complete investigation. I'll follow your suggestions and will reply any succecss in the next days. I checked the source of the vexpress and found the assert, but wasn't clever enough to compare it to another board. I would support the idea of checking the incompatible p

[Qemu-devel] [PATCH for-4.1? 0/4] block: Fix three .bdrv_has_zero_init()s

2019-07-15 Thread Max Reitz
Hi, .bdrv_has_zero_init() must not return 1 if the (newly created[1]) image may not return zeroes when read. [1] This is guaranteed by the caller. If the image is preallocated, this generally depends on the protocol layer, because the format layer will just allocate the necessary metadata, make

[Qemu-devel] [PATCH for-4.1? 2/4] vdi: Fix .bdrv_has_zero_init()

2019-07-15 Thread Max Reitz
Static VDI images cannot guarantee to be zero-initialized. If the image has been statically allocated, forward the call to the underlying storage node. Reported-by: Stefano Garzarella Signed-off-by: Max Reitz --- block/vdi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH for-4.1? 4/4] iotests: Convert to preallocated encrypted qcow2

2019-07-15 Thread Max Reitz
Add a test case for converting an empty image (which only returns zeroes when read) to a preallocated encrypted qcow2 image. qcow2_has_zero_init() should return 0 then, thus forcing qemu-img convert to create zero clusters. Signed-off-by: Max Reitz --- tests/qemu-iotests/188 | 20 +++

[Qemu-devel] [PATCH for-4.1? 3/4] vhdx: Fix .bdrv_has_zero_init()

2019-07-15 Thread Max Reitz
Fixed VHDX images cannot guarantee to be zero-initialized. If the image has the "fixed" subformat, forward the call to the underlying storage node. Reported-by: Stefano Garzarella Signed-off-by: Max Reitz --- block/vhdx.c | 21 - 1 file changed, 20 insertions(+), 1 deletion

[Qemu-devel] [PATCH for-4.1? 1/4] qcow2: Fix .bdrv_has_zero_init()

2019-07-15 Thread Max Reitz
If a qcow2 file is preallocated, it can no longer guarantee that it initially appears as filled with zeroes. So implement .bdrv_has_zero_init() by checking whether the file is preallocated; if so, forward the call to the underlying storage node, except for when it is encrypted: Encrypted prealloca

Re: [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Thomas Huth
On 15/07/2019 12.19, Peter Maydell wrote: > On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: >> >> On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: >>> If a controller device provides a PCI bus, we can plug any PCI >>> daughter card on it. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >

Re: [Qemu-devel] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI

2019-07-15 Thread Thomas Huth
On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > TYPE_NEC_XHCI is child of TYPE_XHCI. Add the missing Kconfig > dependency. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/usb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/Kconfig b/hw/usb/Kconf

Re: [Qemu-devel] [PATCH] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object

2019-07-15 Thread Max Reitz
On 15.07.19 10:16, Stefano Garzarella wrote: > On Fri, Jul 12, 2019 at 08:35:12PM +0200, Max Reitz wrote: >> On 12.07.19 12:46, Stefano Garzarella wrote: >>> When the backing_file is specified as a JSON object, the >>> qemu_gluster_reopen_prepare() fails with this message: >>> invalid URI json:

Re: [Qemu-devel] [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread BALATON Zoltan
On Mon, 15 Jul 2019, Philippe Mathieu-Daudé wrote: The USB_EHCI entry currently include PCI code. Since the EHCI implementation is already split in sysbus/PCI, add a new USB_EHCI_PCI. There are no logical changes, but the Kconfig dependencies tree is cleaner. Signed-off-by: Philippe Mathieu-Daud

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Cornelia Huck
On Mon, 15 Jul 2019 12:48:55 +0200 Thomas Huth wrote: > On 15/07/2019 12.19, Peter Maydell wrote: > > On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > >> > >> On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > >>> If a controller device provides a PCI bus, we can plug any PCI > >>> daugh

Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Paolo Bonzini
On 15/07/19 11:40, Yury Kotov wrote: > Hi, > > 10.07.2019, 12:26, "Yury Kotov" : >> Throttling thread sleeps in VCPU thread. For high throttle percentage >> this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. >> vm_stop() kicks all VCPUs and waits for them. It's called at the end o

Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

2019-07-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Missed during the QOM convertion in 9af21dbee14. Ooops. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/e1000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > index 1dc1466332..ec8ded7252 100

Re: [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread Thomas Huth
On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > The USB_EHCI entry currently include PCI code. Since the EHCI > implementation is already split in sysbus/PCI, add a new > USB_EHCI_PCI. There are no logical changes, but the Kconfig > dependencies tree is cleaner. > > Signed-off-by: Philippe Ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread Thomas Huth
On 15/07/2019 12.54, BALATON Zoltan wrote: > On Mon, 15 Jul 2019, Philippe Mathieu-Daudé wrote: >> The USB_EHCI entry currently include PCI code. Since the EHCI >> implementation is already split in sysbus/PCI, add a new >> USB_EHCI_PCI. There are no logical changes, but the Kconfig >> dependencies

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 12:56 PM, Cornelia Huck wrote: > On Mon, 15 Jul 2019 12:48:55 +0200 > Thomas Huth wrote: > >> On 15/07/2019 12.19, Peter Maydell wrote: >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > If a controller device pr

Re: [Qemu-devel] [PATCH v1 03/26] tests: Run the iotests during "make check" again

2019-07-15 Thread Thomas Huth
On 07/06/2019 11.33, Alex Bennée wrote: > > Alex Bennée writes: > >> From: Thomas Huth >> >> People often forget to run the iotests before submitting patches or >> pull requests - this is likely due to the fact that we do not run the >> tests during our mandatory "make check" tests yet. Now tha

Re: [Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

2019-07-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/12/19 1:18 PM, Alex Bennée wrote: >> Add yet another test type so we cna quickly exercise the miscellaneous > > "cna" -> "can" > >> build products of the build system under various docer configurations. >> >> Signed-off-by: Alex Bennée >> --- >> tests/doc

Re: [Qemu-devel] [PATCH v2] tests/boot_linux_console: add a test for riscv64 + virt

2019-07-15 Thread Chih-Min Chao
On Mon, Jul 15, 2019 at 5:15 PM Philippe Mathieu-Daudé wrote: > On 7/15/19 11:08 AM, Chih-Min Chao wrote: > > Similar to the mips + malta test, it boots a Linux kernel on a virt > > board and verify the serial is working. Also, it relies on the serial > > device set by the machine itself. > > >

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Cornelia Huck
On Mon, 15 Jul 2019 13:04:28 +0200 Philippe Mathieu-Daudé wrote: > On 7/15/19 12:56 PM, Cornelia Huck wrote: > > On Mon, 15 Jul 2019 12:48:55 +0200 > > Thomas Huth wrote: > > > >> On 15/07/2019 12.19, Peter Maydell wrote: > >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread BALATON Zoltan
On Mon, 15 Jul 2019, Thomas Huth wrote: On 15/07/2019 12.54, BALATON Zoltan wrote: On Mon, 15 Jul 2019, Philippe Mathieu-Daudé wrote: The USB_EHCI entry currently include PCI code. Since the EHCI implementation is already split in sysbus/PCI, add a new USB_EHCI_PCI. There are no logical changes

[Qemu-devel] [PULL 1/1] Fix build error when VNC is configured out

2019-07-15 Thread Dr. David Alan Gilbert (git)
From: Christophe de Dinechin In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function ‘hmp_change’: monitor/hmp-cmds.c:1946:17: err

[Qemu-devel] [PULL 0/1] hmp queue

2019-07-15 Thread Dr. David Alan Gilbert (git)
b.com/dagrh/qemu.git tags/pull-hmp-20190715 for you to fetch changes up to ea73f37062a9012a4f151f47f2427011b18569c8: Fix build error when VNC is configured out (2019-07-15 11:26:26 +0100) HMP pull 2019-07-15 Just Ch

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Peter Maydell
On Fri, 12 Jul 2019 at 17:33, Peter Maydell wrote: > Still fails on aarch32 host, I'm afraid: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 > QTEST_QEMU_IMG=qemu-img tests/migration-test -m=quick -k --tap < > /dev/null

Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

2019-07-15 Thread Stefano Garzarella
On Mon, Jul 15, 2019 at 12:22:10PM +0200, Philippe Mathieu-Daudé wrote: > Missed during the QOM convertion in 9af21dbee14. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/e1000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c >

Re: [Qemu-devel] [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread Thomas Huth
On 15/07/2019 13.10, BALATON Zoltan wrote: > On Mon, 15 Jul 2019, Thomas Huth wrote: >> On 15/07/2019 12.54, BALATON Zoltan wrote: >>> On Mon, 15 Jul 2019, Philippe Mathieu-Daudé wrote: The USB_EHCI entry currently include PCI code. Since the EHCI implementation is already split in sysbus

Re: [Qemu-devel] [Qemu-ppc] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI

2019-07-15 Thread Paolo Bonzini
On 15/07/19 13:10, BALATON Zoltan wrote: >> >> If you want to compile without USB_EHCI_PCI and without USB_EHCI_SYSBUS, >> but with USB (e.g. due to XHCI), I think we should not include >> hcd-ehci.o file in the build. So I think it's fine that we have a >> separate config switch for this file. >

Re: [Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes

2019-07-15 Thread Paolo Bonzini
On 15/07/19 11:55, Philippe Mathieu-Daudé wrote: > I actually wanted to clean the USB devices (i.e. to not have > USB3 devices appear on OHCI buses) but this is too late for > the next release, so let's post the patches accumulated. > > Philippe Mathieu-Daudé (3): > hw/Kconfig: PCI bus implies P

Re: [Qemu-devel] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-15 Thread Alexander Popov
On 05.07.2019 17:07, Alexander Popov wrote: > This assertion was introduced in the commit a718978ed58a in July 2015. > It implies that the size of successful DMA transfers handled in > ide_dma_cb() should be multiple of 512 (the size of a sector). > > But guest systems can initiate DMA transfers t

Re: [Qemu-devel] [PATCH v3 1/3] blockdev: reduce aio_context locked sections in bitmap add/remove

2019-07-15 Thread Max Reitz
On 09.07.19 00:05, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Commit 0a6c86d024c52 returned these locks back to add/remove > functionality, to protect from intersection of persistent bitmap > related IO with other IO. But other bitmap-related functions called > here are unrelated t

Re: [Qemu-devel] [PATCH v3 2/3] qapi: implement block-dirty-bitmap-remove transaction action

2019-07-15 Thread Max Reitz
On 09.07.19 00:05, John Snow wrote: > It is used to do transactional movement of the bitmap (which is > possible in conjunction with merge command). Transactional bitmap > movement is needed in scenarios with external snapshot, when we don't > want to leave copy of the bitmap in the base image. >

[Qemu-devel] [PATCH] include: Make headers more self-contained

2019-07-15 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need

Re: [Qemu-devel] [PATCH v3 3/3] iotests: test bitmap moving inside 254

2019-07-15 Thread Max Reitz
On 09.07.19 00:05, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Test persistent bitmap copying with and without removal of original > bitmap. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: John Snow > --- > tests/qemu-iotests/254 | 30 +- > tests

Re: [Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/14/19 2:47 PM, Philippe Mathieu-Daudé wrote: > The Milkymist SoftUSB block provides the OHCI USB standard > (missed in 0858746b835). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig

Re: [Qemu-devel] [PATCH v1 00/27] Add RISC-V Hypervisor Extension

2019-07-15 Thread Chih-Min Chao
On Sat, Jun 8, 2019 at 6:03 AM Alistair Francis wrote: > This patch series adds the RISC-V Hypervisor extension 0.3. This is the > latest draft spec of the Hypervisor extension. > > The Hypervisor extension is disabled by default, so this series should > result in no changes to anyone using QEMU

Re: [Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

2019-07-15 Thread Paolo Bonzini
On 15/07/19 13:47, Philippe Mathieu-Daudé wrote: > On 7/14/19 2:47 PM, Philippe Mathieu-Daudé wrote: >> The Milkymist SoftUSB block provides the OHCI USB standard >> (missed in 0858746b835). >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/lm32/Kconfig | 1 + >> 1 file changed, 1 insertio

Re: [Qemu-devel] [PATCH] include: Make headers more self-contained

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 1:39 PM, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include eve

Re: [Qemu-devel] [PATCH v1 03/26] tests: Run the iotests during "make check" again

2019-07-15 Thread Alex Bennée
Thomas Huth writes: > On 07/06/2019 11.33, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> From: Thomas Huth >>> >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do not run the >>> tests during our mandatory

Re: [Qemu-devel] [PATCH v1 00/27] Add RISC-V Hypervisor Extension

2019-07-15 Thread Peter Maydell
On Fri, 7 Jun 2019 at 23:03, Alistair Francis wrote: > At the moment this spec is in a draft state and is subject to change. As > QEMU is extreamly useful in early bring up I think it makes sense for > QEMU to support non-frozen extensions. I would like to decide with this > series how QEMU will h

Re: [Qemu-devel] [PULL 0/1] hmp queue

2019-07-15 Thread Peter Maydell
> staging (2019-07-15 09:46:15 +0100) > > are available in the Git repository at: > > git://github.com/dagrh/qemu.git tags/pull-hmp-20190715 > > for you to fetch changes up to ea73f37062a9012a4f151f47f2427011b18569c8: > > Fix

[Qemu-devel] [PATCH v5 0/5] hw/block/pflash_cfi01: Add DeviceReset() handler

2019-07-15 Thread Philippe Mathieu-Daudé
Last attempt before sending pull request for rc1. The pflash device lacks a reset() function. When a machine is resetted, the flash might be in an inconsistent state, leading to unexpected behavior: https://bugzilla.redhat.com/show_bug.cgi?id=1678713 Resolve this issue by adding a DeviceReset() ha

[Qemu-devel] [PATCH v5 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-07-15 Thread Philippe Mathieu-Daudé
The 'CFI02' NOR flash was introduced in commit 29133e9a0fff, with timing modelled. One year later, the CFI01 model was introduced (commit 05ee37ebf630) based on the CFI02 model. As noted in the header, "It does not support timings". 12 years later, we never had to model the device timings. Time to

[Qemu-devel] [PATCH v5 5/5] hw/block/pflash_cfi01: Add the DeviceReset() handler

2019-07-15 Thread Philippe Mathieu-Daudé
A "system reset" sets the device state machine in READ_ARRAY mode and, after some delay, set the SR.7 READY bit. We do not model timings, so we set the SR.7 bit directly. The TYPE_DEVICE interface provides a DeviceReset handler. This pflash device is a subclass of TYPE_SYS_BUS_DEVICE (which is a

[Qemu-devel] [PATCH v5 3/5] hw/block/pflash_cfi01: Extract pflash_mode_read_array()

2019-07-15 Thread Philippe Mathieu-Daudé
The same pattern is used when setting the flash in READ_ARRAY mode: - Set the state machine command to READ_ARRAY - Reset the write_cycle counter - Reset the memory region in ROMD Refactor the current code by extracting this pattern. It is used twice: - On a write access (on command failure, error

[Qemu-devel] [PATCH v5 4/5] hw/block/pflash_cfi01: Start state machine as READY to accept commands

2019-07-15 Thread Philippe Mathieu-Daudé
When the state machine is ready to accept command, the bit 7 of the status register (SR) is set to 1. The guest polls the status register and check this bit before writting command to the internal 'Write State Machine' (WSM). Set SR.7 bit to 1 when the device is created. There is no migration imp

  1   2   3   4   >