[Qemu-devel] [PATCH-for-4.1? 4/7] vl: Fix 'braces' coding style issues

2019-07-12 Thread Philippe Mathieu-Daudé
Since we'll move this code around, fix its style first: ERROR: braces {} are necessary for all arms of this statement style Signed-off-by: Philippe Mathieu-Daudé --- vl.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/vl.c b/vl.c index 5089fce

[Qemu-devel] [PATCH-for-4.1? 1/7] hw/arm: Nokia N-series tablet requires Bluetooth

2019-07-12 Thread Philippe Mathieu-Daudé
Missed in 4826ac6d192 because the Bluetooth devices are currently always enabled. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index ab65ecd216..11195251f3 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kco

[Qemu-devel] [PATCH-for-4.1? 5/7] vl: Use qemu_strtoi() instead of strtol()

2019-07-12 Thread Philippe Mathieu-Daudé
Since we'll move this code around, fix this checkpatch warning first: ERROR: consider using qemu_strtol in preference to strtol Signed-off-by: Philippe Mathieu-Daudé --- vl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 96de4f74b9..c7f4d01c99 100

[Qemu-devel] [PATCH-for-4.1? 3/7] MAINTAINERS: Add an entry for the Bluetooth devices

2019-07-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cc9636b43a..5d8f27d9bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1733,6 +1733,13 @@ F: hw/*/*xive* F: include/hw/*/*xive* F: docs/*/*xive* +Blu

[Qemu-devel] [PATCH-for-4.1? 6/7] vl: Extract bt_parse() into its own file

2019-07-12 Thread Philippe Mathieu-Daudé
This is required to be able to compile vl.c with CONFIG_BLUETOOTH disabled. Signed-off-by: Philippe Mathieu-Daudé --- 2300 lines less for the C preprocessor :) --- Makefile.objs | 2 +- bt-opts.c | 140 include/sysemu/bt.h | 3 + v

[Qemu-devel] [PATCH-for-4.1? 7/7] hw/bt: Allow building with CONFIG_BLUETOOTH disabled

2019-07-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Makefile.objs | 3 ++- bt-stubs.c | 18 ++ hw/bt/Makefile.objs | 4 ++-- 3 files changed, 22 insertions(+), 3 deletions(-) create mode 100644 bt-stubs.c diff --git a/Makefile.objs b/Makefile.objs index c2845a0efc..98269e

[Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-12 Thread Stefan Weil
Signed-off-by: Stefan Weil --- v2: Remove also max_cpus (merci à Laurent Vivier ) include/sysemu/sysemu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 984c439ac9..e70edf7c1c 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-12 Thread Laurent Vivier
Le 12/07/2019 à 15:43, Stefan Weil a écrit : > Signed-off-by: Stefan Weil > --- > v2: Remove also max_cpus (merci à Laurent Vivier ) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..e70edf

Re: [Qemu-devel] [RFC 2/5] block: Generic truncation fallback

2019-07-12 Thread Max Reitz
On 12.07.19 13:48, Max Reitz wrote: > On 12.07.19 13:17, Kevin Wolf wrote: >> Am 12.07.2019 um 12:58 hat Max Reitz geschrieben: >>> On 12.07.19 11:49, Kevin Wolf wrote: Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > If a protocol driver does not support truncation, we call fall back t

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-12 Thread Peter Maydell
On Fri, 12 Jul 2019 at 14:43, Stefan Weil wrote: > > Signed-off-by: Stefan Weil > --- > v2: Remove also max_cpus (merci à Laurent Vivier ) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..e

Re: [Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Laurent Vivier
On 12/07/2019 15:35, Alex Bennée wrote: > > Laurent Vivier writes: > >> On 12/07/2019 13:18, Alex Bennée wrote: >>> Quite often the information about which test failed is hidden by the >>> wall of repeated failures for each page. Stop outputting the error >>> after 10 bad pages and just summaris

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Laurent Vivier
Le 12/07/2019 à 15:36, Arnd Bergmann a écrit : > On Fri, Jul 12, 2019 at 3:23 PM Laurent Vivier wrote: >> >> Le 12/07/2019 à 14:47, Arnd Bergmann a écrit : ... >>> No, you don't need to swap. The difference is only in the padding. >>> Since the kernel uses a 64/64 structure here, and user space >>

Re: [Qemu-devel] [PATCH for 4.1 2/4] target/mips: Add missing 'break' for a case of MTHC0 handling

2019-07-12 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 7/12/19 1:37 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This was found by GCC 8.3 static analysis. > I think you can amend: Fixes: 5fb2dcd1792 Reported-by: Stefan Weil > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 1 + > 1 fil

[Qemu-devel] [PULL 0/2] Block layer patches

2019-07-12 Thread Kevin Wolf
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into staging (2019-07-12 11:06:48 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstrea

[Qemu-devel] [PULL 2/2] file-posix: Use max transfer length/segment count only for SCSI passthrough

2019-07-12 Thread Kevin Wolf
From: Maxim Levitsky Regular kernel block devices (/dev/sda*, /dev/nvme*, etc) don't have max segment size/max segment count hardware requirements exposed to the userspace, but rather the kernel block layer takes care to split the incoming requests that violate these requirements. Allowing the k

[Qemu-devel] [PULL 1/2] iotests: Update 082 expected output

2019-07-12 Thread Kevin Wolf
From: Eric Blake A recent tweak to the '-o help' output for qemu-img needs to be reflected into the iotests expected outputs. Fixes: f7077c98 Reported-by: Kevin Wolf Signed-off-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- tests/qemu-iotests/082.out | 54 ++

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Arnd Bergmann
On Fri, Jul 12, 2019 at 3:50 PM Laurent Vivier wrote: > Le 12/07/2019 à 15:36, Arnd Bergmann a écrit : > >> We don't do memcopy() but we set each field one by one, so the padding > >> doesn't > >> seem needed if we define correctly the user structure: > >> > >> struct target_timeval64 { > >>

Re: [Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 1:37 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This was found by GCC 8.3 static analysis. > Again, please amend: Fixes: ead9360e2fb Reported-by: Stefan Weil > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 2 ++ > 1 file changed, 2 inse

Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Paolo Bonzini
On 12/07/19 15:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/usb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig > index 564305e283..1b435ec002 100644 > --- a/hw/usb/Kconfig > +++ b/hw/usb/Kco

Re: [Qemu-devel] [PATCH for 4.1 4/4] target/mips: Add missing 'break' for certain cases of MTTR handling

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 1:37 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This was found by GCC 8.3 static analysis. > Similar to the previous one: Fixes: ead9360e2fb Reported-by: Stefan Weil > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

Re: [Qemu-devel] ?==?utf-8?q? ?==?utf-8?q? [PATCH for 4.1?==?utf-8?q? 2/4]?==?utf-8?q? target/mips: Add missing 'break' for a case of MTHC0 handling

2019-07-12 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé >  > > From: Aleksandar Markovic > > > > This was found by GCC 8.3 static analysis. > > >  > I think you can amend: >  > Fixes: 5fb2dcd1792 > Reported-by: Stefan Weil > Yes, indeed. This will be added in the next version. Thanks, Aleksandar

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Juan Quintela
Peter Maydell wrote: > On Thu, 11 Jul 2019 at 11:56, Juan Quintela wrote: >> >> The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: >> >> Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) >> >> are available in the Git repository at: >> >> https://gith

Re: [Qemu-devel] [RISU PATCH v3 03/18] risugen_x86_asm: add module

2019-07-12 Thread Richard Henderson
On 7/12/19 12:32 AM, Jan Bobek wrote: > The module risugen_x86_asm.pm exports named register constants and > asm_insn_* family of functions, which greatly simplify emission of x86 > instructions. > > Signed-off-by: Jan Bobek > --- > risugen_x86_asm.pm | 918 ++

Re: [Qemu-devel] [PATCH v2 for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-12 Thread Christophe Lyon
On Thu, 11 Jul 2019 at 15:12, Peter Maydell wrote: > > The ARMv5 architecture didn't specify detailed per-feature ID > registers. Now that we're using the MVFR0 register fields to > gate the existence of VFP instructions, we need to set up > the correct values in the cpu->isar structure so that we

Re: [Qemu-devel] ?==?utf-8?q? ?==?utf-8?q? [PATCH for 4.1?==?utf-8?q? 3/4]?==?utf-8?q? target/mips: Add missing 'break' for certain cases of MFTR handling

2019-07-12 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé >  > > From: Aleksandar Markovic > >  > > This was found by GCC 8.3 static analysis. > > >  > Again, please amend: >  > Fixes: ead9360e2fb Who would think that this bug existed since 2007? ...étrange. Thanks, Aleksandar

Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 3:58 PM, Paolo Bonzini wrote: > On 12/07/19 15:39, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/usb/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig >> index 564305e283..1b435ec002

[Qemu-devel] Call for agenda for KVM call for 2019-07-16

2019-07-12 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [RISU PATCH v3 04/18] risugen_x86_constraints: add module

2019-07-12 Thread Richard Henderson
On 7/12/19 12:32 AM, Jan Bobek wrote: > +sub vex($%) > +{ > +my ($insn, %vex) = @_; > +my $regidw = $is_x86_64 ? 4 : 3; > + > +# There is no point in randomizing other VEX fields, since > +# VEX.R/.X/.B are encoded automatically by risugen_x86_asm, and > +# VEX.M/.P are opcodes.

Re: [Qemu-devel] [PATCH v2 06/13] doc: update AMD SEV to include Live migration flow

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > Signed-off-by: Brijesh Singh > --- > docs/amd-memory-encryption.txt | 42 +- > 1 file changed, 41 insertions(+), 1 deletion(-) > > diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt > inde

[Qemu-devel] [Bug 1836192] Re: Regressions on arm926 target with some GCC tests

2019-07-12 Thread Christophe Lyon
I confirm this patch fixes the problem I reported. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836192 Title: Regressions on arm926 target with some GCC tests Status in QEMU: In Progre

[Qemu-devel] [Bug 1834496] Re: Regressions on arm target with some GCC tests

2019-07-12 Thread Christophe Lyon
I confirm this patch fixes the problem I reported. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1834496 Title: Regressions on arm target with some GCC tests Status in QEMU: In Progress

[Qemu-devel] [Bug 1836078] Re: Regressions on arm-linux-gnueabihf target with some GCC tests

2019-07-12 Thread Christophe Lyon
I confirm this patch fixes the problem I reported. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836078 Title: Regressions on arm-linux-gnueabihf target with some GCC tests Status in QEMU

[Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Juan Quintela
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into staging (2019-07-12 11:06:48 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags

[Qemu-devel] [PULL 01/19] migration: fix multifd_recv event typo

2019-07-12 Thread Juan Quintela
It uses num in multifd_send(). Make it coherent. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Wei Yang Signed-off-by: Juan Quintela --- migration/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/trace-events b/migrati

[Qemu-devel] [PULL 02/19] migration-test: rename parameter to parameter_int

2019-07-12 Thread Juan Quintela
We would need _str ones on the next patch. Signed-off-by: Juan Quintela Reviewed-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 55 +- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/tests/migration-test.c b/tests/

[Qemu-devel] [PULL 04/19] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS

2019-07-12 Thread Juan Quintela
From: Wei Yang On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel's sem_sync semaphore. This semaphore is triggered by a packet with MULTIFD_FLAG_SYNC flag. While in current implementatio

[Qemu-devel] [PULL 06/19] cutils: remove one unnecessary pointer operation

2019-07-12 Thread Juan Quintela
From: Wei Yang Since we will not operate on the next address pointed by out, it is not necessary to do addition on it. After removing the operation, the function size reduced 16/18 bytes. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Message-Id: <2019

[Qemu-devel] [PULL 03/19] migration-test: Add migration multifd test

2019-07-12 Thread Juan Quintela
We set multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Tested-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests

[Qemu-devel] [PULL 10/19] memory: Don't set migration bitmap when without migration

2019-07-12 Thread Juan Quintela
From: Peter Xu Similar to 9460dee4b2 ("memory: do not touch code dirty bitmap unless TCG is enabled", 2015-06-05) but for the migration bitmap - we can skip the MIGRATION bitmap update if migration not enabled. Reviewed-by: Paolo Bonzini Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Mess

[Qemu-devel] [PULL 18/19] migration: Split log_clear() into smaller chunks

2019-07-12 Thread Juan Quintela
From: Peter Xu Currently we are doing log_clear() right after log_sync() which mostly keeps the old behavior when log_clear() was still part of log_sync(). This patch tries to further optimize the migration log_clear() code path to split huge log_clear()s into smaller chunks. We do this by spli

[Qemu-devel] [PULL 09/19] migration: No need to take rcu during sync_dirty_bitmap

2019-07-12 Thread Juan Quintela
From: Peter Xu cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as parameter, which means that it must be with RCU read lock held already. Taking it again inside seems redundant. Removing it. Instead comment on the functions about the RCU read lock. Reviewed-by: Paolo Bonzini Reviewe

[Qemu-devel] [PULL 19/19] migration: allow private destination ram with x-ignore-shared

2019-07-12 Thread Juan Quintela
From: Peng Tao By removing the share ram check, qemu is able to migrate to private destination ram when x-ignore-shared capability is on. Then we can create multiple destination VMs based on the same source VM. This changes the x-ignore-shared migration capability to work similar to Lai's origin

[Qemu-devel] [PULL 11/19] bitmap: Add bitmap_copy_with_{src|dst}_offset()

2019-07-12 Thread Juan Quintela
From: Peter Xu These helpers copy the source bitmap to destination bitmap with a shift either on the src or dst bitmap. Meanwhile, we never have bitmap tests but we should. This patch also introduces the initial test cases for utils/bitmap.c but it only tests the newly introduced functions. Si

[Qemu-devel] [PULL 05/19] migration/xbzrle: update cache and current_data in one place

2019-07-12 Thread Juan Quintela
From: Wei Yang When we are not in the last_stage, we need to update the cache if page is not the same. Currently this procedure is scattered in two places and mixed with encoding status check. This patch extract this general step out to make the code a little bit easy to read. Signed-off-by: W

[Qemu-devel] [PULL 07/19] migration/multifd: sync packet_num after all thread are done

2019-07-12 Thread Juan Quintela
From: Wei Yang Notification from recv thread is not ordered, which means we may be notified by one MultiFDRecvParams but adjust packet_num for another. Move the adjustment after we are sure each recv thread are sync-ed. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Reviewed-by: Peter Xu

[Qemu-devel] [PULL 12/19] memory: Pass mr into snapshot_and_clear_dirty

2019-07-12 Thread Juan Quintela
From: Peter Xu Also we change the 2nd parameter of it to be the relative offset within the memory region. This is to be used in follow up patches. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20190603065056.25211-6-pet...@redhat.com> Signed-off-by: Juan Quintela --- exec.c

[Qemu-devel] [PULL 14/19] kvm: Update comments for sync_dirty_bitmap

2019-07-12 Thread Juan Quintela
From: Peter Xu It's obviously obsolete. Do some update. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20190603065056.25211-8-pet...@redhat.com> Signed-off-by: Juan Quintela --- accel/kvm/kvm-all.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --g

[Qemu-devel] [PULL 08/19] migration/ram.c: reset complete_round when we gets a queued page

2019-07-12 Thread Juan Quintela
From: Wei Yang In case we gets a queued page, the order of block is interrupted. We may not rely on the complete_round flag to say we have already searched the whole blocks on the list. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Message-Id: <20190605010828.6969-1-richardw.y...@linux.in

[Qemu-devel] [PULL 13/19] memory: Introduce memory listener hook log_clear()

2019-07-12 Thread Juan Quintela
From: Peter Xu Introduce a new memory region listener hook log_clear() to allow the listeners to hook onto the points where the dirty bitmap is cleared by the bitmap users. Previously log_sync() contains two operations: - dirty bitmap collection, and, - dirty bitmap clear on remote site. L

[Qemu-devel] [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap

2019-07-12 Thread Juan Quintela
From: Peter Xu When synchronizing dirty bitmap from kernel KVM we do it in a per-kvmslot fashion and we allocate the userspace bitmap for each of the ioctl. This patch instead make the bitmap cache be persistent then we don't need to g_malloc0() every time. More importantly, the cached per-kvms

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711104412.31233-1-quint...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711104412.31233-1-quint...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/19] Migration p

[Qemu-devel] [PULL 17/19] kvm: Support KVM_CLEAR_DIRTY_LOG

2019-07-12 Thread Juan Quintela
From: Peter Xu Firstly detect the interface using KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 and mark it. When failed to enable the new feature we'll fall back to the old sync. Provide the log_clear() hook for the memory listeners for both address spaces of KVM (normal system memory, and SMM) and deliev

[Qemu-devel] [PULL 16/19] kvm: Introduce slots lock for memory listener

2019-07-12 Thread Juan Quintela
From: Peter Xu Introduce KVMMemoryListener.slots_lock to protect the slots inside the kvm memory listener. Currently it is close to useless because all the KVM code path now is always protected by the BQL. But it'll start to make sense in follow up patches where we might do remote dirty bitmap

Re: [Qemu-devel] [PATCH for 4.1] Fix broken build with WHPX enabled

2019-07-12 Thread Philippe Mathieu-Daudé
Cc'ing Justin Maybe we should add a MAINTAINERS section for the WHPX files. On 7/12/19 3:26 PM, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > target/i386/whpx-all.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/whpx-all.c b/target/i386/whpx-

Re: [Qemu-devel] [PATCH 2/2] spapr: initial implementation for H_TPM_COMM hcall

2019-07-12 Thread Michael Roth
Quoting David Gibson (2019-07-12 01:46:19) > On Thu, Jul 11, 2019 at 08:19:34PM -0500, Michael Roth wrote: > > This implements the H_TPM_COMM hypercall, which is used by an > > Ultravisor to pass TPM commands directly to the host's TPM device, or > > a TPM Resource Manager associated with the devic

[Qemu-devel] [PATCH] .gitignore: ignore some vhost-user* related files

2019-07-12 Thread Michal Privoznik
Commit d52c454aadc creates '/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu' and commit 06914c97d3a creates '/vhost-user-input' neither of which is ignored by git. Signed-off-by: Michal Privoznik --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.g

Re: [Qemu-devel] [PATCH v3] LUKS: support preallocation

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711150940.17483-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711150940.17483-1-mlevi...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v3] LUKS: support

Re: [Qemu-devel] [PATCH] .gitignore: ignore some vhost-user* related files

2019-07-12 Thread Marc-André Lureau
On Fri, Jul 12, 2019 at 6:42 PM Michal Privoznik wrote: > > Commit d52c454aadc creates > '/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu' > and commit 06914c97d3a creates '/vhost-user-input' neither of > which is ignored by git. > > Signed-off-by: Michal Privoznik Reviewed-by: Ma

[Qemu-devel] [PATCH] hw/i386: turn off vmport if CONFIG_VMPORT is disabled

2019-07-12 Thread Julio Montes
vmport device is not included when CONFIG_VMPORT is disabled, hence QEMU fails with the following error: `Unknown device 'vmport' for bus 'ISA': unknown.` Signed-off-by: Julio Montes --- hw/i386/pc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c33c

Re: [Qemu-devel] [PATCH v3] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711171556.3377-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711171556.3377-1-laur...@vivier.eu Type: series Subject: [Qemu-devel] [PATCH v3] linux-user: fix to h

Re: [Qemu-devel] [PATCH] hw/i386: turn off vmport if CONFIG_VMPORT is disabled

2019-07-12 Thread Paolo Bonzini
On 12/07/19 16:50, Julio Montes wrote: > vmport device is not included when CONFIG_VMPORT is disabled, hence > QEMU fails with the following error: > > `Unknown device 'vmport' for bus 'ISA': unknown.` > > Signed-off-by: Julio Montes > --- > hw/i386/pc.c | 5 + > 1 file changed, 5 insertion

Re: [Qemu-devel] [PATCH v2 04/13] kvm: add support to sync the page encryption state bitmap

2019-07-12 Thread Singh, Brijesh
On 7/11/19 2:05 PM, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: >> The SEV VMs have concept of private and shared memory. The private memory >> is encrypted with guest-specific key, while shared memory may be encrypted >> with hyperivosr key. The KVM_GET_PAGE_E

Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Paolo Bonzini
On 12/07/19 16:16, Philippe Mathieu-Daudé wrote: > I wondered but am not sure, it is default to Yes, but Bluetooth code is > deprecated and print a big warning when you use it, so I think this > device should not be selected as default, neither pull in the deprecated > bluetooth code. > > So perso

Re: [Qemu-devel] [PATCH v2 08/13] misc.json: add migrate-set-sev-info command

2019-07-12 Thread Singh, Brijesh
On 7/12/19 5:09 AM, Daniel P. Berrangé wrote: > On Fri, Jul 12, 2019 at 11:00:22AM +0100, Dr. David Alan Gilbert wrote: >> * Singh, Brijesh (brijesh.si...@amd.com) wrote: >>> The command can be used by the hypervisor to specify the target Platform >>> Diffie-Hellman key (PDH) and certificate chai

Re: [Qemu-devel] [RFC v4 00/29] vSMMUv3/pSMMUv3 2 stage VFIO integration

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711172845.31035-1-eric.au...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711173131.6347-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711173131.6347-1-laur...@vivier.eu Type: series Subject: [Qemu-devel] [PATCH v4] linux-user: fix to h

Re: [Qemu-devel] [PATCH 1/2] docs/specs: initial spec summary for Ultravisor-related hcalls

2019-07-12 Thread Michael Roth
Quoting David Gibson (2019-07-12 01:40:27) > On Thu, Jul 11, 2019 at 08:19:33PM -0500, Michael Roth wrote: > > For now this only covers hcalls relating to TPM communication since > > it's the only one particularly important from a QEMU perspective atm, > > but others can be added here where it make

Re: [Qemu-devel] [PATCH-for-4.1 v4 2/5] hw/block/pflash_cfi01: Use the correct READ_ARRAY value

2019-07-12 Thread Peter Maydell
On Thu, 11 Jul 2019 at 16:58, Philippe Mathieu-Daudé wrote: > > In the "Read Array Flowchart" the command has a value of 0xFF. > > In the document [*] the "Read Array Flowchart", the READ_ARRAY > command has a value of 0xff. > > Use the correct value in the pflash model. > > There is no change of

Re: [Qemu-devel] [PATCH v2 09/13] target/i386: sev: add support to encrypt the outgoing page

2019-07-12 Thread Singh, Brijesh
On 7/12/19 5:43 AM, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: >> The sev_save_outgoing_page() provide the implementation to encrypt the >> guest private pages during the transit. The routines uses the SEND_START >> command to create the outgoing encryption co

Re: [Qemu-devel] [PATCH v2 10/13] target/i386: sev: add support to load incoming encrypted page

2019-07-12 Thread Singh, Brijesh
On 7/12/19 6:02 AM, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: >> The sev_load_incoming_page() provide the implementation to read the >> incoming guest private pages from the socket and load it into the guest >> memory. The routines uses the RECEIVE_START comm

Re: [Qemu-devel] [PATCH v2 09/13] target/i386: sev: add support to encrypt the outgoing page

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > > > On 7/12/19 5:43 AM, Dr. David Alan Gilbert wrote: > > * Singh, Brijesh (brijesh.si...@amd.com) wrote: > >> The sev_save_outgoing_page() provide the implementation to encrypt the > >> guest private pages during the transit. The routines uses th

Re: [Qemu-devel] [PULL 0/2] Block layer patches

2019-07-12 Thread Peter Maydell
On Fri, 12 Jul 2019 at 14:53, Kevin Wolf wrote: > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' > into staging (2019-07-12 11:06:48 +0100) > > are ava

Re: [Qemu-devel] [RFC PATCH 0/2] spapr: Implement H_TPM_COMM for accessing host TPM device

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190712011934.29863-1-mdr...@linux.vnet.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190712011934.29863-1-mdr...@linux.vnet.ibm.com Type: series Subject: [Qemu-devel] [RFC PATCH 0

Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix non-secure flash mode

2019-07-12 Thread Peter Maydell
On Fri, 12 Jul 2019 at 08:53, David Engraf wrote: > > Using the whole 128 MiB flash in non-secure mode is not working because > virt_flash_fdt() expects the same address for secure_sysmem and sysmem. > This is not correctly handled by caller because it forwards NULL for > secure_sysmem in non-secu

[Qemu-devel] [PULL 0/8] virtio, pc, pci: fixes, cleanups, tests

2019-07-12 Thread Michael S. Tsirkin
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into staging (2019-07-12 11:06:48 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qem

[Qemu-devel] [PULL 2/8] pcie: consistent names for function args

2019-07-12 Thread Michael S. Tsirkin
The function declarations for pci_cap_slot_get and pci_cap_slot_write_config call the argument "slot_ctl", but the function definitions and all the call sites drop the 'o' and call it "slt_ctl". Let's be consistent. Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel

[Qemu-devel] [PULL 1/8] xio3130_downstream: typo fix

2019-07-12 Thread Michael S. Tsirkin
slt ctl/status are passed in incorrect order. Fix this up. Signed-off-by: Michael S. Tsirkin Reported-by: Peter Maydell Reviewed-by: Marcel Apfelbaum --- hw/pci-bridge/xio3130_downstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/xio3130_downstream.c b

Re: [Qemu-devel] [PATCH v2 12/13] migration: add support to migrate page encryption bitmap

2019-07-12 Thread Singh, Brijesh
On 7/12/19 6:30 AM, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: >> When memory encryption is enabled, the hypervisor maintains a page >> encryption bitmap which is referred by hypervisor during migratoin to check >> if page is private or shared. The bitmap is b

[Qemu-devel] [Bug 1811533] Re: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer

2019-07-12 Thread Žilvinas Žaltiena
Refresh: still happening with Qemu 4.0 and Kernel 5.2. One additional observation: 4) problem disappears when vhost is disabled. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811533 Title: Unstab

Re: [Qemu-devel] [PATCH v2 03/13] migration/ram: add support to send encrypted pages

2019-07-12 Thread Singh, Brijesh
On 7/12/19 4:27 AM, Dr. David Alan Gilbert wrote: [snip] >>> >>> OK, that's our very last usable flag! Use it wisely! >>> >> >> Hmm, maybe then I missed something. I thought the flag is 64-bit and >> we have more room. Did I miss something ? > > The 64bit value written in the stream is >(

[Qemu-devel] [PATCH v2] hw/i386: turn off vmport if CONFIG_VMPORT is disabled

2019-07-12 Thread Julio Montes
vmport device is not included when CONFIG_VMPORT is disabled, hence QEMU fails with the following error: `Unknown device 'vmport' for bus 'ISA': unknown.` v2: imply VMPORT (Paolo Bonzini ) Signed-off-by: Julio Montes --- hw/i386/Kconfig | 4 ++-- hw/i386/pc.c| 5 + 2 files changed, 7 i

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Peter Maydell
On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote: > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' > into staging (2019-07-12 11:06:48 +0100) > > are ava

Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 4:58 PM, Paolo Bonzini wrote: > On 12/07/19 16:16, Philippe Mathieu-Daudé wrote: >> I wondered but am not sure, it is default to Yes, but Bluetooth code is >> deprecated and print a big warning when you use it, so I think this >> device should not be selected as default, neither pull in

Re: [Qemu-devel] [Qemu-block] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-12 Thread John Snow
On 7/11/19 8:24 AM, Stefan Hajnoczi wrote: > On Sun, Jul 07, 2019 at 07:55:03PM -0700, shaju.abra...@nutanix.com wrote: > > Reviewed-by: Stefan Hajnoczi > > CCing John Snow, IDE maintainer. > > You can use scripts/get_maintainer.pl -f hw/ide/core.c to find out who > to send patches to. > >

[Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning

2019-07-12 Thread Marc-André Lureau
../contrib/rdmacm-mux/main.c: In function ‘parse_args’: ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835 equals destination size [-Werror=stringop-truncation] 118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX); Signed-off-by: Marc-André Lureau --- c

Re: [Qemu-devel] [PATCH-for-4.1 v4 2/5] hw/block/pflash_cfi01: Use the correct READ_ARRAY value

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 5:15 PM, Peter Maydell wrote: > On Thu, 11 Jul 2019 at 16:58, Philippe Mathieu-Daudé > wrote: >> >> In the "Read Array Flowchart" the command has a value of 0xFF. >> >> In the document [*] the "Read Array Flowchart", the READ_ARRAY >> command has a value of 0xff. >> >> Use the correct

Re: [Qemu-devel] [PATCH] .gitignore: ignore some vhost-user* related files

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 4:41 PM, Michal Privoznik wrote: > Commit d52c454aadc creates > '/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu' > and commit 06914c97d3a creates '/vhost-user-input' neither of > which is ignored by git. > > Signed-off-by: Michal Privoznik > --- > .gitignore | 3 +++ >

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 9:35 AM, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > Please amend: Fixes: Coverity (CID 1403009) > Signed-off-by: Pankaj Gupta Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/11/19 9:25 PM, Michael S. Tsirkin wrote: > slt ctl/status are passed in incorrect order. > Fix this up. > Fixes: Coverity (CID 1403007) > Signed-off-by: Michael S. Tsirkin > Reported-by: Peter Maydell > --- > hw/pci-bridge/xio3130_downstream.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-12 Thread Philippe Mathieu-Daudé
Cc'ing Gerd On 7/11/19 12:55 AM, Carlo Marcelo Arenas Belón wrote: > If SDL2 is requested but pkg-config doesn't have a module for it > configure should fallback to use sdl*-config, but wasn't able to > because and old variable (from SDL) was being used by mistake. > > Correct the variable name a

Re: [Qemu-devel] [PATCH for-4.1 2/2] crypto: fix function signatures for nettle 2.7 vs 3

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 12:18 PM, Daniel P. Berrangé wrote: > Nettle version 2.7.x used 'unsigned int' instead of 'size_t' for length > parameters in functions. Use a local typedef so that we can build with > the correct signature depending on nettle version, as we already do in > the cipher code. > Reported-

[Qemu-devel] [Bug 1836078] Re: Regressions on arm-linux-gnueabihf target with some GCC tests

2019-07-12 Thread Alex Bennée
I think the ieee6 test is due to a broken runtime: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78314 ** Bug watch added: GCC Bugzilla #78314 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78314 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [PATCH] build-sys: remove slirp cflags from main-loop.o

2019-07-12 Thread Marc-André Lureau
Left over from c2d63650d962612cfa1b21302782d4cd12142c74. Signed-off-by: Marc-André Lureau --- util/Makefile.objs | 1 - 1 file changed, 1 deletion(-) diff --git a/util/Makefile.objs b/util/Makefile.objs index 38178201ff..68af3cd5e9 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@ -3,

Re: [Qemu-devel] [PATCH for-4.1?] hw/arm/fsl-imx6ul.c: Remove dead SMP-related code

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 1:50 PM, Peter Maydell wrote: > The i.MX6UL always has a single Cortex-A7 CPU (we set FSL_IMX6UL_NUM_CPUS > to 1 in line with this). This means that all the code in fsl-imx6ul.c to > handle multiple CPUs is dead code, and Coverity is now complaining that > it is unreachable (CID 1403008,

Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Paolo Bonzini
On 12/07/19 18:45, Philippe Mathieu-Daudé wrote: > On 7/12/19 4:58 PM, Paolo Bonzini wrote: >> The other is whether we want to enable USB_BLUETOOTH by default. I >> wouldn't have any problem there, but if we disable it basically no one >> would ship/use it and we might as well delete the whole thi

Re: [Qemu-devel] [PATCH] build-sys: remove slirp cflags from main-loop.o

2019-07-12 Thread Paolo Bonzini
On 12/07/19 19:27, Marc-André Lureau wrote: > Left over from c2d63650d962612cfa1b21302782d4cd12142c74. > > Signed-off-by: Marc-André Lureau > --- > util/Makefile.objs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/Makefile.objs b/util/Makefile.objs > index 38178201ff..68af3cd5e9 1

Re: [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning

2019-07-12 Thread Paolo Bonzini
On 12/07/19 18:51, Marc-André Lureau wrote: > ../contrib/rdmacm-mux/main.c: In function ‘parse_args’: > ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835 > equals destination size [-Werror=stringop-truncation] > 118 | strncpy(unix_socket_path, optarg, SOCKET_

[Qemu-devel] [PATCH] util: merge main-loop.c and iohandler.c

2019-07-12 Thread Paolo Bonzini
main-loop.c has a dependency on iohandler.c, and everything breaks if that dependency is instead satisfied by stubs/iohandler.c. Just put everything in the same file to avoid strange dependencies on the order of files in util-obj-y. Signed-off-by: Paolo Bonzini --- util/Makefile.objs | 2 +- u

[Qemu-devel] [PATCH 0/7] block: Generic file creation fallback

2019-07-12 Thread Max Reitz
Hi, Kevin commented on my RFC, so I got what an RFC wants, and he didn’t object to the creation fallback part. So I suppose I can go down that route at least. (Which was actually the more important part of the series.) So as in the RFC, this series adds a fallback path for creating files (on th

[Qemu-devel] [PATCH 2/7] block: Add blk_truncate_for_formatting()

2019-07-12 Thread Max Reitz
Signed-off-by: Max Reitz --- include/sysemu/block-backend.h | 12 block/block-backend.c | 54 ++ 2 files changed, 66 insertions(+) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index 733c4957eb..cd9ec8bf52 100644 --

<    1   2   3   >