On 7/12/19 4:58 PM, Paolo Bonzini wrote: > On 12/07/19 16:16, Philippe Mathieu-Daudé wrote: >> I wondered but am not sure, it is default to Yes, but Bluetooth code is >> deprecated and print a big warning when you use it, so I think this >> device should not be selected as default, neither pull in the deprecated >> bluetooth code. >> >> So personally I'd respin without 'default y'. If you have a good reason >> to use it, I can use 'select' instead. > > There are two separate questions. One is whether USB_BLUETOOTH should > select BLUETOOTH and the answer there is almost certainly yes (in the > words of kconfig.rst, BLUETOOTH is a "subsystem" while USB_BLUETOOTH is > a "device"; devices select the bus that the device provides).
Fair :) > The other is whether we want to enable USB_BLUETOOTH by default. I > wouldn't have any problem there, but if we disable it basically no one > would ship/use it and we might as well delete the whole thing. The only user is the ARM Nokia N-series board, so if we set default=n, the Bluetooth subsystem will be only be selected on arm-softmmu (and aarch64-softmmu). This seems a sane cleanup. If another board wants to use the bluetooth code, it should probably move it out of the orphan status.
