On 7/12/19 3:58 PM, Paolo Bonzini wrote: > On 12/07/19 15:39, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> hw/usb/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig >> index 564305e283..1b435ec002 100644 >> --- a/hw/usb/Kconfig >> +++ b/hw/usb/Kconfig >> @@ -82,7 +82,7 @@ config USB_NETWORK >> config USB_BLUETOOTH >> bool >> default y >> - depends on USB >> + depends on USB && BLUETOOTH >> >> config USB_SMARTCARD >> bool >> > > Shouldn't it select BLUETOOTH instead?
I wondered but am not sure, it is default to Yes, but Bluetooth code is deprecated and print a big warning when you use it, so I think this device should not be selected as default, neither pull in the deprecated bluetooth code. So personally I'd respin without 'default y'. If you have a good reason to use it, I can use 'select' instead. Regards, Phil.
