On 2019/4/1 下午9:44, Michael S. Tsirkin wrote:
On Wed, Mar 27, 2019 at 10:27:01AM +0800, Jason Wang wrote:
On 2019/3/26 下午8:49, Michael S. Tsirkin wrote:
On Tue, Mar 26, 2019 at 02:59:19PM +0800, Jason Wang wrote:
On 2019/3/25 下午8:32, Michael S. Tsirkin wrote:
On Mon, Mar 25, 2019 at 11:56:1
On Mon, Apr 08, 2019 at 02:15:36PM +0800, Catherine Ho wrote:
> Hi Peter Xu
>
> On Mon, 8 Apr 2019 at 11:25, Peter Xu wrote:
>
> > On Sun, Apr 07, 2019 at 10:19:05PM -0400, Catherine Ho wrote:
> > > Currently it is not forbidden to use "-object
> > memory-backend-file,share=on"
> > > and togethe
On Wed, 3 Apr 2019 16:25:49 +
Shameerali Kolothum Thodi wrote:
> Hi Laszlo,
>
> > -Original Message-
> > From: Laszlo Ersek [mailto:ler...@redhat.com]
> > Sent: 03 April 2019 14:29
> > To: Shameerali Kolothum Thodi ;
> > Igor Mammedov
> > Cc: Auger Eric ; Ard Biesheuvel
> > ; peter.
On Wed, 3 Apr 2019 15:19:52 +0200
Laszlo Ersek wrote:
> On 04/03/19 11:49, Igor Mammedov wrote:
> > On Tue, 2 Apr 2019 17:38:26 +0200
> > Laszlo Ersek wrote:
> >
> >> On 04/02/19 17:29, Auger Eric wrote:
> >>> Hi Laszlo,
> >>>
> >>> On 4/1/19 3:07 PM, Laszlo Ersek wrote:
> On 03/29
On Fri, Apr 05, 2019 at 06:29:49PM +0200, Sergio Lopez wrote:
>
> Stefan Hajnoczi writes:
>
> > Hi Sergio,
> > Here are the forgotten event loop optimizations I mentioned:
> >
> > https://github.com/stefanha/qemu/commits/event-loop-optimizations
> >
> > The goal was to eliminate or reorder sysc
char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr. No other
ChardevClass::open() prints anything on success. Drop the message.
Cc: "Marc-André Lureau"
Cc: Paolo Bonzini
Signed-off-by: Markus Armbruster
---
chardev/cha
This series cleans up two kinds of error_printf() misuse:
* Errors and warnings should be reported with error_report() and
warn_report().
* Help output should be go to stdout, not stderr.
This is obviously for 4.1. If nobody objects, I'll take the whole
series through my tree.
Markus Armbrus
error_exit() uses low-level error_printf() to report errors.
Modernize it to use error_vreport().
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
---
qemu-img.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qemu-img.c b/qemu-i
kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns
-ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by
ioctl(). Its caller s390_cpu_virt_mem_rw() recovers from both
failures.
kvm_s390_mem_op() prints "KVM_S390_MEM_OP failed" with error_printf()
in the latter failu
Cc: Paul Burton
Cc: Aleksandar Rikalo
Signed-off-by: Markus Armbruster
---
hw/mips/boston.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index e5bab3cadc..a8b29f62f5 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -528,21
Command line help help explicitly requested by the user should be
printed to stdout, not stderr. We do elsewhere. Adjust -machine
$TYPE,help and -accel help to match: use printf() instead of
error_printf().
Cc: Marcel Apfelbaum
Signed-off-by: Markus Armbruster
---
vl.c | 10 +-
1 file
Command line help explicitly requested by the user should be printed
to stdout, not stderr. We do elsewhere. Adjust -chardev to match:
use qemu_printf() instead of error_printf(). Plain printf() would be
wrong because we need to print to the current monitor for chardev-add
help".
Cc: "Marc-Andr
On 4/8/19 8:21 AM, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 19:17:35 -0400
> schrieb "Michael S. Tsirkin" :
>
>> Let's keep it simple: set a config variable, then check it here.
>
> Better revert f590a812c21074e82228de3e1dfb57b75fc02b62 and
> 23858f4092fc9ebf9e7a5e5110e44abef6fc6643 for the time
load_fit() reports errors with error_printf() instead of
error_report(). Worse, it even reports errors it actually recovers
from, in fit_cfg_compatible() and fit_load_fdt(). Messed up in
initial commit 51b58561c1d.
Convert the helper functions for load_fit() to Error. Make sure each
failure pat
We commonly want to print to the current monitor if we have one, else
to stdout/stderr. For stderr, have error_printf(). For stdout, all
we have is monitor_vfprintf(), which is rather unwieldy. We often
print to stderr just because error_printf() is easier.
New qemu_printf() and qemu_vprintf()
Commit 18269069c310 ("migration: Introduce ignore-shared capability")
addes ignore-shared capability to bypass the shared ramblock (e,g,
membackend + numa node). It does good to live migration.
As told by Yury,this commit expectes that QEMU doesn't write to guest RAM
until VM starts, but it does o
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Signed-off-by: Markus Armbruster
---
hw/timer/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index d97436bc7b..41024f39fb 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -744,7 +744,7
Callbacks ssh_co_readv(), ssh_co_writev(), ssh_co_flush() report
errors to the user with error_printf(). They shouldn't, it's their
caller's job. Replace by a suitable trace point.
Perhaps we should convert this part of the block driver interface to
Error, so block drivers can pass more detail t
Commit a95db58f210 added monitor_vfprintf() as an error_printf()
generalized from stderr to arbitrary streams, then used it wrapped in
helper out_printf() to print -device/device_add help to stdout. Use
qemu_printf() instead, and delete monitor_vfprintf() and out_printf().
Cc: Dr. David Alan Gilb
printf() & friends return the number of characters written on success,
negative value on error.
monitor_printf(), monitor_vfprintf(), monitor_vprintf(),
error_printf(), error_printf_unless_qmp(), error_vprintf(), and
error_vprintf_unless_qmp() return void. Some of them carry a TODO
comment asking
Cc: Alex Williamson
Signed-off-by: Markus Armbruster
---
hw/vfio/pci.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 504019c458..0142819ea6 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -947,8 +947,10 @@ static vo
Currently it is not forbidden to use "-object memory-backend-file,share=on"
and together with "-incoming". But after incoming migration is finished,
the memory-backend-file will be definitely written if share=on. So the
memory-backend-file can only be used once, but failed in the 2nd time
incoming.
On 08/04/2019 10.36, Markus Armbruster wrote:
> kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns
> -ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by
> ioctl(). Its caller s390_cpu_virt_mem_rw() recovers from both
> failures.
>
> kvm_s390_mem_op() prints "KVM_S
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Signed-off-by: Markus Armbruster
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 35451c1e99..a74995b596 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -927,7 +927,7 @@ static ui
Command line help explicitly requested by the user should be printed
to stdout, not stderr. We do elsewhere. Adjust -drive to match: use
qemu_printf() instead of error_printf(). Plain printf() would be
wrong because we need to print to the current monitor for "drive_add
... format=help".
Cc: Ke
* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Hello,
>
> Dr. David Alan Gilbert (git), le ven. 05 avril 2019 19:46:48 +0100, a ecrit:
> > From: "Dr. David Alan Gilbert"
> >
> > Gcc 9 needs some convincing that sopreprbuf really is going to fill
> > in iov in the call from soreadbuf, even
Wei Yang writes:
> Function find_default_machine() is introduced by commit 2c8cffa599b7
> "vl: make find_default_machine externally visible", and it was used
> outside of vl.c until commit a904410af5f1 "pc_sysfw: remove the rom_only
> property".
>
> Commit a904410af5f1 "pc_sysfw: remove the rom_o
On Fri, Apr 05, 2019 at 05:24:04PM +0300, Andrey Shinkevich wrote:
> On a file system used by the customer, fallocate() returns an error
> if the block is not properly aligned. So, bdrv_co_pwrite_zeroes()
> fails. We can handle that case the same way as it is done for the
> unsupported cases, namel
Am Mon, 8 Apr 2019 11:04:09 +0200
schrieb Laszlo Ersek :
> This is not a QEMU build failure, but an issue in the downstream
> packaging that not only tries to build QEMU, but performs a maintainer
> build on binary artifacts.
I'm sure everyone will rebuild the things from source that can be rebui
On 04/05/19 17:33, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Two trivial fixes to avoid the latest EDK2 testing series to
> cause trouble to downstream distributions (in particular if
> they have PIE enforced).
I disgree with this.
(1) In the first commit message, you say,
"The iPXE project alread
---
linux-user/syscall.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 208fd1813d..985095e4d5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8240,7 +8240,7 @@ st
On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote:
>
> Command line help explicitly requested by the user should be printed
> to stdout, not stderr. We do elsewhere. Adjust -chardev to match:
> use qemu_printf() instead of error_printf(). Plain printf() would be
> wrong because we need to
On 04/08/19 11:02, Laszlo Ersek wrote:
> On 04/05/19 17:33, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> Two trivial fixes to avoid the latest EDK2 testing series to
>> cause trouble to downstream distributions (in particular if
>> they have PIE enforced).
>
> I disgree with this.
>
> (1) In the fi
Juan Quintela writes:
> Signed-off-by: Juan Quintela
>
> ---
> Rename it to NONE
> ---
> hmp.c| 17 +
> hw/core/qdev-properties.c| 11 +++
> include/hw/qdev-properties.h | 1 +
> migration/migration.c| 16
> qapi/comm
On Mon, 8 Apr 2019 10:39:40 +0200
Thomas Huth wrote:
> On 08/04/2019 10.36, Markus Armbruster wrote:
> > kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns
> > -ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by
> > ioctl(). Its caller s390_cpu_virt_mem_rw() reco
Hi
On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote:
>
> char_pty_open() prints a "char device redirected to PTY_NAME (label
> LABEL)" message to the current monitor or else to stderr. No other
> ChardevClass::open() prints anything on success. Drop the message.
>
> Cc: "Marc-André Lurea
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote:
> > * Jens Freimann (jfreim...@redhat.com) wrote:
> > > ping
> > >
> > > FYI: I'm also working on a few related tools to detect driver behaviour
> > > when
> > > assigning a MAC
Patchew URL:
https://patchew.org/QEMU/20190408084056.26212-1-ghor...@xiyoulinux.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190408084056.26212-1-ghor...@xiyoulinux.org
Subject: [Qemu-devel] Wshadow in qemu/linux-user/sysc
On 04/05/19 12:59, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 12:49:15 +0200
> schrieb Philippe Mathieu-Daudé :
>
>> The EDK2 submodule was added for UEFI testing, you don't need to compile
>> it to build/use QEMU.
>>
>> How did you end up compiling it?
>
> The qemu.spec file has this since a very l
On 4/8/19 11:36 AM, Markus Armbruster wrote:
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Signed-off-by: Markus Armbruster
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 35451c1e99..a74995b596 100644
--- a/hw/pci/pc
On 04/08/19 11:09, Olaf Hering wrote:
> Am Mon, 8 Apr 2019 11:04:09 +0200
> schrieb Laszlo Ersek :
>
>> This is not a QEMU build failure, but an issue in the downstream
>> packaging that not only tries to build QEMU, but performs a
>> maintainer build on binary artifacts.
>
> I'm sure everyone will
On Mon, 8 Apr 2019 at 02:45, Heyi Guo wrote:
> On 2019/4/7 21:16, Peter Maydell wrote:
> > I don't think it makes much sense to keep adding UARTs for every
> > bit of the system software stack. We don't have an infinite
> > supply of UARTs on real hardware either -- how is this handled
> > there ?
Hi Markus,
On 4/8/19 11:36 AM, Markus Armbruster wrote:
Command line help help explicitly requested by the user should be
printed to stdout, not stderr. We do elsewhere. Adjust -machine
$TYPE,help and -accel help to match: use printf() instead of
error_printf().
Cc: Marcel Apfelbaum
Signed-o
On 06/04/2019 01:50, John Snow wrote:
>
>
> On 4/5/19 10:24 AM, Andrey Shinkevich wrote:
>> On a file system used by the customer, fallocate() returns an error
>> if the block is not properly aligned. So, bdrv_co_pwrite_zeroes()
>> fails. We can handle that case the same way as it is done for t
On 08/04/2019 12:00, Stefan Hajnoczi wrote:
> On Fri, Apr 05, 2019 at 05:24:04PM +0300, Andrey Shinkevich wrote:
>> On a file system used by the customer, fallocate() returns an error
>> if the block is not properly aligned. So, bdrv_co_pwrite_zeroes()
>> fails. We can handle that case the same
On Sat, 6 Apr 2019 at 00:12, Michael S. Tsirkin wrote:
>
> The following changes since commit 436960c95946007aca713330e7a488a6f2e0696f:
>
> Merge remote-tracking branch
> 'remotes/berrange/tags/filemon-next-pull-request' into staging (2019-04-02
> 14:52:17 +0100)
>
> are available in the Git r
PINGING
I kindly remind you about this small patch for QEMU 4.1.
I am going to be away for vacation from April, 10th to May, 15th.
--
With the best regards,
Andrey Shinkevich
On 19/03/2019 01:18, John Snow wrote:
>
>
> On 2/28/19 4:26 AM, Andrey Shinkevich wrote:
>> When a bitmap is removed,
Am 08.04.2019 um 11:44 hat Andrey Shinkevich geschrieben:
>
>
> On 06/04/2019 01:50, John Snow wrote:
> >
> >
> > On 4/5/19 10:24 AM, Andrey Shinkevich wrote:
> >> On a file system used by the customer, fallocate() returns an error
> >> if the block is not properly aligned. So, bdrv_co_pwrite_z
Am 08.04.2019 um 12:04 hat Kevin Wolf geschrieben:
> Am 08.04.2019 um 11:44 hat Andrey Shinkevich geschrieben:
> >
> >
> > On 06/04/2019 01:50, John Snow wrote:
> > >
> > >
> > > On 4/5/19 10:24 AM, Andrey Shinkevich wrote:
> > >> On a file system used by the customer, fallocate() returns an er
Hi,
thanks for your patch! But please add a short patch description (beside
the subject), e.g. "Change the name of some variables so that the code
can be compiled with -Wshadow, too".
And you've got to put a "Signed-off-by" line at the end of the patch
description, too. See this URL for detail
On Sun, 7 Apr 2019 22:19:05 -0400
Catherine Ho wrote:
> Currently it is not forbidden to use "-object memory-backend-file,share=on"
> and together with "-incoming". But after incoming migration is finished,
> the memory-backend-file will be definitely written if share=on. So the
> memory-backend
Am 08.04.2019 um 10:40 hat ghorges geschrieben:
> ---
> linux-user/syscall.c | 66 ++--
> 1 file changed, 33 insertions(+), 33 deletions(-)
Thomas already gave you some hints what to improve. I'd just like to add
that you shouldn't send the email to the qem
On 05/04/19 18:33, Sergio Lopez wrote:
>> - qemu_bh_schedule_nested should not be necessary since we have
>> ctx->notify_me to also avoid the event_notifier_set call. However, it
>> is possible to avoid the smp_mb at the beginning of aio_notify, since
>> atomic_xchg already implies it. Maybe
On 07/04/19 11:23, Thomas Huth wrote:
> QEMU currently crashes when you try to hot-plug an "nvdimm" device
> on older machine types:
>
> $ qemu-system-x86_64 -monitor stdio -M pc-1.1
> QEMU 3.1.92 monitor - type 'help' for more information
> (qemu) device_add nvdimm,id=nvdimmn1
> qemu-system-x86_6
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> load_fit() reports errors with error_printf() instead of
> error_report(). Worse, it even reports errors it actually recovers
> from, in fit_cfg_compatible() and fit_load_fdt(). Messed up in
> initial commit 51b58561c1d.
>
> Convert the helper funct
Patchew URL: https://patchew.org/QEMU/20190408083627.7479-1-arm...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time ma
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> Cc: Paul Burton
> Cc: Aleksandar Rikalo
> Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/mips/boston.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --
On 04/05/19 17:33, Philippe Mathieu-Daudé wrote:
> The iPXE project already uses the EFIROM for a tool named 'efirom'
> which is not the Intel EfiRom used by the EDK2 project. To make
> the difference obvious, rename the variable.
>
> This fixes a long standing issue which is now masked since comm
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> We commonly want to print to the current monitor if we have one, else
> to stdout/stderr. For stderr, have error_printf(). For stdout, all
> we have is monitor_vfprintf(), which is rather unwieldy. We often
> print to stderr just because error_print
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> Command line help explicitly requested by the user should be printed
> to stdout, not stderr. We do elsewhere. Adjust -drive to match: use
> qemu_printf() instead of error_printf(). Plain printf() would be
> wrong because we need to print to the cur
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> Command line help explicitly requested by the user should be printed
> to stdout, not stderr. We do elsewhere. Adjust -chardev to match:
> use qemu_printf() instead of error_printf(). Plain printf() would be
> wrong because we need to print to the c
On 04/05/19 17:33, Philippe Mathieu-Daudé wrote:
> Since commit f590a812c210 we build the EDK2 EfiRom utility
> unconditionally. This has been tested on all the Linux
> distribution providing continuous integration (namely Debian
> and Fedora). Not all distributions are able to build the
> EfiRom w
Hi Peter,
the following changes since commit f55a585d1037e5de6088f25e75443c2776786e29:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2019-04-07 14:54:55 +0100)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git pull-request-2019-04-08
fo
From: "Dr. David Alan Gilbert"
The test uses the trick:
if (!opts) {
opts = &(QOSGraph...Options) { };
}
in a couple of places, however the temporary created
by the &() {} goes out of scope at the bottom of the if,
and results in a seg or assert when opts-> fields are
used (on fedo
From: Jafar Abdi
Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are dec
From: Jafar Abdi
Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are dec
Sorry, I am a newbie. I have never used this kind of thing before.
I will definitely pay attention next time.
-- Original --
From: "Kevin Wolf";
Date: Mon, Apr 8, 2019 06:39 PM
To: "ghorges";
Cc: "qemu-devel"; "qemu-block";
Subject: Re: [Qemu-devel] Wshad
It fixes heap-use-after-free which was found by clang's ASAN.
Control flow of this use-after-free:
main_thread:
* Got SIGTERM and completes main loop
* Calls migration_shutdown
- migrate_fd_cancel (so, migration_thread begins to complete)
- object_unref(OBJECT(current_migration
Hi,
I've sent another patch to fix this UAF:
"migration: Fix use-after-free during process exit"
It's more simple and fixes only the regression.
Regards,
Yury
05.04.2019, 12:07, "Dr. David Alan Gilbert" :
> * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> 03.04.2019, 22:06, "Dr. David Alan G
On 08/04/2019 13:04, Kevin Wolf wrote:
> Am 08.04.2019 um 11:44 hat Andrey Shinkevich geschrieben:
>>
>>
>> On 06/04/2019 01:50, John Snow wrote:
>>>
>>>
>>> On 4/5/19 10:24 AM, Andrey Shinkevich wrote:
On a file system used by the customer, fallocate() returns an error
if the block is
05.04.2019 23:04, Eric Blake wrote:
> On 4/5/19 9:39 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 03.04.2019 6:05, Eric Blake wrote:
>>> We've recently added traces for clients to flag server non-compliance;
>>> let's do the same for servers to flag client non-compliance. According
>
> Thus, s/Trace
---
linux-user/syscall.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 208fd1813d..985095e4d5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8240,7 +8240,7 @@ st
Marc-André Lureau writes:
> Hi
>
> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote:
>>
>> char_pty_open() prints a "char device redirected to PTY_NAME (label
>> LABEL)" message to the current monitor or else to stderr. No other
>> ChardevClass::open() prints anything on success. Drop t
Cornelia Huck writes:
> On Mon, 8 Apr 2019 10:39:40 +0200
> Thomas Huth wrote:
>
>> On 08/04/2019 10.36, Markus Armbruster wrote:
>> > kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns
>> > -ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by
>> > ioctl(). Its c
Patchew URL:
https://patchew.org/QEMU/20190408122816.595-1-ghor...@xiyoulinux.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190408122816.595-1-ghor...@xiyoulinux.org
Subject: [Qemu-devel] Wshadow in qemu/linux-user/syscall.
> Hi everyone,
>
>
>
> The following new patches are queued for QEMU stable v3.0.1:
>
> https://github.com/mdroth/qemu/commits/stable-3.0-staging
>
> The release is planned for 2019-04-11:
>
> ht
Marcel Apfelbaum writes:
> Hi Markus,
>
> On 4/8/19 11:36 AM, Markus Armbruster wrote:
>> Command line help help explicitly requested by the user should be
>> printed to stdout, not stderr. We do elsewhere. Adjust -machine
>> $TYPE,help and -accel help to match: use printf() instead of
>> error
On Fri, 29 Mar 2019 16:48:39 +0800
Like Xu wrote:
here should be a commit message explaining what patch does
in more detail.
> Signed-off-by: Like Xu
Generic note, try not call qdev_get_machine() every time
you replace smp_cpus or other variables. It's often possible
to pass MachineState via
On Mon, Apr 08, 2019 at 10:16:50AM +0100, Dr. David Alan Gilbert wrote:
* Michael S. Tsirkin (m...@redhat.com) wrote:
On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote:
> * Jens Freimann (jfreim...@redhat.com) wrote:
> > On Fri, Mar 22, 2019 at 02:44:45PM +0100, Jens Freiman
---
linux-user/syscall.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 208fd1813d..985095e4d5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8240,7 +8240,7 @@ st
Patchew URL:
https://patchew.org/QEMU/20190408130450.12233-1-ghor...@xiyoulinux.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190408130450.12233-1-ghor...@xiyoulinux.org
Type: series
Subject: [Qemu-devel] Wshadow in qemu/li
On Fri, 29 Mar 2019 16:48:40 +0800
Like Xu wrote:
> Signed-off-by: Like Xu
> ---
> hw/arm/fsl-imx6.c | 5 +
> hw/arm/fsl-imx6ul.c| 5 +
> hw/arm/fsl-imx7.c | 5 +
> hw/arm/highbank.c | 1 +
> hw/arm/mcimx6ul-evk.c | 1 +
> hw/arm/mcimx7d-sabre.c | 3 +++
> hw/arm
---
linux-user/syscall.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 208fd1813d..985095e4d5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8240,7 +8240,7 @@ st
Markus Armbruster writes:
> printf() & friends return the number of characters written on success,
> negative value on error.
>
> monitor_printf(), monitor_vfprintf(), monitor_vprintf(),
> error_printf(), error_printf_unless_qmp(), error_vprintf(), and
> error_vprintf_unless_qmp() return void. S
On Mon, Apr 08, 2019 at 10:16:50AM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote:
> > > * Jens Freimann (jfreim...@redhat.com) wrote:
> > > > ping
> > > >
> > > > FYI: I'm also working
On Thu, 4 Apr 2019 11:26:09 +0800
Like Xu wrote:
> On 2019/3/29 18:21, Igor Mammedov wrote:
> > On Fri, 29 Mar 2019 16:48:36 +0800
> > Like Xu wrote:
> >
> >> This patch series make existing cores/threads/sockets into machine
> >> properties and get rid of global variables they use currently.
Patchew URL:
https://patchew.org/QEMU/20190408131519.15527-1-ghor...@xiyoulinux.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190408131519.15527-1-ghor...@xiyoulinux.org
Subject: [Qemu-devel] Wshadow in qemu/linux-user/sysc
From: ghorges <1298394...@qq.com>
Signed-off-by: ghorges
---
linux-user/syscall.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 208fd1813d..985095e4d5 100644
--- a/linux-user/sy
On 2019/4/3 23:35, Laszlo Ersek wrote:
>> I thought about your comments and wrote the following patch (just for test)
>> which uses a file mapping to replace the anonymous mapping. UEFI seems to
>> work
>> fine. So why not use a file mapping to read or write a pflash device?
> Honestly I can't a
On Sun, Apr 07, 2019 at 11:23:14AM +0200, Thomas Huth wrote:
>QEMU currently crashes when you try to hot-plug an "nvdimm" device
>on older machine types:
>
>$ qemu-system-x86_64 -monitor stdio -M pc-1.1
>QEMU 3.1.92 monitor - type 'help' for more information
>(qemu) device_add nvdimm,id=nvdimmn1
>q
Hi,
Le 08/04/2019 à 15:38, ghorges a écrit :
> From: ghorges <1298394...@qq.com>
Very weird. Perhaps you can update the author with "git commit --amend
--author='ghorges '" to have the same email address?
> Signed-off-by: ghorges
we need a description here with at least the problem you are try
03.04.2019 6:05, Eric Blake wrote:
> Previous commits have mentioned that our NBD server still sends
> unaligned fragments when an active layer with large advertised minimum
> block size is backed by another layer with a smaller block
> size. Expand the test to actually cover this scenario, by usin
05.04.2019 19:56, Andrey Shinkevich wrote:
> The bottom node is the intermediate block device that has the base as its
> backing image. It is used instead of the base node while a block stream
> job is running to avoid dependency on the base that may change due to the
> parallel jobs. The change ma
On Mon, 8 Apr 2019 at 14:40, ghorges wrote:
>
> From: ghorges <1298394...@qq.com>
>
> Signed-off-by: ghorges
Hi; the name in a Signed-off-by: line should generally
be your full name (whatever you would use to sign
legal documents, etc). This looks like maybe it's your
login name or email address
On 4/8/19 7:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> 05.04.2019 23:04, Eric Blake wrote:
>> On 4/5/19 9:39 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 03.04.2019 6:05, Eric Blake wrote:
We've recently added traces for clients to flag server non-compliance;
let's do the same for server
This series adds optional feature lists to struct definitions in the
QAPI schema and makes use of them to advertise the new behaviour of
auto-read-only=on in file-posix.
Kevin Wolf (4):
qapi: Support features for structs
tests/qapi-schema: Test for good feature lists in structs
tests/qapi-sc
Signed-off-by: Kevin Wolf
---
tests/qapi-schema/qapi-schema-test.json | 27 +
tests/qapi-schema/qapi-schema-test.out | 26
tests/qapi-schema/test-qapi.py | 4
3 files changed, 57 insertions(+)
diff --git a/tests/qapi-schema/qapi-sc
Signed-off-by: Kevin Wolf
---
tests/qapi-schema/features-bad-type.json | 3 +++
tests/qapi-schema/features-missing-name.json | 3 +++
tests/qapi-schema/features-name-bad-type.json | 3 +++
tests/qapi-schema/features-no-list.json | 3 +++
tests/qapi-schema/features-unknown-key.json |
Sometimes, the behaviour of QEMU changes compatibly, but without a
change in the QMP syntax (usually by allowing values or operations that
previously resulted in an error). QMP clients may still need to know
whether the extension is available.
This allows to add a list of features to struct defini
In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') ,
auto-read-only=on changed its behaviour in file-posix for the 4.0
release. This change cannot be detected through the usual mechanisms
like schema introspection. Add a new feature flag to the schema to
allow libvirt to detect the p
1 - 100 of 235 matches
Mail list logo
