On Thu, 4 Apr 2019 11:26:09 +0800 Like Xu <like...@linux.intel.com> wrote:
> On 2019/3/29 18:21, Igor Mammedov wrote: > > On Fri, 29 Mar 2019 16:48:36 +0800 > > Like Xu <like...@linux.intel.com> wrote: > > > >> This patch series make existing cores/threads/sockets into machine > >> properties and get rid of global variables they use currently. > > Thanks for looking into it! > > Its long overdue and rather desired conversion (albeit naive one, > > but this series is a good starting point). I'll go over your patches > > next week with comments and concrete suggestions how to implement > > particular things. > > Hi Igor, any comments and suggestions on smp machine properties > in this patch considering we may add die topology for PCMachine as an > extension? I've looked at several patches and that it for this series. The most comments apply to the patches I've not reviewed as well. > > > >> Like Xu (9): > >> cpu/topology: add struct CpuTopology to MachineState > >> cpu/topology: add general support for machine properties > >> cpu/topology: add uncommon arch support for smp machine properties > >> cpu/topology: add ARM support for smp machine properties > >> cpu/topology: add i386 support for smp machine properties > >> cpu/topology: add PPC support for smp machine properties > >> cpu/topology: add riscv support for smp machine properties > >> cpu/topology: add s390x support for smp machine properties > >> cpu/topology: replace smp global variables with machine propertie > >> > >> accel/kvm/kvm-all.c | 3 +++ > >> backends/hostmem.c | 4 ++++ > >> cpus.c | 4 ++++ > >> exec.c | 2 ++ > >> gdbstub.c | 7 ++++++- > >> hw/alpha/dp264.c | 1 + > >> hw/arm/fsl-imx6.c | 5 +++++ > >> hw/arm/fsl-imx6ul.c | 5 +++++ > >> hw/arm/fsl-imx7.c | 5 +++++ > >> hw/arm/highbank.c | 1 + > >> hw/arm/mcimx6ul-evk.c | 1 + > >> hw/arm/mcimx7d-sabre.c | 3 +++ > >> hw/arm/raspi.c | 2 ++ > >> hw/arm/realview.c | 1 + > >> hw/arm/sabrelite.c | 1 + > >> hw/arm/vexpress.c | 3 +++ > >> hw/arm/virt.c | 7 +++++++ > >> hw/arm/xlnx-zynqmp.c | 7 +++++++ > >> hw/cpu/core.c | 3 +++ > >> hw/hppa/machine.c | 4 ++++ > >> hw/i386/acpi-build.c | 3 +++ > >> hw/i386/kvmvapic.c | 5 +++++ > >> hw/i386/pc.c | 12 +++++++++++ > >> hw/mips/boston.c | 1 + > >> hw/mips/mips_malta.c | 9 +++++++++ > >> hw/openrisc/openrisc_sim.c | 1 + > >> hw/ppc/e500.c | 3 +++ > >> hw/ppc/mac_newworld.c | 2 ++ > >> hw/ppc/mac_oldworld.c | 2 ++ > >> hw/ppc/pnv.c | 3 +++ > >> hw/ppc/prep.c | 2 ++ > >> hw/ppc/spapr.c | 29 ++++++++++++++++++++++++++ > >> hw/ppc/spapr_rtas.c | 3 +++ > >> hw/riscv/sifive_e.c | 4 ++++ > >> hw/riscv/sifive_plic.c | 3 +++ > >> hw/riscv/sifive_u.c | 4 ++++ > >> hw/riscv/spike.c | 2 ++ > >> hw/riscv/virt.c | 1 + > >> hw/s390x/s390-virtio-ccw.c | 2 ++ > >> hw/s390x/sclp.c | 1 + > >> hw/smbios/smbios.c | 11 ++++++++++ > >> hw/sparc/sun4m.c | 2 ++ > >> hw/sparc64/sun4u.c | 2 ++ > >> hw/xtensa/sim.c | 1 + > >> hw/xtensa/xtfpga.c | 1 + > >> include/hw/arm/virt.h | 2 +- > >> include/hw/boards.h | 8 ++++++++ > >> include/sysemu/sysemu.h | 2 +- > >> migration/postcopy-ram.c | 7 +++++++ > >> numa.c | 1 + > >> target/arm/cpu.c | 7 +++++++ > >> target/i386/cpu.c | 4 ++++ > >> target/openrisc/sys_helper.c | 5 +++++ > >> target/s390x/cpu.c | 3 +++ > >> target/s390x/excp_helper.c | 6 ++++++ > >> tcg/tcg.c | 15 ++++++++++++++ > >> vl.c | 48 > >> ++++++++++++++++++++++++-------------------- > >> 57 files changed, 261 insertions(+), 25 deletions(-) > >> > > > > > > > >
