Marcel Apfelbaum <marcel.apfelb...@gmail.com> writes:
> Hi Markus,
>
> On 4/8/19 11:36 AM, Markus Armbruster wrote:
>> Command line help help explicitly requested by the user should be
>> printed to stdout, not stderr. We do elsewhere. Adjust -machine
>> $TYPE,help and -accel help to match: use printf() instead of
>> error_printf().
>>
>> Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> vl.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index c696ad2a13..792ef36001 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1556,12 +1556,12 @@ static int machine_help_func(QemuOpts *opts,
>> MachineState *machine)
>> continue;
>> }
>> - error_printf("%s.%s=%s",
>> MACHINE_GET_CLASS(machine)->name,
>> - prop->name, prop->type);
>> + printf("%s.%s=%s", MACHINE_GET_CLASS(machine)->name,
>> + prop->name, prop->type);
>
> Does the line above have an alignment issue?
Oops! Will fix.
> Anyway,
>
> Reviewed-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
Thank you!
