Re: [Qemu-devel] [PATCH 06/15] pci: Report fatal errors with error_report(), not error_printf()

[Marcel Apfelbaum]

On 4/8/19 11:36 AM, Markus Armbruster wrote:

Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
  hw/pci/pci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 35451c1e99..a74995b596 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -927,7 +927,7 @@ static uint16_t pci_req_id_cache_extract(PCIReqIDCache 
*cache)
          result = PCI_BUILD_BDF(bus_n, 0);
          break;
      default:
-        error_printf("Invalid PCI requester ID cache type: %d\n",
+        error_report("Invalid PCI requester ID cache type: %d",
                       cache->type);
          exit(1);
          break;

Reviewed-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>

Thanks,
Marcel