Re: [Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host

On 4/3/19 11:59 AM, Peter Maydell wrote: >> +#if TARGET_LONG_BITS == 32 && HOST_LONG_BITS == 64 >> +g_assert(h2g_valid(address)); >> +#endif > > I'm not sure this is right. h2g_valid() will check whether the guest address > is > below GUEST_ADDR_MAX. For architectures which set > TARGET_VIRT_

Re: [Qemu-devel] [Qemu-arm] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill

On 4/3/19 12:14 PM, Peter Maydell wrote: > On Wed, 3 Apr 2019 at 10:44, Richard Henderson > wrote: > >> +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size, >> + MMUAccessType access_type, int mmu_idx, >> + bool probe, uintptr_t retaddr) >> +{ >>

[Qemu-devel] Question: can we hot plug a PCIe switch on machine "virt"

Hi folks, In physical world, a PCIe switch including one upstream port and several downstream ports is a single physical device, however we treat each port as a device in qemu world. In qemu docs/pcie.txt, we have below statements: Line 230: Be aware that PCI Express Downstream Ports can't be

Re: [Qemu-devel] [PATCH v5 1/2] target/mips: Optimize ILVOD. MSA instructions

On 4/2/19 10:15 PM, Mateja Marjanovic wrote: > +static inline void gen_ilvod_w(CPUMIPSState *env, uint32_t wd, > + uint32_t ws, uint32_t wt) > +{ > +TCGv_i64 t1 = tcg_temp_new_i64(); > +const uint64_t mask = 0xULL; > + > +tcg_gen_andi_i64(t1

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 4/2/19 11:19 PM, Philippe Mathieu-Daudé wrote: >> +static inline void gen_ilvev_b(CPUMIPSState *env, uint32_t wd, >> + uint32_t ws, uint32_t wt) >> +{ >> +TCGv_i64 t1 = tcg_temp_new_i64(); >> +TCGv_i64 t2 = tcg_temp_new_i64(); >> +const uint64_t mask = 0

Re: [Qemu-devel] [PATCH v2] vmstate: check subsection_found is enough

On Wed, Apr 03, 2019 at 09:10:16AM +0800, Wei Yang wrote: > subsection_found is true implies vmdesc is not NULL. > > This patch remove the additional check on vmdesc and rename > subsection_found to vmdesc_has_subsections to make it more self-explain. > > Signed-off-by: Wei Yang > > --- > v2: >

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 4/2/19 10:15 PM, Mateja Marjanovic wrote: > +static inline void gen_ilvev_w(CPUMIPSState *env, uint32_t wd, > + uint32_t ws, uint32_t wt) > +{ > +TCGv_i64 t1 = tcg_temp_new_i64(); > +const uint64_t mask = 0xULL; > + > +tcg_gen_andi_i64(t1

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 4/3/19 5:28 AM, Aleksandar Markovic wrote: >> +    tcg_gen_andi_i64(t1, msa_wr_d[wt * 2], mask); >> +    tcg_gen_deposit_i64(msa_wr_d[wd * 2], t1, msa_wr_d[ws * 2], 32, 32); >> + >> +    tcg_gen_andi_i64(t1, msa_wr_d[wt * 2 + 1], mask); >> +    tcg_gen_deposit_i64(msa_wr_d[wd * 2 + 1], t1, msa_w

Re: [Qemu-devel] [PATCH v2 2/3] block/stream: refactor stream_run: drop goto

On 02/04/2019 15:43, Alberto Garcia wrote: > On Mon 01 Apr 2019 02:06:04 PM CEST, Andrey Shinkevich wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: Andrey Shinkevich >> --- > > You can also say in the log message that the goto i

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

On 29/03/2019 19:07, Alberto Garcia wrote: > On Fri 29 Mar 2019 02:29:14 PM CET, Andrey Shinkevich wrote: >> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char >> *job_id, const char *device, >> job_flags |= JOB_MANUAL_DISMISS; >> } >> >> -stream_star

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 2.4.19. 20:37, Philippe Mathieu-Daudé wrote: On 4/2/19 7:07 PM, Aleksandar Markovic wrote: From: Philippe Mathieu-Daudé Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions Hi Mateja, On 4/2/19 5:15 PM, Mateja Marjanovic wrote: From: Mateja Marjanovic

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 2.4.19. 20:51, Aleksandar Markovic wrote: +/* + * [MSA] ILVEV.D wd, ws, wt + * + * Vector Interleave Even (Double data elements) + * + */ Double -> Doubleword I will change it in v6.

Re: [Qemu-devel] [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions

On 2.4.19. 22:50, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions From: Mateja Marjanovic The old version of the helper for the INSERT. MSA instructions has been replaced with four helpers that don't use switch,

[Qemu-devel] [PATCH] migration: fix migration shutdown

It fixes heap-use-after-free which was found by clang's ASAN. Control flow of this use-after-free: main_thread: * Got SIGTERM and completes main loop * Calls migration_shutdown - migrate_fd_cancel (so, migration_thread begins to complete) - object_unref(OBJECT(current_migration

Re: [Qemu-devel] [PATCH v1] exec: check the range in the address_space_unmap routine

On Fri, Mar 22, 2019 at 01:35:57PM +, Peter Maydell wrote: > On Fri, 22 Mar 2019 at 13:19, Dima Stepanov wrote: > > > > In case of the virtio-blk communication, can get the following assertion > > for the specifically crafted virtio packet: > > qemu-system-x86_64: exec.c:3725: address_space_

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 3.4.19. 01:25, Aleksandar Markovic wrote: On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" mailto:mateja.marjano...@rt-rk.com>> wrote: > > From: Mateja Marjanovic > > > Optimize set of MSA instructions ILVEV, using directly Use full instruction names, wit

Re: [Qemu-devel] Issues around TYPE_INTERFACE

I figure what I wrote was too long to read, so let me try again, focusing on just the main issue, leaving the bonus messes for later. Here's the main issue in a nutshell: (1) our interfaces can't have state (but that's okay), (2) our conversions to interface types actually convert to "an Object th

Re: [Qemu-devel] [PATCH v2 0/2] intel_iommu: misc scalable mode fixes for 4.0

On Fri, Mar 29, 2019 at 02:14:20PM +0800, Peter Xu wrote: > v2: > - patch 2: use "1" instead of "sizeof(bool)" for VMSTATE_UNUSED > because sizeof(bool) can be >1 depends on definition [Dave] > > The first patch is the important one. It should fix up a migration > issue that Dave reported betwe

Re: [Qemu-devel] [PATCH] hostmem: Disable add/del memory during migration

25.03.2019, 14:58, "Juan Quintela" : > Yury Kotov wrote: >>  I found a bug in QEMU 2.12 with adding memory-backend while live migration >>  thread is running. >> >>  But it seems that this bug was implicitly fixed in this commit (QEMU 3.0): >>    b895de50: migration: discard non-migratable RAMBloc

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

Ping 21.03.2019, 19:27, "Yury Kotov" : > Hi, > > 19.03.2019, 14:52, "Dr. David Alan Gilbert" : >>  * Peter Maydell (peter.mayd...@linaro.org) wrote: >>>   On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert >>>    wrote: >>>   > >>>   > * Peter Maydell (peter.mayd...@linaro.org) wrote: >>>   > >

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

On Tue, 2 Apr 2019 17:11:29 +0100 Daniel P. Berrangé wrote: > On Tue, Apr 02, 2019 at 06:00:33PM +0200, Cornelia Huck wrote: > > On Fri, 29 Mar 2019 11:11:01 + > > Daniel P. Berrangé wrote: > > > > > The GCC 9 compiler complains about many places in s390 code > > > that take the address o

Re: [Qemu-devel] [PATCH] hostmem: Disable add/del memory during migration

On Mon, Mar 25, 2019 at 12:52:06PM +0100, Juan Quintela wrote: > Yury Kotov wrote: > > I found a bug in QEMU 2.12 with adding memory-backend while live migration > > thread is running. > > > > But it seems that this bug was implicitly fixed in this commit (QEMU 3.0): > > b895de50: migration: dis

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

On Tue, 2 Apr 2019 17:38:26 +0200 Laszlo Ersek wrote: > On 04/02/19 17:29, Auger Eric wrote: > > Hi Laszlo, > > > > On 4/1/19 3:07 PM, Laszlo Ersek wrote: > >> On 03/29/19 14:56, Auger Eric wrote: > >>> Hi Ard, > >>> > >>> On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 201

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

On 4/3/19 6:25 AM, Aleksandar Markovic wrote: > > On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" > wrote: >> >> From: Mateja Marjanovic > >> >> Optimize set of MSA instructions ILVEV, using directly > > Use full instruction na

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

> > From: Mateja Marjanovic > > Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize > > ILVEV. MSA > > instructions > > > > > > On 3.4.19. 01:25, Aleksandar Markovic wrote: > > > > On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" > > > mailto:mateja.marjano...@rt-rk.com>> wrote: > > >

[Qemu-devel] [PULL for-4.0 1/4] hw/vfio/ccw: avoid taking address members in packed structs

From: Daniel P. Berrangé The GCC 9 compiler complains about many places in s390 code that take the address of members of the 'struct SCHIB' which is marked packed: hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: hw/vfio/ccw.c:133:15: warning: taking address of packed member of ‘struct

[Qemu-devel] [PULL for-4.0 4/4] hw/s390x/3270-ccw: avoid taking address of fields in packed struct

From: Daniel P. Berrangé Compiling with GCC 9 complains hw/s390x/3270-ccw.c: In function ‘emulated_ccw_3270_cb’: hw/s390x/3270-ccw.c:81:19: error: taking address of packed member of ‘struct SCHIB’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 81 | SCSW

[Qemu-devel] [PULL for-4.0 0/4] s390x gcc 9 warning fixes

The following changes since commit 061b51e9195670e9d190cdec46fabcb3c77763fb: Update version for v4.0.0-rc2 release (2019-04-02 17:01:20 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20190403 for you to fetch changes up to

[Qemu-devel] [PULL for-4.0 3/4] hw/s390x/ipl: avoid taking address of fields in packed struct

From: Daniel P. Berrangé Compiling with GCC 9 complains hw/s390x/ipl.c: In function ‘s390_ipl_set_boot_menu’: hw/s390x/ipl.c:256:25: warning: taking address of packed member of ‘struct QemuIplParameters’ may result in an unaligned pointer value [-Waddress-of-packed-member] 256 | uint32_t

[Qemu-devel] [PULL for-4.0 2/4] hw/s390/css: avoid taking address members in packed structs

From: Daniel P. Berrangé The GCC 9 compiler complains about many places in s390 code that take the address of members of the 'struct SCHIB' which is marked packed: hw/s390x/css.c: In function ‘sch_handle_clear_func’: hw/s390x/css.c:698:15: warning: taking address of packed member of ‘struct SCH

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

> From: Richard Henderson > Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize > ILVEV. MSA > instructions > > On 4/3/19 6:25 AM, Aleksandar Markovic wrote: > > > > On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" > > wrote: > >> > >> From: Mateja Marj

Re: [Qemu-devel] [PATCH v2] vmstate: check subsection_found is enough

* Wei Yang (richardw.y...@linux.intel.com) wrote: > subsection_found is true implies vmdesc is not NULL. > > This patch remove the additional check on vmdesc and rename > subsection_found to vmdesc_has_subsections to make it more self-explain. > > Signed-off-by: Wei Yang Thanks, Reviewed-by: D

[Qemu-devel] [PATCH v4 0/5] virtio pmem driver

This patch series has implementation for "virtio pmem". "virtio pmem" is fake persistent memory(nvdimm) in guest which allows to bypass the guest page cache. This also implements a VIRTIO based asynchronous flush mechanism. Sharing guest kernel driver in this patchset with the changes

[Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

Virtio pmem provides asynchronous host page cache flush mechanism. we don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta --- fs/xfs/xfs_file.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 1f2e2845eb76..dced2e

[Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into sy

[Qemu-devel] [PATCH v4 3/5] libnvdimm: add dax_dev sync flag

This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/s

[Qemu-devel] [PATCH v4 1/5] ibnvdimm: nd_region flush callback support

This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsy

[Qemu-devel] [PATCH v4 4/5] ext4: disable map_sync for async flush

Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta --- fs/ext4/file.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 69d65d4

Re: [Qemu-devel] [PATCH 17/26] target/s390x: Convert to CPUClass::tlb_fill

> #endif /* CONFIG_USER_ONLY */ > + > +bool s390_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > + MMUAccessType access_type, int mmu_idx, > + bool probe, uintptr_t retaddr) > +{ > +S390CPU *cpu = S390_CPU(cs); > + > +#ifndef CONFIG_USER_ONLY >

Re: [Qemu-devel] [PATCH v4 4/5] ext4: disable map_sync for async flush

On Wed 03-04-19 16:10:17, Pankaj Gupta wrote: > Virtio pmem provides asynchronous host page cache flush > mechanism. We don't support 'MAP_SYNC' with virtio pmem > and ext4. > > Signed-off-by: Pankaj Gupta The patch looks good to me. You can add: Reviewed-by: Jan Kara

[Qemu-devel] [PATCH v3 0/4] pvrdma: Add support for SRQ

This series implements the SRQ (Shared Receive Queue) for the pvrdma device, It also includes all the needed functions and definitions for support SRQ in the backend and resource management layers. Changes from v2->3: - Patch #1: -- Fix commit message. -- Remove initialization of backend_qp from r

[Qemu-devel] [PATCH v3 1/4] hw/rdma: Add SRQ support to backend layer

Add the required functions and definitions to support shared receive queues (SRQs) in the backend layer. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 116 +++- hw/rdma/rdma_backend.h | 12 hw/rdma/rdma_backend_defs.h | 5 ++ hw/rdma/rdm

[Qemu-devel] [PATCH 2/4] hw/rdma: Add support for managing SRQ resource

Adding the required functions and definitions for support managing the shared receive queues (SRQs). Signed-off-by: Kamal Heib --- hw/rdma/rdma_rm.c | 93 ++ hw/rdma/rdma_rm.h | 10 + hw/rdma/rdma_rm_defs.h | 8 3 files changed, 111 ins

[Qemu-devel] [PATCH v3 3/4] hw/rdma: Modify create/destroy QP to support SRQ

Modify create/destroy QP to support shared receive queue and rearrange the destroy_qp() code to avoid touching the QP after calling rdma_rm_dealloc_qp(). Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 9 -- hw/rdma/rdma_backend.h | 6 ++-- hw/rdma/rdma_rm.c| 22

[Qemu-devel] [PATCH v3 4/4] hw/pvrdma: Add support for SRQ

Implement the pvrdma device commands for supporting SRQ Signed-off-by: Kamal Heib --- hw/rdma/vmw/pvrdma_cmd.c| 147 hw/rdma/vmw/pvrdma_main.c | 16 hw/rdma/vmw/pvrdma_qp_ops.c | 46 ++- hw/rdma/vmw/pvrdma_qp_ops.h | 1 + 4 files change

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

On 3/26/19 8:35 PM, Peter Maydell wrote: > On Thu, 7 Mar 2019 at 14:47, Richard Henderson > wrote: >> >> This will let backends implement the double-word shift operation. >> >> Signed-off-by: Richard Henderson >> diff --git a/tcg/README b/tcg/README >> index 603f4df659..ddabf33017 100644 >> --- a

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

On 01.04.19 23:48, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 related informati

[Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression support

v2: - improve the code left and right - Split better the zlib code - rename everything to v4.1 - Add tests for multifd-compress zlib - Parameter is now an enum (soon will see sztd) ToDo: - Make operations for diferent methods: * multifd_prepare_send_none/zlib * multifd_send_none/zlib * multi

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

On Wed, 3 Apr 2019 at 18:37, Richard Henderson wrote: > > On 3/26/19 8:35 PM, Peter Maydell wrote: > > On Thu, 7 Mar 2019 at 14:47, Richard Henderson > > wrote: > >> > >> This will let backends implement the double-word shift operation. > >> > >> Signed-off-by: Richard Henderson > >> diff --git

[Qemu-devel] [PATCH v2 8/8] multifd: rest of zlib compression (WIP)

This is still a work in progress, but get everything sent as expected and it is faster than the code that is already there. Signed-off-by: Juan Quintela --- migration/ram.c | 93 ++--- 1 file changed, 88 insertions(+), 5 deletions(-) diff --git a/migr

[Qemu-devel] [PATCH v2 3/8] migration-test: rename parameter to parameter_int

We would need _str ones on the next patch. Signed-off-by: Juan Quintela --- tests/migration-test.c | 49 +- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index bd3f5c3125..0b25aa3d6c 100644

[Qemu-devel] [PATCH v2 5/8] migration-test: introduce functions to handle string parameters

Signed-off-by: Juan Quintela --- tests/migration-test.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index ff480e0682..65d5e256a7 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -427,

[Qemu-devel] [PATCH v2 2/8] migration: fix multifd_recv event typo

It uses num in multifd_send(). Make it coherent. Signed-off-by: Juan Quintela --- migration/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/trace-events b/migration/trace-events index de2e136e57..cd50a1e659 100644 --- a/migration/trace-events +++ b/mig

[Qemu-devel] [PATCH v2 7/8] multifd: Add zlib compression support

Signed-off-by: Juan Quintela --- migration/migration.c | 9 migration/migration.h | 1 + migration/ram.c| 47 ++ qapi/common.json | 4 +++- tests/migration-test.c | 6 ++ 5 files changed, 66 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter

Otherwise we are setting err twice, what is wrong and causes an abort. Signed-off-by: Juan Quintela --- hmp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index 92941142af..8eec768088 100644 --- a/hmp.c +++ b/hmp.c @@ -1825,8 +1825,10 @@ void hmp_migrat

Re: [Qemu-devel] [PATCH v2 0/2] util/readline: errors clean-ups

On Mon, Apr 01, 2019 at 03:44:04AM +0100, Jules Irenge wrote: > This v2 version combines two fix of errors into one and replace tab > indent by four spaces > > Jules Irenge (2): > util/readline: add a space to fix errors by checkpatch tool > util: readline: replace tab indent by four spaces t

Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

On Mon, Apr 01, 2019 at 12:30:51PM +0300, n.alekseev2...@gmail.com wrote: > From: Nikita Alekseev > > bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function. > Thus, it also needs to be marked as a coroutine. > > Signed-off-by: Nikita Alekseev > --- > block.c | 2 +- > 1 file c

[Qemu-devel] [PATCH v2 4/8] tests: Add migration multifd test

We set multifd-channels. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 0b

[Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter

Signed-off-by: Juan Quintela --- Rename it to NONE --- hmp.c| 17 + hw/core/qdev-properties.c| 11 +++ include/hw/qdev-properties.h | 1 + migration/migration.c| 16 qapi/common.json | 13 + qap

Re: [Qemu-devel] [PATCH] util/readline: Add braces to fix checkpatch errors

On Sat, Mar 30, 2019 at 11:21:42AM +, Jules Irenge wrote: > Add braces to fix errors issued by checkpatch.pl tool > "ERROR: braces {} are necessary for all arms of this statement" > Within "util/readline.c" file > --- > util/readline.c | 50 - >

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 03 April 2019 10:49 > To: Laszlo Ersek > Cc: Auger Eric ; Ard Biesheuvel > ; peter.mayd...@linaro.org; > sa...@linux.intel.com; qemu-devel@nongnu.org; Shameerali Kolothum Thodi > ; Linuxarm > ; shannon.zha..

Re: [Qemu-devel] [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions

> From: Mateja Marjanovic > Subject: Re: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. > instructions > > On 2.4.19. 22:50, Aleksandar Markovic wrote: > >> From: Mateja Marjanovic > >> Subject: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. > >> instructions > >> > >> From: Mateja

Re: [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression support

Patchew URL: https://patchew.org/QEMU/20190403114958.3705-1-quint...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190403114958.3705-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression

[Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

Compiling with clang-8 fails with: CC util/qemu-sockets.o util/qemu-sockets.c: In function 'unix_connect_saddr': util/qemu-sockets.c:925:5: error: 'strncpy' specified bound 108 equals destination size [-Werror=stringop-truncation] strncpy(un.sun_path, saddr->path, sizeof(un.su

[Qemu-devel] [Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

Thank you Daniel, we will most likely keep Disco as-is for now and merge this in 19.10 where then mesa can drop the revert. I tagged it for 19.10 to be revisited. ** Tags added: qemu-19.10 ** Also affects: mesa (Ubuntu Ee-series) Importance: Undecided Status: New ** Also affects: qemu

Re: [Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

On Wed, Apr 03, 2019 at 02:16:20PM +0200, Philippe Mathieu-Daudé wrote: > Compiling with clang-8 fails with: > > CC util/qemu-sockets.o > util/qemu-sockets.c: In function 'unix_connect_saddr': > util/qemu-sockets.c:925:5: error: 'strncpy' specified bound 108 equals > destination size

Re: [Qemu-devel] [PATCH v2] Replace calls to object_child_foreach() with object_child_foreach_recursive()

On Mon, Apr 01, 2019 at 04:40:28PM +0100, Ernest Esene wrote: > Replace calls to object_child_foreach() with object_child_foreach_recursive() > when applicable: nvdimm_device_list, nmi_monitor_handle, > find_sysbus_device, > pc_dimm_slot2bitmap, build_dimm_list. > > Signed-off-by: Ernest Esene >

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: > On 01.04.19 23:48, Collin Walling wrote: > > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > > be intercepted by SIE and handled via KVM. Let's introduce some > > functions to communicate between QEMU and KVM via

Re: [Qemu-devel] VSOCK benchmark and optimizations

On Mon, Apr 01, 2019 at 06:32:40PM +0200, Stefano Garzarella wrote: > Hi Alex, > I'm sending you some benchmarks and information about VSOCK CCing qemu-devel > and linux-netdev (maybe this info could be useful for others :)) > > One of the VSOCK advantages is the simple configuration: you don't ne

Re: [Qemu-devel] VSOCK benchmark and optimizations

On Tue, Apr 02, 2019 at 09:37:06AM +0200, Stefano Garzarella wrote: > On Tue, Apr 02, 2019 at 04:19:25AM +, Alex Bennée wrote: > > > > Stefano Garzarella writes: > > > > > Hi Alex, > > > I'm sending you some benchmarks and information about VSOCK CCing > > > qemu-devel > > > and linux-netde

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

> Subject: Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver > > On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and regist

[Qemu-devel] [PATCH] configure: Relax check for libseccomp

On a non-release architecture, the configure program aborts if the --enable-seccomp flag was given (with no way to work around it on the command line): ERROR: User requested feature libseccomp configure was not able to find it. libseccomp is not supported for host cpu parisc64 Ins

Re: [Qemu-devel] [PATCH] sun4m: obey -vga none

Hi Paolo, On 3/19/19 3:40 PM, Paolo Bonzini wrote: > Do not create a TCX if "-vga none" was passed on the command line. > Remove some dead code along the way to avoid big reindentation. Can you add: This fixes when configuring with --without-default-devices: $ sparc-softmmu/qemu-system-sparc

[Qemu-devel] [PATCH 3/5] target/mips: replace indentation with space to fix checkpatch errors

Replace indentation with space to fix errors issued by checkpatch.pl tool "ERROR: code indent should never use tabs" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 136 +++--- 1 file changed, 68 insertions(+), 68 dele

[Qemu-devel] [PATCH 4/5] target/mips: remove space to fix checkpatch errors

Remove space to fix errors issued by checkpatch.pl tool "ERROR: space prohibited between function name and open parenthesis" "ERROR: trailing white space" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 10 +- 1 file changed, 5 insertions(+), 5 delet

[Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

This v1 series cleans up all warnings and errors of coding style within cpu.h file Jules Irenge (5): target/mips: add space to fix checkpatch errors target/mips: realign comments to fix checkpatch warnings target/mips: replace indentation with space to fix checkpatch errors target/mips: re

[Qemu-devel] [PATCH 1/5] target/mips: add space to fix checkpatch errors

Add space to fix errors reported by checkpatch.pl tool "ERROR: spaces required around that ..." "ERROR: space required before the open parenthesis" "ERROR: space required after that ..." Signed-off-by: Jules Irenge --- target/mips/cpu.h | 20 ++-- 1 file changed, 10 insertions(+)

[Qemu-devel] [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings

Realign comments to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(

[Qemu-devel] [PATCH 5/5] target/mips: wrap line into multiple lines to to fix checkpatch errors

Wrap line into multiple lines to fix errors issued by checkpatch.pl tool ERROR: line over 90 characters" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/mips

Re: [Qemu-devel] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment

Am 03.04.2019 um 05:05 hat Eric Blake geschrieben: > Previous patches mentioned how the blkdebug filter driver demonstrates > a bug present in our NBD server; the bug is also present with the raw > format driver when probing occurs. Basically, if we specify a > particular alignment > 1, but defer t

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

On 04/03/19 11:49, Igor Mammedov wrote: > On Tue, 2 Apr 2019 17:38:26 +0200 > Laszlo Ersek wrote: > >> On 04/02/19 17:29, Auger Eric wrote: >>> Hi Laszlo, >>> >>> On 4/1/19 3:07 PM, Laszlo Ersek wrote: On 03/29/19 14:56, Auger Eric wrote: > Hi Ard, > > On 3/29/19 2:14 PM, Ard

Re: [Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

On Wed, Apr 3, 2019 at 2:23 PM Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 02:16:20PM +0200, Philippe Mathieu-Daudé wrote: > > Compiling with clang-8 fails with: > > > > CC util/qemu-sockets.o > > util/qemu-sockets.c: In function 'unix_connect_saddr': > > util/qemu-sockets.c:9

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

On 04/03/19 14:10, Shameerali Kolothum Thodi wrote: > So, the condition for hiding the hotpluggable memory nodes in question > from the DT is: > > (aarch64 && firmware_loaded && acpi_enabled) >>> While UEFI has bindings for both 32-bit and 64-bit ARM, ACPI has a >>> 64-bit-

Re: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

Patchew URL: https://patchew.org/QEMU/20190403125055.26564-1-jbi.oct...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190403125055.26564-1-jbi.oct...@gmail.com Subject: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors

Re: [Qemu-devel] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment

On 4/3/19 8:03 AM, Kevin Wolf wrote: > Am 03.04.2019 um 05:05 hat Eric Blake geschrieben: >> Previous patches mentioned how the blkdebug filter driver demonstrates >> a bug present in our NBD server; the bug is also present with the raw >> format driver when probing occurs. Basically, if we specify

Re: [Qemu-devel] [PATCH 1/5] target/mips: add space to fix checkpatch errors

> From: Jules Irenge > Subject: [PATCH 1/5] target/mips: add space to fix checkpatch errors > > Add space to fix errors reported by checkpatch.pl tool > "ERROR: spaces required around that ..." > "ERROR: space required before the open parenthesis" > "ERROR: space required after that ..." > > Sig

Re: [Qemu-devel] [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings

> From: Jules Irenge > Subject: [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings > > Realign comments to fix warnings issued by checkpatch.pl tool > "WARNING: Block comments use a leading /* on a separate line" > within "target/mips/cpu.h" file. > > Signed-off-by: Jules Iren

Re: [Qemu-devel] [PATCH 3/5] target/mips: replace indentation with space to fix checkpatch errors

> From: Jules Irenge > Subject: [PATCH 3/5] target/mips: replace indentation with space to fix > checkpatch errors > > Replace indentation with space to fix errors issued by checkpatch.pl tool > "ERROR: code indent should never use tabs" > within "target/mips/cpu.h" file. > > Signed-off-by: Jule

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

Hi Laszlo and Markus, Thanks for your useful suggestions and comments! :) On 2019/3/27 2:36, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 03/26/19 17:39, Markus Armbruster wrote: >>> Laszlo Ersek writes: >> With the dynamic sizing in QEMU (which, IIRC, I had originally int

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

On 4/3/19 8:30 AM, Cornelia Huck wrote: On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: On 01.04.19 23:48, Collin Walling wrote: DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communi

Re: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

> From: Jules Irenge > Subject: [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup > > This v1 series cleans up all warnings and errors of coding style within cpu.h > file > Hi, Jules! There are a couple of minor problems that I described in my comments to other patches. Other

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

On 4/3/19 10:16 AM, Collin Walling wrote: On 4/3/19 8:30 AM, Cornelia Huck wrote: On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: On 01.04.19 23:48, Collin Walling wrote: DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM

[Qemu-devel] [PATCH for-4.1] commit: Use bdrv_append() in commit_start()

This function combines bdrv_set_backing_hd() and bdrv_replace_node() so we can use it to simplify the code a bit in commit_start(). Signed-off-by: Alberto Garcia --- block/commit.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/block/commit.c b/block/commit.c ind

[Qemu-devel] [Bug 1818483] Re: qemu user mode does not support binfmt_misc config with flags include "P"

This patch is for linux kernel. It will set the 3rd bit of AT_FLAGS, if P is set for binfmt_misc. The major concern is that AT_FLAGS is never used, then, should we use it here? ** Patch added: "binfmt_preserve_argv0.patch" https://bugs.launchpad.net/qemu/+bug/1818483/+attachment/5252516/+fil

Re: [Qemu-devel] [PULL for-4.0 0/4] s390x gcc 9 warning fixes

m/cohuck/qemu tags/s390x-20190403 > > for you to fetch changes up to 7357b2215978debf2fd17b525ba745d3c69272a3: > > hw/s390x/3270-ccw: avoid taking address of fields in packed struct > (2019-04-03 11:19:57 +0200) > >

Re: [Qemu-devel] VSOCK benchmark and optimizations

On Wed, Apr 03, 2019 at 01:34:38PM +0100, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2019 at 06:32:40PM +0200, Stefano Garzarella wrote: > > Hi Alex, > > I'm sending you some benchmarks and information about VSOCK CCing qemu-devel > > and linux-netdev (maybe this info could be useful for others :)) >

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: [cc'ing Eduardo as the seccomp submaintainer] > On a non-release architecture, the configure program aborts if the > --enable-seccomp flag was given (with no way to work around it on the > command line): > > ERROR: User requested feature libseccom

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

On Wed, 3 Apr 2019 at 22:16, Peter Maydell wrote: > > On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: > > [cc'ing Eduardo as the seccomp submaintainer] > > > On a non-release architecture, the configure program aborts if the > > --enable-seccomp flag was given (with no way to work around it on t

Re: [Qemu-devel] [PATCH v2] migration: avoid filling ignore-shared ramblock when in incoming migration

Hi Peter Xu On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote: > On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote: > > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > > addes ignore-shared capability to bypass the shared ramblock (e,g, > > membackend + numa node). I

  1   2   >