On 4/3/19 11:59 AM, Peter Maydell wrote: >> +#if TARGET_LONG_BITS == 32 && HOST_LONG_BITS == 64 >> + g_assert(h2g_valid(address)); >> +#endif > > I'm not sure this is right. h2g_valid() will check whether the guest address > is > below GUEST_ADDR_MAX. For architectures which set > TARGET_VIRT_ADDR_SPACE_BITS to something less than 32 there are > address values which aren't h2g_valid() but which we still want to cause > a guest exception rather than asserting, aren't there ?
Hmm, you're right, this should test something else. I'll drop this for now... r~
