Hi Stefan,
Thanks for looking into this. Please find the requested details below.
If you need any further details (like the host storage details) just let me
know.
Host details:
CPU: Intel(R) Xeon(R) CPU E3-1230 V2
Memory: 32GB (ECC)
OS: Alpine 3.9
Kernel version: 4.19.18-0-vanilla
Qemu version:
On Fri, 1 Feb 2019 07:46:40 +0100
Thomas Huth wrote:
> On 2019-02-01 07:14, Thomas Huth wrote:
> > On 2019-01-31 19:08, Paolo Bonzini wrote:
> >> On 31/01/19 19:00, Thomas Huth wrote:
> > (and the prototypes in the header) anymore, so if you try to compile
> > s390x
> > without C
On Thu, 31 Jan 2019 15:43:16 -0500
Collin Walling wrote:
> On 1/30/19 10:57 AM, David Hildenbrand wrote:
> > These are all the patches that are not yet upstream (@Conny you might
> > already picked some, including them for the full picture) and after
> > a good discussion yesterday, including a p
Paolo Bonzini writes:
> On 31/01/19 13:12, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 31/01/19 10:41, Markus Armbruster wrote:
Paolo Bonzini writes:
> On 31/01/19 09:40, Markus Armbruster wrote:
>>> Maybe we should just add pflash block properties to the mach
Kevin Wolf writes:
> bdrv_co_invalidate_cache() clears the BDRV_O_INACTIVE flag before
> actually activating a node so that the correct permissions etc. are
> taken. In case of errors, the flag must be restored so that the next
> call to bdrv_co_invalidate_cache() retries activation.
>
> Restorin
On Fri, Feb 01, 2019 at 12:29:28PM +0800, Stefan Hajnoczi wrote:
> On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote:
> > In order to avoid migration issues, we enable DISCARD and
> > WRITE ZEROES features only for machine type >= 4.0
>
> Please use two separate properties that co
Julia Suvorova via Qemu-devel writes:
> The whitelist option allows to run a reduced monitor with a subset of
> QMP commands. This allows the monitor to run in secure mode, which is
For a value of "secure". I'm not saying this can't be useful, just
tempering expecations. I guess you intend to
On 01.02.19 09:35, Cornelia Huck wrote:
> On Thu, 31 Jan 2019 15:43:16 -0500
> Collin Walling wrote:
>
>> On 1/30/19 10:57 AM, David Hildenbrand wrote:
>>> These are all the patches that are not yet upstream (@Conny you might
>>> already picked some, including them for the full picture) and after
On Fri, Feb 01, 2019 at 08:52:25AM +0100, Stefan Weil wrote:
> On 29.01.19 12:39, Daniel P. Berrangé wrote:
> > This is a few misc fixes identified after the icon location changes
> > were merged. Most importantly it deals with the nsis installer file
> > manifest.
> >
> > Daniel P. Berrangé (5):
On Thu, 31 Jan 2019 at 20:02, Peter Maydell wrote:
>
> On Wed, 30 Jan 2019 at 08:59, Hongbo Zhang wrote:
> >
> > On Tue, 22 Jan 2019 at 19:42, Peter Maydell
> > wrote:
> > >
> > > On Fri, 7 Dec 2018 at 09:08, Hongbo Zhang wrote:
> > > > +[VIRT_SECURE_MEM] = { 0x2000, 0x2000
Fei Li writes:
> It seems that this poor patch is left alone. :(
> I sent all, but this patch failed to join them, so sorry for that..
> Could we just let it be?
It'll do, thanks.
On Fri, Feb 01, 2019 at 12:58:31PM +0800, Stefan Hajnoczi wrote:
> On Thu, Jan 31, 2019 at 04:19:12PM +0100, Stefano Garzarella wrote:
> > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> > index 542ec52536..34ee676895 100644
> > --- a/hw/block/virtio-blk.c
> > +++ b/hw/block/virtio-blk
Fei Li writes:
> From: Fei Li
>
> qemu_thread_create() abort()s on error. Not nice. Give it a return
> value and an Error ** argument, so it can return success/failure.
>
> Considering qemu_thread_create() is quite widely used in qemu, split
> this into two steps: this patch passes the &error_ab
On Fri, Feb 01, 2019 at 10:09:08AM +0100, Stefano Garzarella wrote:
> On Fri, Feb 01, 2019 at 12:29:28PM +0800, Stefan Hajnoczi wrote:
> > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote:
> > > In order to avoid migration issues, we enable DISCARD and
> > > WRITE ZEROES features
On Fri, Feb 01, 2019 at 10:54:30AM +0100, Stefano Garzarella wrote:
> On Fri, Feb 01, 2019 at 12:58:31PM +0800, Stefan Hajnoczi wrote:
> > On Thu, Jan 31, 2019 at 04:19:12PM +0100, Stefano Garzarella wrote:
> Only a question about options: I used a single option "dwz_max_sectors"
> for both "max_di
On Thu, 31 Jan 2019 22:21:01 +0100
David Hildenbrand wrote:
> Thinking out loud:
>
> We should migrate the flag in the future. This is already a problem
> right now, as the timer is also not migrated.
>
> If the unplug request is sent and we migrate before the guest can react,
> the unplug woul
On Wed, 30 Jan 2019 16:57:33 +0100
David Hildenbrand wrote:
> When resetting the guest we should unplug and remove all devices that
> are still pending.
>
> With this patch, the requested device will be unpluged on reboot
> (S390_RESET_EXTERNAL and S390_RESET_REIPL, which reset the pcihost bridg
Am 31.01.2019 um 19:43 hat Eric Blake geschrieben:
> On 1/31/19 11:55 AM, Kevin Wolf wrote:
> > This adds external data file to the qcow2 spec as a new incompatible
> > feature.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > docs/interop/qcow2.txt | 19 ---
> > 1 file changed, 16
On Thu, 31 Jan 2019 at 00:59, Max Reitz wrote:
>
> The following changes since commit b4fbe1f65a4769c09e6bf2d79fc84360f840f40e:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20190129' into staging (2019-01-29
> 12:00:19 +)
>
> are available in the Git repository
Am 31.01.2019 um 22:44 hat Nir Soffer geschrieben:
> On Thu, Jan 31, 2019 at 8:43 PM Eric Blake wrote:
> ...
>
> > > @@ -450,8 +461,10 @@ Standard Cluster Descriptor:
> >
> > 1 - 8:Reserved (set to 0)
> > >
> > > 9 - 55:Bits 9-55 of host cluster offset. Must be aligne
Am 31.01.2019 um 19:44 hat Eric Blake geschrieben:
> On 1/31/19 11:55 AM, Kevin Wolf wrote:
> > This adds a .bdrv_open option to specify the external data file node.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > qapi/block-core.json | 3 ++-
> > block/qcow2.h| 4 +++-
> > block/qcow2.c
On Fri, 18 Jan 2019 at 16:17, Kevin Wolf wrote:
>
> Am 10.12.2018 um 12:26 hat Peter Maydell geschrieben:
> > This patchset fixes the remaining clang warnings in the block/ code
> > about taking the address of a packed struct member, which are all
> > in block/vpc and block/vdi code handling UUIDs
Patchew URL:
https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de
Subject: [Qemu-devel] [PAT
On 01.02.19 11:08, Cornelia Huck wrote:
> On Thu, 31 Jan 2019 22:21:01 +0100
> David Hildenbrand wrote:
>
>> Thinking out loud:
>>
>> We should migrate the flag in the future. This is already a problem
>> right now, as the timer is also not migrated.
>>
>> If the unplug request is sent and we mig
On Wed, 30 Jan 2019 16:57:31 +0100
David Hildenbrand wrote:
> PCI on s390x is really weird and how it was modeled in QEMU might not have
> been the right choice. Anyhow, right now it is the case that:
> - Hotplugging a PCI device will silently create a zPCI device
> (if none is provided)
> - Ho
Hi Hia,
On 1/29/19 3:25 PM, Jia He wrote:
> Hi Eric
>
> On 2019/1/23 18:14, Eric Auger wrote:
>> Add the kvm_arm_get_max_vm_phys_shift() helper that returns the
>> log of the maximum IPA size supported by KVM. This capability
>> needs to be known to create the VM with a specific IPA max size
>> (
Hi,
On 1/25/19 11:06 AM, Paolo Bonzini wrote:
> (I'm only momentarily at the helm and will give control back to Yang after
> this iteration.)
>
> This is still RFC mostly because of the lack of documentation, and because
> only x86 is fully converted, but it's converging. Other targets still
> e
Le 1/31/19 à 5:15 PM, Luc Michel a écrit :
On 1/30/19 8:24 PM, Max Filippov wrote:
With multiprocess extensions gdb uses 'vKill' packet instead of 'k' to
kill the inferior. Handle 'vKill' the same way 'k' was handled in the
presence of single process.
Fixes: 7cf48f6752e5 ("gdbstub: add multi
On Fri, 1 Feb 2019 11:37:56 +0100
David Hildenbrand wrote:
> On 01.02.19 11:08, Cornelia Huck wrote:
> > On Thu, 31 Jan 2019 22:21:01 +0100
> > David Hildenbrand wrote:
> >
> >> Thinking out loud:
> >>
> >> We should migrate the flag in the future. This is already a problem
> >> right now, as
On Wed, 30 Jan 2019 16:57:32 +0100
David Hildenbrand wrote:
> Let's handle it similar to x86 ACPI PCI code and don't use a timer.
> Instead, remember if an unplug request is pending and keep it pending
> for eternity. (a follow up patch will process the request on
> reboot).
>
> We expect that a
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> Print the memory device info just like for PCDIMM/NVDIMM.
> >>
> >> Signed-off-by: David Hildenbrand
> >> ---
> >> hmp.c | 27 +++
>
Am 01.02.2019 um 11:30 hat Peter Maydell geschrieben:
> On Fri, 18 Jan 2019 at 16:17, Kevin Wolf wrote:
> >
> > Am 10.12.2018 um 12:26 hat Peter Maydell geschrieben:
> > > This patchset fixes the remaining clang warnings in the block/ code
> > > about taking the address of a packed struct member,
* Markus Armbruster (arm...@redhat.com) wrote:
> Eric Blake writes:
>
> > On 1/31/19 2:08 PM, Yuval Shaia wrote:
> >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote:
> >>> On 1/31/19 7:08 AM, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia
> ---
> hmp-commands-info.hx
Patchew URL:
https://patchew.org/QEMU/20190123101458.12478-1-eric.au...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
Alexey Kardashevskiy writes:
> On 01/02/2019 08:57, Fabiano Rosas wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 31/01/2019 03:30, Fabiano Rosas wrote:
Alexey Kardashevskiy writes:
>
> but this is a register which does not have endianness, the endianness
> appears here
From: Philippe Mathieu-Daudé
The TMU device requires both X11 and OpenGL.
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20190130120005.23123-4-phi...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/lm32/milkymist-hw.h | 4 ++--
default-configs/lm32-softmmu.mak | 2 +-
hw/display/
From: Philippe Mathieu-Daudé
The Milkymist specific hardware is only used by the LM32 target,
it is pointless to compile those objects in other targets.
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20190130120005.23123-2-phi...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/display/Makef
From: Philippe Mathieu-Daudé
Move the complexity of milkymist_tmu2_create() into the
source file. Doing so we avoid to include the X11/OpenGL
headers in all LM32 devices, and we also avoid the duplicate
declaration of glx_fbconfig_attr[] (it is already declared
in hw/display/milkymist-tmu2.c).
Si
The following changes since commit e8977901b79fb678f288dd372261b640bbeccd0d:
Merge remote-tracking branch
'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-01-31
15:40:39 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-201
From: Daniel P. Berrangé
SDL1.2 was deprecated in the 2.12.0 release with:
commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa
Author: Daniel P. Berrange
Date: Mon Jan 15 14:25:33 2018 +
ui: deprecate use of SDL 1.2 in favour of 2.0 series
The SDL 2.0 release was made in Aug,
Fei Li writes:
> From: Fei Li
>
> Utilize the existed errp to propagate the error instead of the
> temporary &error_abort.
>
> Cc: Markus Armbruster
> Cc: Marc-André Lureau
> Signed-off-by: Fei Li
Reviewed-by: Markus Armbruster
From: Philippe Mathieu-Daudé
Commit 5f9b1e35060b8 remove the dependency between OpenGL and X11.
However the milkymist-tmu2 device do require X11.
When using SDL, the configure script sets need_x11=yes, so the X11
flags are populated to the makefiles.
When building without SDL, X11 is not pulled a
* Yuval Shaia (yuval.sh...@oracle.com) wrote:
> Utilize error_report for all pr_err calls and some pr_dbg that are
> considered as errors.
> For the remaining pr_dbg calls, the important ones were replaced by
> trace points while other deleted.
>
> Signed-off-by: Yuval Shaia
> ---
> hw/rdma/rdma
Fei Li writes:
> From: Fei Li
>
> The callers of qemu_init_vcpu() already passed the **errp to handle
> errors. In view of this, add a new Error parameter to qemu_init_vcpu()
> and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to
> propagate the error and let the further callers c
Am 31.01.2019 um 13:38 hat Alberto Garcia geschrieben:
> The cmd() method of the QEMUQtestProtocol class sends a qtest command
> to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
> Because of this, it can return control to the caller before the
> command has actually finished.
We currently don't migrate any state for zpci devices, which are
coupled with standard pci devices. This means funny things happen
when we e.g. try to migrate with a virtio-pci device but the s390x-
specific zpci state is not migrated (vfio-pci is not affected, as
it is not migratable anyway.)
Unt
Am 25.01.2019 um 18:46 hat Kevin Wolf geschrieben:
> The vendor specific designator in the Device Identification VPD page has
> two problems:
>
> 1. It defaults to the BlockBackend name (-drive id=...), which everyone
>expected to be a host detail that the guest never sees
>
> 2. With -blockd
Fei Li writes:
> From: Fei Li
>
> Utilize the existed errp to propagate the error and do the
> corresponding cleanup to replace the temporary &error_abort.
>
> Cc: Markus Armbruster
> Cc: Jiri Slaby
> Signed-off-by: Fei Li
> ---
> hw/misc/edu.c | 11 ---
> 1 file changed, 8 insertion
Hi all.
Here is most of preparatory refactoring for NBD reconnect, rebased
on master. Let's push it.
Sorry for a long delay in answering on v4 review and for v4 which
I pinged a lot can't be applied on master directly :(
v5:
02: rebased on master, object_unref() moved to fail: block
05: tiny fix
Split connection code to reuse it for reconnect.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/nbd-client.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index 641666
Fei Li writes:
> From: Fei Li
>
> Add a local_err to hold the error, and return the corresponding
> error code to replace the temporary &error_abort.
>
> Cc: Markus Armbruster
> Cc: David Gibson
> Signed-off-by: Fei Li
> Acked-by: David Gibson
Reviewed-by: Markus Armbruster
Keep all connection code in one file, to be able to implement reconnect
in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Notes:
v5:
rebase on master, object_unref under fail:.
fix comment to "/*\n" style.
block/nbd-client.h | 2 +-
block/nbd-client.c | 40 ++
To implement nbd reconnect in further patches, we need to distinguish
error codes, returned by nbd server, from channel errors, to reconnect
only in the latter case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/nbd-client.c | 83 ++---
We have several paranoid checks for ioc != NULL. But ioc may become
NULL only on close, which should not happen during requests handling.
Also, we check ioc only sometimes, not after each yield, which is
inconsistent. Let's drop these checks. However, for safety, let's leave
asserts instead.
Signe
Use exported report, not the variable to be reused (should not really
matter).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/nbd-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index a8ce0824c2.
Fei Li writes:
> From: Fei Li
>
> Utilize the existed errp to propagate the error and do the
> corresponding cleanup to replace the temporary &error_abort.
>
> Cc: Markus Armbruster
> Cc: Gerd Hoffmann
> Signed-off-by: Fei Li
> ---
> hw/usb/ccid-card-emulated.c | 15 ++-
> 1 file
This coroutine will serve nbd reconnects, so, rename it to be something
more generic.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/nbd-client.h | 4 ++--
block/nbd-client.c | 24
2 files changed, 14 insertions(+), 14 deletions(-)
diff
On Sat, 26 Jan 2019, BALATON Zoltan wrote:
According to BookE docs, invalid bits (while undefined behaviour) should
not raise exception but be ignored. This seems to be implementation
dependent though and QEMU currently does what e500 CPUs do and raise
exception for invalid bits. Unfortunately so
Patchew URL:
https://patchew.org/QEMU/20190128181047.20781-1-peter.mayd...@linaro.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGI
On 01.02.19 13:45, Cornelia Huck wrote:
> We currently don't migrate any state for zpci devices, which are
> coupled with standard pci devices. This means funny things happen
> when we e.g. try to migrate with a virtio-pci device but the s390x-
> specific zpci state is not migrated (vfio-pci is not
Hi Lucien,
On 1/31/19 5:48 AM, Lucien Murray-Pitts wrote:
> The result is that vCont now does not recognise the case where no
> process/thread is provided after the action.
>
> This may not show up with GDB, but using Lauterbach Trace32, and Hexrays IDA
> Pro this issue is immediately seen.
> T
* Leonardo Soares Müller (leozinho29...@hotmail.com) wrote:
> libspice-server1 on host: 0.14.0-1ubuntu2.2
> spice-vdagent (the only package) on guest: 0.17.0-1ubuntu2
> Guest kernel version: 4.15.0-44-generic
Hmm, I'm also getting a crash, but I think it's very different from
yours:
./x86_64-soft
On Fri, 1 Feb 2019 14:29:47 +0100
David Hildenbrand wrote:
> On 01.02.19 13:45, Cornelia Huck wrote:
> > We currently don't migrate any state for zpci devices, which are
> > coupled with standard pci devices. This means funny things happen
> > when we e.g. try to migrate with a virtio-pci device
On Wed, Jan 30, 2019 at 09:36:05PM -0200, Murilo Opsfelder Araujo wrote:
> The commit 7197fb4058bcb68986bae2bb2c04d6370f3e7218 ("util/mmap-alloc:
> fix hugetlb support on ppc64") fixed Huge TLB mappings on ppc64.
>
> However, we still need to consider the underlying huge page size
> during munmap(
On Wed, Jan 30, 2019 at 09:36:04PM -0200, Murilo Opsfelder Araujo wrote:
> Unfold parts of qemu_ram_mmap() for the sake of understanding, moving
> declarations to the top, and keeping architecture-specifics in the
> ifdef-else blocks. No changes in the function behaviour.
>
> Give ptr and ptr1 me
Fei Li writes:
> From: Fei Li
>
> For iothread_complete: utilize the existed errp to propagate the
"For iothread_complete" is redundant, isn't it?
> error and do the corresponding cleanup to replace the temporary
> &error_abort.
>
> Cc: Markus Armbruster
> Cc: Stefan Hajnoczi
> Cc: Eric Blak
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>> > * David Hildenbrand (da...@redhat.com) wrote:
>> >> Print the memory device info just like for PCDIMM/NVDIMM.
>> >>
>> >> Signed-off-by: David Hildenbrand
>> >> ---
>>
Fei Li writes:
> From: Fei Li
>
> For qemu_signalfd_compat: set errno, do some cleanup, and return
"For iothread_complete" is redundant, isn't it?
> -1 to replace the temporary &error_abort when failing to create
> sigwait_compat.
>
> Cc: Markus Armbruster
> Cc: Eric Blake
> Signed-off-by: F
On 31.01.19 13:38, Alberto Garcia wrote:
> The cmd() method of the QEMUQtestProtocol class sends a qtest command
> to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
> Because of this, it can return control to the caller before the
> command has actually finished.
>
> In cases
Fei Li writes:
> From: Fei Li
>
> Supplement the error handling for vnc_thread_worker_thread: add
> an Error parameter for it to propagate the error to its caller to
> handle in case it fails, and make it return a Boolean to indicate
> whether it succeeds.
>
> Cc: Markus Armbruster
> Cc: Gerd H
On 31.01.19 03:21, John Snow wrote:
>
>
> On 1/30/19 6:52 PM, Max Reitz wrote:
>> Without this filter, this test sometimes fails.
>>
>> Signed-off-by: Max Reitz
>> ---
>> I intended to send this as part of my iotest fixes series, but it ended
>> up on the wrong branch... Doesn't really matter,
Hi Luc,
Great feedback from both you and Eric - im blown away, I dont thinktheres a
single 1byte ascii character left unturned there :)My coding style snuck in
erywhere, as did my Scottish English!
On Friday, February 1, 2019, 10:33:18 PM GMT+9, Luc Michel
wrote: > > + GDBThreadIdKind v
On 18/01/2019 13:33, Mark Cave-Ayland wrote:
> On 03/01/2019 15:48, Corentin Labbe wrote:
>
>> Hello
>>
>> When using an initrd > 5M, I hit the following kernel crash:
>> qemu-system-sparc -kernel vmlinux -initrd rootfs.cpio.gz -nographic
>> Configuration device id QEMU version 1 machine id 32
>>
On Fri, Feb 01, 2019 at 02:42:10PM +, Vladimir Sementsov-Ogievskiy wrote:
> 31.01.2019 16:46, Andrey Shinkevich wrote:
> > Inform a user in case qcow2_get_specific_info fails to obtain
> > QCOW2 image specific information. This patch is preliminary to
> > the print of bitmap information in the
31.01.2019 16:46, Andrey Shinkevich wrote:
> Inform a user in case qcow2_get_specific_info fails to obtain
> QCOW2 image specific information. This patch is preliminary to
> the print of bitmap information in the 'qemu-img info' output.
>
> Signed-off-by: Andrey Shinkevich
> Reviewed-by: Eric Bla
sphinx-build complains:
docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation.
docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation.
docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line;
unexpected unindent.
docs/cpu-hotplug.rst:75: WARNING: Block quote ends without a blank
Convert the memory API documentation from plain text
to restructured text format.
This is a very minimal conversion: all I had to change
was to mark up the ASCII art parts as Sphinx expects
for 'literal blocks', and fix up the bulleted lists
(Sphinx expects no leading space before the bullet, and
This patchset enables building and installing the various rST
docs we have started to accumulate in our docs/ directory.
It does this using Sphinx (which is the docs tooling that the
Linux kernel uses). The series is not trying to take us in one
giant leap to a brave new Sphinx-powered world -- it
Abstract out the "identify the pkgversion" code from the
rule for creating qemu-version.h, so it sets makefile
variables for QEMU_PKGVERSION and QEMU_FULL_VERSION.
(We will want to use these when building the Sphinx docs.)
Signed-off-by: Peter Maydell
---
Makefile | 33 --
We don't yet have any custom static files, so disable this
config file setting to avoid a warning from sphinx about
not being able to find the directory.
Signed-off-by: Peter Maydell
---
docs/conf.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/conf.py b/docs/con
sphinx-build complains about using :option: to mark up option
flags that it doesn't know about (because they were not defined
using the "option::" directive):
docs/pr-manager.rst:68: WARNING: unknown option: -d
Suppress these warnings. This way we get the semantic markup
of the option flag but no
Add support to our configure and makefile machinery for building
our rST docs into HTML files.
Building the documentation now requires that sphinx-build is
available; this seems better than allowing half the docs to
be built if it is not present but having half of them missing.
(In particular it m
Add the 'navigation' bar to the sidebar, which for some
reason is not enabled by default. Remove 'relations', which
is effectively disabled anyway and isn't useful for us.
Signed-off-by: Peter Maydell
---
docs/conf.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/con
On 1/31/19 11:15 PM, Paolo Bonzini wrote:
> On 31/01/19 22:48, Philippe Mathieu-Daudé wrote:
>> There is something I don't understand here: Does CONFIG_XEN in
>> Kconfig.host take precedence over the target configs? I'm looking at
>> these configs:
>>
>> if supported_xen_target $target; then
>>
Commit the initial Sphinx conf.py and skeleton index.rst as
generated with sphinx-quickstart
---
docs/conf.py | 168 +
docs/index.rst | 20 ++
2 files changed, 188 insertions(+)
create mode 100644 docs/conf.py
create mode 100644 docs/index.r
Don't hard-code the QEMU version number into conf.py. Instead
we either pass it to sphinx-build on the command line, or
(if doing a standalone Sphinx run in a readthedocs.org setup)
extract it from the VERSION file.
Signed-off-by: Peter Maydell
---
Makefile | 2 +-
docs/conf.py | 21 +++
---
docs/conf.py | 37 +++--
docs/devel/conf.py | 15 +++
docs/devel/index.rst | 21 +
docs/index.rst | 9 ++---
docs/interop/conf.py | 15 +++
docs/interop/index.rst | 18 ++
Cc: Paolo for preexisting issues due to commit 1e356fc14be.
Fei Li writes:
> From: Fei Li
>
> Supplement the error handling for touch_all_pages: add an Error
> parameter for it to propagate the error to its caller to do the
> handling in case it fails.
>
> Cc: Markus Armbruster
> Signed-off-by
Hi Paolo,
On 1/25/19 11:07 AM, Paolo Bonzini wrote:
> This way, the default-configs file only need to specify the boards
> and any optional devices.
>
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Yang Zhong
> Message-Id: <20190123065618.3520-37-yang.zh...@intel.com>
> Signed-off-by: Paolo Bo
Sphinx defaults to including all the rST source files
in the HTML build and making each HTML page link to the
source file. Disable that.
Signed-off-by: Peter Maydell
---
docs/conf.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/conf.py b/docs/conf.py
index 348e6358740..6ddaa549f28
Patchew URL:
https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs
Type: series
Message-id: 2019020
Patchew URL:
https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs
Message-id: 20190201145035.22739
On Fri, 25 Jan 2019 at 22:57, Richard Henderson
wrote:
>
> Initialize the keys to a non-zero value on process start.
>
> Signed-off-by: Richard Henderson
> +static uint64_t arm_rand64(void)
> +{
> +int shift = 64 - clz64(RAND_MAX);
> +int i, n = 64 / shift + (64 % shift != 0);
> +uin
On 01.02.19 11:19, Cornelia Huck wrote:
> On Wed, 30 Jan 2019 16:57:33 +0100
> David Hildenbrand wrote:
>
>> When resetting the guest we should unplug and remove all devices that
>> are still pending.
>>
>> With this patch, the requested device will be unpluged on reboot
>> (S390_RESET_EXTERNAL a
On Fri, 25 Jan 2019 at 22:57, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/aarch64/target_syscall.h | 7 ++
> linux-user/syscall.c| 33 +
> 2 files changed, 40 insertions(+)
> @@ -9691,6 +9691,39 @@ static abi_
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> "Dr. David Alan Gilbert" writes:
> >>
> >> > * David Hildenbrand (da...@redhat.com) wrote:
> >> >> Print the memory device info just like for PCDIMM/NVDIMM
On Fri, 25 Jan 2019 at 22:57, Richard Henderson
wrote:
>
> (1) Fix a bug I introduced at the last moment in the last
> patch set -- enable pac keys during reset, not before.
> (2) Add the HWCAP bits.
> (3) Add the new prctl
> (4) Add a smoke test so that (1) doesn't happen again.
>
>
> r~
>
>
31.01.2019 16:46, Andrey Shinkevich wrote:
> In the 'Format specific information' section of the 'qemu-img info'
> command output, the supplemental information about existing QCOW2
> bitmaps will be shown, such as a bitmap name, flags and granularity:
>
> image: /vz/vmprivate/VM1/harddisk.hdd
> fi
On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote:
> In order to avoid migration issues, we enable DISCARD and
> WRITE ZEROES features only for machine type >= 4.0
>
> Suggested-by: Dr. David Alan Gilbert
> Signed-off-by: Stefano Garzarella
> ---
> hw/block/virtio-blk.c
On Fri, 25 Jan 2019 at 23:02, Rémi Denis-Courmont wrote:
>
> Hello,
>
> As things stand, ARMv8.3-PAuth does not work in user mode. These tiny patches
> attempt to fix that.
>
> Br,
>
>
> Remi Denis-Courmont (3):
> targe
1 - 100 of 378 matches
Mail list logo
