Hi Luc,
Great feedback from both you and Eric - im blown away, I dont thinktheres a
single 1byte ascii character left unturned there :)My coding style snuck in
erywhere, as did my Scottish English!
On Friday, February 1, 2019, 10:33:18 PM GMT+9, Luc Michel
<luc.mic...@greensocs.com> wrote: > > + GDBThreadIdKind vcontThreadType ;
> The coding style ... CODING_STYLE ...
Ah I didnt pick up on this whilst reading the Wiki for coding style, thank you!
> > + vcontThreadType = GDB_ALL_THREAD ;> + pid = 1 ;
> The spec is not clear but I would opt for GDB_ALL_PROCESSES instead of
> GDB_ALL_THREAD here. pid = 1; is clearly wrong since you don't know if
> this PID exists or is currently attached.
I was in a quandary here, and I did see your previous email too.However, I
looked at how the call to read_thread_id() behaved and copied over the same
behavior as if the command was vCont;c:-1which I understand to mean continue
all threads?
So maybe we should look at altering read_thread_id() which sets pid=1 when
thereis no "ppid." part to the thread-id description, and if you set "tid=-1"
then it performs a GDB_ALL_THREAD
>From the vCont spec I also got;"p-1 ... means all processes""An action with no
>thread-id matches all threads."
"tid=-1 ... matches all threads"
But it is not very clear what happens if you omit ppid and supply tid as -1.
What do you think?
Cheers,
Luc
