On Fri, Feb 01, 2019 at 10:09:08AM +0100, Stefano Garzarella wrote: > On Fri, Feb 01, 2019 at 12:29:28PM +0800, Stefan Hajnoczi wrote: > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > > In order to avoid migration issues, we enable DISCARD and > > > WRITE ZEROES features only for machine type >= 4.0 > > > > Please use two separate properties that correspond to the > > VIRTIO_BLK_F_DISCARD and VIRTIO_BLK_F_WRITE_ZEROES virtio-blk feature > > bits. > > Okay. > As Michael suggested, what do you think if I use a similar approach of > virtio-net, adding an host_features variable and setting a corresponding > feature bit?
Yes, that's a clean way of supporting feature bit options. Stefan
signature.asc
Description: PGP signature
