On Wed, Nov 28, 2018 at 02:54:09PM +, Daniel P. Berrangé wrote:
> On Wed, Nov 28, 2018 at 06:46:37PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Nov 28, 2018 at 6:33 PM Daniel P. Berrangé
> > wrote:
> > >
> > > On Wed, Nov 28, 2018 at 06:21:35PM +0400, Marc-André Lureau wrote:
> >
On Wed, Nov 21, 2018 at 04:39:41AM +0800, Kirti Wankhede wrote:
> - Migration function are implemented for VFIO_DEVICE_TYPE_PCI device.
> - Added SaveVMHandlers and implemented all basic functions required for live
> migration.
> - Added VM state change handler to know running or stopped state of
On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> Looking at chardev/spice.c code, I realize compilation was broken for
> a while with spice-server < 0.12.3. Let's bump required version
> to 0.12.5, released May 19 2014, instead of adding more #ifdef.
Oh, you did the 0.12.5 patc
>
> On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > Looking at chardev/spice.c code, I realize compilation was broken for
> > a while with spice-server < 0.12.3. Let's bump required version
> > to 0.12.5, released May 19 2014, instead of adding more #ifdef.
>
> Oh, you did
On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote:
>
> On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > Looking at chardev/spice.c code, I realize compilation was broken for
> > a while with spice-server < 0.12.3. Let's bump required version
> > to 0.12.5, released May 19
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips
Message-id: 20181127121724.19755-1...@weilnetz.de
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --onel
> On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote:
> >
> > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > > Looking at chardev/spice.c code, I realize compilation was broken for
> > > a while with spice-server < 0.12.3. Let's bump required version
> > > to 0.12.5, rele
Fei Li writes:
> On 11/28/2018 08:53 PM, Markus Armbruster wrote:
>> Fei Li writes:
>>
>>> When qemu_signal_init() fails in qemu_init_main_loop(), we return
>>> without setting an error. Its callers crash then when they try to
>>> report the error with error_report_err().
>> Yes, that's a bug.
>
> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
>
> Signed-off-by: Zhang Yi
> ---
> numa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,
Hi Shannon,
On 11/29/18 3:24 AM, Shannon Zhao wrote:
>
>
> On 2018/11/29 1:26, Auger Eric wrote:
> struct AcpiIortSmmu3 {
> ACPI_IORT_NODE_HEADER_DEF
> uint64_t base_address;
> @@ -639,6 +645,8 @@ struct AcpiIortSmmu3 {
> uint32_t pri_gsiv;
>
Eric Blake writes:
> On 11/28/18 3:25 AM, Markus Armbruster wrote:
>> xiezhide writes:
>>
>>> Rename the ThrottleLimits member names and modify related code
>>>
>>> Signed-off-by: xiezhide
>>> ---
>>> qapi/block-core.json | 70 +++---
>>> util/throttle.c | 163
>>>
Am 28.11.2018 um 17:40 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Kevin Wolf [mailto:kw...@redhat.com]
> > Sent: 28 November 2018 16:35
> > To: Paul Durrant
> > Cc: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; xen-
> > de...@lists.xenproject.org; Stefano Stabellini ;
>
Add optional colors to make seeing message types a bit easier.
The default is to show them on a tty. The chosen colors should resemble
gcc's.
Inspired by Linux commit 57230297116faf5b0a995916d5dd5fedab54cba3
("checkpatch: colorize output to terminal").
---
scripts/checkpatch.pl | 51
Right now, patchew has a small script around checkpatch to show
some feedback about which patches have problems. The idea behind
this series is that patchew should be able to do just
"scripts/checkpatch.pl --mailback base..", and everything
should just work.
Paolo
Paolo Bonzini (4):
checkpatch
Pull the test before the anticipated exits from the process sub.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d58fcb1efd..c216c55e01 100755
--- a/scripts/check
Similar to how patchew output looks like for multiple patches,
say what file or patch is being tested _before_ emitting errors.
This is clearer to a human that scans the output from top to
bottom.
In addition, provide a truncated commit hash and subject instead of
the full hash, and process the co
In some cases, checkpatch's process subroutine is exiting the
whole process. This is wrong, just return from the subroutine
instead.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/c
On Thu, Nov 29, 2018 at 03:32:28AM -0500, Frediano Ziglio wrote:
> > On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote:
> > >
> > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > > > Looking at chardev/spice.c code, I realize compilation was broken for
> > > > a while wi
Am 28.11.2018 um 17:46 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Paul Durrant
> > Sent: 28 November 2018 16:46
> > To: 'Kevin Wolf'
> > Cc: 'Stefano Stabellini' ; qemu-bl...@nongnu.org;
> > qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Eduardo Habkost
> > ; Mi
Extract two new functions from memory_region_update_coalesced_range_as.
To avoid duplication in the creation of the MemoryRegionSection, use
MEMORY_LISTENER_UPDATE_REGION instead of MEMORY_LISTENER_CALL
to invoke the listener callback.
Signed-off-by: Paolo Bonzini
---
memory.c | 53 +
The e1000 driver calls memory_region_add_coalescing but
kvm_coalesce_mmio_region is never called for those regions. The bug
dates back to the introduction of the memory region API; to fix it,
delete and re-add coalesced MMIO ranges when building the FlatViews.
Because coalesced MMIO regions apply
The e1000 driver calls memory_region_add_coalescing but
kvm_coalesce_mmio_region is never called for those regions. The bug
dates back to the introduction of the memory region API; to fix it,
the last patch deletes and re-adds coalesced MMIO ranges when building
the FlatViews. The first two patch
Store whether the FlatRange has had any coalesced I/O ranges applied,
and if not avoid calling coalesced_io_del. This is useful in preparation
for the next patch, which will call coalesced_io_del when rendering
memory regions.
Signed-off-by: Paolo Bonzini
---
memory.c | 11 +++
1 file c
>
> As more flag parameters besides the existing 'share' are going to be
> added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a
> 'flags' parameters in advance, so as to ease the further additions.
>
> Signed-off-by: Haozhong Zhang
> Signed-off-by: Zhang Yi
> ---
> exec.c | 6 +
On 11/29/2018 04:35 PM, Markus Armbruster wrote:
Fei Li writes:
On 11/28/2018 08:53 PM, Markus Armbruster wrote:
Fei Li writes:
When qemu_signal_init() fails in qemu_init_main_loop(), we return
without setting an error. Its callers crash then when they try to
report the error with erro
On 15/02/18 11:37, Stefan Hajnoczi wrote:
> On Sat, Feb 03, 2018 at 07:16:18AM +0100, Stefan Hajnoczi wrote:
>> v2:
>> * It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this
>>function already protects against duplicate calls internally [Stefan]
>>
>> Patches 1 & 2 are cl
On 29/11/18 00:15, Benjamin Herrenschmidt wrote:
> Afaik, this isn't well documented (at least it wasn't when I last looked)
> but OSes such as Linux rely on this behaviour:
>
> The HW updates to the page tables need to be done atomically with the
> checking of the present bit (and other permissio
Eric Blake writes:
[...]
>> +++ b/qapi/sockets.json
>> @@ -152,3 +152,16 @@
>> 'unix': 'UnixSocketAddress',
>> 'vsock': 'VsockSocketAddress',
>> 'fd': 'String' } }
>> +
>> +##
>> +# @DummyStruct:
>> +#
>> +# Both block-core and migration needs SocketAddre
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 29 November 2018 09:01
> To: Paul Durrant
> Cc: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; xen-
> de...@lists.xenproject.org; Stefano Stabellini ;
> Anthony Perard ; Max Reitz
> Subject: Re: [PATCH 14/18] xen: ad
On Wed, Nov 28, 2018 at 12:23:32PM -0500, Emilio G. Cota wrote:
> On Wed, Nov 28, 2018 at 13:43:30 +0300, Roman Bolshakov wrote:
> > qemu-ga fails to link because it doesn't have symbols declared in
> > qemu-plugins-ld64.symbols. Perhaps "-Wl,-exported_symbols_list" should
> > be applied only to qe
On 28/11/18 22:56, Guenter Roeck wrote:
> The guest OS reads RSTAT, RSEQ, and RINTR, and expects those registers
> to reflect a consistent state. However, it is possible that the registers
> can change after RSTAT was read, but before RINTR is read.
>
> Guest OS qemu
>
On 28/11/18 22:56, Guenter Roeck wrote:
> Per AM53C974 datasheet, definition of "SCSI Bus and Control (SBAC)"
> register:
>
> Bit 24 – STATUS – Write Erase Control
>
> This bit controls the Write Erase feature on bits 3:1 and bit 6 of the DMA
> Status Register ((B)+54h). When this bit is programm
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2 +-
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it. And make the
function be: void multifd_save_cleanup(void).
Signed-off-by: Fei Li
Reviewed-by: Juan Quint
When qemu_signal_init() fails in qemu_init_main_loop(), we return
without setting an error. Its callers crash then when they try to
report the error with error_report_err().
To avoid such segmentation fault, add a new Error parameter to make
the call trace to propagate the err to the final caller
These five patches almost get the Reviewed-by and are extracted from
previous "[PATCH RFC v7 0/9] qemu_thread_create: propagate errors to
callers to check." The mentioned patch series have waited on one
multifd issue for a while and still needs a further discussion.
Thus separate(send) these five
In our current code, when multifd is used during migration, if there
is an error before the destination receives all new channels, the
source keeps running, however the destination does not exit but keeps
waiting until the source is killed deliberately.
Fix this by dumping the specific error and l
On 29/11/18 10:01, Paolo Bonzini wrote:
>
> +if ($color =~ /^[01]$/) {
> + $color = !$color;
> +} elsif ($color =~ /^always$/i) {
This first "if" is unnecessary, not sure why Linux has it (probably
because it implements --nocolor differently).
Paolo
Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
---
migration/postcopy-ram.c | 1 +
migration/savevm.c | 1 +
2
On Thu, 2018-11-29 at 10:26 +0100, Paolo Bonzini wrote:
> On 29/11/18 00:15, Benjamin Herrenschmidt wrote:
> > Afaik, this isn't well documented (at least it wasn't when I last looked)
> > but OSes such as Linux rely on this behaviour:
> >
> > The HW updates to the page tables need to be done atom
On 29/11/18 11:04, Benjamin Herrenschmidt wrote:
> On Thu, 2018-11-29 at 10:26 +0100, Paolo Bonzini wrote:
>> On 29/11/18 00:15, Benjamin Herrenschmidt wrote:
>>> Afaik, this isn't well documented (at least it wasn't when I last looked)
>>> but OSes such as Linux rely on this behaviour:
>>>
>>> The
Daniel Henrique Barboza writes:
> When issuing the qmp/hmp 'system_wakeup' command, what happens in a
> nutshell is:
>
> - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason
> and notify the event
> - in the main_loop, all vcpus are paused, a system reset is issued, all
> sub
On 22/11/18 12:00, Marc-André Lureau wrote:
> Hi,
>
> Here is a small series improving a bit Windows headers inclusion, and
> setting the default required API version globally to Vista. It also
> allows easier tweaking of available API version via CFLAGS.
>
> Building QGA for older versions (XP)
Let start from the beginning:
Commit b9e413dd375 (in 2.9)
"block: explicitly acquire aiocontext in aio callbacks that need it"
added pairs of aio_context_acquire/release to mirror_write_complete and
mirror_read_complete, when they were aio callbacks for blk_aio_* calls.
Then, commit 2e1990b26e5 (
On Wed, 28 Nov 2018 10:59:39 +0100
David Hildenbrand wrote:
> Just like on other architectures, we should stop the clock while the guest
> is not running. This is already properly done for TCG. Right now, doing an
> offline migration (stop, migrate, cont) can easily trigger stalls in the
> guest.
This test is broken without previous commit fixing dead-lock in mirror.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/235 | 59 ++
tests/qemu-iotests/235.out | 1 +
tests/qemu-iotests/group | 1 +
3 files changed, 61 insertions(+)
Hi Philippe,
I'll investigate further running with --enable-debug option to fix this
issue.
In the meantime, we could note enable-debug as 'To Be Done/Work In
Progress' for nanoMIPS in qemu docs .
Thanks,
Stefan
On 28.11.18. 15:31, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 28/11/1
Hi all!
v2: add fix:)
We've faced the following mirror bug:
Just run mirror on qcow2 image more than 1G, and qemu is in dead lock.
Dead lock described in 01, in short, we have extra aio_context_acquire
and aio_context_release around blk_aio_pwritev in mirror_read_complete.
So, write may yield t
On 26/11/18 14:59, Vitaly Kuznetsov wrote:
> It was found that QMP users of QEMU (e.g. libvirt) may need
> HV_CPUID_ENLIGHTMENT_INFO.EAX/HV_CPUID_NESTED_FEATURES.EAX information. In
> particular, 'hv_tlbflush' and 'hv_evmcs' enlightenments are only exposed in
> HV_CPUID_ENLIGHTMENT_INFO.EAX.
>
> H
On Thu, 29 Nov 2018 at 02:11, berkus infinitus wrote:
>
> I suspect the main problem is the blocking call to qemu_main
> from the UI thread in the app delegate didFinishLoadingWithOptions
> if i’m not mistaken and everything else grows from there.
Yes; if there's no way that Mojave will allow us
On Wed, Nov 28, 2018 at 12:33:32PM +0100, Juan Quintela wrote:
> - Finish tl trasport test
> I already knew that I hate certificates, but this is too much. Trying
> to understand how to use them.
I'll happily contribute TLS tests on top of your basic series here
if you want. Just let me know.
On Thu, 29 Nov 2018 at 10:18, Stefan Markovic wrote:
> I'll investigate further running with --enable-debug option to fix this
> issue.
>
> In the meantime, we could note enable-debug as 'To Be Done/Work In
> Progress' for nanoMIPS in qemu docs .
This isn't just "--enable-debug doesn't work", it
To be able to build and test QEMU binaries where certain devices are
disabled, we have to use the right CONFIG_* switches to run certain
tests only if the corresponding device really has been compiled into
the binary.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 10 +-
1 file
On 29/11/18 11:25, Thomas Huth wrote:
> To be able to build and test QEMU binaries where certain devices are
> disabled, we have to use the right CONFIG_* switches to run certain
> tests only if the corresponding device really has been compiled into
> the binary.
>
> Signed-off-by: Thomas Huth
N
Hi
On Wed, Nov 28, 2018 at 9:53 PM Igor Mammedov wrote:
>
> On Tue, 27 Nov 2018 11:35:27 -0200
> Eduardo Habkost wrote:
>
> > On Tue, Nov 27, 2018 at 05:10:05PM +0400, Marc-André Lureau wrote:
> > > On Tue, Nov 27, 2018 at 4:57 PM Eduardo Habkost
> > > wrote:
> > > >
> > > > On Tue, Nov 27, 201
>
> On Thu, Nov 29, 2018 at 03:32:28AM -0500, Frediano Ziglio wrote:
> > > On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote:
> > > >
> > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote:
> > > > > Looking at chardev/spice.c code, I realize compilation was broken for
> > >
To be able to build and test QEMU binaries where certain devices or machines
are disabled, we have to use the right CONFIG_* switches to run certain tests
only if the corresponding device or machine really has been compiled into
the binary.
Signed-off-by: Thomas Huth
---
tests/Makefile.include |
Am 28.11.2018 um 21:13 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> We've faced the following mirror bug:
>
> Just run mirror on qcow2 image more than 1G, and qemu is in dead lock.
>
> Note: I've decided to send this as a patch with reproducer, to make it
> easier to reproduce). N
On 29/11/18 11:43, Thomas Huth wrote:
> To be able to build and test QEMU binaries where certain devices or machines
> are disabled, we have to use the right CONFIG_* switches to run certain tests
> only if the corresponding device or machine really has been compiled into
> the binary.
>
> Signed-
Am 29.11.2018 um 11:16 schrieb Paolo Bonzini:
> On 22/11/18 12:00, Marc-André Lureau wrote:
>> include/qemu/osdep.h | 17 ++
>> accel/tcg/translate-all.c | 4 ---
>> qga/commands-win32.c | 70 +--
>> util/qemu-thread-win32.c | 4 ---
>> conf
Am 29.11.2018 um 10:33 hat Paul Durrant geschrieben:
> > -Original Message-
> > From: Kevin Wolf [mailto:kw...@redhat.com]
> > Sent: 29 November 2018 09:01
> > To: Paul Durrant
> > Cc: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; xen-
> > de...@lists.xenproject.org; Stefano Stabellini ;
>
Add a README file that tells people this is a jekyll based static
website, and shows people how to run jekyll for testing purposes.
Tested-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 2 ++
README | 55 +
_config.ym
On Thu, Nov 29, 2018 at 2:45 PM Stefan Weil wrote:
>
> Am 29.11.2018 um 11:16 schrieb Paolo Bonzini:
> > On 22/11/18 12:00, Marc-André Lureau wrote:
> >> include/qemu/osdep.h | 17 ++
> >> accel/tcg/translate-all.c | 4 ---
> >> qga/commands-win32.c | 70 +--
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 29 November 2018 10:46
> To: Paul Durrant
> Cc: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; xen-
> de...@lists.xenproject.org; Stefano Stabellini ;
> Anthony Perard ; Max Reitz
> Subject: Re: [PATCH 14/18] xen: ad
On 2018-11-28 16:38, Daniel P. Berrangé wrote:
> The new version numbering scheme was mentioned in the blog post
> announcing 3.0 previously, but this will fall out of view over
> time. It is thus preferrable to mention this on the download page
> too.
>
> Reported-by: Marc-André Lureau
> Signed-
On Thu, Nov 29, 2018 at 11:58:22AM +0100, Thomas Huth wrote:
> On 2018-11-28 16:38, Daniel P. Berrangé wrote:
> > The new version numbering scheme was mentioned in the blog post
> > announcing 3.0 previously, but this will fall out of view over
> > time. It is thus preferrable to mention this on th
The new version numbering scheme was mentioned in the blog post
announcing 3.0 previously, but this will fall out of view over
time. It is thus preferrable to mention this on the download page
too.
Reported-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
download.html | 24 +
> > seems the spice-protocol dep is there due to qemu itself needing it:
> >
> > commit 358689fe299c306f1d81bea57a5067d0abb56699
> > Author: Michal Privoznik
> > Date: Fri Mar 1 08:43:18 2013 +0100
> >
> > configure: Require at least spice-protocol-0.12.3
> >
> > As of 5a49d3e9 we
On 2018-11-29 12:03, Daniel P. Berrangé wrote:
> The new version numbering scheme was mentioned in the blog post
> announcing 3.0 previously, but this will fall out of view over
> time. It is thus preferrable to mention this on the download page
> too.
>
> Reported-by: Marc-André Lureau
> Signed-
On Thu, 22 Nov 2018 17:35:50 +0100
Pierre Morel wrote:
> In the case we will enter QEMU through interception of instructions,
> we will need to retrieve the AP devices.
> The base device is the AP bridge.
>
> Let us implement a way to retrieve the AP Bridge from qtree.
>
> Signed-off-by: Pierre
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH] glib-compat: work around g_test_message bug with
subprocess tests
Message-id: 1543343726-53531-1-git-send-email-pbonz...@redhat.com
=== TEST SCRIPT BEGIN =
Paolo Bonzini writes:
> On 26/11/18 14:59, Vitaly Kuznetsov wrote:
>> It was found that QMP users of QEMU (e.g. libvirt) may need
>> HV_CPUID_ENLIGHTMENT_INFO.EAX/HV_CPUID_NESTED_FEATURES.EAX information. In
>> particular, 'hv_tlbflush' and 'hv_evmcs' enlightenments are only exposed in
>> HV_CPUI
On 29/11/2018 09:58, Paolo Bonzini wrote:
> On 28/11/18 22:56, Guenter Roeck wrote:
>> The guest OS reads RSTAT, RSEQ, and RINTR, and expects those registers
>> to reflect a consistent state. However, it is possible that the registers
>> can change after RSTAT was read, but before RINTR is read.
>
There are some "#ifdef CONFIG_VIRTIO_VGA" in the code here which
do not work as expected: CONFIG_VIRTIO_VGA is a Makefile switch,
but not a CPP macro, so the "guarded" code currently simply never
gets enabled.
So enable this code now unconditionally, with some runtime switches
for the architecture
On Thu, 22 Nov 2018 17:35:51 +0100
Pierre Morel wrote:
> Two good reasons to use the base device as a child of the
> AP BUS:
> - We can easily find the device without traversing the qtree.
> - In case we have different APdevice instantiation, VFIO with
> interception or emulation, we will need
I have attached a patch that enables support for direct use of Intel GPUs in
QEMU. With this you can build the libdrm and mesa on for instance an AArch64
emulated system and have native OpenGL support inside QEMU.
The code has been sitting around on my drive for a year, and isn't quite as
polis
On 11/29/2018 08:43 AM, Thomas Huth wrote:
To be able to build and test QEMU binaries where certain devices or machines
are disabled, we have to use the right CONFIG_* switches to run certain tests
only if the corresponding device or machine really has been compiled into
the binary.
Signed-off
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
("net: ignore packet size greater than INT_MAX") during packet
delivering. Unfortunately, this is not sufficient as we may hit
another integer overflow when trying to queue such large packet in
qemu_net_queue_append_iov():
- siz
Hi:
This series tries to fix a possible OOB during queueing packets
through qemu_net_queue_append_iov(). This could happen when it tries
to queue a packet whose size is larger than INT_MAX which may lead
integer overflow. We've fixed similar issue in the past during
qemu_net_queue_deliver_iov() by
This allows flexibility to be reused for all kinds of command line
used by other tests.
Reviewed-by: Thomas Huth
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/virtio-net-test.c b/tests/virtio-ne
Reviewed-by: Thomas Huth
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/virtio-net-test.c b/tests/virtio-net-test.c
index dcb87a8b6e..231e7c767e 100644
--- a/tests/virtio-net-test.c
+++ b/tests/virtio-net-test.c
@@ -24,7 +24,6 @@
On 2018/11/29 下午2:21, Thomas Huth wrote:
On 2018-11-29 04:12, Jason Wang wrote:
This test tries to build a packet whose size is greater than INT_MAX
which tries to trigger integer overflow in qemu_net_queue_append_iov()
which may result OOB.
Signed-off-by: Jason Wang
---
tests/virtio-net-t
This test tries to build a packet whose size is greater than INT_MAX
which tries to trigger integer overflow in qemu_net_queue_append_iov()
which may result OOB.
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 45 +
1 file changed, 45 insertions(+)
29.11.2018 13:42, Kevin Wolf wrote:
> Am 28.11.2018 um 21:13 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Hi all!
>>
>> We've faced the following mirror bug:
>>
>> Just run mirror on qcow2 image more than 1G, and qemu is in dead lock.
>>
>> Note: I've decided to send this as a patch with reprod
* miny...@acm.org (miny...@acm.org) wrote:
> From: Corey Minyard
>
> Migration capability is being added for pm_smbus and SMBus devices.
> This change will allow backwards compatibility to be kept when
> migrating back to an old qemu version. Add a bool to the machine
> class tho keep smbus migr
* miny...@acm.org (miny...@acm.org) wrote:
> From: Corey Minyard
>
> This will be needed by coming I2C changes.
>
> Signed-off-by: Corey Minyard
Reviewed-by: Dr. David Alan Gilbert
> ---
> include/migration/vmstate.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/migra
Daniel Henrique Barboza writes:
> This patch updates the descriptions of 'guest-suspend-ram' and
> 'guest-suspend-hybrid' to mention that both commands relies now
> on the proper support for wake up from suspend, retrieved by the
> 'wakeup-suspend-support' attribute of the 'query-current-machine'
On 29/11/2018 12:45, Cornelia Huck wrote:
On Thu, 22 Nov 2018 17:35:51 +0100
Pierre Morel wrote:
Two good reasons to use the base device as a child of the
AP BUS:
- We can easily find the device without traversing the qtree.
- In case we have different APdevice instantiation, VFIO with
inte
We must set the correct context (via eglMakeCurrent) before
calling qemu_egl_create_context, so we need a thin wrapper and can't
hook qemu_egl_create_context directly as ->dpy_gl_ctx_create callback.
Reported-by: Frederik Carlier
Signed-off-by: Gerd Hoffmann
---
ui/egl-headless.c | 10 +
Daniel Henrique Barboza writes:
> The qmp/hmp command 'system_wakeup' is simply a direct call to
> 'qemu_system_wakeup_request' from vl.c. This function verifies if
> runstate is SUSPENDED and if the wake up reason is valid before
> proceeding. However, no error or warning is thrown if any of tho
On 11/26/2018 10:58 AM, Caio Carrara wrote:
On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote:
QEMUMachine launches the VM with a monitor enabled, afterwards
a qmp connection is attempted on _post_launch(). In case
the QEMU process exits with an error, qmp.accept() re
* miny...@acm.org (miny...@acm.org) wrote:
> From: Corey Minyard
>
> Transfer the state information for the SMBus registers and
> internal data so it will work on a VM transfer.
>
> Signed-off-by: Corey Minyard
> Cc: Michael S. Tsirkin
> Cc: Paolo Bonzini
> Cc: Dr. David Alan Gilbert
Review
You neglected to cc the maintainer. I'm doing that for you now. Cc'ing
maintainers is important to maximize your chances at getting your
patches picked up. Use scripts/get_maintainer.pl to find them.
Fei Li writes:
> When qemu_signal_init() fails in qemu_init_main_loop(), we return
> without
Cc'ing folks who might be able to help.
"Kirk Allan" writes:
> When I try to build qga-vss.dll I get the following link error:
>
> LINKqga/vss-win32/qga-vss.dll
> /usr/lib64/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld:
> qga/vss-win32/requester.o: in function `requester_f
Richard Henderson writes:
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> tcg/i386/tcg-target.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
> index 7488c3d869..2441658865 100644
> --- a/tcg/i386/
Richard Henderson writes:
> For x86_64, this can result in smaller code when manipulating
> TCG_TYPE_I32, as we can omit a REX prefix.
I take it you mean passing TCG_TYPE_I32 back and forth from the register
backing store in CPUEnv which TCG_AREG0 points at?
Anyway:
Reviewed-by: Alex Bennée
* miny...@acm.org (miny...@acm.org) wrote:
> From: Corey Minyard
>
> There is no vmstate handling for SMBus, so no device sitting on SMBus
> can have a state transfer that works reliably. So add it.
>
> Signed-off-by: Corey Minyard
Reviewed-by: Dr. David Alan Gilbert
> Cc: Paolo Bonzini
>
Hi Wainer,
Thanks for your reply. I pretty much agreed with most of it. I just
added a comment about that new method that is not used anywere.
On Thu, Nov 29, 2018 at 10:45:33AM -0200, Wainer dos Santos Moschetta wrote:
>
> On 11/26/2018 10:58 AM, Caio Carrara wrote:
> > On Wed, Nov 21, 2018 at
For both x86 and ARM architectures, the internal RSDP build API can
return void as the current return value is unused.
Signed-off-by: Samuel Ortiz
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
hw/arm/virt-acpi-bu
From: Igor Mammedov
When RSDP table was introduced (d4bec5d87), we calculated only legacy
checksum, and that was incorrect as it
- specified rev=2 and forgot about extended checksum.
- legacy checksum calculated on full table instead of the 1st 20 bytes
Fix it by adding extended checksum calcu
1 - 100 of 365 matches
Mail list logo
