> On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann <kra...@redhat.com> wrote: > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > Looking at chardev/spice.c code, I realize compilation was broken for > > > a while with spice-server < 0.12.3. Let's bump required version > > > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > > > Oh, you did the 0.12.5 patch already. Scratch my other reply then. > > > > > - if $pkg_config --atleast-version=0.12.0 spice-server && \ > > > + if $pkg_config --atleast-version=0.12.5 spice-server && \ > > > $pkg_config --atleast-version=0.12.3 spice-protocol && \ > > > > I think we should adjust spice-protocol too to whatever 0.12.5 requires > > to build. > > > > Why not leave that responsibility to pkg-config, and only require in > qemu what is required there? > >
That is remove explicit requirement in configure script? I can see that spice-core.h (spice-server, one of the mail include) is including spice-protocol headers. Looking at configure both are required so would make sense to check only spice-server, unless packaging has some bugs if you have spice-server (devel) installed you also have spice-protocol. Frediano
