Fei Li <f...@suse.com> writes: > On 11/28/2018 08:53 PM, Markus Armbruster wrote: >> Fei Li <f...@suse.com> writes: >> >>> When qemu_signal_init() fails in qemu_init_main_loop(), we return >>> without setting an error. Its callers crash then when they try to >>> report the error with error_report_err(). >> Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0. Has escaped notice >> since qemu_signalfd() is quite unlikely to fail. Could go into 3.1 as a >> bug fix, but I think punting it to the next release is just fine. > Thanks. :) BTW, should I send the next version only includes patch 1/5 > and 2/5 separately so that you can merge? (I guess Dave will help to > merge the other three migration related patches)
I can pick patches out of a series for merging, and I trust Dave can, too. But keeping unrelated fixes separate is a good idea. I can see three groups: PATCH 1 (main loop), PATCH 2 (thread abstraction), PATCH 3-5 (migration). [...]
