On 11/24/18 2:29 AM, Dr. David Alan Gilbert wrote:
static void
-update_compress_thread_counts(const CompressParam *param, int bytes_xmit)
+update_compress_thread_counts(CompressData *cd, int bytes_xmit)
Keep the const?
Yes, indeed. Will correct it in the next version.
+if (deflate
On 11/24/18 8:12 AM, Emilio G. Cota wrote:
On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote:
+ /*
+ * the bit in these two bitmaps indicates the index of the ＠requests
This @ is not ASCII, is it?
Good eyes. :)
Will fix it.
+ * respectively. If it's the
+ */
+
+#ifndef PPC_XIVE_H
+#define PPC_XIVE_H
+
+#include "hw/sysbus.h"
>>>
>>> So, I'm a bit dubious about making the XiveSource a SysBus device -
>>> I'm concerned it won't play well with tying it into the other devices
>>> like PHB that "own" it in real hardware.
>
On 11/24/18 8:17 AM, Emilio G. Cota wrote:
On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote:
+static uint64_t get_free_request_bitmap(Threads *threads, ThreadLocal *thread)
+{
+uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap;
+
+request_fill_bitm
Hi,
> What are the required semantics for update/switch/refresh?
> These don't seem to be documented. Can we validly make
> those be asychronous, or does the midlayer require that
> the operation has completed and been reflected onscreen
> before the update/switch/refresh callback returns ?
re
>
> This option controls whether QEMU mmap(2) the memory backend file with
> MAP_SYNC flag, which can fully guarantee the guest write persistence
Not sure 'persistence' is the right word here. I think it should be
something like 'consistent filesystem metadata for every guest write' just
to av
On Mon, Nov 26, 2018 at 06:53:23AM +, linzhecheng wrote:
>
>
> > -Original Message-
> > From: Gerd Hoffmann [mailto:kra...@redhat.com]
> > Sent: Monday, November 26, 2018 2:46 PM
> > To: linzhecheng
> > Cc: qemu-devel@nongnu.org; wangxin (U) ;
> > Zhoujian (jay)
> > Subject: Re: [Qe
On 11/26/18 4:20 AM, Mao Zhongyi wrote:
Signed-off-by: Mao Zhongyi
---
target/riscv/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Bastian Koppelmann
Cheers,
Bastian
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, November 26, 2018 4:50 PM
> To: linzhecheng
> Cc: qemu-devel@nongnu.org; wangxin (U) ;
> Zhoujian (jay)
> Subject: Re: [Qemu-devel] [question] live migration about redir-usb
>
> On Mon, Nov 26, 2018
On Sat, 24 Nov 2018 22:07:57 +0100
Halil Pasic wrote:
> On Thu, 22 Nov 2018 17:54:29 +0100
> Cornelia Huck wrote:
>
> > [This is the Linux kernel part, git tree is available at
> > https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git
> > vfio-ccw-caps
> >
> > The companion QEMU
On 11/26/18 6:44 AM, David Gibson wrote:
> On Fri, Nov 23, 2018 at 11:28:24AM +0100, Cédric Le Goater wrote:
>> On 11/23/18 2:10 AM, David Gibson wrote:
>>> On Thu, Nov 22, 2018 at 05:50:07PM +1100, Benjamin Herrenschmidt wrote:
On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote:
>
On Fri, 23 Nov 2018 14:08:03 +0100
Pierre Morel wrote:
> On 22/11/2018 17:54, Cornelia Huck wrote:
> > Add a region to the vfio-ccw device that can be used to submit
> > asynchronous I/O instructions. ssch continues to be handled by the
> > existing I/O region; the new region handles hsch and csc
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ac5d25491f..c73dde10a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1887,6 +1887,7 @@ S: Supported
> F:
And also the g_malloc doesn't need check return value,
remove it.
Cc: qemu-triv...@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Signed-off-by: Li Qiang
---
target/i386/hax-all.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 28e5038c73..ac5d25491f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1846,12 +1846,
On 26/11/2018 10:56, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Markus Armbruster
> Signed-off-by: Li Qiang
> ---
> target/i386/hax-all.c | 15 +++
> 1
The following changes since commit 5298f4d67a911dd9cefa4c4185eed242074d64c2:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2018-11-23 08:54:52 +)
are available in the Git repository at:
https://github.com/gkurz/qemu.git tags/for-upstream
for you to fetch
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
target/i386/hax-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index 502ce6f0af..464744a406 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -205,7 +2
Hi Shameer,
On 11/23/18 5:28 PM, Shameerali Kolothum Thodi wrote:
>
>
>> -Original Message-
>> From: Qemu-devel [mailto:qemu-devel-
>> bounces+shameerali.kolothum.thodi=huawei@nongnu.org] On Behalf Of
>> Eric Auger
>> Sent: 21 September 2018 09:18
>> To: eric.auger@gmail.com; eri
When using the 9P2000.u version of the protocol, the following shell
command line in the guest can cause QEMU to crash:
while true; do rm -rf aa; mkdir -p a/b & touch a/b/c & mv a aa; done
With 9P2000.u, file renaming is handled by the WSTAT command. The
v9fs_wstat() function calls v9fs_compl
On Fri, 23 Nov 2018 15:13:12 +0100
Pierre Morel wrote:
> On 22/11/2018 17:54, Cornelia Huck wrote:
> > A vfio-ccw device may provide an async command subregion for
> > issuing halt/clear subchannel requests. If it is present, use
> > it for sending halt/clear request to the device; if not, fall
>
On Mon, Nov 26, 2018 at 09:07:32AM +, linzhecheng wrote:
>
>
> > -Original Message-
> > From: Gerd Hoffmann [mailto:kra...@redhat.com]
> > Sent: Monday, November 26, 2018 4:50 PM
> > To: linzhecheng
> > Cc: qemu-devel@nongnu.org; wangxin (U) ;
> > Zhoujian (jay)
> > Subject: Re: [Qe
Yuval Shaia writes:
> pvrdma requires that the same GID attached to it will be attached to the
> backend device in the host.
>
> A new QMP messages is defined so pvrdma device can broadcast any change
> made to its GID table. This event is captured by libvirt which in turn
> will update the GID t
The token field contains the (guest-filled) state of the qtd, which
indicates whenever the other fields are valid or not. So make sure
we read the token first, otherwise we may end up with an stale next
pointer:
(1) ehci reads next
(2) guest writes next
(3) guest writes token
(4) ehci rea
On Mon, Nov 26, 2018 at 11:01:59AM +0100, Markus Armbruster wrote:
> Yuval Shaia writes:
>
> > pvrdma requires that the same GID attached to it will be attached to the
> > backend device in the host.
> >
> > A new QMP messages is defined so pvrdma device can broadcast any change
> > made to its G
On Fri, Nov 23, 2018 at 02:46:46PM +0800, linzhecheng wrote:
> From: Wang Xin
>
> The cirrus bank0/1 offset should be updated before we update the vram's alias
> offset.
Queued for 3.1
thanks,
Gerd
On Tue, Nov 20, 2018 at 04:34:19PM +0800, linzhecheng wrote:
> If no kernel driver is active, we can already claim and perform I/O on
> it without detaching it.
Queued for 3.1
thanks,
Gerd
On Fri, 23 Nov 2018 11:10:01 -0500
"Michael S. Tsirkin" wrote:
> On Thu, Nov 22, 2018 at 11:29:33AM +0100, Igor Mammedov wrote:
> > AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp)
> > for checksum calculation isn't correct since we are adding extra 16 bytes.
> > But acpi
On 26/11/18 09:18, Xiao Guangrong wrote:
>>
>>> +static uint64_t get_free_request_bitmap(Threads *threads,
>>> ThreadLocal *thread)
>>> +{
>>> + uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap;
>>> +
>>> + request_fill_bitmap =
>>> atomic_rcu_read(&thread->request_fill_bitmap
Re-sending the comments, some of the recipients didn't get it,
Thanks,
Marcel
On 11/25/18 9:51 AM, Marcel Apfelbaum wrote:
On 11/22/18 2:14 PM, Yuval Shaia wrote:
Interface with the device is changed with the addition of support for
MAD packets.
Adjust documentation accordingly.
While there
在 2018/11/26 18:08, Gerd Hoffmann 写道:
> The token field contains the (guest-filled) state of the qtd, which
> indicates whenever the other fields are valid or not. So make sure
> we read the token first, otherwise we may end up with an stale next
> pointer:
>
>(1) ehci reads next
>(2) gue
AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp)
for checksum calculation isn't correct since we are adding extra 16 bytes.
But acpi_data_push() zeroes out table, so just by luck we are summing up
exta zeros which still yelds correct checksum.
Fix it up by explicitly stati
On Mon, Nov 26, 2018 at 11:31:25AM +0100, Igor Mammedov wrote:
> On Fri, 23 Nov 2018 11:11:50 -0500
> "Michael S. Tsirkin" wrote:
>
> > On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote:
> > > * arm/virt is broken but it looks like linux doesn't care, lets fix it
> > > anyways
> > >
Use a CONFDIR variable to show the configured sysconf path in the
generated documentations (html, man pages etc).
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1644985
Signed-off-by: Marc-André Lureau
---
Makefile | 9 ++---
qemu-ga.texi | 4 ++--
2 files changed, 8 insertions
On Fri, 23 Nov 2018 11:11:50 -0500
"Michael S. Tsirkin" wrote:
> On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote:
> > * arm/virt is broken but it looks like linux doesn't care, lets fix it
> > anyways
> > * x86, got lucky since we didn't use extended fields,
> >fix it so that
* Xiao Guangrong (guangrong.x...@gmail.com) wrote:
>
>
> On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote:
>
> > > +#include "qemu/osdep.h"
> > > +#include "qemu/bitmap.h"
> > > +#include "qemu/threaded-workqueue.h"
> > > +
> > > +#define SMP_CACHE_BYTES 64
> >
> > That's architecture dependen
Emilio G. Cota writes:
> On Fri, Nov 23, 2018 at 17:00:59 +, Alex Bennée wrote:
>>
>> Emilio G. Cota writes:
>>
>> > Signed-off-by: Emilio G. Cota
>> > ---
>> > accel/tcg/translate-all.c | 6 ++
>> > 1 file changed, 6 insertions(+)
>> >
>> > diff --git a/accel/tcg/translate-all.c b/a
Emilio G. Cota writes:
> On Thu, Nov 22, 2018 at 17:09:22 +, Alex Bennée wrote:
>>
>> Emilio G. Cota writes:
>>
>> > This will be used by plugin code to flush the code cache as well
>> > as doing other bookkeeping in a safe work environment.
>>
>> This seems a little excessive given the pl
Emilio G. Cota writes:
> On Fri, Nov 23, 2018 at 17:10:53 +, Alex Bennée wrote:
>> Emilio G. Cota writes:
> (snip)
>> > @@ -1322,12 +1323,21 @@ static void qemu_tcg_rr_wait_io_event(CPUState
>> > *cpu)
>> >
>> > static void qemu_wait_io_event(CPUState *cpu)
>> > {
>> > +bool asleep
On 11/26/18 6:39 AM, David Gibson wrote:
> On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote:
>>
>> +/*
>> + * Returns whether the event notification should be forwarded.
>> + */
>> +static bool xive_source_lsi_trigger(XiveSource *xsrc, uint32_t
>> srcno)
>
>>
Emilio G. Cota writes:
> On Thu, Nov 22, 2018 at 17:12:34 +, Alex Bennée wrote:
>>
>> Emilio G. Cota writes:
>>
>> > In preparation for plugin support.
>> >
>> > Signed-off-by: Emilio G. Cota
>>
>> More macros for the macro-god. I guess this works but I wonder if it's
>> possible to do a
Li Qiang writes:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Markus Armbruster
> Signed-off-by: Li Qiang
Reviewed-by: Alex Bennée
> ---
> target/i386/hax-all.c | 15 +++---
Kevin Wolf (2):
block: Don't inactivate children before parents
iotests: Test migration with -blockdev
block.c| 22
tests/qemu-iotests/234 | 105 +
tests/qemu-iotests/234.out | 27 ++
tests/qemu-iotests/group |
bdrv_child_cb_inactivate() asserts that parents are already inactive
when children get inactivated. This precondition is necessary because
parents could still issue requests in their inactivation code.
When block nodes are created individually with -blockdev, all of them
are monitor owned and will
Check that block node activation and inactivation works with a block
graph that is built with individually created nodes.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/234 | 105 +
tests/qemu-iotests/234.out | 27 ++
tests/qemu-iotests/group
Add pvpanic device in arm virt machine.
Signed-off-by: Peng Hao
---
default-configs/arm-softmmu.mak | 1 +
hw/arm/virt.c | 21 +
include/hw/arm/virt.h | 1 +
3 files changed, 23 insertions(+)
diff --git a/default-configs/arm-softmmu.mak b/defaul
From: Philippe Mathieu-Daudé
To ease the MMIO device addition in the next patch, rename:
- ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE.
- MemoryRegion io -> mr.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Peng Hao
---
hw/misc/pvpanic.c | 28
1 file changed,
The first patches are simple cleanups:
- patch 1 move the pvpanic device with the 'ocmmon objects' so we compile
it once for the x86/arm/aarch64 archs,
- patch 2 simply renames ISA fields/definitions to generic ones.
Then instead of add/use the MMIO pvpanic device in
From: Philippe Mathieu-Daudé
The 'pvpanic' ISA device can be use by any machine with an ISA bus.
Reviewed-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Peng Hao
---
hw/misc/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/Make
Prepare for pvpanic-mmio configure interface.
Signed-off-by: Peng Hao
---
hw/arm/sysbus-fdt.c | 2 ++
hw/arm/virt.c | 1 +
hw/misc/pvpanic.c | 10 +-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c
index ad698d4..34577f3
Add pvpanic new type "TYPE_PVPANIC_MMIO"
Signed-off-by: Peng Hao
---
hw/misc/pvpanic.c | 50 +++
include/hw/misc/pvpanic.h | 1 +
2 files changed, 47 insertions(+), 4 deletions(-)
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 0f23a
Add configure query interface for pvpanic-mmio.
Signed-off-by: Peng Hao
---
include/hw/misc/pvpanic.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/hw/misc/pvpanic.h b/include/hw/misc/pvpanic.h
index f1a05b2..2f0e9f4 100644
--- a/include/hw/misc/pvpanic.h
+++ b/include/hw/misc
Add pvpanic device in virt acpi table, so when kenrel command line
uses acpi=force, kernel can get info from acpi table.
Signed-off-by: Peng Hao
---
hw/arm/virt-acpi-build.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
i
Add configure interface for pvpanic-mmio. In qemu command line
use -device pvpanic-mmio to enable the device.
Signed-off-by: Peng Hao
---
hw/arm/virt-acpi-build.c | 4 +++-
hw/arm/virt.c| 9 -
hw/misc/pvpanic.c| 1 +
3 files changed, 8 insertions(+), 6 deletions(-)
d
Add mmio support info in docs/specs/pvpanic.txt.
Signed-off-by: Peng Hao
---
docs/specs/pvpanic.txt | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
index c7bbacc..67f5591 100644
--- a/docs/specs/pvpanic.txt
+++
On Sun, 25 Nov 2018 at 23:12, Max Filippov wrote:
>
> Hi Peter,
>
> please pull the following batch of fixes for target/xtensa.
>
> The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16:
>
> Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +)
>
> are available
Peter Maydell writes:
> On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote:
>>
>> Hi Peter,
>> Thanks for the review and comments.
>>
>> >
>> > On 8 November 2018 at 10:29, Dongjiu Geng wrote:
>> > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset)
>> >
>> > What is this a
Li Qiang writes:
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
Reviewed-by: Alex Bennée
> ---
> target/i386/hax-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index 502ce6f0af..464744a406 100644
> -
On 26.11.18 12:28, Kevin Wolf wrote:
> bdrv_child_cb_inactivate() asserts that parents are already inactive
> when children get inactivated. This precondition is necessary because
> parents could still issue requests in their inactivation code.
>
> When block nodes are created individually with -b
On Sat, 24 Nov 2018 20:36:54 -
GH Cao <1804...@bugs.launchpad.net> wrote:
> ** Description changed:
>
> When I emulate a virt-3.0 machine, Windows 10 BSoD on boot, with the
> error code being ACPI_BIOS_ERROR(0x00A5), virt-2.12 boots fine.
>
> Windows Build: 10.0.17134.1
> QEMU
On 23/11/2018 7:04 PM, Vladimir Sementsov-Ogievskiy wrote:
> 31.10.2018 14:34, Anton Nefedov wrote:
>> This adds some protection from accounting unitialized cookie.
>
> uninitialized
>
fixed
>> That is, block_acct_failed/done without previous block_acct_start;
>> in that case, cookie probably
On 23/11/2018 9:25 PM, Vladimir Sementsov-Ogievskiy wrote:
> 31.10.2018 14:34, Anton Nefedov wrote:
>> Signed-off-by: Anton Nefedov
>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy
>
> but be careful: on git am, the chunk about read-only case goes into
> scsi_disk_emulate_write_same instead
Am 26.11.2018 um 13:05 hat Max Reitz geschrieben:
> On 26.11.18 12:28, Kevin Wolf wrote:
> > bdrv_child_cb_inactivate() asserts that parents are already inactive
> > when children get inactivated. This precondition is necessary because
> > parents could still issue requests in their inactivation co
On 26.11.18 13:05, Max Reitz wrote:
> On 26.11.18 12:28, Kevin Wolf wrote:
>> bdrv_child_cb_inactivate() asserts that parents are already inactive
>> when children get inactivated. This precondition is necessary because
>> parents could still issue requests in their inactivation code.
>>
>> When bl
On Mon, 26 Nov 2018 at 09:57, Greg Kurz wrote:
>
> The following changes since commit 5298f4d67a911dd9cefa4c4185eed242074d64c2:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2018-11-23 08:54:52 +)
>
> are available in the Git repository at:
>
> https:/
Hi,
This series is based on previously discussed "[PATCH v4 00/29]
vhost-user for input & GPU" and "vhost-user: define conventions for
vhost-user backends" work. The GPU part is left off for now.
This series introduces a "vhost-user-backend": a convenience object
for vhost-user devices, for commo
Take a VhostUserState* that can be pre-allocated, and initialize it
with the associated chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Tiwei Bie
---
include/hw/virtio/vhost-user-blk.h | 2 +-
include/hw/virtio/vhost-user-scsi.h | 2 +-
include/hw/virtio/vhost-user.h | 2 +-
bac
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user
no longer panics on disconnect (rc == 0), and instead silently ignores
an invalid VHOST_USER_NONE message.
Without extra work from the API user, this will simply busy-loop on
HUP events. The obvious thing to do is to exit(0) inst
Create a vhost-user-backend object that holds a connection to a
vhost-user backend and can be referenced from virtio devices that
support it. See later patches for input & gpu usage.
A chardev must be specified to communicate with the vhost-user
backend, ex: -chardev socket,id=char0,path=/tmp/foo.
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
review, let's define a common set of backend conventions to help with
management layer implementation, and interoperability.
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
---
MAINTAINERS | 1
Simplify the creation of FD sources for other users. This is just
convenience to avoid duplicating similar code elsewhere.
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user-glib.h | 3 +++
contrib/libvhost-user/libvhost-user-glib.c | 11 ++-
2 files changed, 9 ins
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
hw/virtio/vhost-user.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 90a9492bcf..0131bbb0fc 100644
--- a/hw/virtio/vhost-user.c
++
On 26.11.18 13:33, Kevin Wolf wrote:
> Am 26.11.2018 um 13:05 hat Max Reitz geschrieben:
>> On 26.11.18 12:28, Kevin Wolf wrote:
>>> bdrv_child_cb_inactivate() asserts that parents are already inactive
>>> when children get inactivated. This precondition is necessary because
>>> parents could still
Split vhost_user_read(), so only header can be read with
vhost_user_read_header().
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
---
hw/virtio/vhost-user.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/hw/virtio/vhost-user.c
vhost-user-input will make use of this function to undo some queue pop
in case the virtio queue does not have enough room.
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user.h | 14 ++
contrib/libvhost-user/libvhost-user.c | 16
2 files changed,
Ask vhost user input backend the list of virtio_input_config.
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user.h | 1 +
include/hw/virtio/vhost-backend.h | 4 ++
hw/virtio/vhost-user.c| 60 +++
docs/interop/vhost-user.txt
On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote:
> On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias
> wrote:
> > Not sure if it's too late to even get the removal of the assert into this
> > release? Peter?
>
> If you're happy that removing the assert is the correct fix,
> yes, this
Add a new virtio-input device, which connects to a vhost-user
backend. Usage:
-object vhost-user-backend,id=vuid,chardev=... \
-device vhost-user-input-pci,vhost-user=vuid
vhost-user-input is similar to virtio-input-host, it is wrapped by
vhost-user-input-pci. Instead of reading configuration dir
On 23/11/2018 10:21 PM, Vladimir Sementsov-Ogievskiy wrote:
> 31.10.2018 14:35, Anton Nefedov wrote:
>> A block driver can provide a callback to report driver-specific
>> statistics.
>>
>> file-posix driver now reports discard statistics
>>
>> Signed-off-by: Anton Nefedov
>> ---
>>qapi/block-c
Add a vhost-user input backend example, based on virtio-input-host
device. It takes an evdev path as argument, and can be associated with
a vhost-user-backend object, for example via a unix socket:
$ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock
$ qemu ... -chardev socket,id=vuic,path=/t
On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote:
> QEMUMachine launches the VM with a monitor enabled, afterwards
> a qmp connection is attempted on _post_launch(). In case
> the QEMU process exits with an error, qmp.accept() reaches
> timeout and raises an exception.
>
On Fri, Nov 23, 2018 at 10:09:53PM +, Felipe Franciosi wrote:
> Hi Alex,
>
> I'm also terribly sorry for the delay in responding to this. I'm only now
> having the time resources to come back to this topic and figure out a way
> forward with my proposal. Please see my notes below (quoting on
On Mon, Nov 26, 2018 at 12:34:41PM +0200, Marcel Apfelbaum wrote:
> Re-sending the comments, some of the recipients didn't get it,
>
> Thanks,
> Marcel
>
> On 11/25/18 9:51 AM, Marcel Apfelbaum wrote:
> >
> >
> > On 11/22/18 2:14 PM, Yuval Shaia wrote:
> > > Interface with the device is changed
On Tue, 20 Nov 2018 15:48:06 +0800
Zhang Yi wrote:
> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
>
> Signed-off-by: Zhang Yi
Reviewed-by: Igor Mammedov
> ---
> numa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/numa.c b/numa.c
>
vhost does not have to be supported only if KVM is present, in fact
vhost-user does not even need any kind of kernel support. This series
changes this. The rationale is that, when vhost-user-test.c will be
converted to qgraph, it will be able to test vhost-user support
for virtio-mmio backend eve
vhost-user does not depend on Linux; it can run on any POSIX system. Restrict
vhost-kernel to Linux in hw/virtio/vhost-backend.c, everything else can be
compiled on all POSIX systems.
Signed-off-by: Paolo Bonzini
---
backends/Makefile.objs | 5 ++---
default-configs/virtio.mak | 4 ++--
h
This shows a preexisting bug: if a KVM target did not have virtio-net enabled,
it would fail with undefined symbols when vhost was enabled. This must now
be fixed, lest targets that have no virtio-net fail to compile.
Signed-off-by: Paolo Bonzini
---
configure | 11 ---
hw/
hw/net/vhost_net.c needs functions that are declared in net/vhost-user.c: the
vhost-user code is always compiled into QEMU, only the constructor
net_init_vhost_user is unreachable. Also, net/vhost-user.c needs functions
declared in hw/virtio/vhost-stub.c even if no virtio device exists.
Break thi
There is no reason for CONFIG_VHOST_NET to be specific to a single target;
it is a host feature that can be add to all targets, as long as they support
the virtio-net device. Currently CONFIG_VHOST_NET depends on CONFIG_KVM,
but ioeventfd support is present in the core memory API and works with
ot
On 11/26/2018 01:59 PM, Stefan Hajnoczi wrote:
On Fri, Nov 23, 2018 at 10:09:53PM +, Felipe Franciosi wrote:
Hi Alex,
I'm also terribly sorry for the delay in responding to this. I'm only now
having the time resources to come back to this topic and figure out a way
forward with my proposa
Detect all invalid configurations (e.g. mingw32 with vhost-user,
non-Linux with vhost-kernel). As a collateral benefit, all vhost-kernel
backends can be now disabled if one wants to reduce the attack surface.
Signed-off-by: Paolo Bonzini
---
configure | 88 ++
On Wed, 7 Nov 2018 16:36:48 +0400
Marc-André Lureau wrote:
> It's now possible to use the common function.
>
> Teach object_apply_global_props() to warn if Error argument is NULL.
>
> Signed-off-by: Marc-André Lureau
> ---
> hw/core/qdev-properties.c | 24 ++--
> qom/obje
On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Eduardo,
>
> On 23/11/18 19:10, Eduardo Habkost wrote:
> > Hi,
> >
> > Sorry for not reviewing this series earlier. I just stumbled
> > upon this part of the code:
> >
> > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Stefan Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 007f89f126..4e396cbe71 100644
> --- a/MAINTAINERS
> +++ b/M
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAI
On Thu, 22 Nov 2018 at 18:01, Eric Auger wrote:
>
> Add a new ARM SMMU section and set Eric Auger as the maintainer
> for ARM SMMU emulation sources.
>
> Signed-off-by: Eric Auger
> Suggested-by: Peter Maydell
> ---
> MAINTAINERS | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/M
On Mon, 26 Nov 2018 at 12:52, Edgar E. Iglesias
wrote:
>
> On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote:
> > On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias
> > wrote:
> > > Not sure if it's too late to even get the removal of the assert into this
> > > release? Peter?
> >
> > I
On Tue, Nov 6, 2018 at 4:41 PM Artem Pisarenko
wrote:
>
> Validate that frontend callbacks for CHR_EVENT_OPENED/CHR_EVENT_CLOSED
> events are being issued when expected and in strictly pairing order.
>
> Signed-off-by: Artem Pisarenko
Reviewed-by: Marc-André Lureau
> ---
> tests/test-char.c |
On Tue, Nov 6, 2018 at 4:41 PM Artem Pisarenko
wrote:
>
> When chardev is multiplexed (mux=on) there are a lot of cases where
> CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from
> frontend side) is broken. There are either generation of multiple
> repeated or extra CHR_EVENT_OPENED e
On Wed, 7 Nov 2018 16:36:49 +0400
Marc-André Lureau wrote:
> The following patches are going to implement post_init callbacks for
> settings properties. The interface post_init are called before the
> instance post_init, so the default interface behaviour can be
> overriden if necessary.
CCing
1 - 100 of 352 matches
Mail list logo
