>>>> + */ >>>> + >>>> +#ifndef PPC_XIVE_H >>>> +#define PPC_XIVE_H >>>> + >>>> +#include "hw/sysbus.h" >>> >>> So, I'm a bit dubious about making the XiveSource a SysBus device - >>> I'm concerned it won't play well with tying it into the other devices >>> like PHB that "own" it in real hardware. >> >> It does but I can take a look at changing it to a DeviceState. The >> reset handlers might be a concern. > > As "non bus" device I think you'd need to register your own reset > handler rather than just setting dc->reset. Otherwise, I think that > should work.
I removed from XIVE the SysBus dependencies and indeed it's better not to rely on the default reset and mapping behavior of sysbus. I am addressing your comments in a WIP v6 branch on github. C.
