On Mon, Nov 26, 2018 at 11:31:25AM +0100, Igor Mammedov wrote: > On Fri, 23 Nov 2018 11:11:50 -0500 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote: > > > * arm/virt is broken but it looks like linux doesn't care, lets fix it > > > anyways > > > * x86, got lucky since we didn't use extended fields, > > > fix it so that it will calculate checksum using correct length > > > so that it would be easier to unify arm/x86 into one impl. > > > > > > > I'd say patch 2 should go into this release. > > What about patch 1? It's cosmetic and it isn't the best we can do. > > > > Let me know whether you agree. > I'd say they are both 'cosmetic' as they don't cause guest > failure nor even warning (linux doesn't care (so far) and > we don't have windows for ARM to verify extended checksum). > So we don't have to delay release for both of them. Agreed.
> I assumed that Samuel, would include patches in his RSDP > refactoring series and we would merge them as whole later on. That's correct, yes. Cheers, Samuel.
