Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-28 Thread Yi Zhang
On 2018-08-24 at 20:14:37 +0300, Michael S. Tsirkin wrote: > On Fri, Aug 24, 2018 at 05:57:06PM +0100, Peter Maydell wrote: > > On 24 August 2018 at 17:53, Michael S. Tsirkin wrote: > > > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: > > >> object_get_canonical_path_component() re

Re: [Qemu-devel] [3/4] cpus: protect TimerState writes with a spinlock

2018-08-28 Thread Pavel Dovgalyuk
Hi, Paolo! Seems that this one breaks the record/replay. > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > In the next patch, we will need to write cpu_ticks_offset from any > thread, even outside the BQL. Currently, it is protected by the BQL > just because cpu_enable_ticks and cpu_disable_t

[Qemu-devel] [RFC V1] hw/pci/pci_example.c : Added a new pci device

2018-08-28 Thread Yoni Bettan
- this is a simple example of how to write a pci device that supports portio, mmio, irq and dma Signed-off-by: Yoni Bettan --- hw/pci/Makefile.objs | 1 + hw/pci/pci_example.c | 309 +++ 2 files changed, 310 insertions(+) create mode 100644 hw

Re: [Qemu-devel] [PATCH V11 16/20] filter: Add handle_event method for NetFilterClass

2018-08-28 Thread Jason Wang
On 2018年08月24日 13:57, Zhang Chen wrote: On Wed, Aug 22, 2018 at 4:22 PM Jason Wang wrote: On 2018年08月21日 17:25, Zhang Chen wrote: On Tue, Aug 21, 2018 at 11:30 AM Jason Wang wrote: On 2018年08月12日 04:59, Zhang Chen wrote: Filter needs to process the event of checkpoint/failover or other

[Qemu-devel] [PATCH 1/1] hostmem-file: fixed the memory leak while get pmem path.

2018-08-28 Thread Zhang Yi
object_get_canonical_path_component() returns a string which must be freed using g_free(). Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin Signed-off-by: Zhang Yi --- backends/hostmem-file.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/backends/ho

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-28 Thread  Christian Ehrhardt 
Note: The code change already passed the general regression checks on the identical content against a PPA (Also on the weekend prior to the full maturing period I'll have another automated run on proposed). -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

2018-08-28 Thread Daniel P . Berrangé
On Mon, Aug 27, 2018 at 12:53:21PM +0200, Gerd Hoffmann wrote: > Hi, > > > The only way we can stop using "-device sga" is if we either have > > something explicit in the XML saying whether to use it or not, or > > alternatively have some indicator associated with the next versioned > > machine

Re: [Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-28 Thread Daniel P . Berrangé
On Mon, Aug 27, 2018 at 09:41:02PM +0300, Julia Suvorova wrote: > New option "websock" added to allow using websocket protocol for > chardev socket backend. > Example: > -chardev socket,websock,id=... > > Signed-off-by: Julia Suvorova > --- > chardev/char-socket.c | 124 +

Re: [Qemu-devel] [PATCH v2 2/2] tests/test-char: Check websocket chardev functionality

2018-08-28 Thread Daniel P . Berrangé
On Mon, Aug 27, 2018 at 09:41:03PM +0300, Julia Suvorova wrote: > Test order: > Creating server websocket chardev > Creating usual tcp chardev client > Sending handshake message from client > Receiving handshake reply > Sending ping frame with "hello" payload > Receiving pon

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > terminal3270 is uses the front-end side of the chardev. It shouldn't > > create sources from backend side context. Fwiw, send_timing_mark_cb > > calls qemu_chr_fe_write_al

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-28 Thread  Christian Ehrhardt 
Running the Bionic ISO like: $ qemu-system-x86_64 -cpu host -smp cores=4,threads=2 -boot d -m 2048 -enable-kvm -vga qxl -vnc :21 -cdrom ubuntu-18.04-desktop-amd64.iso Attaching like: $ vncviewer FullColor=1 AutoSelect=0 10.245.168.42:5921 (alternatives on tigervnc) Well for me it had "-k de" as w

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-28 Thread  Christian Ehrhardt 
Thanks Leonardo for your check as well! I agree that this particular issue here is fixed as we hoped. The other one with the freeze did not occur for me, you might open another bug if you have any pointers how we could go on on this. -- You received this bug notification because you are a member

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-28 Thread  Christian Ehrhardt 
Arr reading is hard today, you had the other bug open already ... grml :-) Never the less - This bug here is fixed in the proposed version and for now that is the important part. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [Qemu-devel] Guest crash when VNC connection is established with password (QEMU 2.5.1.1)

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 09:01:24AM +0800, John Y. wrote: > (Sorry for repost, I had asked in qemu-stable, but someone told me that I > should send to qemu-devel.) > > After I updated my Centos to 7.5.1804, my virtual machine crashed when I > connected with vnc password. [snip] > > (qemu) change

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-28 Thread  Christian Ehrhardt 
Subscribed there as well now to stay on top of it if upstream gets to a conclusion. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755912 Title: qemu-system-x86_64 crashed with SIGABRT when using o

Re: [Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 01:04:41PM +0300, Julia Suvorova wrote: > On 28.08.2018 12:02, Daniel P. Berrangé wrote: > > On Mon, Aug 27, 2018 at 09:41:02PM +0300, Julia Suvorova wrote: > > > New option "websock" added to allow using websocket protocol for > > > chardev socket backend. > > > Example: >

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-28 Thread Gerd Hoffmann
Hi, > > Where is the pxb-pcie device? :$somewhere? Or $domain:00:00.0? > > :$somewhere (On PCI domain 0) Cool, so we don't have an chicken-and-egg issue. > > If we can access pxb-pcie registers before configuring MMCFG then yes, > > we should use pxb-pcie registers for that. > > Y

Re: [Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-28 Thread Julia Suvorova via Qemu-devel
On 28.08.2018 13:09, Daniel P. Berrangé wrote: On Tue, Aug 28, 2018 at 01:04:41PM +0300, Julia Suvorova wrote: On 28.08.2018 12:02, Daniel P. Berrangé wrote: On Mon, Aug 27, 2018 at 09:41:02PM +0300, Julia Suvorova wrote: New option "websock" added to allow using websocket protocol for chardev

Re: [Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-28 Thread Julia Suvorova via Qemu-devel
On 28.08.2018 12:02, Daniel P. Berrangé wrote: On Mon, Aug 27, 2018 at 09:41:02PM +0300, Julia Suvorova wrote: New option "websock" added to allow using websocket protocol for chardev socket backend. Example: -chardev socket,websock,id=... Signed-off-by: Julia Suvorova --- chardev/char-

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

2018-08-28 Thread Gerd Hoffmann
On Tue, Aug 28, 2018 at 09:19:20AM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 27, 2018 at 12:53:21PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > The only way we can stop using "-device sga" is if we either have > > > something explicit in the XML saying whether to use it or not, or > > > a

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Peter Xu
On Tue, Aug 28, 2018 at 11:09:28AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > > terminal3270 is uses the front-end side of the chardev. It shouldn't > > > create sources fr

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-28 Thread Denis Plotnikov
On 27.08.2018 19:05, John Snow wrote: On 08/27/2018 03:05 AM, Denis Plotnikov wrote: PING! PING! Sorry, Kevin and Stefan are both on PTO right now, I think. I can't promise I have the time to look soon, but you at least deserve an answer for the radio silence the last week. --js Thanks

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 12:20 PM Peter Xu wrote: > > On Tue, Aug 28, 2018 at 11:09:28AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > > > > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > > > terminal3270 is uses th

Re: [Qemu-devel] [PATCH v2 1/2] chardev: Add websocket support

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 01:18:19PM +0300, Julia Suvorova wrote: > On 28.08.2018 13:09, Daniel P. Berrangé wrote: > > On Tue, Aug 28, 2018 at 01:04:41PM +0300, Julia Suvorova wrote: > > > On 28.08.2018 12:02, Daniel P. Berrangé wrote: > > > > On Mon, Aug 27, 2018 at 09:41:02PM +0300, Julia Suvorova

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 12:20:02PM +0200, Gerd Hoffmann wrote: > On Tue, Aug 28, 2018 at 09:19:20AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 27, 2018 at 12:53:21PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > The only way we can stop using "-device sga" is if we either have > > >

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-28 Thread Marc-André Lureau
Hi On Fri, Jul 13, 2018 at 3:12 PM Marc-André Lureau wrote: > > Hi, > > vhost-user allows to drive a virtio device in a seperate > process. After vhost-user-net, we have seen > vhost-user-{scsi,blk,crypto} added more recently. > > This series, initially proposed 2 years ago > (https://lists.gnu.o

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Marc-André Lureau
ping On Fri, Aug 17, 2018 at 7:32 PM Marc-André Lureau wrote: > > VNC server is calling sasl_server_init() during startup of QEMU, even > if SASL auth has not been enabled. > > This may create undesirable warnings like "Could not find keytab file: > /etc/qemu/krb5.tab" when the user didn't configu

Re: [Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-08-28 Thread Marc-André Lureau
ping On Tue, Aug 21, 2018 at 12:07 PM Marc-André Lureau wrote: > > -object iothread,id=foo,? will crash qemu: > > qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion > `cond->initialized' failed. > > Use thread_id != -1 to check if iothread_complete() finished > successfully

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 07:31:03PM +0200, Marc-André Lureau wrote: > VNC server is calling sasl_server_init() during startup of QEMU, even > if SASL auth has not been enabled. > > This may create undesirable warnings like "Could not find keytab file: > /etc/qemu/krb5.tab" when the user didn't conf

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Gerd Hoffmann
On Tue, Aug 28, 2018 at 12:57:56PM +0200, Marc-André Lureau wrote: > ping patchew flagged a codestyle issue, I've expected to see a v2 with that fixed ... cheers, Gerd

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 2/2] target: arm: Add support for VCPU event states

2018-08-28 Thread Shannon Zhao
Hi, On 8/28/2018 4:46 AM, Dongjiu Geng wrote: This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. And also it can support the exception state migration. Signed-off-by: Dongjiu Geng --- change since v6: 1. Add

[Qemu-devel] [PATCH 2/2] qapi: Update docs for generator changes since commit 9ee86b85267

2018-08-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 131 ++- 1 file changed, 100 insertions(+), 31 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index c2e11465f0..49149f495a 100644 --- a/docs/devel/qapi-code-

[Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update

2018-08-28 Thread Markus Armbruster
Markus Armbruster (2): qapi: Emit a blank line before dummy declaration qapi: Update docs for generator changes since commit 9ee86b85267 docs/devel/qapi-code-gen.txt | 131 ++- scripts/qapi/common.py | 1 + 2 files changed, 101 insertions(+), 31 deletio

[Qemu-devel] [PATCH 1/2] qapi: Emit a blank line before dummy declaration

2018-08-28 Thread Markus Armbruster
We emit a dummy variable in each .c file "to shut up OSX toolchain warnings about empty .o files" (commit 252dc3105fc). Separate it from the code preceding it (if any) with a blank line. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 2:05 AM Michael Roth wrote: > > Quoting Marc-André Lureau (2018-08-25 08:57:23) > > Simplify the code around qmp_dispatch(): > > - rely on qmp_dispatch/check_obj() for message checking > > - have a single send_response() point > > - constify send_response() argument > >

Re: [Qemu-devel] [RFC v3 0/2] kvm "fake DAX" device flushing

2018-08-28 Thread David Hildenbrand
On 13.07.2018 09:52, Pankaj Gupta wrote: > This is RFC V3 for 'fake DAX' flushing interface sharing > for review. This patchset has two parts: > > - Guest virtio-pmem driver > Guest driver reads persistent memory range from paravirt device > and registers with 'nvdimm_bus'. 'nvdimm/pmem' driv

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Minor introspect.py cleanups

2018-08-28 Thread Markus Armbruster
Eric Blake writes: > Commit 7d0f982b changed generated introspection output to no longer > produce long lines in the generated .c file, but failed to adjust > comments to match. Add some clarity that the shorter length that > matters most is the overall QMP response on the wire. > > Commit 25b1e

Re: [Qemu-devel] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:34:58 PM CEST, Max Reitz wrote: > Before this patch, bdrv_refresh_filename() is used in a pushing manner: > Whenever the BDS graph is modified, the parents of the modified edges > are supposed to be updated (recursively upwards). However, that is > nonviable, considering that

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device specification

2018-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2018 at 03:31:02AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 24, 2018 8:54 PM > > > > On Fri, Aug 24, 2018 at 12:07:44PM +, Gonglei (Arei) wrote: > > > Hi Michael, > > > > > > >

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Add comments to aid debugging generated introspection

2018-08-28 Thread Markus Armbruster
Eric Blake writes: > We consciously chose in commit 1a9a507b to hide QAPI type names > from the introspection output on the wire, but added a command > line option -u to unmask the type name when doing a debug build. > The unmask option still remains useful to some other forms of > automated anal

Re: [Qemu-devel] [PATCH for-3.1 v10 02/31] block: Use children list in bdrv_refresh_filename

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:34:59 PM CEST, Max Reitz wrote: > bdrv_refresh_filename() should invoke itself recursively on all > children, not just on file. > > With that change, we can remove the manual invocations in blkverify, > quorum, commit, mirror, and blklogwrites. > > Signed-off-by: Max Reitz R

[Qemu-devel] [PATCH 1/3] qemu-error: add {error, warn}_report_once_cond

2018-08-28 Thread Cornelia Huck
Add two functions to print an error/warning report once depending on a passed-in condition variable and flip it if printed. This is useful if you want to print a message not once-globally, but e.g. once-per-device. Inspired by warn_once() in hw/vfio/ccw.c. Signed-off-by: Cornelia Huck --- inclu

[Qemu-devel] [PATCH 0/3] qemu-error: advanced report_once handling

2018-08-28 Thread Cornelia Huck
Based on previous discussions, I wanted to enhance the recently merged report_once infrastucture with a way to print a message once based on a variable instead of globally-once, similar to what vfio-ccw uses today. Not really tested, mainly wanted to get this out before my vacation to get the ball

[Qemu-devel] [PATCH 3/3] vfio-ccw: switch to warn_report_once_cond()

2018-08-28 Thread Cornelia Huck
We can replace the local function with the new common interface. Signed-off-by: Cornelia Huck --- hw/vfio/ccw.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index e96bbdc78b..9246729a75 100644 --- a/hw/vfio/ccw.c +++ b/hw/v

[Qemu-devel] [PATCH 2/3] qemu-error: make use of {error, warn}_report_once_cond

2018-08-28 Thread Cornelia Huck
{error,warn}_report_once() are a special case of the new functions and can simply switch to them. Signed-off-by: Cornelia Huck --- include/qemu/error-report.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h

Re: [Qemu-devel] [RFC v3 0/2] kvm "fake DAX" device flushing

2018-08-28 Thread Pankaj Gupta
Hi David, > > for review. This patchset has two parts: > > > > - Guest virtio-pmem driver > > Guest driver reads persistent memory range from paravirt device > > and registers with 'nvdimm_bus'. 'nvdimm/pmem' driver uses this > > information to allocate persistent memory range. Also, we h

[Qemu-devel] Telling qemu to run for a number of guest milliseconds and then pause

2018-08-28 Thread Martin Schroeder via Qemu-devel
I'm working on an interface between qemu and an in house testing suite and one of the things I would like to do is tell qemu to run the guest for a number of guest milliseconds and then pause execution of the guest. I do not want qemu to raise a debug exception. I just want it to pause (ie sleep o

[Qemu-devel] [PATCH v3 4/8] target/mips: Add MXU instruction S8LDD

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the S8LDD MXU instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used deposit_tl instructions instead of shift and bitmask v3 - Split gen_mxu function into command specific gen_mxu_ functions

[Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Craig Janeczek via Qemu-devel
This commit makes the MXU registers and the utility functions for reading/writing to them. This is required for full MXU instruction support. Adds support for emulating the S32I2M and S32M2I MXU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - Fix checkpatch.pl e

Re: [Qemu-devel] [PATCH for-3.1 v10 18/31] block/nfs: Implement bdrv_dirname()

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:15 PM CEST, Max Reitz wrote: > While the basic idea is obvious and could be handled by the default > bdrv_dirname() implementation, we cannot generate a directory name if > the gid or uid are set, so we have to explicitly return NULL in those > cases. > > Signed-off-by: Max

[Qemu-devel] [PATCH v3 6/8] target/mips: Add MXU instruction D16MAC

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the D16MAC instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used sextract_tl instructions instead of shift and ext v3 - Split gen_mxu function into command specific gen_mxu_ functions targe

[Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Craig Janeczek via Qemu-devel
Define and initialize the 16 MXU registers. Signed-off-by: Craig Janeczek --- v1 - NA v2 - NA v3 - Initial patch, split out from prior first patch target/mips/cpu.h | 1 + target/mips/translate.c | 16 2 files changed, 17 insertions(+) diff --git a/target

[Qemu-devel] [PATCH v3 0/8] Add limited MXU instruction support

2018-08-28 Thread Craig Janeczek via Qemu-devel
This patch set begins to add MXU instruction support for mips emulation. Craig Janeczek (8): target/mips: Introduce MXU registers target/mips: Add all MXU opcodes target/mips: Add MXU instructions S32I2M and S32M2I target/mips: Add MXU instruction S8LDD target/mips: Add MXU instruction D

[Qemu-devel] [PATCH v3 7/8] target/mips: Add MXU instructions Q8MUL and Q8MULSU

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the Q8MUL and Q8MULSU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 v3 - Split gen_mxu function into command specific gen_mxu_ functions target/mips/translate.c | 86 +

[Qemu-devel] [PATCH v3 5/8] target/mips: Add MXU instruction D16MUL

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the D16MUL instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used sextract_tl instructions instead of shift and ext v3 - Split gen_mxu function into command specific gen_mxu_ functions targe

[Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with existing misc and Loongson 2F copcodes. The enums were updated to reflect the multiple possible meanings where applicable. Signed-off-by: Craig Janeczek --- v1 - NA v2 - NA v3 - Initial patch, split out from prio

Re: [Qemu-devel] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info()

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:04 PM CEST, Max Reitz wrote: > This function queries a node; since we cannot do that right now, it > executes query-named-block-nodes and returns the matching node's object. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 10 ++ > 1 file chang

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device specification

2018-08-28 Thread Gonglei (Arei)
> > On Tue, Aug 28, 2018 at 03:31:02AM +, Gonglei (Arei) wrote: > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Friday, August 24, 2018 8:54 PM > > > > > > On Fri, Aug 24, 2018 at 12:07:44PM +, Gonglei (Arei) wrote: > > > > Hi Michae

[Qemu-devel] [PATCH v3 8/8] target/mips: Add MXU instructions S32LDD and S32LDDR

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the S32LDD and S32LDDR MXU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 v3 - Split gen_mxu function into command specific gen_mxu_ functions target/mips/translate.c | 47

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-28 Thread Igor Mammedov
On Tue, 28 Aug 2018 10:52:37 +1000 David Gibson wrote: > On Mon, Aug 27, 2018 at 04:02:39PM +0200, Greg Kurz wrote: > > On Mon, 27 Aug 2018 13:07:10 +0200 > > Igor Mammedov wrote: > > > > > The first cpu unplug wasn't ever supported and corresponding > > > monitor/qmp commands refuse to unplu

Re: [Qemu-devel] [PATCH v4 06/29] libvhost-user: exit by default on VHOST_USER_NONE

2018-08-28 Thread Jens Freimann
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user no longer panics on disconnect (rc == 0), and instead silently ignores an invalid VHOST_USER_NONE message. Without extra work from the API user, this will simply busy-loop on HUP events. The obvious thing to do is to exit(0) ins

[Qemu-devel] [PATCH v3] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid option

Re: [Qemu-devel] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote: > +backing_overridden = bdrv_backing_overridden(bs); > + > +if (bs->open_flags & BDRV_O_NO_IO) { > +/* Without I/O, the backing file does not change anything. > + * Therefore, in such a case (primarily qemu-img), we can >

Re: [Qemu-devel] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:26 PM CEST, Max Reitz wrote: > While we cannot represent the latency-ns option in a filename, it is not > a strong option so not being able to should not stop us from generating > a filename nonetheless. > > Signed-off-by: Max Reitz I thought I had reviewed this one alrea

Re: [Qemu-devel] [PATCH v3] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Andrew Jones
On Tue, Aug 28, 2018 at 03:26:07PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [PATCH for-3.1 v10 19/31] block: Use bdrv_dirname() for relative filenames

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:16 PM CEST, Max Reitz wrote: > bdrv_get_full_backing_filename_from_filename() breaks down when it comes > to JSON filenames. Using bdrv_dirname() as the basis is better because > since we have BDS, we can descend through the BDS tree to the protocol > layer, which gives us

[Qemu-devel] [PATCH v4] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid option

[Qemu-devel] [PATCH v8 0/2] add support for VCPU event states

2018-08-28 Thread Dongjiu Geng
Support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception state, and support the state migration. Now the VCPU event only includes the SError exception status, it can be extended if needed. When do migration, If source machine has serror pending, the target machine is also needed to pen

[Qemu-devel] [PATCH v8 1/2] linux-headers: Update to kernel mainline commit 815f0ddb3

2018-08-28 Thread Dongjiu Geng
Update our kernel headers to mainline commit 815f0ddb346c196018d4d8f8f55c12b83da1de3f (include/linux/compiler*.h: make compiler-*.h mutually exclusive) Signed-off-by: Dongjiu Geng --- include/standard-headers/linux/input.h | 9 + linux-headers/asm-arm/kvm.h| 13 +

[Qemu-devel] 答复: [Qemu-arm] [PATCH v7 2/2] target: arm: Add support for VCPU event states

2018-08-28 Thread gengdongjiu
Hi Shannon Ihave changed it according to your comments and repost the patches, thanks for the review. > > Hi, > > On 8/28/2018 4:46 AM, Dongjiu Geng wrote: > > This patch extends the qemu-kvm state sync logic with support for > > KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError e

[Qemu-devel] [PATCH v8 2/2] target: arm: Add support for VCPU event states

2018-08-28 Thread Dongjiu Geng
This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. And also it can support the exception state migration. Signed-off-by: Dongjiu Geng --- change since v7: 1. Change "pending" and "has_esr" from uint32_t to uint

Re: [Qemu-devel] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename()

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:23 PM CEST, Max Reitz wrote: > Currently, nvme's bdrv_refresh_filename() is an exact copy of null's > implementation. However, for null, "null-co://" and "null-aio://" are > indeed valid filenames -- for nvme, they are not, as a device address is > still required. > > The

Re: [Qemu-devel] [PATCH v9 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-08-28 Thread Marc-André Lureau
ping On Fri, Aug 10, 2018 at 5:34 PM Marc-André Lureau wrote: > > The following patch is going to add compatiblity parameters. > > Signed-off-by: Marc-André Lureau > --- > include/hw/compat.h | 4 +++- > include/hw/i386/pc.h | 5 - > hw/i386/pc_piix.c| 13 - > hw/i386/pc_q

Re: [Qemu-devel] [PATCH v3 6/8] target/mips: Add MXU instruction D16MAC

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 6/8] target/mips: Add MXU instruction D16MAC > > Adds support for emulating the D16MAC instruction. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v4] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Andrew Jones
On Tue, Aug 28, 2018 at 03:48:13PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Add MXU instruction S8LDD

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 4/8] target/mips: Add MXU instruction S8LDD > > Adds support for emulating the S8LDD MXU instruction. > > Signed-off-by

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-28 Thread Peter Krempa
On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > The block-commit QMP command required specifying the top and base nodes > of the commit jobs using the file name of that node. While this works > in simple cases (local files with absolute paths), the file names > generated for more compli

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I > > This commit makes the MXU registers and the utility functio

Re: [Qemu-devel] [PATCH for-3.1 v10 21/31] block: Add strong_runtime_opts to BlockDriver

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:18 PM CEST, Max Reitz wrote: > This new field can be set by block drivers to list the runtime options > they accept that may influence the contents of the respective BDS. As of > a follow-up patch, this list will be used by the common > bdrv_refresh_filename() implementatio

Re: [Qemu-devel] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:27 PM CEST, Max Reitz wrote: > When BDSs are created by qemu itself (e.g. as filters in block jobs), > they may not have a "driver" option in their options QDict. When > generating a json:{} filename, however, it must always be present. > > Signed-off-by: Max Reitz Revie

Re: [Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 1/8] target/mips: Introduce MXU registers > > Define and initialize the 16 MXU registers. > > Signed-off-by: Craig Ja

[Qemu-devel] [PATCH] Add support for TCP path/QMP_PATH in scripts/qmp/qmp

2018-08-28 Thread Chen Zhang via Qemu-devel
From a1f93198020b8c043edab5292db39b52ac77f78b Mon Sep 17 00:00:00 2001 Signed-off-by: Zhang Chen --- scripts/qmp/qmp | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qmp b/scripts/qmp/qmp index 6cb46fd..0e8ed19 100755 --- a/scripts/qmp/qmp +++ b/scr

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 2/8] target/mips: Add all MXU opcodes > > Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with > existi

Re: [Qemu-devel] [PATCH V4 0/4] introduce coalesced pio support

2018-08-28 Thread Eduardo Habkost
On Sat, Aug 25, 2018 at 08:19:46PM +0800, Peng Hao wrote: [...] > Peng Hao (4): > target-i386: introduce coalesced_pio kvm header update > target-i386:add coalesced_pio API > target-i386: add rtc 0x70 port as coalesced_pio > target-i386: add i440fx 0xcf8 port as coalesced_pio Do you have a

Re: [Qemu-devel] [PATCH V4 1/4] target-i386: introduce coalesced_pio kvm header update

2018-08-28 Thread Eduardo Habkost
On Sat, Aug 25, 2018 at 08:19:47PM +0800, Peng Hao wrote: > add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header. > > Signed-off-by: Peng Hao What's the status of the corresponding KVM header patch? > --- > accel/kvm/kvm-all.c | 4 ++-- > linux-headers/linux/kvm.h | 5 +++-- > 2

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-28 Thread Eric Blake
On 08/28/2018 10:01 AM, Eric Blake wrote: The question remains, then, if a fixed-size gap (by making JSON_MIN be exactly 100) is any smarter than a contiguous layout (by making JSON_MIN be IN_START_INTERP + 1).  I can't see any strong reason for preferring one form over the other, so keeping th

Re: [Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has no parent

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:50PM +0200, Marc-André Lureau wrote: > It's possible to write code creating a chardev backend that is not > registered. When it is not user-created, it makes sense to keep it > hidden. Let the associated frontend destroy it also in this case. > > Signed-off-by: Marc-A

Re: [Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Janeczek, Craig via Qemu-devel
Where is the definition of MXU control register (MXU_CR)? MXU_CR is the last element in this array. Before sending patches, it is obligatory to run scripts/checkpatch.pl - this (missing braces) will be reported by this script. I did run checkpath before sending a patch. This was not reported.

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Janeczek, Craig via Qemu-devel
I see that I can check the loongson instructions by checking for INSN_LOONGSON2F. Using MXU if that is not set What should I check for the mult or misc instructions that were there first? -Original Message- From: Aleksandar Markovic Sent: Tuesday, August 28, 2018 11:07 AM To: Janeczek,

Re: [Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() counter

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:49PM +0200, Marc-André Lureau wrote: > There is no obvious reason to have a loop counter. This limits from > reading several megabytes large buffers in one go, since socket > read/write usually have a limit. The counter was there since this method's introduction in 7b

Re: [Qemu-devel] [PATCH v4 09/29] qio: add qio_channel_command_new_spawn_with_pre_exec()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:56PM +0200, Marc-André Lureau wrote: > Add a new function to let caller do some tuning thanks to a callback > before exec(). > > Signed-off-by: Marc-André Lureau > --- > include/io/channel-command.h | 18 ++ > io/channel-command.c | 33 ++

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-28 Thread Eric Blake
On 08/27/2018 11:40 PM, Markus Armbruster wrote: typedef enum json_token_type { -JSON_MIN = 100, -JSON_LCURLY = JSON_MIN, +JSON_ERROR = 0, /* must be zero, see json_lexer[] */ +/* Gap for lexer states */ +JSON_LCURLY = 100, +JSON_MIN = JSON_LCURLY, In an

Re: [Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update

2018-08-28 Thread Eric Blake
On 08/28/2018 07:07 AM, Markus Armbruster wrote: Markus Armbruster (2): qapi: Emit a blank line before dummy declaration qapi: Update docs for generator changes since commit 9ee86b85267 Reviewed-by: Eric Blake (Nothing like my patch to the same file to make it obvious that we're not al

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Janeczek, Craig via Qemu-devel
What happens if reg > 16? Also, the argument reg should be unsigned. If rev > 16 the instruction is invalid. What type of error can/should I throw here. This does not handle the case xra == XR16. From the doc: I do not see where the case is un-handled. XR16 maps to index 15 in the mxu_gpr array.

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Add comments to aid debugging generated introspection

2018-08-28 Thread Eric Blake
On 08/28/2018 07:27 AM, Markus Armbruster wrote: --- v2: rebase on conditional code additions, drop patch to remove -u, update documentation to match My update wasn't very accurate, as you discovered :) Let's rebase onto my "[PATCH 0/2] qapi: A whitespace touch-up, and a doc update". The a

Re: [Qemu-devel] [PATCH] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-28 Thread Shivaprasad G Bhat
On 08/27/2018 06:55 PM, Laurent Vivier wrote: Le 27/08/2018 à 14:37, Shivaprasad G Bhat a écrit : If the hostpage size is greater than the TARGET_PAGESIZE, the target-pages of size TARGET_PAGESIZE are marked valid only till the length requested during the elfload. The glibc attempts to consum

[Qemu-devel] [PATCH v2] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-28 Thread Shivaprasad G Bhat
If the hostpage size is greater than the TARGET_PAGESIZE, the target-pages of size TARGET_PAGESIZE are marked valid only till the length requested during the elfload. The glibc attempts to consume unused space in the last page of data segment(__libc_memalign() in elf/dl-minimal.c). If PT_LOAD p_ali

Re: [Qemu-devel] [RFC V1] hw/pci/pci_example.c : Added a new pci device

2018-08-28 Thread Yoni Bettan
On 8/28/18 10:24 AM, Yoni Bettan wrote: - this is a simple example of how to write a pci device that supports portio, mmio, irq and dma As the commit message miss a little bit of information I will add it here and update the commit message in the next Version. The main goal is

Re: [Qemu-devel] [PATCH v4 10/29] HACK: vhost-user-backend: allow to specify binary to execute

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:57PM +0200, Marc-André Lureau wrote: > An executable with its arguments may be given as 'cmd' property, ex: > -object vhost-user-backend,id=vui,cmd="./vhost-user-input > /dev/input..". The executable is then spawn and, by convention, the > vhost-user socket is passed a

Re: [Qemu-devel] [PATCH v4 11/29] vhost-user: split vhost_user_read()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:58PM +0200, Marc-André Lureau wrote: > Split vhost_user_read(), so only header can be read with > vhost_user_read_header(). > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user.c | 27 +++ > 1 file changed, 19 insertions(+), 8 de

  1   2   >