On Fri, Jul 13, 2018 at 03:08:49PM +0200, Marc-André Lureau wrote: > There is no obvious reason to have a loop counter. This limits from > reading several megabytes large buffers in one go, since socket > read/write usually have a limit.
The counter was there since this method's introduction in 7b0bfdf52d694c9a3a96505aa42ce3f8d63acd35, and no obvious indication of its purpose in that commit. I can imagine maybe it was a misguided attempt to prevent QEMU blocking forever if no data was pending, but it does not in fact achieve that. > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > --- > chardev/char-fe.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
