Re: [Qemu-devel] [PATCH v5 3/3] target: arm: Add support for VCPU event states

2018-08-20 Thread gengdongjiu
On 2018/8/17 22:50, Peter Maydell wrote: > On 21 July 2018 at 18:57, Dongjiu Geng wrote: >> This patch extends the qemu-kvm state sync logic with support for >> KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. >> And also it can support the exception state migration. > >>

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-20 Thread Denis Plotnikov
ping ping! On 14.08.2018 10:08, Denis Plotnikov wrote: On 13.08.2018 19:30, Kevin Wolf wrote: Am 13.08.2018 um 10:32 hat Denis Plotnikov geschrieben: Ping ping! On 16.07.2018 21:59, John Snow wrote: On 07/16/2018 11:01 AM, Denis Plotnikov wrote: Ping! I never saw a reply to Stefan's

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-20 Thread Denis Plotnikov
ping ping! On 14.08.2018 10:08, Denis Plotnikov wrote: On 13.08.2018 19:30, Kevin Wolf wrote: Am 13.08.2018 um 10:32 hat Denis Plotnikov geschrieben: Ping ping! On 16.07.2018 21:59, John Snow wrote: On 07/16/2018 11:01 AM, Denis Plotnikov wrote: Ping! I never saw a reply to Stefan's

Re: [Qemu-devel] [PATCH v8 81/87] linux-user: Add support for statx() syscall for all platforms

2018-08-20 Thread Timothy Baldwin
On 13/08/18 18:53, Aleksandar Markovic wrote: From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation includes invoking other (more mature) syscalls (from the same 'stat' family) on the host side. This way, problems of availability of statx() on the

Re: [Qemu-devel] [PATCH 0/7] jobs: remove job_defer_to_main_loop

2018-08-20 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180817190457.8292-1-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] jobs: remove job

Re: [Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

2018-08-20 Thread Markus Armbruster
no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: [...] > Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test... > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #48: > new file mode

Re: [Qemu-devel] [PATCH v6 09/11] migration: poll the cm event for destination qemu

2018-08-20 Thread 858585 jemmy
On Fri, Aug 17, 2018 at 10:01 PM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> The destination qemu only poll the comp_channel->fd in >> qemu_rdma_wait_comp_channel. But when source qemu disconnnect >> the rdma connection, the destination qemu should be notified.

Re: [Qemu-devel] [PATCH v2 05/60] qmp-test: Cover syntax and lexical errors

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- > > Might be worth mentioning the addition of qtest_qmp_send_raw() in the > commit message body. I'm adding: qmp-test neglects to cover QMP input that isn't valid JSON. libqtes

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-20 Thread  Christian Ehrhardt 
** Changed in: qemu (Ubuntu Bionic) Status: New => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755912 Title: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl St

Re: [Qemu-devel] [PATCH v2 28/60] json: Fix \uXXXX for surrogate pairs

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> The JSON parser treats each half of a surrogate pair as unpaired >> surrogate. Fix it to recognize surrogate pairs. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake > > I might have dropped the R-b, to en

Re: [Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

2018-08-20 Thread Fam Zheng
On Mon, 08/20 10:31, Markus Armbruster wrote: > no-re...@patchew.org writes: > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > [...] > > Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test... > > WARNING: added, moved or deleted

Re: [Qemu-devel] Pipe key broken on US keyboards

2018-08-20 Thread Gerd Hoffmann
On Fri, Aug 17, 2018 at 11:16:29AM -0400, Phillip Susi wrote: > On 8/17/2018 11:05 AM, Daniel P. Berrangé wrote: > > Reading again, this is a bit odd. On most keyboards, holding down shift > > key generally would NOT change the scan code that is reported (there are a > > Right; a real keyboard won

Re: [Qemu-devel] [PATCH v2 25/60] json: Leave rejecting invalid escape sequences to parser

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> Both lexer and parser reject invalid escape sequences in strings. The >> parser's check is useless. >> > >> While there, fix parse_string()'s inaccurate function comment. >> >> Signed-off-by: Markus Armbruster >> --- > >>

Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Bump timeout to 6 minutes

2018-08-20 Thread Peter Maydell
On 20 August 2018 at 07:21, Thomas Huth wrote: > On 2018-08-18 12:10, Peter Maydell wrote: >> On 18 August 2018 at 10:07, Thomas Huth wrote: >>> 6 minutes is really a lot already. I guess most users will hit CTRL-C >>> before waiting so long if there is a realy problem here ... If the >>> current

Re: [Qemu-devel] [PULL 0/4] VFIO update 2018-08-17

2018-08-20 Thread Peter Maydell
On 17 August 2018 at 18:08, Alex Williamson wrote: > The following changes since commit 0abaa41d936becd914a16ee1fe2a981d96d19428: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2018-08-17 09:46:00 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread KONRAD Frederic
Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : We now support direct execution from MMIO regions in the core memory subsystem. This means that we don't need to have device-specific support for it, and we can remove the request_ptr handling from the Xilinx SPIPS device. (It was broken anyway

Re: [Qemu-devel] [PATCH 2/3] memory: Remove MMIO request_ptr APIs

2018-08-20 Thread KONRAD Frederic
Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : Remove the obsolete MMIO request_ptr APIs; they have no users now. Signed-off-by: Peter Maydell Reviewed-by: KONRAD Frederic --- include/exec/memory.h | 35 -- memory.c | 110

Re: [Qemu-devel] [PATCH 3/3] hw/misc: Remove mmio_interface device

2018-08-20 Thread KONRAD Frederic
Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : The mmio_interface device was a purely internal artifact of the implementation of the memory subsystem's request_ptr APIs. Now that we have removed those APIs, we can remove the mmio_interface device too. Signed-off-by: Peter Maydell Reviewe

Re: [Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread Peter Maydell
On 20 August 2018 at 09:49, KONRAD Frederic wrote: > > > Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : >> >> We now support direct execution from MMIO regions in the >> core memory subsystem. This means that we don't need to >> have device-specific support for it, and we can remove >> the requ

Re: [Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread KONRAD Frederic
Le 08/20/2018 à 10:53 AM, Peter Maydell a écrit : On 20 August 2018 at 09:49, KONRAD Frederic wrote: Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : We now support direct execution from MMIO regions in the core memory subsystem. This means that we don't need to have device-specific sup

Re: [Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-08-20 Thread Cornelia Huck
On Tue, 31 Jul 2018 13:29:30 +0200 Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:46 +0200 > Christian Borntraeger wrote: > > > this depends on the current kvms390/next kernel tree. > > > > Christian Borntraeger (2): > > header sync > > s390x/kvm: add etoken facility > > > > linux-head

Re: [Qemu-devel] [PATCH v6 10/11] migration: remove the unnecessary RDMA_CONTROL_ERROR message

2018-08-20 Thread 858585 jemmy
On Fri, Aug 17, 2018 at 10:04 PM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> It's not necessary to send RDMA_CONTROL_ERROR when clean up rdma resource. >> If rdma->error_state is ture, the message may not send successfully. >> and the cm event can also notify t

Re: [Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support

2018-08-20 Thread Cornelia Huck
On Wed, 1 Aug 2018 18:01:59 +0200 Cornelia Huck wrote: > On Wed, 1 Aug 2018 14:19:03 +0100 > Janosch Frank wrote: > > > v4: > > * Now using MiB > > * Now supporting 4k memory backings > > > > v3: > > * Fixed Cap name > > * Added mempath page size check and error reporting > >

Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Bump timeout to 6 minutes

2018-08-20 Thread Thomas Huth
On 2018-08-20 10:45, Peter Maydell wrote: > On 20 August 2018 at 07:21, Thomas Huth wrote: >> On 2018-08-18 12:10, Peter Maydell wrote: >>> On 18 August 2018 at 10:07, Thomas Huth wrote: 6 minutes is really a lot already. I guess most users will hit CTRL-C before waiting so long if ther

Re: [Qemu-devel] [PATCH v2 07/60] check-qjson: Cover escaped characters more thoroughly, part 1

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> escaped_string() first tests double quoted strings, then repeats a few >> tests with single quotes. Repeat all of them: store the strings to >> test without quotes, and wrap them in either kind of quote for >> testing. >> >

Re: [Qemu-devel] [PATCH v2 00/11] convert CPU list to RCU

2018-08-20 Thread Paolo Bonzini
On 19/08/2018 11:13, Emilio G. Cota wrote: > - Add some fixes for test-rcu-list. I wanted to be able to get no > races with ThreadSanitizer, but it still warns about two races. > I'm appending the report just in case, but I think tsan is getting > confused. I cannot understand the first. Th

Re: [Qemu-devel] [PATCH 2/2] qobject: modify qobject_ref() to assert on NULL

2018-08-20 Thread Alberto Garcia
On Fri 17 Aug 2018 07:19:32 PM CEST, Marc-André Lureau wrote: > diff --git a/block/quorum.c b/block/quorum.c > index 9152da8c58..96cd094ede 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -1089,7 +1089,8 @@ static void quorum_refresh_filename(BlockDriverState > *bs, QDict *options) >

Re: [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-20 Thread Vladimir Sementsov-Ogievskiy
18.08.2018 00:50, Max Reitz wrote: On 2018-08-14 19:01, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- [v2 is just a resend. I forget to add Den an me to cc, and I don't see the letter in my thunderbird at all. strange. sorry for that] Hi all! Here is an

Re: [Qemu-devel] [PATCH v8 81/87] linux-user: Add support for statx() syscall for all platforms

2018-08-20 Thread Aleksandar Markovic
> From: Timothy Baldwin > Sent: Monday, August 20, 2018 9:48 AM > > Subject: Re: [PATCH v8 81/87] linux-user: Add support for statx() syscall for > all platforms > > On 13/08/18 18:53, Aleksandar Markovic wrote: > > From: Aleksandar Rikalo > > > > Implement support for translation of system ca

Re: [Qemu-devel] [PATCH v6 11/11] migration: create a dedicated thread to release rdma resource

2018-08-20 Thread 858585 jemmy
On Fri, Aug 17, 2018 at 10:59 PM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> ibv_dereg_mr wait for a long time for big memory size virtual server. >> >> The test result is: >> 10GB 326ms >> 20GB 699ms >> 30GB 1021ms >> 40GB 1387ms >> 50GB 1712ms

Re: [Qemu-devel] [PATCH 0/7] discard blockstats

2018-08-20 Thread Anton Nefedov
On 17/8/2018 8:27 PM, Paolo Bonzini wrote: On 20/11/2017 17:50, Anton Nefedov wrote: qmp query-blockstats provides stats info for write/read/flush ops. Patches 1-5 implement the similar for discard (unmap) command for scsi and ide disks. Discard stat "unmap_ops / unmap_bytes" is supposed to

Re: [Qemu-devel] [PATCH] sheepdog: Replace strncpy() by g_strlcpy()

2018-08-20 Thread David Hildenbrand
On 18.08.2018 04:56, Philippe Mathieu-Daudé wrote: > Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks. > > Replace the strncpy() calls by g_strlcpy() to avoid the following warning: > > block/sheepdog.c: In function 'find_vdi_name': > block/sheepdog.c:1239:5: error: '

Re: [Qemu-devel] [PATCH] hw/intc/apic: Switch away from old_mmio

2018-08-20 Thread Peter Maydell
On 3 August 2018 at 11:19, Peter Maydell wrote: > Switch the apic away from using the old_mmio MemoryRegionOps > accessor functions. > > Signed-off-by: Peter Maydell > --- > I think this is the last old_mmio user. We can clean up the > core code once all the on-list patches get into master. > ---

Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy()

2018-08-20 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks. > > Replace the strncpy() calls by g_strlcpy() to avoid the following warning: > > migration/global_state.c: In function 'global_state_store_running': > migration/global_state.c:45:5: err

Re: [Qemu-devel] [PATCH 0/2] mips: convert devices away from old_mmio

2018-08-20 Thread Peter Maydell
On 2 August 2018 at 16:51, Peter Maydell wrote: > These patches convert a couple of devices used only by MIPS > boards from using the old_mmio MemoryRegionOps accessor functions. > > * vga-isa-mm: used by the MIPS 'jazz' boards "magnum" and "pica61" > * bonito pci controller: used by the MIPS "f

Re: [Qemu-devel] [PATCH] hw/timer/m48t59: Move away from old_mmio accessors

2018-08-20 Thread Peter Maydell
On 3 August 2018 at 08:22, Mark Cave-Ayland wrote: > On 02/08/18 19:06, Peter Maydell wrote: > >> Move the m48t59 device away from using old_mmio MemoryRegionOps >> accessors. >> >> Signed-off-by: Peter Maydell >> --- > > Looks good to me after some quick boot tests on SPARC, SPARC64 and 40p, so

Re: [Qemu-devel] [PATCH v2 1/3] qapi: add x-query-block-graph

2018-08-20 Thread Vladimir Sementsov-Ogievskiy
17.08.2018 23:32, Eric Blake wrote: On 08/17/2018 01:04 PM, Vladimir Sementsov-Ogievskiy wrote: Add a new command, returning block nodes graph. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/block-core.json  | 116 ++ +## +# @BlockGrap

Re: [Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-20 Thread Paolo Bonzini
On 17/08/2018 20:04, Andrew Oates wrote: >>> [1] this is an invalid configuration (in protected mode the L bit is >>> reserved and should be set to zero), but qemu doesn't enforce that. > > Is there a central place to do that sort of validation?  We could do it > in load_segment_ra, but that doesn'

Re: [Qemu-devel] [PATCH] hw/intc/apic: Switch away from old_mmio

2018-08-20 Thread Paolo Bonzini
On 03/08/2018 12:19, Peter Maydell wrote: > Switch the apic away from using the old_mmio MemoryRegionOps > accessor functions. > > Signed-off-by: Peter Maydell > --- > I think this is the last old_mmio user. We can clean up the > core code once all the on-list patches get into master. > --- > hw

Re: [Qemu-devel] [PATCH v2 1/3] qapi: add x-query-block-graph

2018-08-20 Thread Vladimir Sementsov-Ogievskiy
18.08.2018 00:03, Max Reitz wrote: On 2018-08-17 22:32, Eric Blake wrote: On 08/17/2018 01:04 PM, Vladimir Sementsov-Ogievskiy wrote: Add a new command, returning block nodes graph. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/block-core.json  | 116

Re: [Qemu-devel] [PATCH 0/2] mips: convert devices away from old_mmio

2018-08-20 Thread Aleksandar Markovic
> From: Peter Maydell > Sent: Monday, August 20, 2018 11:50 AM > Subject: Re: [Qemu-devel] [PATCH 0/2] mips: convert devices away from old_mmio > > On 2 August 2018 at 16:51, Peter Maydell wrote: > > These patches convert a couple of devices used only by MIPS > > boards from using the old_mmio M

[Qemu-devel] [PULL 07/25] target/arm: Implement AArch32 HVBAR

2018-08-20 Thread Peter Maydell
Implement the AArch32 HVBAR register; we can do this just by making the existing VBAR_EL2 regdefs be STATE_BOTH. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Luc Michel Message-id: 20180814124254.5229-5-peter.mayd...@linaro.org --- target/arm/helper.c | 4 ++-- 1 fi

[Qemu-devel] [PULL 00/25] target-arm queue

2018-08-20 Thread Peter Maydell
18-08-20 09:48:03 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180820 for you to fetch changes up to b85fad1588e812566f897f747e38da345a7016d6: hw/dma/pl080: Remove hw_error() if DMA is enab

[Qemu-devel] [PULL 19/25] nvic: Expose NMI line

2018-08-20 Thread Peter Maydell
On real v7M hardware, the NMI line is an externally visible signal that an SoC or board can toggle to assert an NMI. Expose it in our QEMU NVIC and armv7m container objects so that a board model can wire it up if it needs to. In particular, the MPS2 watchdog is wired to NMI. Signed-off-by: Peter

[Qemu-devel] [PULL 06/25] target/arm: Add missing .cp = 15 to HMAIR1 and HAMAIR1 regdefs

2018-08-20 Thread Peter Maydell
ARMCPRegInfo structs will default to .cp = 15 if they are ARM_CP_STATE_BOTH, but not if they are ARM_CP_STATE_AA32 (because a coprocessor number of 0 is valid for AArch32). We forgot to explicitly set .cp = 15 for the HMAIR1 and HAMAIR1 regdefs, which meant they would UNDEF when the guest tried to

[Qemu-devel] [PULL 11/25] target/arm: Implement AArch32 ERET instruction

2018-08-20 Thread Peter Maydell
ARMv7VE introduced the ERET instruction, which is necessary to return from an exception taken to Hyp mode. Implement this. In A32 encoding it is a completely new encoding; in T32 it is an adjustment of the behaviour of the existing "SUBS PC, LR, #" instruction. Signed-off-by: Peter Maydell Review

[Qemu-devel] [PULL 08/25] target/arm: Implement AArch32 Hyp FARs

2018-08-20 Thread Peter Maydell
The AArch32 virtualization extensions support these fault address registers: * HDFAR: aliased with AArch64 FAR_EL2[31:0] and AArch32 DFAR(S) * HIFAR: aliased with AArch64 FAR_EL2[63:32] and AArch32 IFAR(S) Implement the accessors for these. This fixes in passing a bug where we weren't implementi

[Qemu-devel] [PULL 05/25] target/arm: Correct typo in HAMAIR1 regdef name

2018-08-20 Thread Peter Maydell
We implement the HAMAIR1 register as RAZ/WI; we had a typo in the regdef, though, and were incorrectly naming it HMAIR1 (which is a different register which we also implement as RAZ/WI). Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Luc Michel Message-id: 201808141242

[Qemu-devel] [PULL 02/25] docs/generic-loader: mention U-Boot and Intel HEX executable formats

2018-08-20 Thread Peter Maydell
From: Stefan Hajnoczi The generic loader device supports the U-Boot and Intel HEX executable formats in addition to the document raw and ELF formats. Reword the documentation to include these formats and explain how various options depend on the executable format. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 10/25] target/arm: Permit accesses to ELR_Hyp from Hyp mode via MSR/MRS (banked)

2018-08-20 Thread Peter Maydell
The MSR (banked) and MRS (banked) instructions allow accesses to ELR_Hyp from either Monitor or Hyp mode. Our translate time check was overly strict and only permitted access from Monitor mode. The runtime check we do in msr_mrs_banked_exc_checks() had the correct code in it, but never got there b

[Qemu-devel] [PULL 04/25] imx_serial: Generate interrupt on receive data ready if enabled

2018-08-20 Thread Peter Maydell
From: Hans-Erik Floryd Generate an interrupt if USR2_RDR and UCR4_DREN are both set. Signed-off-by: Hans-Erik Floryd Message-id: 1534341354-11956-1-git-send-email-hans-erik.flo...@rt-labs.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/hw/char/imx_serial.h | 1 + hw/c

[Qemu-devel] [PULL 13/25] sdhci: add i.MX SD Stable Clock bit

2018-08-20 Thread Peter Maydell
From: Hans-Erik Floryd Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd Message-id: 1534507843-4251-1-git-send-email-hans-erik.flo...@rt-labs.com [PMM: fixed indentati

[Qemu-devel] [PULL 01/25] target/arm: Fix crash on conditional instruction in an IT block

2018-08-20 Thread Peter Maydell
From: Roman Kapl If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to an undefined label is generated, and QEMU crashes. CBZ in IT block is an UNPREDICTABLE behavior, but we should not crash. Honouring the condition code is allowed

[Qemu-devel] [PULL 12/25] hw/arm/virt: Add virt-3.1 machine type

2018-08-20 Thread Peter Maydell
From: Andrew Jones Signed-off-by: Andrew Jones Reviewed-by: Igor Mammedov Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/virt.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0807be985c0..0b

[Qemu-devel] [PULL 18/25] hw/watchdog/cmsdk_apb_watchdog: Implement CMSDK APB watchdog module

2018-08-20 Thread Peter Maydell
The Arm Cortex-M System Design Kit includes a simple watchdog module based on a 32-bit down-counter. Implement this. Signed-off-by: Peter Maydell --- Makefile.objs| 1 + hw/watchdog/Makefile.objs| 1 + include/hw/watchdog/cmsdk-apb-watchdog.h | 59

[Qemu-devel] [PULL 09/25] target/arm: Implement ESR_EL2/HSR for AArch32 and no-EL2

2018-08-20 Thread Peter Maydell
The AArch32 HSR is the equivalent of AArch64 ESR_EL2; we can implement it by marking our existing ESR_EL2 regdef as STATE_BOTH. It also needs to be "RES0 from EL3 if EL2 not implemented", so add the missing stanza to el3_no_el2_cp_reginfo. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesi

[Qemu-devel] [PULL 03/25] hw/intc/arm_gicv3_its: downgrade error_report to warn_report in kvm_arm_its_reset

2018-08-20 Thread Peter Maydell
From: Jia He In scripts/arch-run.bash of kvm-unit-tests, it will check the qemu output log with: if [ -z "$(echo "$errors" | grep -vi warning)" ]; then Thus without the warning prefix, all of the test fail. Since it is not unrecoverable error in kvm_arm_its_reset for current implementation, dow

[Qemu-devel] [PULL 17/25] hw/timer/m48t59: Move away from old_mmio accessors

2018-08-20 Thread Peter Maydell
Move the m48t59 device away from using old_mmio MemoryRegionOps accessors. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Mark Cave-Ayland Message-id: 20180802180602.22047-1-peter.mayd...@linaro.org --- hw/timer/m48t59.c | 59 +--

[Qemu-devel] [PULL 21/25] hw/dma/pl080: Support all three interrupt lines

2018-08-20 Thread Peter Maydell
The PL080 and PL081 have three outgoing interrupt lines: * DMACINTERR signals DMA errors * DMACINTTC is the DMA count interrupt * DMACINTR is a combined interrupt, the logical OR of the other two We currently only implement DMACINTR, because that's all the realview and versatile boards needed,

[Qemu-devel] [PULL 14/25] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread Peter Maydell
We now support direct execution from MMIO regions in the core memory subsystem. This means that we don't need to have device-specific support for it, and we can remove the request_ptr handling from the Xilinx SPIPS device. (It was broken anyway due to race conditions, and disabled by default.) Thi

[Qemu-devel] [PULL 15/25] memory: Remove MMIO request_ptr APIs

2018-08-20 Thread Peter Maydell
Remove the obsolete MMIO request_ptr APIs; they have no users now. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Reviewed-by: KONRAD Frederic Message-id: 20180817114619.22354-3-peter.mayd...@linaro.org --- include/exec/memory.h | 35 --

[Qemu-devel] [Bug 1485010] Re: qemu-guest-agent should support systemd in addition to pmutils

2018-08-20 Thread Thomas Huth
This should now be fixed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=067927d62e097a8a3624a9 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[Qemu-devel] [PULL 16/25] hw/misc: Remove mmio_interface device

2018-08-20 Thread Peter Maydell
The mmio_interface device was a purely internal artifact of the implementation of the memory subsystem's request_ptr APIs. Now that we have removed those APIs, we can remove the mmio_interface device too. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Alistair Francis

[Qemu-devel] [PULL 20/25] hw/dma/pl080: Allow use as embedded-struct device

2018-08-20 Thread Peter Maydell
Create a new include file for the pl081's device struct, type macros, etc, so that it can be instantiated using the "embedded struct" coding style. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- include/hw/dma/pl080.h | 62 ++ hw/dma

[Qemu-devel] [PULL 22/25] hw/dma/pl080: Don't use CPU address space for DMA accesses

2018-08-20 Thread Peter Maydell
Currently our PL080/PL081 model uses a combination of the CPU's address space (via cpu_physical_memory_{read,write}()) and the system address space for performing DMA accesses. For the PL081s in the MPS FPGA images, their DMA accesses must go via Master Security Controllers. Switch the PL080/PL081

[Qemu-devel] [Bug 1364501] Re: Gdb hangs when trying to single-step after an invalid instruction

2018-08-20 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [PULL 23/25] hw/dma/pl080: Provide device reset function

2018-08-20 Thread Peter Maydell
The PL080/PL081 model is missing a reset function; implement it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/pl080.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/dma/pl080.c b/hw/dma/pl080.c index 8f9f3e08d9a..a7aacad74f0 1006

Re: [Qemu-devel] [PATCH] qemu-guest-agent: freeze-hook to ignore dpkg files as well

2018-08-20 Thread Christian Ehrhardt
On Thu, May 10, 2018 at 8:47 PM Philippe Mathieu-Daudé wrote: > Hi Paolo, > > On 04/24/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > > Hi Christian, > > > > On 04/09/2018 04:18 AM, Christian Ehrhardt wrote: > >> Re-Ping for consideration? > >> > >> On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrh

[Qemu-devel] [PULL 24/25] hw/dma/pl080: Correct bug in register address decode logic

2018-08-20 Thread Peter Maydell
A bug in the handling of the register address decode logic for the PL08x meant that we were incorrectly treating accesses to the DMA channel registers (DMACCxSrcAddr, DMACCxDestaddr, DMACCxLLI, DMACCxControl, DMACCxConfiguration) as bad offsets. Fix this long-standing bug. Fixes: https://bugs.laun

[Qemu-devel] [PULL 25/25] hw/dma/pl080: Remove hw_error() if DMA is enabled

2018-08-20 Thread Peter Maydell
The PL08x model currently will unconditionally call hw_error() if the DMA engine is enabled by the guest. This has been present since the PL080 model was edded in 2006, and is presumably either unintentional debug code left enabled, or a guard against untested DMA engine code being used. Remove th

[Qemu-devel] [Bug 1484990] Re: fsfreeze-hook script should also ignored dpkg generated files

2018-08-20 Thread Thomas Huth
Christian, what happened to the upstream patch? Looks like it never got included? Could you please poke the maintainer, so we could finally close this bug for upstream, too? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

[Qemu-devel] [Bug 1484990] Re: fsfreeze-hook script should also ignored dpkg generated files

2018-08-20 Thread  Christian Ehrhardt 
Yeah I even got help back then to make sure CCs are better but nothing happened. Old thread: http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02142.html I re-pinged on the old thread to be reconsidered. New Ping: http://lists.nongnu.org/archive/html/qemu-devel/2018-08/msg03892.html Tha

Re: [Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-20 Thread Andrew Oates
On Mon, Aug 20, 2018 at 6:06 AM Paolo Bonzini wrote: > > On 17/08/2018 20:04, Andrew Oates wrote: > >>> [1] this is an invalid configuration (in protected mode the L bit is > >>> reserved and should be set to zero), but qemu doesn't enforce that. > > > > Is there a central place to do that sort of

Re: [Qemu-devel] [PATCH v2 41/60] json: Nicer recovery from invalid leading zero

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> For input 0123, the lexer produces the tokens >> >> JSON_ERROR01 >> JSON_INTEGER 23 >> >> Reporting an error is correct; 0123 is invalid according to RFC 7159. >> But the error recovery isn't nice. >> >> Make

Re: [Qemu-devel] [PATCH v2 52/60] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/17/2018 10:05 AM, Markus Armbruster wrote: >> Bonus: static json_lexer[] loses its unused elements. It shrinks from >> 8KiB to 4.75KiB for me. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- > >> ['a' ... 'z'] = IN_KEYWORD, >> -

Re: [Qemu-devel] [PATCH] qemu-guest-agent: freeze-hook to ignore dpkg files as well

2018-08-20 Thread Paolo Bonzini
On 20/08/2018 12:54, Christian Ehrhardt wrote: > > > On Thu, May 10, 2018 at 8:47 PM Philippe Mathieu-Daudé > wrote: > > Hi Paolo, > > On 04/24/2018 10:01 PM, Philippe Mathieu-Daudé wrote: > > Hi Christian, > > > > On 04/09/2018 04:18 AM, Christian E

Re: [Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-20 Thread Paolo Bonzini
On 20/08/2018 13:32, Andrew Oates wrote: > We should just remove the part that > implies qemu should enforce it from my patch commit message. Ok, will do. Paolo

Re: [Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

2018-08-20 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 08/20 10:31, Markus Armbruster wrote: >> no-re...@patchew.org writes: >> >> > Hi, >> > >> > This series seems to have some coding style problems. See output below for >> > more information: >> [...] >> > Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test... >> > WA

[Qemu-devel] [PATCH 01/16] test/qgraph: arm/smdkc210 machine node

2018-08-20 Thread Emanuele Giuseppe Esposito
Add arm/smdkc210 machine machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 9 ++-- tests/libqos/smdkc210-machine.c | 82 +++

[Qemu-devel] [PATCH 00/16] qtest: converted sdhci-test and most nop test to qgraph framework

2018-08-20 Thread Emanuele Giuseppe Esposito
This series continues the QEMU tests conversion using the qgraph framework started in the previous series. Add the missing machines required to complete the sdhci-test started previously, and convert most of the nop tests. Based-on: 20180813101453.10200-1-e.emanuelegiuse...@gmail.com Signed-off-b

[Qemu-devel] [PATCH 06/16] test/qgraph: tpci200 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/tpci200-test in qgraph test node, tpci200-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 2 +- tests/tpci200-test.c | 60 +++--- 2

[Qemu-devel] [PATCH 09/16] test/qgraph: nvme test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/nvme-test in qgraph test node, nvme-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/nvme-test.c | 43 -- 2 files

[Qemu-devel] [PATCH 04/16] test/qgraph: aarch64/xlnx-zcu102 machine node

2018-08-20 Thread Emanuele Giuseppe Esposito
Add xlnx-zcu102 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/xlnx-zcu102-machine.c | 83 ++

[Qemu-devel] [PATCH 03/16] test/qgraph: arm/xlinx-zynq-a9 machine node

2018-08-20 Thread Emanuele Giuseppe Esposito
Add xlinx-zynq-a9 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include| 1 + tests/libqos/xilinx-zynq-a9-machine.c | 84 ++

[Qemu-devel] [PATCH 07/16] test/qgraph: ipoctal232 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/ipoctal232-test in qgraph test node, ipoctal232-test. Since it's a nop test, node creation and initialization is made in the same file. This test creates a tpci200 node that produces an interface ipack consumed by the ipoctal232 device. Signed-off-by: Emanuele Giuseppe Esposito ---

[Qemu-devel] [PATCH 15/16] test/qgraph: eepro100 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/eepro100-test in qgraph test nodes, eepro100-test. Since it's a nop test, node creation and initialization is made in the same file. In addition, all nodes share the same constructor and destructor. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- test

[Qemu-devel] [PATCH 02/16] test/qgraph: arm/sabrelite machine node

2018-08-20 Thread Emanuele Giuseppe Esposito
Add arm/sabrelite machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/sabrelite-machine.c | 82

[Qemu-devel] [PATCH 10/16] test/qgraph: pcnet test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/pcnet-test in qgraph test node, pcnet-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/pcnet-test.c | 39 ++- 2 files

[Qemu-devel] [PATCH 13/16] test/qgraph: vmxnet3 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/vmxnet3-test in qgraph test node, vmxnet3-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/vmxnet3-test.c | 39 ++- 2 fi

[Qemu-devel] [PATCH 08/16] test/qgraph: ne2k_pci test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/ne2000-test in qgraph test node, ne2000-test. Since it's a nop test, node creation and initialization is made in the same file. The actual device consumed by the test is ne2k_pci. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/ne2000-test.c

[Qemu-devel] [PATCH 14/16] test/qgraph: es1370 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/es1370-test in qgraph test node, es1370-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/es1370-test.c| 39 ++- 2 file

[Qemu-devel] [PATCH 05/16] test/qgraph: ac97 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/ac97-test in qgraph test node, ac97-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/ac97-test.c | 39 ++- 2 files ch

[Qemu-devel] [PATCH 12/16] test/qgraph: usb-hcd-ohci test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/usb-hcd-ohci-test in qgraph test node, usb-hcd-ohci-test. Since it's a nop test, node creation and initialization is made in the same file. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include| 4 +--- tests/usb-hcd-ohci-test.c | 46

[Qemu-devel] [PATCH 16/16] test/qgraph: e1000 test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/e1000-test in qgraph test nodes, e1000-test. Since it's a nop test, node creation and initialization is made in the same file. In addition, all nodes share the same constructor and destructor. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/e100

[Qemu-devel] [PATCH 11/16] test/qgraph: spapr-phb test node

2018-08-20 Thread Emanuele Giuseppe Esposito
Convert tests/spapr-phb-test in qgraph test node, spapr-phb-test. This test adds another spapr-pci-host-bridge device in the ppc64/pseries machine Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 +-- tests/spapr-phb-test.c | 28 +++- 2 files chan

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-20 Thread Max Reitz
On 2018-08-20 04:07, Fam Zheng wrote: > On Thu, 08/16 04:20, Max Reitz wrote: >> No, the real issue is that dd is still not implemented just as a >> frontend to convert. Which it should be. I'm not sure dd was a very >> good idea from the start, and now it should ideally be a frontend to >> conve

Re: [Qemu-devel] [PULL 0/3] Machine queue, 2018-08-17

2018-08-20 Thread Peter Maydell
On 17 August 2018 at 19:30, Eduardo Habkost wrote: > The following changes since commit bb16c0412a572c2c9cd44496deb3ad430bc49c1a: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180816' into staging (2018-08-16 > 14:35:50 +0100) > > are available in the Git reposito

[Qemu-devel] [PATCH] arm: fix reset operation on netduino2 board.

2018-08-20 Thread Marko Klopcic
Because roms are located on aliased addresses on netduino2 (Cortex M3, STM32F205), PC and SP are not read from loaded kernel, which means that the first reset fails. This fix adds additional call to reset. See more details in code comment below. Signed-off-by: Marko Klopcic [1] --

Re: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back

2018-08-20 Thread Max Reitz
On 2018-08-20 08:38, Markus Armbruster wrote: > Max Reitz writes: > >> On 2018-08-16 08:40, Markus Armbruster wrote: [...] >> (And technically you need a string filename to point to when doing >> block-commit (Kevin sent patches to remedy this, though), so that could >> be called an application

Re: [Qemu-devel] [Qemu-arm] [PATCH] arm: fix reset operation on netduino2 board.

2018-08-20 Thread Peter Maydell
On 20 August 2018 at 12:10, Marko Klopcic wrote: > Because roms are located on aliased addresses on netduino2 (Cortex M3, > STM32F205), PC and SP are not read from loaded kernel, which means > that the first reset fails. This fix adds additional call to reset. > See more details in code comment be

  1   2   3   4   5   >