Fam Zheng <f...@redhat.com> writes:
> On Mon, 08/20 10:31, Markus Armbruster wrote:
>> no-re...@patchew.org writes:
>>
>> > Hi,
>> >
>> > This series seems to have some coding style problems. See output below for
>> > more information:
>> [...]
>> > Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test...
>> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>> > #48:
>> > new file mode 100644
>>
>> False positive: the patch does update MAINTAINERS. Surprising, since
>> commit 1a6fad0c3bd "checkpatch: reduce MAINTAINERS update message
>> frequency" suppresses this. Fam, is patchew running an outdated version
>> of checkpatch?
>
> I'm sure Patchew is using the latest checkpatch here. This is basically /me
> reproducing what it does:
>
> fam@lemon:~/work/qemu [master]$ git fetch
> https://github.com/patchew-project/qemu
> tags/patchew/20180817150559.16243-1-arm...@redhat.com
>>From https://github.com/patchew-project/qemu
> * tag patchew/20180817150559.16243-1-arm...@redhat.com
> -> FETCH_HEAD
> fam@lemon:~/work/qemu [master]$ git checkout FETCH_HEAD
> Note: checking out 'FETCH_HEAD'.
>
> You are in 'detached HEAD' state. You can look around, make experimental
> changes and commit them, and you can discard any commits you make in this
> state without impacting any branches by performing another checkout.
>
> If you want to create a new branch to retain commits you create, you may
> do so (now or later) by using -b with the checkout command again. Example:
>
> git checkout -b <new-branch-name>
>
> HEAD is now at 884c1e75d7 json: Support %% in JSON strings when interpolating
> fam@lemon:~/work/qemu$ git log --oneline | grep 'qmp-cmd-test: Split off
> qmp-test'
> b9ac2b614b qmp-cmd-test: Split off qmp-test
> fam@lemon:~/work/qemu$ git show --format=email b9ac2b614b |
> ./scripts/checkpatch.pl -
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #48:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 460 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> fam@lemon:~/work/qemu$ git log --oneline ./scripts/checkpatch.pl | grep
> 1a6fad0
> 1a6fad0c3b checkpatch: reduce MAINTAINERS update message frequency
Okay, I can reproduce the warning the way patchew runs checkpatch:
$ git-show --format=email 4552d915d3 | ./scripts/checkpatch.pl -
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47:
new file mode 100644
total: 0 errors, 1 warnings, 460 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
However:
$ git-format-patch -1 4552d915d3
0001-qmp-cmd-test-Split-off-qmp-test.patch
$ ./scripts/checkpatch.pl 0001-qmp-cmd-test-Split-off-qmp-test.patch
total: 0 errors, 0 warnings, 460 lines checked
0001-qmp-cmd-test-Split-off-qmp-test.patch has no obvious style problems
and is ready for submission.
The difference between the two: git-show --format=email lacks diffstat.
$ git-show --format=email 4552d915d3 | diff -
0001-qmp-cmd-test-Split-off-qmp-test.patch
11a12,18
> ---
> MAINTAINERS | 1 +
> tests/Makefile.include | 3 +
> tests/qmp-cmd-test.c | 213 +++++++++++++++++++++++++++++++++++++++++
> tests/qmp-test.c | 193 +------------------------------------
> 4 files changed, 219 insertions(+), 191 deletions(-)
> create mode 100644 tests/qmp-cmd-test.c
497a505,507
> --
> 2.17.1
>
