On 09/08/2018 15:19, Emanuele wrote:
>
>
> On 08/09/2018 03:02 PM, Laurent Vivier wrote:
>> On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
>>> +void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts,
>>> QGuestAllocator *alloc)
>>> +{
>>> assert(qts);
>>> + /* tests cannot use
"Michael S. Tsirkin" wrote:
> On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote:
>> * Juan Quintela (quint...@redhat.com) wrote:
>> > They are all already included in virtio_pci.h.
>
> All I see in virtio_pci.h is:
>
> #include "standard-headers/linux/types.h"
>
> Weird.
>
> B
On Thu, Aug 09, 2018 at 07:18:52PM -0300, Eduardo Habkost wrote:
> Enabling TOPOEXT is always allowed, but it can't be enabled
> blindly by "-cpu host" because it may make guests crash if the
> rest of the cache topology information isn't provided or isn't
> consistent.
>
> This addresses the bug
On 08/10/2018 02:46 AM, David Gibson wrote:
> On Mon, Jul 30, 2018 at 04:11:33PM +0200, Cédric Le Goater wrote:
>> This proposal moves all the related IRQ routines of the sPAPR machine
>> behind a sPAPR IRQ backend interface 'spapr_irq' to prepare for future
>> changes. First of which will be to in
On 10/08/18 06:37, Hervé Poussineau wrote:
> OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff
> Use it, instead of relying on an unmaintained and very limited firmware.
>
> Signed-off-by: Hervé Poussineau
> ---
> hw/ppc/prep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 d
It should save us some CPU cycles as these routines perform a lot of
checks.
Signed-off-by: Cédric Le Goater
---
hw/ppc/spapr_pci.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 3791ced6c536..5cd676e4430d 100644
---
On 10.08.2018 01:51, Michael S. Tsirkin wrote:
> On Thu, Aug 09, 2018 at 07:54:37PM +0300, Ilya Maximets wrote:
>> New feature bit for in-order feature of the upcoming
>> virtio 1.1. It's already supported by DPDK vhost-user
>> and virtio implementations. These changes required to
>> allow feature
On Fri 10 Aug 2018 08:26:41 AM CEST, Leonid Bloch wrote:
> Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
Berto
On 09/08/2018 19:03, Peter Maydell wrote:
> On 9 August 2018 at 17:43, Paolo Bonzini wrote:
>>> I'm still not used to the leeading-/*-on-it's-own style,
>>> so having checkpatch catch my lapses is handy...
>>
>> ... if it's not what we are using, why enforce it?
>
> See the enormous long threads
On 10.08.2018 11:28, Ilya Maximets wrote:
> On 10.08.2018 01:51, Michael S. Tsirkin wrote:
>> On Thu, Aug 09, 2018 at 07:54:37PM +0300, Ilya Maximets wrote:
>>> New feature bit for in-order feature of the upcoming
>>> virtio 1.1. It's already supported by DPDK vhost-user
>>> and virtio implementati
Eduardo Habkost writes:
> On Wed, Aug 08, 2018 at 01:39:31PM +0100, Alex Bennée wrote:
>> Given our issues with failing disassembly we could try and re-use the
>> decode tree data to output what instruction is being decoded. This
>> will be used if registered as a fall-back for when the "proper
On 9 August 2018 at 22:54, Samuel Thibault wrote:
> Dr. David Alan Gilbert, le jeu. 09 août 2018 12:32:05 +0100, a ecrit:
>> >|--datasize>|---m_len--->
>> >|--m_size-->
>> >|M_ROOM>
>> >
On 10 August 2018 at 06:27, Philippe Mathieu-Daudé wrote:
> On 08/10/2018 02:18 AM, Philippe Mathieu-Daudé wrote:
>> On 08/09/2018 10:01 AM, Peter Maydell wrote:
>>> Create a new include file for the pl081's device struct,
>>> type macros, etc, so that it can be instantiated using
>>> the "embedde
On 10 August 2018 at 07:22, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> We now require Linux-kernel-style multiline comments:
>> /*
>> * line one
>> * line two
>> */
>>
>> Enforce this in checkpatch.pl, by backporting the relevant
>> parts of the Linux kernel's checkp
Peter Maydell, le ven. 10 août 2018 10:02:37 +0100, a ecrit:
> (a) you should add a comment describing what 'gapsize'
> is, ie that there may be a gap between the in-use data and the
> start of the allocated buffer, and
> (b) m_inc() should change its variable name to match.
Right, I have done so
On 10 August 2018 at 09:34, Paolo Bonzini wrote:
> This is one of the cases where we are decently consistent:
>
> Lone "/*" or "/**": 9986 cases
> of which in the first column: 7617
> of which the first line in the file (license headers): 2834
> regex: ^[ \t]*/\*\*?[ \t]*$
Richard Henderson writes:
> Uses tlb_vaddr_to_host for correct operation with softmmu.
> Optimize for accesses within a single page or pair of pages.
>
> Perf report comparison for cortex-strings test-strlen
> with aarch64-linux-user:
>
> +/*
> + * Common helper for all contiguous one-register
On 10 August 2018 at 10:08, Samuel Thibault wrote:
> Peter Maydell, le ven. 10 août 2018 10:02:37 +0100, a ecrit:
>> (a) you should add a comment describing what 'gapsize'
>> is, ie that there may be a gap between the in-use data and the
>> start of the allocated buffer, and
>> (b) m_inc() should
From: Peter Maydell
and fix confusing datasize name into gapsize in m_inc.
Signed-off-by: Peter Maydell
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 14 +++---
slirp/mbuf.h | 13 +
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mb
On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote:
> >> * Juan Quintela (quint...@redhat.com) wrote:
> >> > They are all already included in virtio_pci.h.
> >
> > All I see in virt
On Fri, Aug 10, 2018 at 11:28:47AM +0300, Ilya Maximets wrote:
> On 10.08.2018 01:51, Michael S. Tsirkin wrote:
> > On Thu, Aug 09, 2018 at 07:54:37PM +0300, Ilya Maximets wrote:
> >> New feature bit for in-order feature of the upcoming
> >> virtio 1.1. It's already supported by DPDK vhost-user
> >
Paolo Bonzini writes:
> On 09/08/2018 19:03, Peter Maydell wrote:
>> On 9 August 2018 at 17:43, Paolo Bonzini wrote:
I'm still not used to the leeading-/*-on-it's-own style,
so having checkpatch catch my lapses is handy...
>>>
>>> ... if it's not what we are using, why enforce it?
>>
On Thu, Aug 09, 2018 at 02:46:16PM +0300, Liran Alon wrote:
> From: Leonid Shatz
>
> These commands are neither mentioned nor documented in VMware SVGA
> development-kit and Linux vmware-svga driver source code.
> Thus, they should be subject to future deletion, if not encountered in
> practice.
On 08/09/2018 04:16 PM, Laurent Vivier wrote:
On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:
-static void mmio_basic(void)
+static void basic_resize(void *obj, void *data, QGuestAllocator *t_alloc)
{
-QVirtioMMIODevice *dev;
-QVirtQueue *vq;
-QGuestAllocator *alloc;
+QV
> +#ifdef HW_MOUSE_ACCEL
> +vmsvga_rgba_cursor_define(s, &cursor);
> +break;
> +#else
> +args = 0;
> +goto badcmd;
> +#endif
Hmm, do we want keep this #ifdef ?
In case it is useful to disable hardware cursor support for some reason
(which I doubt) t
On 10/08/2018 11:45, Emanuele wrote:
> On 08/09/2018 04:16 PM, Laurent Vivier wrote:
>> On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:
>>> -static void mmio_basic(void)
>>> +static void basic_resize(void *obj, void *data, QGuestAllocator
>>> *t_alloc)
>>> {
>>> - QVirtioMMIODevice *dev
Hi,
> +case SVGA_REG_DISPLAY_WIDTH:
> +if ((s->display_id == 0) || (s->display_id == SVGA_ID_INVALID))
> +ret = s->new_width ? s->new_width : surface_width(surface);
> +else
> +ret = 0;
> +break;
> +case SVGA_REG_DISPLAY_HEIGHT:
> +
> +#ifdef HW_RECT_ACCEL
> +caps |= SVGA_CAP_RECT_COPY;
> +#endif
> +#ifdef HW_FILL_ACCEL
> +caps |= SVGA_CAP_RECT_FILL;
> +#endif
Same with these #ifdefs. I think we should either make them runtime
options or just drop them.
cheers,
Gerd
Hi,
> +if (cmd == SVGA_CMD_UPDATE_VERBOSE)
> +vmsvga_fifo_read(s);
Code style. qemu wants braces unconditionally. There might be more of
this in following patches. You can use scripts/checkpatch.pl to check.
cheers,
Gerd
"Michael S. Tsirkin" wrote:
> On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote:
>> "Michael S. Tsirkin" wrote:
>> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote:
>> >> * Juan Quintela (quint...@redhat.com) wrote:
>> >> > They are all already included in virt
On Thu, Aug 09, 2018 at 02:46:13PM +0300, Liran Alon wrote:
> Hi,
>
> This patch series aim to fix many issues in vmware-svga emulation
> which have prevented it from being fully functional in a wide-variety
> of guests.
Nice job in modernizing the vmware svga emulation.
What guests this was tes
On 09/08/2018 13:01, Laurent Vivier wrote:
>> No, there is only one libqgraph. The same test (qos-test) can run for
>> both PCI and non-PCI machines, and will cull the unnecessary part of the
>> graph automatically simply because there is no path from a machine to a
>> PCI device.
> So, all libqgr
On Fri, Aug 10, 2018 at 12:01:44PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote:
> >> "Michael S. Tsirkin" wrote:
> >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote:
> >> >> * Juan Quintela (
On 08/08/2018 13:48, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> default-configs/alpha-softmmu.mak | 2 --
> default-configs/arm-softmmu.mak | 2 --
> default-configs/hppa-softmmu.mak| 3 ---
> default-configs/i386-softmmu.mak| 2 --
> default-configs
On 08/08/2018 13:48, Juan Quintela wrote:
> Once there, untangle endianness-test and boot-serial-test.
>
> Signed-off-by: Juan Quintela
Emanuele's qos-test would do this automatically. It would be nicer to
convert the whole ISA subsystem to use libqos and qos-test...
Paolo
> --
>
> boot-seri
On 08/08/2018 13:48, Juan Quintela wrote:
> Hi
>
> First the things I didn'~t touch:
> - CONFIG_FOO in source files (scsi mainly)
> Paolo said that there are people working on that
IIRC I was referring to tests, so basically the first half of this
series. The virtio-pci bits look great though.
On 09/08/2018 17:03, Paolo Bonzini wrote:
> On 09/08/2018 16:55, Olaf Hering wrote:
>>
>>> I think the simplest fix is for the map
>>> cache to set aside a zero page and return it whenever it is asked for a
>>> ballooned page.
>> Can qemu actually know if it ran into a ballooned page? I think no.
>
Instead initialise the device via qdev to allow us to set device properties
directly as required.
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/mac_oldworld.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index 064d7eb
Here are a couple of patches to switch the fw_cfg initialisation for
the Mac Old World and New World machines over to use qdev rather than
using the legacy fw_cfg_init_mem() function.
Signed-off-by: Mark Cave-Ayland
Mark Cave-Ayland (2):
mac_oldworld: don't use legacy fw_cfg_init_mem() functi
Instead initialise the device via qdev to allow us to set device properties
directly as required.
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/mac_newworld.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index 2ca2946
Am Fri, 10 Aug 2018 12:25:09 +0200
schrieb Paolo Bonzini :
> There are many more callers of qemu_ram_ptr_length, and none of them check
> the result.
So you mean that function must not return NULL?
Or should the caller check for the result?
Olaf
pgp6zq9J9aL36.pgp
Description: Digitale Signatu
* Simon Ruderich (si...@ruderich.org) wrote:
> Adapted patch from Baojun Wang [1] with the following commit message:
>
> I found this could be useful to have qemu-softmmu as a cross
> debugger (launch with -s -S command line option), then if we can
> have a command to load guest physic
On 08/09/2018 11:44 AM, Paolo Bonzini wrote:
On 09/08/2018 11:20, Emanuele wrote:
Why this? Shouldn't it be:
if (g_strcmp0(old_path, path)) {
qtest_end(); /* handles global_qtest = NULL */
g_free(old_path); /* handles NULL */
old_path = path;
global_qtest = q
On 10.08.2018 12:34, Michael S. Tsirkin wrote:
> On Fri, Aug 10, 2018 at 11:28:47AM +0300, Ilya Maximets wrote:
>> On 10.08.2018 01:51, Michael S. Tsirkin wrote:
>>> On Thu, Aug 09, 2018 at 07:54:37PM +0300, Ilya Maximets wrote:
New feature bit for in-order feature of the upcoming
virtio
Paolo Bonzini wrote:
> On 08/08/2018 13:48, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> default-configs/alpha-softmmu.mak | 2 --
>> default-configs/arm-softmmu.mak | 2 --
>> default-configs/hppa-softmmu.mak| 3 ---
>> default-configs/i386-softmmu.mak
"Michael S. Tsirkin" wrote:
> On Fri, Aug 10, 2018 at 12:01:44PM +0200, Juan Quintela wrote:
>> "Michael S. Tsirkin" wrote:
>> > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote:
>> >> "Michael S. Tsirkin" wrote:
>> >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbe
Paolo Bonzini wrote:
> On 08/08/2018 13:48, Juan Quintela wrote:
>> Once there, untangle endianness-test and boot-serial-test.
>>
>> Signed-off-by: Juan Quintela
>
> Emanuele's qos-test would do this automatically. It would be nicer to
> convert the whole ISA subsystem to use libqos and qos-tes
Valgrind reports that when loading a non-ELF kernel, kernel_top may be used
uninitialised when checking for an initrd.
Since there are no known non-ELF kernels for SPARC64 then we can simply
initialise kernel_top to 0 and then skip the initrd load process if it hasn't
been set by load_elf().
Repo
Instead initialise the device via qdev to allow us to set device properties
directly as required.
Signed-off-by: Mark Cave-Ayland
---
hw/sparc/sun4m.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index d981de1841..3c29b68e67
Am 07.08.2018 um 16:52 hat Eric Blake geschrieben:
> On 08/06/2018 11:33 PM, John Snow wrote:
> > Signed-off-by: John Snow
> > ---
> > blockdev.c | 8
> > qapi/block-core.json | 3 ++-
> > 2 files changed, 10 insertions(+), 1 deletion(-)
> >
>
> > +++ b/qapi/block-core.jso
On Fri 10 Aug 2018 08:26:39 AM CEST, Leonid Bloch wrote:
> Signed-off-by: Leonid Bloch
> ---
> docs/qcow2-cache.txt | 16 +++-
> qemu-options.hx | 9 ++---
> 2 files changed, 17 insertions(+), 8 deletions(-)
>
> diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
> inde
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
MAINTAINERS.
Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
On Fri 10 Aug 2018 08:26:44 AM CEST, Leonid Bloch wrote:
> The upper limit on the L2 cache size is increased from 1 MB to 32 MB.
> This is done in order to allow default full coverage with the L2 cache
> for images of up to 256 GB in size (was 8 GB). Note, that only the
> needed amount to cover the
Still present on git master:
/usr/bin/make -f src/server/CMakeFiles/KF5WaylandServer_autogen.dir/build.make
src/server/CMakeFiles/KF5WaylandServer_autogen.dir/build
make[3]: Entering directory '/<>/obj-sh4-linux-gnu'
make[3]: Entering directory '/<>/obj-sh4-linux-gnu'
[ 0%] Automatic MOC for tar
Instead initialise the device via qdev to allow us to set device properties
directly as required.
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/prep.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 3401570d98..9cf4a2adc3 100644
Peter Maydell writes:
> On 10 August 2018 at 07:22, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> We now require Linux-kernel-style multiline comments:
>>> /*
>>> * line one
>>> * line two
>>> */
>>>
>>> Enforce this in checkpatch.pl, by backporting the relevant
>>
On 10/08/2018 13:06, Juan Quintela wrote:
>> I don't think CONFIG_SERIAL_ISA should be in pci.mak though, and
>> CONFIG_SERIAL is a dependency of both CONFIG_SERIAL and
>> CONFIG_SERIAL_PCI. Perhaps introduce a superio.mak with all the legacy
>> ISA devices?
>
> Hi
>
> Several things here.
>
> a
On 10/08/2018 13:08, Juan Quintela wrote:
>> Emanuele's qos-test would do this automatically. It would be nicer to
>> convert the whole ISA subsystem to use libqos and qos-test...
> Can we get this in until we get some volunteer for that other work?
> /me full of things on his plate at the moment.
Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben:
> If we know we've already locked the bytes, don't do it again; similarly
> don't unlock a byte if we haven't locked it. This doesn't change the
> behavior, but fixes a corner case explained below.
>
> Libvirt had an error handling bug that an imag
On Fri, Aug 10, 2018 at 09:55:50AM +0100, Alex Bennée wrote:
>
> Eduardo Habkost writes:
>
> > On Wed, Aug 08, 2018 at 01:39:31PM +0100, Alex Bennée wrote:
> >> Given our issues with failing disassembly we could try and re-use the
> >> decode tree data to output what instruction is being decoded
On 10/08/2018 12:32, Olaf Hering wrote:
> Am Fri, 10 Aug 2018 12:25:09 +0200
> schrieb Paolo Bonzini :
>
>> There are many more callers of qemu_ram_ptr_length, and none of them check
>> the result.
>
> So you mean that function must not return NULL?
> Or should the caller check for the result?
Thanks for the test case. I'm having difficulty matching up your guest
code with the documentation of the fb mbox tags in
https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface
...
Your code sets the physical height to FBHEIGHT via tag 0x48003, and the
virtual height to FBHEIGHT *
On 08/08/18 21:19, Mark Cave-Ayland wrote:
> On 08/08/18 20:53, Eduardo Habkost wrote:
>
>> On Wed, Aug 08, 2018 at 08:19:51PM +0100, Mark Cave-Ayland wrote:
>>> For the older machines (such as Mac and SPARC) the DT nodes representing
>>> bootdevices for disk nodes are irregular for mainly histor
For the older machines (such as Mac and SPARC) the DT nodes representing
bootdevices for disk nodes are irregular for mainly historical reasons.
Since the majority of bootdevice nodes for these machines either do not have a
separate disk node or require different (custom) names then it is much eas
On 10/08/2018 11:10, Peter Maydell wrote:
>> So my proposal, which is actually consistent with what QEMU is doing, is
>> the following:
>>
>> 1) the first line of a file should always be "/*", otherwise warn
>>
>> 2) a comment that starts with "/**" should have it on a lone line
>>
>> 3) every othe
On 10/08/2018 11:41, Markus Armbruster wrote:
>> Lone "/*" or "/**": 9986 cases
>> of which in the first column: 7617
>> of which the first line in the file (license headers): 2834
>> regex: ^[ \t]*/\*\*?[ \t]*$
>>
>> "/*" with the first line of the comment: 11246
>> of which in
Hi all,
I've been experimenting with adding virtio-blk support to the QEMU
PPC/SPARC64 machines and have found that it is possible for a guest to
program a virtio-blk-pci device such that the qemu-system-ppc process on
the host gets stuck at 100% CPU and requires a "kill -9" to remove it.
The eas
Thanks for your suggestion, I will review your comments carefully and take
modification in the next patch.
Best,
SU Hang
Philippe Mathieu-Daudé 于2018年8月10日周五 下午3:19写道：
> Hi Su,
>
> On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote:
> > From: Su Hang
> >
> > This patch adds Intel Hexadecimal Object
On 10 August 2018 at 13:45, Paolo Bonzini wrote:
> On 10/08/2018 11:10, Peter Maydell wrote:
>>> So my proposal, which is actually consistent with what QEMU is doing, is
>>> the following:
>>>
>>> 1) the first line of a file should always be "/*", otherwise warn
>>>
>>> 2) a comment that starts wi
On Fri, Aug 10, 2018 at 01:40:27PM +0100, Mark Cave-Ayland wrote:
> For the older machines (such as Mac and SPARC) the DT nodes representing
> bootdevices for disk nodes are irregular for mainly historical reasons.
>
> Since the majority of bootdevice nodes for these machines either do not have a
On Thu, 9 Aug 2018 23:01:32 -0400
Pavel Zbitskiy wrote:
> Found while attempting to run an old tool in qemu.
>
> * BAL and BALR:Added.
> * CSST:Qemu crashed after an accidental jump to garbage.
> * IPM: A tool produced an incorrect output.
> * EX TRT/TRTR: A tool
On 10.08.2018 05:01, Pavel Zbitskiy wrote:
> CSST is defined as:
>
> C(0xc802, CSST,SSF, CASS, la1, a2, 0, 0, csst, 0)
>
> It means that the first parameter is handled by in1_la1().
> in1_la1() fills addr1 field, and not in1.
>
> Furthermore, when extract32() is used for the alignment
On Fri 10 Aug 2018 08:26:40 AM CEST, Leonid Bloch wrote:
> Some refactoring for better readability is done here.
>
> Signed-off-by: Leonid Bloch
> -*l2_cache_entry_size = qemu_opt_get_size(
> -opts, QCOW2_OPT_L2_CACHE_ENTRY_SIZE, s->cluster_size);
> +*l2_cache_entry_size = qemu_op
On 10.08.2018 05:01, Pavel Zbitskiy wrote:
> Suppose psw.mask=0x8000, cc=2, r1=0 and we do "ipm 1".
> This command must touch only bits 32-39, so the expected output
> is r1=0x2000. However, currently qemu yields r1=0x20008000,
> because irrelevant parts of PSW leak into r1 during p
On 10.08.2018 05:01, Pavel Zbitskiy wrote:
> Found while attempting to run an old tool in qemu.
>
> * BAL and BALR:Added.
> * CSST:Qemu crashed after an accidental jump to garbage.
> * IPM: A tool produced an incorrect output.
> * EX TRT/TRTR: A tool ran quite slow.
On Fri 10 Aug 2018 08:26:42 AM CEST, Leonid Bloch wrote:
> The refcount cache size does not need to be set to its minimum value in
> read_cache_sizes(), as it is set to at least its minimum value in
> qcow2_update_options_prepare().
>
> Signed-off-by: Leonid Bloch
> -} else {
> -if (!
Paolo Bonzini writes:
> On 10/08/2018 11:41, Markus Armbruster wrote:
>>> Lone "/*" or "/**": 9986 cases
>>> of which in the first column: 7617
>>> of which the first line in the file (license headers): 2834
>>> regex: ^[ \t]*/\*\*?[ \t]*$
>>>
>>> "/*" with the first line of the comme
Signed-off-by: Gerd Hoffmann
---
hw/display/qxl.h | 1 -
hw/display/qxl.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/display/qxl.h b/hw/display/qxl.h
index 089696ef62..6eacba080d 100644
--- a/hw/display/qxl.h
+++ b/hw/display/qxl.h
@@ -43,7 +43,6 @@ typedef struct PCIQXLDevice {
On 08/10/18 14:40, Mark Cave-Ayland wrote:
> For the older machines (such as Mac and SPARC) the DT nodes representing
> bootdevices for disk nodes are irregular for mainly historical reasons.
>
> Since the majority of bootdevice nodes for these machines either do not have a
> separate disk node or
On 10 August 2018 at 14:22, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> hw/display/qxl.h | 1 -
> hw/display/qxl.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/display/qxl.h b/hw/display/qxl.h
> index 089696ef62..6eacba080d 100644
> --- a/hw/display/qxl.h
> +++ b/
In kill_qemu() we have an assert that checks that the QEMU process
didn't dump core:
assert(!WCOREDUMP(wstatus));
Unfortunately the WCOREDUMP macro here means the resulting message
is not very easy to comprehend on at least some systems:
ahci-test: tests/libqtest.c:113: kill_qemu: Ass
Signed-off-by: Gerd Hoffmann
---
hw/display/exynos4210_fimd.c | 4 +---
hw/display/g364fb.c | 2 +-
hw/display/jazz_led.c| 3 +--
hw/display/tc6393xb.c| 4 ++--
hw/display/vga.c | 3 +--
hw/display/virtio-gpu.c | 2 +-
hw/display/vmware_vga.c | 5 +--
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> qobject_from_json() can return null without setting an error on
>> lexical errors. I call that a bug. Add test coverage to demonstrate
>> it.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/check-qjson.c | 36 +++
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/check-qjson.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/check-qjson.c b/tests/check-qjson.c
>> index 81b92d6b0c..0a9a054c7b 100644
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> qmp-test is for QMP protocol tests. Commit e4a426e75ef added generic,
>> basic tests of query commands to it. Move them to their own test
>> program qmp-cmd-test, to keep qmp-test focused on the protocol.
>>
>> Signed-off-
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/libqtest.c | 17 +
>> tests/libqtest.h | 11 +++
>> tests/qmp-test.c | 39 +++
>> 3 files changed, 67 inserti
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> To permit recovering from arbitrary JSON parse errors, the JSON parser
>> resets itself on lexical errors. We recommend sending a 0xff byte for
>> that purpose, and test-qga covers this usage since commit 5229564b832.
>> Th
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> escaped_string() first tests double quoted strings, then repeats a few
>> tests with single quotes. Repeat all of them: store the strings to
>> test without quotes, and wrap them in either kind of quote for
>> testing.
>
>
On 08/10/2018 08:52 AM, Markus Armbruster wrote:
+/* lexical error: impossible byte outside string */
+qtest_qmp_send_raw(qts, "{\xFF");
\xff is an impossible byte inside a string as well; plus it has
special meaning to at least QMP for commanding a parser reset. Is a
better byte more
Add an util function feature_word_description(), which help construct the string
describing the feature word (both CPUID and MSR types).
report_unavailable_features(): add MSR_FEATURE_WORD type support.
x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
x86_cpu_get_supported_feature_wo
Add kvm_get_supported_feature_msrs() to get supported MSR feature index list.
Add kvm_arch_get_supported_msr_feature() to get each MSR features value.
kvm_get_supported_feature_msrs() is called in kvm_arch_init().
kvm_arch_get_supported_msr_feature() is called by
x86_cpu_get_supported_feature_word
KVM side has added the framework (kvm.git:d1d93fa90) to support MSR based
features.
Here is the QEMU part, including data structure changes/expanding, referring
functions changes, and the implementations on
KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl.
Changelog:
v3: patch 2&3 in
Commit 848a1cc1e8b04 while introducing SRAT entries for DIMM and NVDIMM
also introduced fake entries for gaps between memory devices, assuming
that we need all possible range covered with SRAT entries.
And it did it wrong since gap would overlap with preceeding entry.
Reproduced with following CLI:
Define FeatureWordType.
Expand FeatureWordInfo to support both CPUID type feature word as well as
MSR type's.
Change feature_word_info[] accordingly.
Signed-off-by: Robert Hoo
---
target/i386/cpu.c | 133 ++
target/i386/cpu.h | 5 ++
2 files
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> escaped_string() first tests double quoted strings, then repeats a few
>> tests with single quotes. Repeat all of them: store the strings to
>> test without quotes, and wrap them in either kind of quote for
>> testing.
>>
>
After commit b3f1c8c413bc83e4a2cc7a63e4eddf9fe6449052 "qemu-pr-helper: use new
libmultipath API", QEMU started using new libmultipath API, which is not
available on CentOS 7.x.
This fixes that by probing the new libmultipath API in configure. If it fails,
then try probing the old API. If it fail
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Cover surrogates, invalid escapes, and noncharacters. This
>> demonstrates that valid surrogate pairs are misinterpreted, and
>> invalid surrogates and noncharacters aren't rejected.
>>
>> Signed-off-by: Markus Armbruster
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Merge a few closely related test strings, and drop a few redundant
>> ones.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/check-qjson.c | 14 ++
>> 1 file changed, 2 insertions(+), 12 deletions(-)
>>
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> utf8_string() tests only double quoted strings. Cover single quoted
>> strings, too: store the strings to test without quotes, then wrap them
>> in either kind of quote.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> t
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Fix the lexer to reject unescaped control characters in JSON strings,
>> in accordance with RFC 7159.
>
> Question - can this break existing QMP clients that were relying on
> this extension working?
In theory, yes.
The "e
1 - 100 of 191 matches
Mail list logo
