Eric Blake <ebl...@redhat.com> writes: > On 08/08/2018 07:02 AM, Markus Armbruster wrote: >> Merge a few closely related test strings, and drop a few redundant >> ones. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> tests/check-qjson.c | 14 ++------------ >> 1 file changed, 2 insertions(+), 12 deletions(-) >> > >> } test_cases[] = { >> - { "\\b", "\b" }, >> - { "\\f", "\f" }, >> - { "\\n", "\n" }, >> - { "\\r", "\r" }, >> - { "\\t", "\t" }, >> - { "/", "/" }, >> - { "\\/", "/", .skip = 1 }, >> - { "\\\\", "\\" }, >> - { "\\\"", "\"" }, >> - { "hello world \\\"embedded string\\\"", >> - "hello world \"embedded string\"" }, >> - { "hello world\\nwith new line", "hello world\nwith new line" }, >> + { "\\b\\f\\n\\r\\t\\\\\\\"", "\b\f\n\r\t\\\"" }, >> + { "\\/\\'", "/'", .skip = 1 }, > > Aha - this adds coverage of the escaped ' not present in 7/56.
You're right. I'll move that part there. > Aha - this adds coverage of the escaped ' not present in 7/56. (Still > nothing about the unescaped versions of ' or " with correct quoting). > > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!