Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 04/01/2018 15:21, Samuel Thibault wrote: >> Samuel Thibault, on jeu. 04 janv. 2018 15:15:24 +0100, wrote: >>> I'm however still unable to make usb-serial and usb-braille work, as >>> mentioned in my other mail :) >> >> Ah, now with the documentation I understand, one h

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Peter Maydell writes: > On 4 January 2018 at 15:47, Paolo Bonzini wrote: >> The point of deprecation is not to make the interface simpler, it is to >> avoid cases where one option is doing too much and/or crossing >> abstraction boundaries, for example -net creating both a device and a >> hub po

Re: [Qemu-devel] CVE-2017-5715: relevant qemu patches

2018-01-05 Thread Paolo Bonzini
On 04/01/2018 21:15, Stefan Priebe - Profihost AG wrote: > attached the relevant patch for everybody who needs it. This is the original patch from Intel, which doesn't work unless you have a patched kernel (which you almost certainly don't have) and doesn't even warn you about that. In other word

Re: [Qemu-devel] [virtio-dev] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

2018-01-05 Thread Jason Wang
On 2018年01月05日 14:58, Liang, Cunming wrote: Thanks for the pointer. Looks rather interesting. We're also working on it (including defining a standard device for vhost data path acceleration based on mdev to hide vendor specific details). This is exactly what I mean. Form my point of view, th

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Paolo Bonzini
On 05/01/2018 09:18, Markus Armbruster wrote: >>> Would it be possible to make this automatic? Before I could tell people >>> "use -usbdevice braille to test braille", and now it would be >>> "use -chardev braille,chardev=foobar -device usb-braille,chardev=foobar" >> Maybe we can add "-braille" in

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-05 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 01/03/2018 03:38 AM, Juan Quintela wrote: > > Hi > > > > This are the changes for migration that are already reviewed. > > > > Please, apply. > > > > > Alexey Perevalov (6): > > migration: introduce postcopy-blocktime capability > > migra

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-05 Thread Auger Eric
Hi Alexey, On 15/12/17 07:29, Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > With this change,

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-05 Thread Juan Quintela
Eric Blake wrote: > On 01/03/2018 03:38 AM, Juan Quintela wrote: >> Hi >> >> This are the changes for migration that are already reviewed. >> >> Please, apply. >> > >> Alexey Perevalov (6): >> migration: introduce postcopy-blocktime capability >> migration: add postcopy blocktime ct

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/01/2018 09:18, Markus Armbruster wrote: Would it be possible to make this automatic? Before I could tell people "use -usbdevice braille to test braille", and now it would be "use -chardev braille,chardev=foobar -device usb-braille,chardev=foobar" >>>

Re: [Qemu-devel] [Bug 1740364] Re: qemu-img: fails to get shared 'write' lock

2018-01-05 Thread Richard Jones
On Fri, Jan 05, 2018 at 02:44:54AM -, Ping Li wrote: > The behaviour should be expected. Since qemu 2.10, image locking is > enabled which make multiple QEMU processes cannot write to the same > image, even if boot snapshot and backing file at the same time are > not allowed. > You could get i

[Qemu-devel] [Bug 1740364] Re: qemu-img: fails to get shared 'write' lock

2018-01-05 Thread Ping Li
1. The error prompt may be misleading. I guess your backing image should be running. It should report that "failed to get the lock of backing image". The operation will be allowed in the future. 2. Check the help doc of qemu-img, the you can get the support sub-command by force share option "-U".

Re: [Qemu-devel] [PATCH v3 00/18] Various build-sys and sanitizer related fixes

2018-01-05 Thread Paolo Bonzini
On 04/01/2018 17:05, Marc-André Lureau wrote: > Hi, > > This is a series that improves a bit the build system, and introduces > ASAN/UBSan by default when --enable-debug. Then it fixes a few leaks > that occur during make check: common and x86_64 target tests are leak > free after this series. The

Re: [Qemu-devel] [virtio-dev] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

2018-01-05 Thread Liang, Cunming
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, January 5, 2018 4:39 PM > To: Liang, Cunming ; Bie, Tiwei > > Cc: Tan, Jianfeng ; virtio-...@lists.oasis-open.org; > m...@redhat.com; qemu-devel@nongnu.org; alex.william...@redhat.com; > Wang, Xiao W ; s

[Qemu-devel] [qemu-web PATCH] refine spectre blog post

2018-01-05 Thread Paolo Bonzini
People were confused about the level of protection provided by host kernel updates (which do not exist yet, but I digress). They were also asking whether it will be possible to live migrate from old to new QEMU and get the fixes. Clarify both aspects. Suggested-by: Dr. David Alan Gilbert Sugges

Re: [Qemu-devel] CVE-2017-5715: relevant qemu patches

2018-01-05 Thread Stefan Priebe - Profihost AG
Thanks! But it‘s very difficult to get all opinions all together. SuSE Enterprise told me to update: - kernel - qemu - Intel microcode And the released already updates for all of them. Stefan Excuse my typo sent from my mobile phone. > Am 05.01.2018 um 09:33 schrieb Paolo Bonzini : > >> On 04

Re: [Qemu-devel] [qemu-web PATCH] refine spectre blog post

2018-01-05 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > People were confused about the level of protection provided by host kernel > updates (which do not exist yet, but I digress). They were also asking > whether it will be possible to live migrate from old to new QEMU and get > the fixes. Clarify both a

Re: [Qemu-devel] [qemu-web PATCH] refine spectre blog post

2018-01-05 Thread Juan Quintela
Paolo Bonzini wrote: > People were confused about the level of protection provided by host kernel > updates (which do not exist yet, but I digress). They were also asking > whether it will be possible to live migrate from old to new QEMU and get > the fixes. Clarify both aspects. > > Suggested-b

Re: [Qemu-devel] CVE-2017-5715: relevant qemu patches

2018-01-05 Thread Paolo Bonzini
On 05/01/2018 11:40, Stefan Priebe - Profihost AG wrote: > Thanks! But it‘s very difficult to get all opinions all together. > > SuSE Enterprise told me to update: > - kernel > - qemu > - Intel microcode > > And the released already updates for all of them. Yes, but live migrate an updated guest

Re: [Qemu-devel] [PATCH v3 00/16] piix4: cleanup and improvements

2018-01-05 Thread Paolo Bonzini
On 29/12/2017 15:29, Hervé Poussineau wrote: > Hi, > > This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices > are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices > belong. This lets us reuse PIIX4 in other machines, while not loosing any > functionality.

Re: [Qemu-devel] [PATCHv2] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-05 Thread Greg Kurz
On Fri, 5 Jan 2018 14:38:06 +1100 David Gibson wrote: > Currently the pseries machine sets the compatibility mode for the > guest's cpus in two places: 1) at machine reset and 2) after CAS > negotiation. > > This means that if we set or negotiate a compatiblity mode, then > hotplug a cpu, the h

Re: [Qemu-devel] [PATCH] isa/piix: move to mips

2018-01-05 Thread Paolo Bonzini
On 05/01/2018 00:21, Michael S. Tsirkin wrote: > This device is only used on mips, move to the correct maintainer > section. > > Cc: Aurelien Jarno > Cc: Yongbok Kim > Cc: Hervé Poussineau > Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Paolo > --- > MAINTAINERS | 2 +- > 1 fil

Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1

2018-01-05 Thread Alex Bennée
Fam Zheng writes: > On Wed, 01/03 15:54, Michael Clark wrote: >> On Wed, Jan 3, 2018 at 3:41 PM, Fam Zheng wrote: >> >> > On Wed, 01/03 15:00, Michael Clark wrote: >> > > So it's essentially one error, the single line case pattern for >> > > table-driven decode which flags for long lines and as

Re: [Qemu-devel] [PATCH v3 00/16] piix4: cleanup and improvements

2018-01-05 Thread Philippe Mathieu-Daudé
>> This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices >> are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices >> belong. This lets us reuse PIIX4 in other machines, while not loosing any >> functionality. >> >> Last patch allows adding a new PIIX4 device

Re: [Qemu-devel] [PATCH v12 1/6] migration: introduce postcopy-blocktime capability

2018-01-05 Thread Alexey Perevalov
On 01/03/2018 12:20 AM, Eric Blake wrote: On 10/30/2017 08:16 AM, Alexey Perevalov wrote: Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory pa

Re: [Qemu-devel] [PATCH v12 6/6] migration: add postcopy total blocktime into query-migrate

2018-01-05 Thread Alexey Perevalov
On 01/03/2018 12:26 AM, Eric Blake wrote: On 10/30/2017 08:16 AM, Alexey Perevalov wrote: Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy block

Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1

2018-01-05 Thread Fam Zheng
On Fri, 01/05 11:49, Alex Bennée wrote: > > Fam Zheng writes: > > > On Wed, 01/03 15:54, Michael Clark wrote: > >> On Wed, Jan 3, 2018 at 3:41 PM, Fam Zheng wrote: > >> > >> > On Wed, 01/03 15:00, Michael Clark wrote: > >> > > So it's essentially one error, the single line case pattern for > >>

Re: [Qemu-devel] [PATCH 1/6] hw/sd/milkymist-memcard: use qemu_log_mask()

2018-01-05 Thread Philippe Mathieu-Daudé
I'm too comfortable with the 'log' trace backend and again forgot to add the "qemu/log.h" dependency ... /home/travis/build/philmd/qemu/hw/sd/milkymist-memcard.c:141:17: error: implicit declaration of function ‘qemu_log_mask’ [-Werror=implicit-function-declaration] qemu_log_mask(L

Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1

2018-01-05 Thread Alex Bennée
Fam Zheng writes: > On Fri, 01/05 11:49, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Wed, 01/03 15:54, Michael Clark wrote: >> >> On Wed, Jan 3, 2018 at 3:41 PM, Fam Zheng wrote: >> >> >> >> > On Wed, 01/03 15:00, Michael Clark wrote: >> >> > > So it's essentially one error, the sing

Re: [Qemu-devel] [PATCHv2] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-05 Thread satheesh rajendran
On Fri, Jan 05, 2018 at 12:19:14PM +0100, Greg Kurz wrote: > On Fri, 5 Jan 2018 14:38:06 +1100 > David Gibson wrote: > > > Currently the pseries machine sets the compatibility mode for the > > guest's cpus in two places: 1) at machine reset and 2) after CAS > > negotiation. > > > > This means t

[Qemu-devel] [PATCH v4 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-05 Thread Daniel Henrique Barboza
When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a notific

[Qemu-devel] [PATCH v4 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-01-05 Thread Daniel Henrique Barboza
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP c

[Qemu-devel] [PATCH v4 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-01-05 Thread Daniel Henrique Barboza
v4: - added a comment in 'qemu_register_wakeup_notifier' about the effects of adding a wakeup notifier without proper suspend/wakeup support in the logic of the new wakeup-suspend-support flag, as suggested by Mike Roth - previous version link: https://lists.gnu.org/archive/html/qemu-devel/2018-01/

Re: [Qemu-devel] [PATCH v1 06/19] fpu/softfloat: propagate signalling NaNs in MINMAX

2018-01-05 Thread Alex Bennée
Richard Henderson writes: > On 12/11/2017 04:56 AM, Alex Bennée wrote: >> While a comparison between a QNaN and a number will return the number >> it is not the same with a signaling NaN. In this case the SNaN will >> "win" and after potentially raising an exception it will be quietened. >> >> S

[Qemu-devel] [PATCH 0/1] qemu/nbd: fix segmentation fault when .desc is not null-terminated

2018-01-05 Thread Murilo Opsfelder Araujo
Hello, QEMU community. The following patch is to fix a segmentation fault when nbd_runtime_opts.desc is not null-terminated. This issue emerged when building QEMU with --enable-gcov, as described by https://bugs.launchpad.net/qemu/+bug/1727259. To reproduce on ppc64le, run the following commands

[Qemu-devel] [PATCH 1/1] block/nbd: fix segmentation fault when .desc is not null-terminated

2018-01-05 Thread Murilo Opsfelder Araujo
The find_desc_by_name() from util/qemu-option.c relies on the .name not being NULL to call strcmp(). This check becomes unsafe when the list is not NULL-terminated, which is the case of nbd_runtime_opts in block/nbd.c, and can result in segmentation fault when strcmp() tries to access an invalid me

[Qemu-devel] [Bug 1727259] Re: qemu-io-test 58 segfaults when configured with gcov

2018-01-05 Thread Murilo Opsfelder Araújo
Patch sent: http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00883.html ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1727259 Title:

Re: [Qemu-devel] [PATCH 1/1] block/nbd: fix segmentation fault when .desc is not null-terminated

2018-01-05 Thread Eric Blake
On 01/05/2018 07:32 AM, Murilo Opsfelder Araujo wrote: > The find_desc_by_name() from util/qemu-option.c relies on the .name not being > NULL to call strcmp(). This check becomes unsafe when the list is not > NULL-terminated, which is the case of nbd_runtime_opts in block/nbd.c, and can > result in

[Qemu-devel] [qemu-web PATCH] improved phrasing regarding Meltdown and live migration

2018-01-05 Thread Paolo Bonzini
--- _posts/2018-01-04-spectre.md | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/_posts/2018-01-04-spectre.md b/_posts/2018-01-04-spectre.md index 5bbc7ed..ca11324 100644 --- a/_posts/2018-01-04-spectre.md +++ b/_posts/2018-01-04-spectre.md @@ -13,11 +13

Re: [Qemu-devel] [PATCH] oslib-posix: check for posix_memalign in configure script

2018-01-05 Thread Kamil Rytarowski
On 04.01.2018 18:39, Andreas Gustafsson wrote: > Check for the presence of posix_memalign() in the configure script, > not using "defined(_POSIX_C_SOURCE) && !defined(__sun__)". This > lets qemu use posix_memalign() on NetBSD versions that have it, > instead of falling back to valloc() which is wa

Re: [Qemu-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysbus device list

2018-01-05 Thread Anthony PERARD
On Sat, Nov 25, 2017 at 01:16:09PM -0200, Eduardo Habkost wrote: > There's no need to make the machine allow every possible sysbus > device. We can now just add xen-sysdev to the allowed list. > > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: xen-de...@lists.xenproject.org > Cc: Juergen Gro

[Qemu-devel] [PATCH] block/ssh: fix possible segmentation fault when .desc is not null-terminated

2018-01-05 Thread Murilo Opsfelder Araujo
This patch prevents a possible segmentation fault when .desc members are checked against NULL. The ssh_runtime_opts was added by commit 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for runtime options"). This fix was inspired by http://lists.nongnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [PATCH 1/1] block/nbd: fix segmentation fault when .desc is not null-terminated

2018-01-05 Thread Murilo Opsfelder Araújo
On 01/05/2018 11:57 AM, Eric Blake wrote: > On 01/05/2018 07:32 AM, Murilo Opsfelder Araujo wrote: >> The find_desc_by_name() from util/qemu-option.c relies on the .name not being >> NULL to call strcmp(). This check becomes unsafe when the list is not >> NULL-terminated, which is the case of nbd_r

Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure

2018-01-05 Thread Eric Blake
On 01/05/2018 12:47 AM, Michael Clark wrote: >> >>> +## >>> +{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } } >> >> Should this be 'uint64' or other specific type, rather than the generic >> 'int' (which happens to be 64 bits, but signed)? Other architectures >> use 'int' because of history,

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

2018-01-05 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 06:49:22PM -0300, Philippe Mathieu-Daudé wrote: > Use Base64 to serialize the binary blobs in JSON. > So far at most 512 bytes will be transfered, which result > in a 684 bytes payload. > Since this command is intented for qtesting, it is acceptable. Not a requirement, but

Re: [Qemu-devel] [RFC PATCH v2 2/4] libqos: add a sdbus API

2018-01-05 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 06:49:23PM -0300, Philippe Mathieu-Daudé wrote: > +typedef struct SDBusAdapter SDBusAdapter; > +struct SDBusAdapter { > + > +ssize_t (*do_command)(SDBusAdapter *adapter, enum NCmd cmd, uint32_t arg, > + uint8_t **response); > +void (*write_by

Re: [Qemu-devel] [RFC PATCH v2 3/4] libqos: implement sdbus QMP driver

2018-01-05 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 06:49:24PM -0300, Philippe Mathieu-Daudé wrote: > +static const char *qmp_sdbus_getpath(const char *blkname) > +{ > +QDict *response, *minfo; > +QList *list; > +const QListEntry *le; > +QString *qstr; > +const char *mname; > +QObject *qobj; > + > +

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-05 Thread Alex Williamson
On Fri, 5 Jan 2018 10:48:07 +0100 Auger Eric wrote: > Hi Alexey, > > On 15/12/17 07:29, Alexey Kardashevskiy wrote: > > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > > which tells that a region with MSIX data can be mapped entirely, i.e. > > the VFIO PCI driver won't pr

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

2018-01-05 Thread Eric Blake
On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote: > Use Base64 to serialize the binary blobs in JSON. > So far at most 512 bytes will be transfered, which result s/transfered/transferred/ > in a 684 bytes payload. > Since this command is intented for qtesting, it is acceptable. s/intented/in

Re: [Qemu-devel] [RFC PATCH v2 4/4] tests: add some sdcard qtest

2018-01-05 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 06:49:25PM -0300, Philippe Mathieu-Daudé wrote: > +static const char *machines[PROTO_COUNT] = { > +[PROTO_SD] = "nuri", > +//[PROTO_MMC] = "vexpress-a9", > +//[PROTO_SPI] = "lm3s6965evb" > +}; > + > +static const uint64_t sizes[] = { > +//512 * M_BYTE, > +

Re: [Qemu-devel] [RFC PATCH v2 0/4] sdbus: testing sdcards

2018-01-05 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 06:49:21PM -0300, Philippe Mathieu-Daudé wrote: > This RFC series intends to add a sdcard test in C using the libqos. Thanks for adding sdbus support to libqos! Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] vhost-user graceful connect/disconnect

2018-01-05 Thread Stefan Hajnoczi
On Thu, Jan 04, 2018 at 07:15:38PM +0800, Wei Wang wrote: > On 01/04/2018 06:47 PM, Stefan Hajnoczi wrote: > > On Thu, Dec 21, 2017 at 06:01:29AM -0500, Marc-André Lureau wrote: > > > > I'm not going to prototype this yet, I'm working on virtio-vhost-user > > first, but eventually I might get back

Re: [Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float

2018-01-05 Thread Alex Bennée
Richard Henderson writes: > On 12/11/2017 04:57 AM, Alex Bennée wrote: >> These are considerably simpler as the lower order integers can just >> use the higher order conversion function. As the decomposed fractional >> part is a full 64 bit rounding and inexact handling comes from the >> pack fu

Re: [Qemu-devel] [RFC PATCH v2 4/4] tests: add some sdcard qtest

2018-01-05 Thread Philippe Mathieu-Daudé
Hi Stefan, On 01/05/2018 12:31 PM, Stefan Hajnoczi wrote: > On Wed, Jan 03, 2018 at 06:49:25PM -0300, Philippe Mathieu-Daudé wrote: >> +static const char *machines[PROTO_COUNT] = { >> +[PROTO_SD] = "nuri", >> +//[PROTO_MMC] = "vexpress-a9", >> +//[PROTO_SPI] = "lm3s6965evb" >> +}; >> +

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Move img_open error reporting to callers

2018-01-05 Thread Eric Blake
On 01/05/2018 12:55 AM, Fam Zheng wrote: > In the next patch one caller will have a special error handling logic > than reporting it, add "Error **" parameters to functions and give s/than/rather than/ s/it, add/it. Add/ > control back to callers, to make that possible. > > Update iotests outpu

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

2018-01-05 Thread Philippe Mathieu-Daudé
Hi Eric, On 01/05/2018 12:29 PM, Eric Blake wrote: > On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result > > s/transfered/transferred/ > >> in a 684 bytes payload. >> Since this co

Re: [Qemu-devel] [PATCH 2/2] qemu-img: info: try -U automatically

2018-01-05 Thread Eric Blake
On 01/05/2018 12:55 AM, Fam Zheng wrote: > The error message we had didn't have a hint about "-U" when locking the > image failed, which is not friendly. Also it is imaginable that the > reaction to that error by the user would be a retry with '-U'. > > So the reason we require "-U" for "qemu-img

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

2018-01-05 Thread Eric Blake
On 01/05/2018 10:06 AM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 01/05/2018 12:29 PM, Eric Blake wrote: >> On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote: >>> Use Base64 to serialize the binary blobs in JSON. >>> So far at most 512 bytes will be transfered, which result >> >> s/transf

Re: [Qemu-devel] vhost-user graceful connect/disconnect

2018-01-05 Thread Stefan Hajnoczi
On Thu, Jan 04, 2018 at 06:53:07PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 19, 2017 at 04:21:51PM +, Stefan Hajnoczi wrote: > > Hi, > > Vhost-user implementations assume the slave is already running before > > the master starts. The slave is required during virtio device > > initializat

Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2018-01-05 Thread Philippe Mathieu-Daudé
On 12/18/2017 06:44 PM, Richard Henderson wrote: > On 12/11/2017 04:56 AM, Alex Bennée wrote: >> +static inline float16 float16_set_sign(float16 a, int sign) >> +{ >> +return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); >> +} >> + > > 1) Do we use this anywhere? > > 2) While this i

Re: [Qemu-devel] [PATCH v12 6/6] migration: add postcopy total blocktime into query-migrate

2018-01-05 Thread Eric Blake
On 01/05/2018 06:15 AM, Alexey Perevalov wrote: > On 01/03/2018 12:26 AM, Eric Blake wrote: >> On 10/30/2017 08:16 AM, Alexey Perevalov wrote: >>> Postcopy total blocktime is available on destination side only. >>> But query-migrate was possible only for source. This patch >>> adds ability to call

Re: [Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread

2018-01-05 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:39PM +0800, Peter Xu wrote: > Create one IOThread for the monitors, prepared to handle all the > input/output IOs using existing iothread framework. > > Signed-off-by: Peter Xu > --- > monitor.c | 29 + > 1 file changed, 29 insertions(+)

Re: [Qemu-devel] [PATCH] scsi: Don't deference in_buf if NULL

2018-01-05 Thread Anthoine Bourgeois
On Thu, Jan 04, 2018 at 11:02:25AM -0600, Eric Blake wrote: On 01/03/2018 08:42 PM, Fam Zheng wrote: scsi_disk_emulate_command passes in_buf=NULL and in_len=0 in the REQUEST_SENSE branch. Inline the fixed_in evaluation and put it after the in_len test. Signed-off-by: Fam Zheng --- scsi/utils.

Re: [Qemu-devel] [PATCH] block/ssh: fix possible segmentation fault when .desc is not null-terminated

2018-01-05 Thread Eric Blake
On 01/05/2018 08:44 AM, Murilo Opsfelder Araujo wrote: > This patch prevents a possible segmentation fault when .desc members are > checked > against NULL. > > The ssh_runtime_opts was added by commit > 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for runtime > options"). >

[Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing

2018-01-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add some comments so I can understand the various nested loops. Add some tracing so I can see what they're doing. Signed-off-by: Dr. David Alan Gilbert --- exec.c | 17 - trace-events | 3 +++ 2 files changed, 19 insertions(+), 1 deletion(-

[Qemu-devel] [PATCH 0/2] find_ram_offset cleanups and alignment

2018-01-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This is mainly the alignment change that Paolo asked for in the 2nd commit, but while I was there I added some comments and tracing that I've split out. Dave Dr. David Alan Gilbert (2): find_ram_offset: Add comments and tracing find_ram_offset: Align ram

[Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries

2018-01-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The dirty bitmaps are built from 'long'sand there is fast-path code for synchronising the case where the RAMBlock is aligned to the start of a long boundary. Align the allocation to this boundary to cause the fast path to be used. Offsets before change: 11398@1515

Re: [Qemu-devel] [PATCH 1/1] block/nbd: fix segmentation fault when .desc is not null-terminated

2018-01-05 Thread Eric Blake
On 01/05/2018 08:47 AM, Murilo Opsfelder Araújo wrote: >>> This patch fixes the segmentation fault in strcmp() by adding a NULL >>> element at >>> the end of nbd_runtime_opts.desc list, which is the common practice to most >>> of >>> other structs like runtime_opts in block/null.c. Thus, the des

Re: [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries

2018-01-05 Thread Eric Blake
On 01/05/2018 11:01 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The dirty bitmaps are built from 'long'sand there is fast-path code s/'long'sand/'long's, and/ > for synchronising the case where the RAMBlock is aligned to the start > of a long boundary. Align th

Re: [Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing

2018-01-05 Thread Eric Blake
On 01/05/2018 11:01 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add some comments so I can understand the various nested loops. > Add some tracing so I can see what they're doing. > > Signed-off-by: Dr. David Alan Gilbert > --- > exec.c | 17 +

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-05 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:40PM +0800, Peter Xu wrote: > if (monitor_is_qmp(mon)) { > -qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, > monitor_qmp_read, > - monitor_qmp_event, NULL, mon, NULL, true); > qemu_chr_fe_set_echo(&mon->chr,

Re: [Qemu-devel] [PATCH RFC 1/1] tests: Add migration test for aarch64

2018-01-05 Thread Wei Huang
On 01/04/2018 02:10 PM, Juan Quintela wrote: > Wei Huang wrote: >> This patch adds the migration test support for aarch64. The test code, >> which implements the same functionality as x86, is compiled into a binary >> and booted as a kernel to qemu. Here are the design ideas: >> >> * We choose t

Re: [Qemu-devel] [PATCH RFC 1/1] tests: Add migration test for aarch64

2018-01-05 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 01/04/2018 02:10 PM, Juan Quintela wrote: > > Wei Huang wrote: > > But once that everybody is looking, I would like to open a discussion > > about how to make more abstract this test, and not adding so many bits > > each time that we need to create a

[Qemu-devel] linux-user/mmap: Should not return NULL on guest call mmap(NULL, ...), causes crash inside glibc

2018-01-05 Thread Maximilian Riemensberger
Hi, yesterday I hit the following problem when running an arm linux executable on qemu-2.10 (qemu-arm-static through binfmt_misc) 1879 mmap2(NULL,8388608,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANONYMOUS|0x2,-1,0) = 0x 1879 write(2,0xf6fd39d0,79) stx_test: allocatestack.c:514: allocat

Re: [Qemu-devel] linux-user/mmap: Should not return NULL on guest call mmap(NULL, ...), causes crash inside glibc

2018-01-05 Thread Peter Maydell
On 5 January 2018 at 18:13, Maximilian Riemensberger wrote: > Hi, > > yesterday I hit the following problem when running an arm linux executable on > qemu-2.10 (qemu-arm-static through binfmt_misc) > > 1879 > mmap2(NULL,8388608,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANONYMOUS|0x2,-1,0) > = 0x0

Re: [Qemu-devel] [PATCH] isa/piix: move to mips

2018-01-05 Thread Philippe Mathieu-Daudé
Hi Michael, On Thu, Jan 4, 2018 at 8:21 PM, Michael S. Tsirkin wrote: > This device is only used on mips, move to the correct maintainer > section. > > Cc: Aurelien Jarno > Cc: Yongbok Kim > Cc: Hervé Poussineau > Signed-off-by: Michael S. Tsirkin > --- > MAINTAINERS | 2 +- > 1 file changed

Re: [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test

2018-01-05 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 68 >> ++ >> 1 file changed, 68 insertions(+) >> >> diff --git a/tests/migration-test.c b/tests/migr

[Qemu-devel] [Bug 1727250] Re: qemu-io-test 147 segfaults when configured with gcov

2018-01-05 Thread Murilo Opsfelder Araújo
I confirmed that my patch http://lists.nongnu.org/archive/html/qemu- devel/2018-01/msg00883.html fixes this bug too. ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Murilo Opsfelder Araújo (mopsfelder) -- You received this bug notificatio

Re: [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test

2018-01-05 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> tests/migration-test.c | 68 > >> ++ > >> 1 file changed, 68 insertions

[Qemu-devel] [PATCH v4 2/2] migration: Set the migration tcp port

2018-01-05 Thread Juan Quintela
We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela -- This was migrate_set_uri(), but as we only need the tcp_port, change to that one. --- migration/migration.c | 10 +

[Qemu-devel] [PATCH v4 0/2] Improve info migrate output on destination

2018-01-05 Thread Juan Quintela
Hi In v4: Based-on: 20180103093834.20879-1-quint...@redhat.com - update and rebase - tcp-port is not a property that can be set anymore (peter xu) - improve comments (eric) Please, review. [v3] On top of my previous migration-for-2.11 patches. - We don't create an uri parameter, just too compl

[Qemu-devel] [PATCH v4 1/2] migration: Create tcp_port parameter

2018-01-05 Thread Juan Quintela
It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense. --- hmp.c

Re: [Qemu-devel] linux-user/mmap: Should not return NULL on guest call mmap(NULL, ...), causes crash inside glibc

2018-01-05 Thread Maximilian Riemensberger
On 05.01.18 19:38, Peter Maydell wrote: > On 5 January 2018 at 18:13, Maximilian Riemensberger > wrote: >> Hi, >> >> yesterday I hit the following problem when running an arm linux executable on >> qemu-2.10 (qemu-arm-static through binfmt_misc) >> >> 1879 >> mmap2(NULL,8388608,PROT_READ|PROT_WRI

[Qemu-devel] [Bug 1731957] Re: qemu-kvm exits with console permission problems

2018-01-05 Thread David Moreau Simard
These might be helpful or related: - https://bugzilla.redhat.com/show_bug.cgi?id=1499800 - https://bugzilla.redhat.com/show_bug.cgi?id=1501957 ** Bug watch added: Red Hat Bugzilla #1499800 https://bugzilla.redhat.com/show_bug.cgi?id=1499800 ** Bug watch added: Red Hat Bugzilla #1501957 http

Re: [Qemu-devel] [PATCH v1 12/21] RISC-V HART Array

2018-01-05 Thread Antony Pavlov
On Wed, 3 Jan 2018 13:44:16 +1300 Michael Clark wrote: > Holds the state of a heterogenous array of RISC-V hardware threads. ... > --- /dev/null > +++ b/include/hw/riscv/riscv_hart.h > @@ -0,0 +1,45 @@ > +/* > + * QEMU RISC-V Hart Array interface > + * > + * Copyright (c) 2017 SiFive, Inc. > +

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

2018-01-05 Thread Philippe Mathieu-Daudé
Hi Eric, On Fri, Jan 5, 2018 at 12:29 PM, Eric Blake wrote: > On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote: [...] >> +if (ambiguous) { >> +error_setg(errp, "Path '%s' is ambiguous", qom_path); >> +} else { >> +error_set(errp, ERROR_CLASS_DEVICE_NOT_

Re: [Qemu-devel] [PATCH v1 19/21] SiFive Freedom E300 RISC-V Machine

2018-01-05 Thread Antony Pavlov
On Wed, 3 Jan 2018 13:44:23 +1300 Michael Clark wrote: > This provides a RISC-V Board compatible with the the SiFive E300 SDK. > The following machine is implemented: > > - 'sifive_e300'; CLINT, PLIC, UART, AON, GPIO, QSPI, PWM > ... > diff --git a/include/hw/riscv/sifive_e300.h b/include/hw

Re: [Qemu-devel] [PATCH v1 12/21] RISC-V HART Array

2018-01-05 Thread Eric Blake
On 01/05/2018 03:41 PM, Antony Pavlov wrote: > On Wed, 3 Jan 2018 13:44:16 +1300 > Michael Clark wrote: > >> Holds the state of a heterogenous array of RISC-V hardware threads. > > > Hmm, you use SysBusDevice, uint32_t and RISCVCPU types but there is no header > files > inclusion to define t

[Qemu-devel] [PATCH v4 01/11] tests: Remove deprecated migration tests commands

2018-01-05 Thread Juan Quintela
We move to use migration_set_parameter() for everything. Signed-off-by: Juan Quintela --- tests/migration-test.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 9fd5dadc0d..0448bc77dc 100

[Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration

2018-01-05 Thread Juan Quintela
Hi In v4: Based-on: 20180105205109.683-1-quint...@redhat.com Changes: - rebase on top on v4 info_migrate patches - Tune sleeps to make patches fast - Create a deprecated test for deprecated commands (i.e. make peterxu happy) - create migrate_start_postcopy function - fix naming/sizes between po

[Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-05 Thread Juan Quintela
Argument file is also needed there. Signed-off-by: Juan Quintela --- tests/migration-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 0448bc77dc..32f3bb86a8 100644 --- a/tests/migration-test.c +++ b/tests/migration

[Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration

2018-01-05 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 32f3bb86a8..d81f22118b 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -434,27 +434,

[Qemu-devel] [PATCH v4 07/11] tests: Add basic migration precopy tcp test

2018-01-05 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 59 +++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test

2018-01-05 Thread Juan Quintela
We add deprecated commands on a new test, so we don't have to add it on normal tests. Signed-off-by: Juan Quintela --- tests/migration-test.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c in

[Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-05 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index d81f22118b..f469235d0b 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -440,13 +440,13

[Qemu-devel] [PATCH v4 09/11] tests: Create migrate-start-postcopy command

2018-01-05 Thread Juan Quintela
This way, it is like the rest of commands Signed-off-by: Juan Quintela --- tests/migration-test.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index c25c9dd7b1..70b3c0870b 100644 --- a/tests/migration-test.c +

[Qemu-devel] [PATCH v4 06/11] tests: Add migration precopy test

2018-01-05 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index bcb0a82d42..88653ad767 100644 --- a/

[Qemu-devel] [PATCH v4 08/11] tests: Add migration xbzrle test

2018-01-05 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 67 +- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 024b6675fb..c25c9dd7b1 100644 --- a/tests/migration-test.c +++ b/tes

[Qemu-devel] [PATCH v4 11/11] [RFH] tests: Add migration compress threads tests

2018-01-05 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 51 +++

[Qemu-devel] [PATCH v4 10/11] tests: Adjust sleeps for migration test

2018-01-05 Thread Juan Quintela
Also reorder code to not sleep when event already happened. Signed-off-by: Juan Quintela --- tests/migration-test.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 70b3c0870b..8914829006 100

Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1

2018-01-05 Thread Paolo Bonzini
On 05/01/2018 13:25, Fam Zheng wrote: >> >> CheckpatchFlags: --ignore-long-lines > It sounds feasible. Putting these flags after a --- line will keep commit > message clean. > > OTOH I think we should spend effort on patching checkpatch.pl to implement > this. Maybe just add something like Pa

  1   2   >