On 01/05/2018 12:47 AM, Michael Clark wrote:
>>
>>> +##
>>> +{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } }
>>
>> Should this be 'uint64' or other specific type, rather than the generic
>> 'int' (which happens to be 64 bits, but signed)? Other architectures
>> use 'int' because of history, but we could use this chance to improve
>> things if desired.
>>
>
> I'll have to defer to your better judgement as to whether we need to change
> this. I like consistency. Is it a change that needs to be made to multiple
> arches? It sounds relatively low risk. You decide.
>
> QAPI Schema
> M: Eric Blake <ebl...@redhat.com>
> M: Markus Armbruster <arm...@redhat.com>I'm fine if this patch uses 'int' for consistency, and will wait for Markus to chime in on whether changing CpuInfo to use specific integer types in general is worth a separate series later on. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
