On 01/05/2018 10:06 AM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 01/05/2018 12:29 PM, Eric Blake wrote: >> On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote: >>> Use Base64 to serialize the binary blobs in JSON. >>> So far at most 512 bytes will be transfered, which result >> >> s/transfered/transferred/ >> >>> in a 684 bytes payload. >>> Since this command is intented for qtesting, it is acceptable. >> >> s/intented/intended/ >> >> Might be worth mentioning the actual command name, >> x-debug-sdbus-command, in the commit message to make future git log >> trawling easier. > > Ok. > > What about using 'x-qtest-sdbus-command'?
x-debug matches existing practice, x-qtest does not. I'm fine with the name you had chosen, and was just asking that it be mentioned in the commit log. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
