On 01/05/2018 03:41 PM, Antony Pavlov wrote: > On Wed, 3 Jan 2018 13:44:16 +1300 > Michael Clark <m...@sifive.com> wrote: > >> Holds the state of a heterogenous array of RISC-V hardware threads. >
> > Hmm, you use SysBusDevice, uint32_t and RISCVCPU types but there is no header > files > inclusion to define these types. > > I propose this fixup: > > --- a/include/hw/riscv/riscv_hart.h > +++ b/include/hw/riscv/riscv_hart.h > @@ -27,6 +27,10 @@ > #ifndef HW_RISCV_HART_H > #define HW_RISCV_HART_H > > +#include "qemu/osdep.h" NACK to this part. Our policy is that all .c files should include osdep.h before anything else, and therefore, all .h files can assume that osdep.h has already been included. Extending that logic, uint32_t is always available for use in any .h, without having to add any includes. > +#include "hw/sysbus.h" > +#include "target/riscv/cpu.h" But including these headers for SysBusDevice and RISCVCPU makes sense. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
