Re: [Qemu-devel] [PATCH RFC 1/3] tcg: support MOV_VEC and MOVI_VEC opcodes in register allocator

2017-11-22 Thread Richard Henderson
On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > Signed-off-by: Kirill Batuzov > --- > tcg/tcg.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index a7854a59a1..6db7dd526a 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -3327,10 +3327,12 @@ int tcg_gen_code(TC

Re: [Qemu-devel] [PATCH RFC 3/3] tcg/optimize: handle vector loads and stores during copy propagation

2017-11-22 Thread Richard Henderson
On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > +} else if (re == INDEX_op_mov_vec) { > +if (ts_are_copies(arg_temp(op->args[0]), ml->copy)) { > +tcg_op_remove(s, op); > +break; > +

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 04:23 AM, Michael Roth wrote: > Quoting Christian Borntraeger (2017-11-21 15:38:32) >> forgot to cc qemu-devel >> >> On 11/21/2017 10:37 PM, Christian Borntraeger wrote: >>> a quick heads up . Rc2 now triggers >>> +qemu-img: block/block-backend.c:2088: blk_root_drained_end: Asse

[Qemu-devel] [PATCH] vfio/common: init giommu_list and hostwin_list of vfio container

2017-11-22 Thread Liu, Yi L
The init of giommu_list and hostwin_list is missed during container initialization. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 7b2924c..14c5940 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c

Re: [Qemu-devel] [PATCH RFC 3/3] tcg/optimize: handle vector loads and stores during copy propagation

2017-11-22 Thread Richard Henderson
On 11/22/2017 09:06 AM, Richard Henderson wrote: > On 11/09/2017 03:41 PM, Kirill Batuzov wrote: >> +} else if (re == INDEX_op_mov_vec) { >> +if (ts_are_copies(arg_temp(op->args[0]), ml->copy)) >> { >> +tcg_op_remove(s, op); >

Re: [Qemu-devel] [PATCH v1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-22 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Daniel Henrique Barboza wrote: >> > When migrating a VM with 'migrate_set_capability postcopy-ram on' >> > a postcopy_state is set during the process, ending up with the >> > state POSTCOPY_INCOMING_END when the mig

Re: [Qemu-devel] [PULL 0/2] Migration pull request

2017-11-22 Thread Juan Quintela
Juan Quintela wrote: > Hi > > THis has two fixes for migration, please apply. > > Later, Juan. > > The following changes since commit a15d835f00dce270fd3194e83d9910f4b5b44ac0: > > Update version for v2.11.0-rc2 release (2017-11-21 17:50:36 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
22.11.2017 03:10, John Snow wrote: On 11/21/2017 12:23 PM, Kevin Wolf wrote: Am 17.11.2017 um 22:35 hat John Snow geschrieben: usage is like this: 1. we have dirty bitmap bitmap0 for incremental backup. 2. prepare image fleecing (create temporary image with backing=our_disk) 3. in qmp transa

[Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Juan Quintela
This commit started use tb_unlock() and tlb_set_dirty() on non TCG code. Add the function as stubs. commit 27266271977c5a30f2f7d493e042be1897827bdd Author: Peter Maydell Date: Mon Nov 20 18:08:27 2017 + exec.c: Factor out before/after actions for notdirty memory writes Signe

Re: [Qemu-devel] [PATCH RFC 2/3] tcg/optimize: do copy propagation for memory locations

2017-11-22 Thread Richard Henderson
On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > +typedef struct TCGMemLocation { > +/* Offset is relative to ENV. Only fields of CPUState are accounted. */ > +tcg_target_ulong offset; > +tcg_target_ulong size; > +TCGType type; > +/* Pointer to a temp containing a valid copy of

[Qemu-devel] [PULL 1/2] migration, xen: Fix block image lock issue on live migration

2017-11-22 Thread Juan Quintela
From: Anthony PERARD When doing a live migration of a Xen guest with libxl, the images for block devices are locked by the original QEMU process, and this prevent the QEMU at the destination to take the lock and the migration fail. >From QEMU point of view, once the RAM of a domain is migrated,

[Qemu-devel] [PULL 0/2] Migration PULL take 2

2017-11-22 Thread Juan Quintela
://github.com/juanquintela/qemu.git tags/migration/20171122 for you to fetch changes up to acab30b85db0885ab161aff4c83c550628f6d8ca: migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END (2017-11-22 08:5

[Qemu-devel] [PULL 2/2] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-22 Thread Juan Quintela
From: Daniel Henrique Barboza When migrating a VM with 'migrate_set_capability postcopy-ram on' a postcopy_state is set during the process, ending up with the state POSTCOPY_INCOMING_END when the migration is over. This postcopy_state is taken into account inside ram_load to check how it will loa

Re: [Qemu-devel] [PATCH for-2.12 1/2] cadence_ttc: extract CadenceTTCState to a new header file

2017-11-22 Thread KONRAD Frederic
On 11/21/2017 07:41 PM, Peter Maydell wrote: On 8 November 2017 at 11:32, KONRAD Frederic wrote: We want to add this model to the xlnx-zynqmp board so let's make CadenceTTCState available in an header file. Signed-off-by: KONRAD Frederic --- hw/timer/cadence_ttc.c | 35 +--

Re: [Qemu-devel] "make -C roms lgplvgabios" broken

2017-11-22 Thread Gerd Hoffmann
Hi, > Do we still care enough about lgplvgabios to try to fix that, or > should we just remove the lgplvgabios rules and the roms/vgabios > submodule? The last commit in our vgabios.git submodule was 7 > years ago. I plan to zap it anyway when switching to the separate firmware repo[1]. Which

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Jeff Cody
On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > Quoting Christian Borntraeger (2017-11-21 15:38:32) > >> forgot to cc qemu-devel > >> > >> On 11/21/2017 10:37 PM, Christian Borntraeger wrote: > >>> a quick heads up .

[Qemu-devel] [PATCH 0/5] NBD server refactoring before BLOCK_STATUS

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Hi all. Here are some preliminary refactoring before implementing BLOCK_STATUS extension. Vladimir Sementsov-Ogievskiy (5): nbd/server: refactor negotiation functions parameters nbd/server: add nbd_opt_{read,drop} to track client->optlen nbd/server: add helper nbd_opt_invalid nbd: rename n

[Qemu-devel] [PATCH 4/5] nbd: rename nbd_option and nbd_opt_reply

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Rename nbd_optino and nbd_opt_reply to NBDOption and NBDOptionReply to correspond to Qemu coding style and other structures here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 8 nbd/client.c| 12 ++-- 2 files changed, 10 insertions(+), 10 deleti

[Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index bccc0274e7..c9445a89e9 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -139,6 +139,19 @@ static v

[Qemu-devel] [PATCH 5/5] nbd/server: structurize option reply sending

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 79b937d88f..975fe8efe9 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -152,43 +152,29 @@ s

[Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 74 +--- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index c9445a89e9..79b937d88f 100644 --- a/nbd/server.c +++ b/nbd/server.c @@

[Qemu-devel] [PATCH 1/5] nbd/server: refactor negotiation functions parameters

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
Instead of passing currently negotiating option and its length to many of negotiation functions let's just store them on NBDClient struct to be state-variables of negotiation phase. This unifies semantics of negotiation functions and this allows to track changes of remaining option length in futur

Re: [Qemu-devel] [Qemu-block] [PULL 1/4] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-22 Thread Kevin Wolf
Am 21.11.2017 um 18:03 hat Jeff Cody geschrieben: > When block_job_sleep_ns() is called, the co-routine is scheduled for > future execution. If we allow the job to be re-entered prior to the > scheduled time, we present a race condition in which a coroutine can be > entered recursively, or even en

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Marcel Apfelbaum
Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. You mean from unmasked "to" masked right? The way it's currently called from msix_reset(), though, may r

[Qemu-devel] postcopy test under load

2017-11-22 Thread Dr. David Alan Gilbert
Hi Peter, I was trying to reproduce the occasional travis postcopy test case failures you were seeing; I can reproduce them but only with tcg - which makes me wonder if the problem is in the test or actually in tcg. My test is: export QTEST_QEMU_BINARY=wherever/try/x86_64-softmmu/qemu-system-x8

[Qemu-devel] [PATCH] qga-win: VSS: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error

2017-11-22 Thread Sameeh Jubran
From: Sameeh Jubran We can get VSS_E_PROVIDER_ALREADY_REGISTERED error if for some reason the uninstall of qemu-ga didn't complete successfully. In this case we can try to unregister the component service and attempt to register it again. Signed-off-by: Sameeh Jubran --- qga/vss-win32/install.

Re: [Qemu-devel] [PATCH for-2.11] Fix build of console and GUI executables for Windows

2017-11-22 Thread Peter Maydell
On 21 November 2017 at 21:04, Stefan Weil wrote: > Am 16.11.2017 um 17:37 schrieb Stefan Weil: >> It was broken by commit 8ecc89f6e792152496eccb684d6c8c48aba8027d which >> moved the SDL linker flags from macro libs_softmmu to macro SDL_LIBS. >> >> Signed-off-by: Stefan Weil >> --- >> >> Peter, ca

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Richard Henderson
On 11/22/2017 09:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + > > exec.c: Factor out be

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 08:41, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + > > exec.c: Factor o

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 12:01, Richard Henderson wrote: > On 11/22/2017 09:41 AM, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >> Author: Peter Maydell >> Date:

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Juan Quintela
Peter Maydell wrote: > On 22 November 2017 at 08:41, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >> Author: Peter Maydell >> Date: Mon Nov 20 18:08:27 2017

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Richard Henderson
On 11/22/2017 01:03 PM, Peter Maydell wrote: > On 22 November 2017 at 12:01, Richard Henderson > wrote: >> On 11/22/2017 09:41 AM, Juan Quintela wrote: >>> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >>> code. Add the function as stubs. >>> >>> commit 27266271977c5a30f2f7d4

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Cornelia Huck
On Tue, 21 Nov 2017 18:05:46 +0100 Halil Pasic wrote: > On 11/21/2017 05:20 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 16:47:29 +0100 > > Halil Pasic wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>> On Tue, 21 Nov 2017 12:18:25 +0100 > >>> Halil Pasic wrote: > >>

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 12:08, Richard Henderson wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: >> Wow, I totally do not expect "assert(tcg_enabled())" to mean >> "we rely on the compiler to be able to determine that this >> code is dead" (and in general I'm not a fan of the compilation >> r

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Cornelia Huck
On Tue, 21 Nov 2017 19:10:15 +0100 Christian Borntraeger wrote: > On 11/21/2017 05:06 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 15:45:17 +0100 > > Christian Borntraeger wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>> On Tue, 21 Nov 2017 12:18:25 +0100 > >>> Halil P

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Dr. David Alan Gilbert
* Richard Henderson (richard.hender...@linaro.org) wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: > > On 22 November 2017 at 12:01, Richard Henderson > > wrote: > >> On 11/22/2017 09:41 AM, Juan Quintela wrote: > >>> This commit started use tb_unlock() and tlb_set_dirty() on non TCG > >>> c

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Thomas Huth
On 22.11.2017 09:10, Yu Ning wrote: > From: Yu Ning > > Following my announcement of the open source release of HAXM, > I was asked to write a blog post for normal Windows users to > advertise the use of "-accel hax": > > https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg02822.html Thank

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

2017-11-22 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 25 ++--- >> migration/migration.h | 2 ++ >> migration/socket.c| 7 +++ >> 3 files changed, 27 insertions(

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Philippe Mathieu-Daudé
On 11/22/2017 05:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + > > exec.c: Factor out be

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Ladi Prosek
On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: > Hi Ladi, > > On 20/11/2017 16:22, Ladi Prosek wrote: >> >> msix_mask_all() is supposed to invoke the release vector notifier if the >> state of the >> respective vector changed from unmasked or masked. > > > You mean from unmasked "to" ma

[Qemu-devel] [PATCH v2 6/6] migration: Set the new port/address in the uri parameter

2017-11-22 Thread Juan Quintela
We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela --- migration/socket.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter

2017-11-22 Thread Juan Quintela
It will be used to store the uri migration parameter. Right now it is just the parameter code. Signed-off-by: Juan Quintela --- hmp.c | 7 +++ migration/migration.c | 13 + qapi/migration.json | 18 +++--- 3 files changed, 35 insertions(+), 3 delet

[Qemu-devel] [PATCH v2 0/6] Improve info migrate output on destination

2017-11-22 Thread Juan Quintela
Hi For v2: - dropped the qio patch, get the address later with qio_socket_get_local_address (danp) - set the uri with all the options (danp found it) - rebase on top of latest rc Please review. Later, Juan. [v1] This series (on top of my last pull requset) do: - Make update port for address w

[Qemu-devel] [PATCH v2 1/6] migration: print features as on off

2017-11-22 Thread Juan Quintela
Once there, do one thing for line Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 4de3b551fe..7

[Qemu-devel] [PATCH v2 4/6] migration: Now set the migration uri

2017-11-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 25 ++--- migration/migration.h | 2 ++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 3e48d37880..507226907b 100644 --- a/migration/migration.c +++ b

[Qemu-devel] [PATCH v4 0/1] Use rightc parames (was Make xbzrle_cache_size a migration parameter)

2017-11-22 Thread Juan Quintela
Hi On v4: - Markus agreed that the change on sizes are right, so resend without RFC. Rest of patches already in, please review. Later, Juan. On v3: - rebase on top of last migration pull requset - improve comments (dave suggestion) - always return 0 in case of error - checked with ovirt/openst

[Qemu-devel] [PATCH v2 2/6] migration: free addr in the same function that we created it

2017-11-22 Thread Juan Quintela
Otherwise, we can't use it after calling socket_start_incoming_migration Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index dee869044a..3a8232dd2d 100644

[Qemu-devel] [PATCH v2 5/6] migration: make migrate uri parameter optional

2017-11-22 Thread Juan Quintela
Now that we have set an uri migration parameter, we can make it optional in the command line. Signed-off-by: Juan Quintela --- hmp-commands.hx | 4 ++-- hmp.c | 5 +++-- migration/migration.c | 12 +--- qapi/migration.json | 2 +- 4 files changed, 15 insertions

[Qemu-devel] [PATCH v4 1/1] migration: Use proper types in json

2017-11-22 Thread Juan Quintela
We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. This change only happens for HMP. QMP always use bytes and similars. Signed-off-by: Juan Quintela --- hmp.c | 22 +++--- migration/migration.c

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

2017-11-22 Thread Daniel P. Berrange
On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> migration/migration.c | 25 ++--- > >> migration/migration.h | 2 ++

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-22 Thread Alberto Garcia
On Tue 21 Nov 2017 04:18:13 PM CET, Anton Nefedov wrote: > >> keep BlockJob referenced while it is > >> paused (by block_job_pause/resume_all()). That should prevent it from > >> deleting the BB. > > looks kind of hacky; maybe referencing in block_job_pause() (and not > just pause_all) seems mor

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

2017-11-22 Thread Daniel P. Berrange
On Wed, Nov 22, 2017 at 12:54:58PM +, Daniel P. Berrange wrote: > On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote: > > "Daniel P. Berrange" wrote: > > > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela > > >> --- > > >> migratio

Re: [Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter

2017-11-22 Thread Daniel P. Berrange
On Wed, Nov 22, 2017 at 01:42:16PM +0100, Juan Quintela wrote: > It will be used to store the uri migration parameter. Right now it is > just the parameter code. > > Signed-off-by: Juan Quintela > --- > hmp.c | 7 +++ > migration/migration.c | 13 + > qapi/migra

Re: [Qemu-devel] [PATCH v1 07/12] target/arm: Decode aa32 armv8.1 two reg and a scalar

2017-11-22 Thread Richard Henderson
On 11/13/2017 06:05 PM, Alex Bennée wrote: >> -default: /* 14 and 15 are RESERVED */ >> +default: >> return 1; > > I think this should now be g_assert_not_reached() as we decode the whole > op space. That said it's tricky to follow in the mega f

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Marcel Apfelbaum
On 22/11/2017 14:32, Ladi Prosek wrote: On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. You m

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-22 Thread Cornelia Huck
On Tue, 21 Nov 2017 19:03:17 +0100 Pierre Morel wrote: > On 21/11/2017 15:25, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 11:38:45 +0100 > > Cornelia Huck wrote: > > > >> On Thu, 16 Nov 2017 18:51:50 +0100 > >> Pierre Morel wrote: > > > >>> @@ -493,9 +494,13 @@ int pcistg_service_call(

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Shalini Chellathurai Saroja
On 11/21/2017 12:18 PM, Halil Pasic wrote: The default css 0xFE is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally don

Re: [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 13:15:21 +0800 Yi Min Zhao wrote: > 在 2017/11/22 上午2:07, Pierre Morel 写道: > > On 21/11/2017 11:42, Cornelia Huck wrote: > >> On Thu, 16 Nov 2017 18:51:52 +0100 > >> Pierre Morel wrote: > >> > >>> Enhance the fault detection. > >>> > >>> Fixup the precedence to check the d

[Qemu-devel] [PATCH 2/4] spice: remove unused watch list

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index ea04dc69b5..85b9ea2127 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -92,9 +92,7 @@ struct SpiceWatch { int event_mask; SpiceWatchFun

[Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-11-22 Thread Frediano Ziglio
This fields points to an old interface that is no more used in the current code. Signed-off-by: Frediano Ziglio --- hw/display/qxl.c | 1 - include/ui/spice-display.h | 1 - ui/spice-display.c | 2 -- 3 files changed, 4 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/q

[Qemu-devel] [PATCH 4/4] spice: remove unused timer list

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6d579faaae..2baf0c7120 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -55,9 +55,7 @@ static QemuThread me; struct SpiceTimer { QEMUTimer

[Qemu-devel] [PATCH 3/4] spice: remove only written event_mask field

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 85b9ea2127..6d579faaae 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -89,7 +89,6 @@ static void timer_remove(SpiceTimer *tim

[Qemu-devel] [RFC PATCH 1/1] s390x: deprecate s390-squash-mcss machine prop

2017-11-22 Thread Halil Pasic
With the cssids unrestricted (commit "s390x/css: unrestrict cssids") the s390-squash-mcss machine property should not be used. Actually libvirt never supported this, so the expectation is that removing it should be pretty painless. But let's play nice and deprecate it first. Signed-off-by: Halil

Re: [Qemu-devel] [RFC PATCH v2 0/3] tests for CCW IDA

2017-11-22 Thread Halil Pasic
ping On 11/08/2017 05:54 PM, Halil Pasic wrote: > I've keept the title althogh the scope shifted a bit: it's > more about introducing ccw-testdev than about IDA. The goal > is to facilitate testing the virtual channel subsystem > implementation, and the ccw interpretation. > > The first patch is

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an undefined value for flags. Right now this is unused, but we better play safe. The same is true for SET_IRQ_STATE. While QEMU is now fixed in that regard, we should make sure to not use the flag and pad fields in the kernel. A correspo

[Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Christian Borntraeger
The QEMU ELF loader does not zero the bss segment. This resulted in several bugs, e.g. see commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css) commit 6a40fa2669d3 (s390-ccw.img: Initialize next_idx) commit 8775d91a0f42 (pc-bios/s390-ccw: Fix problem with i

[Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Christian Borntraeger
Christian Borntraeger (2): s390x/migration: use zero flag parameter pc-bios/s390-ccw: zero out bss section pc-bios/s390-ccw/start.S | 30 +++--- target/s390x/kvm.c | 16 2 files changed, 35 insertions(+), 11 deletions(-) -- 2.9.4

Re: [Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-11-22 Thread Paolo Bonzini
On 21/11/2017 04:12, Michael S. Tsirkin wrote: >> Fair enough, but I'd add nevertheless a 32-bit flags field to both >> GET_CONFIG and SET_CONFIG, and document that the slave MUST check that >> it is zero and otherwise fail. > > We generally just use protocol feature bits for extensions. > But I ha

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:26, Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > that regard, we should make sure

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 13:25, Thomas Huth wrote: > diff --git a/assets/css/skel-noscript.css b/assets/css/skel-noscript.css > index e0a141e..f574b9f 100644 > --- a/assets/css/skel-noscript.css > +++ b/assets/css/skel-noscript.css > @@ -27,6 +27,7 @@ > -o-box-sizing: border-box; >

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:26:26 +0100 Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > that regard, we s

Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:26:27 +0100 Christian Borntraeger wrote: > The QEMU ELF loader does not zero the bss segment. > This resulted in several bugs, e.g. see > > commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - > initialize css) > commit 6a40fa2669d3 (s390-ccw.img:

Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:26:25 +0100 Christian Borntraeger wrote: > Christian Borntraeger (2): > s390x/migration: use zero flag parameter > pc-bios/s390-ccw: zero out bss section > > pc-bios/s390-ccw/start.S | 30 +++--- > target/s390x/kvm.c | 16

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:37:55 +0100 Thomas Huth wrote: > On 22.11.2017 15:26, Christian Borntraeger wrote: > > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > > undefined value for flags. Right now this is unused, but we > > better play safe. > > The same is true for SET_IRQ_STA

Re: [Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-11-22 Thread Michael S. Tsirkin
On Fri, Nov 17, 2017 at 04:44:37AM +0800, Changpeng Liu wrote: > Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be > used for live migration of vhost user devices, also vhost user devices > can benefit from the messages to get/set virtio config space from/to the > I/O target. Fo

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 03:43 PM, Cornelia Huck wrote: > On Wed, 22 Nov 2017 15:26:26 +0100 > Christian Borntraeger wrote: > >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play safe. >> The same is true for SET_

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Yu Ning
On 11/22/2017 20:25, Thomas Huth wrote: On 22.11.2017 09:10, Yu Ning wrote: From: Yu Ning Following my announcement of the open source release of HAXM, I was asked to write a blog post for normal Windows users to advertise the use of "-accel hax": https://lists.gnu.org/archive/html/qemu-dev

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Boris Fiuczynski
On 11/22/2017 01:13 PM, Cornelia Huck wrote: +object_class_property_add_bool(klass, "cssid-unrestricted", + prop_get_true, NULL, NULL); This looks really, really strange. This is a property that is always true if it exists. Won't argue about that. The

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-22 Thread Alberto Garcia
On Tue 07 Nov 2017 05:19:41 PM CET, Anton Nefedov wrote: > The small attached tweak makes iotest 30 (-qcow2 -nocache) fail 10/10 > times on my machine. I can reproduce the crash with v2.11.0-rc2 without having to modify QEMU at all using the attached test case (it's based on one of the existing t

Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Christian Borntraeger
Would have been good to have the qemu iotest before we merged 4afeffc8572f40d8844b946a30c00b10da4442b1 blockjob: do not allow coroutine double entry or entry-after-completion and friends. On 11/22/2017 [...] > -Image committed. > +qemu-img: /tmp/qemu-test/src/block/block-backend.c:2088: > blk_

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-11-22 Thread James Cowgill
I can reproduce the bug in a mips64el chroot running current Debian unstable - the posix_spawn example you mention fails there. I have tested v2.11.0-rc2 and it fails there as well. I think you need glibc >= 2.25 to trigger the bug (artful / bionic chroot). I only noticed it due to Debian updating

Re: [Qemu-devel] [PATCH v3 29/30] i.MX: Add i.MX7 SOC implementation.

2017-11-22 Thread Igor Mammedov
On Mon, 6 Nov 2017 07:48:12 -0800 Andrey Smirnov wrote: > The following interfaces are partially or fully emulated: > > * up to 2 Cortex A9 cores (SMP works with PSCI) > * A7 MPCORE (identical to A15 MPCORE) > * 4 GPTs modules > * 7 GPIO controllers > * 2 IOMUXC controllers

[Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Deepa Srinivasan
Starting qemu with the following arguments causes qemu to segfault: ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name= iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1 This patch fixes blk_aio_ioctl() so it does not pass stack addresses to blk_aio_ioctl_entry()

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:42, Paolo Bonzini wrote: > On 22/11/2017 13:25, Thomas Huth wrote: >> diff --git a/assets/css/skel-noscript.css b/assets/css/skel-noscript.css >> index e0a141e..f574b9f 100644 >> --- a/assets/css/skel-noscript.css >> +++ b/assets/css/skel-noscript.css >> @@ -27,6 +27,7 @@ >>

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-11-22 Thread James Cowgill
Sorry, this is probably the commit that broke things (not the one above). I was added in glibc 2.25: https://sourceware.org/git/?p=glibc.git;a=commit;h=4b4d4056bb154603f36c6f8845757c1012758158 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-11-22 Thread James Cowgill
I think I see the problem. This glibc commit rewrote the posix_spawn implementation on Linux: https://sourceware.org/git/?p=glibc.git;a=commit;h=9ff72da471a509a8c19791efe469f47fa6977410 It now relies on the exact behavior of clone(CLONE_VM | CLONE_VFORK) - ie: - That the parent will wait for the

Re: [Qemu-devel] [PATCH] iotests: fix 075 and 078

2017-11-22 Thread John Snow
On 11/21/2017 09:07 PM, Eric Blake wrote: > On 11/21/2017 06:16 PM, John Snow wrote: >> Both of these tests are for formats which now stipulate that they are >> read-only. Adjust the tests to match. >> >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/075 | 18 +- >> test

Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:26:25 +0100 Christian Borntraeger wrote: > Christian Borntraeger (2): > s390x/migration: use zero flag parameter > pc-bios/s390-ccw: zero out bss section > > pc-bios/s390-ccw/start.S | 30 +++--- > target/s390x/kvm.c | 16

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-22 Thread John Snow
On 11/22/2017 07:55 AM, Alberto Garcia wrote: > On Tue 21 Nov 2017 04:18:13 PM CET, Anton Nefedov wrote: >> >> keep BlockJob referenced while it is >> >> paused (by block_job_pause/resume_all()). That should prevent it from >> >> deleting the BB. >> >> looks kind of hacky; maybe referencing in

Re: [Qemu-devel] [PATCH] iotests: fix 075 and 078

2017-11-22 Thread Kevin Wolf
Am 22.11.2017 um 01:16 hat John Snow geschrieben: > Both of these tests are for formats which now stipulate that they are > read-only. Adjust the tests to match. > > Signed-off-by: John Snow Oh, right, seems I forgot about the tests... Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:45:56 +0100 Boris Fiuczynski wrote: > On 11/22/2017 01:13 PM, Cornelia Huck wrote: > >> +object_class_property_add_bool(klass, "cssid-unrestricted", > >> + prop_get_true, NULL, NULL); > > This looks really, really strange.

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 16:33, Deepa Srinivasan wrote: > Starting qemu with the following arguments causes qemu to segfault: > ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name= > iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1 > > This patch fixes blk_aio_ioctl() so it

Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:26, Christian Borntraeger wrote: > The QEMU ELF loader does not zero the bss segment. > This resulted in several bugs, e.g. see > > commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - > initialize css) > commit 6a40fa2669d3 (s390-ccw.img: Initialize next_

[Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Paolo Bonzini
Make sure that images are scaled to fit inside their container. Tested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- assets/css/style.css | 4 1 file changed, 4 insertions(+) diff --git a/assets/css/style.css b/assets/css/style.css index 2d4fe0c..b828887 10064

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 16:37, Thomas Huth wrote: > On 22.11.2017 15:42, Paolo Bonzini wrote: >> On 22/11/2017 13:25, Thomas Huth wrote: >>> diff --git a/assets/css/skel-noscript.css b/assets/css/skel-noscript.css >>> index e0a141e..f574b9f 100644 >>> --- a/assets/css/skel-noscript.css >>> +++ b/assets/css/s

Re: [Qemu-devel] [PATCH 1/5] nbd/server: refactor negotiation functions parameters

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Instead of passing currently negotiating option and its length to > many of negotiation functions let's just store them on NBDClient > struct to be state-variables of negotiation phase. > > This unifies semantics of negotiation function

Re: [Qemu-devel] [PATCH 08/12] e500: add mpc8540 i2c controller to ccsr

2017-11-22 Thread Michael Davidsaver
On 11/21/2017 10:08 PM, David Gibson wrote: > On Sun, Nov 19, 2017 at 09:24:16PM -0600, Michael Davidsaver wrote: >> Signed-off-by: Michael Davidsaver > > You're adding what seems to be a fairly specific device to the general > e500 init - this again suggests that it should be split, putting > cr

Re: [Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 05:37 PM, Paolo Bonzini wrote: > Make sure that images are scaled to fit inside their container. Thanks God. I was thinking "what is wrong with the channel subsystem in QEMU?" when reading your subject. > Tested-by: Thomas Huth > Reviewed-by: Thomas Huth > Signed-off-by: Pao

Re: [Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 17:48:28 +0100 Christian Borntraeger wrote: > On 11/22/2017 05:37 PM, Paolo Bonzini wrote: > > Make sure that images are scaled to fit inside their container. > > Thanks God. I was thinking "what is wrong with the channel subsystem in > QEMU?" when > reading your subject..

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-11-22 Thread Peter Maydell
Thanks for tracking down the glibc change; I will try to set up a chroot with a more recent glibc to see whether we can do something that fixes that posix_spawn implementation... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

  1   2   >