On 21 November 2017 at 21:04, Stefan Weil <s...@weilnetz.de> wrote: > Am 16.11.2017 um 17:37 schrieb Stefan Weil: >> It was broken by commit 8ecc89f6e792152496eccb684d6c8c48aba8027d which >> moved the SDL linker flags from macro libs_softmmu to macro SDL_LIBS. >> >> Signed-off-by: Stefan Weil <s...@weilnetz.de> >> --- >> >> Peter, can you apply this fix directly, or do you need a pull request? >> >> Regards >> Stefan >> >> Makefile.target | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile.target b/Makefile.target >> index e4244c188a..f9a9da7e7c 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -22,7 +22,7 @@ QEMU_PROG_BUILD = $(QEMU_PROG) >> else >> # system emulator name >> QEMU_PROG=qemu-system-$(TARGET_NAME)$(EXESUF) >> -ifneq (,$(findstring -mwindows,$(libs_softmmu))) >> +ifneq (,$(findstring -mwindows,$(SDL_LIBS))) >> # Terminate program name with a 'w' because the linker builds a windows >> executable. >> QEMU_PROGW=qemu-system-$(TARGET_NAME)w$(EXESUF) >> $(QEMU_PROG): $(QEMU_PROGW) > > > The fix missed v2.11.0-rc2. Can it be applied before v2.11.0-rc3?
Sure, I've put it on my list. In general though, just cc'ing me on patches is not guaranteed to get my attention, as I more or less ignore whether I'm cc'd or not as I scan subject lines. Sending a pull request is the best way to guarantee getting something to my attention to be applied; pull requests are the mechanism for allowing me to ignore patches related to all the parts of QEMU I don't care about, by delegating them to somebody else :-) thanks -- PMM
