On Wed, 22 Nov 2017 15:37:55 +0100 Thomas Huth <th...@redhat.com> wrote:
> On 22.11.2017 15:26, Christian Borntraeger wrote: > > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > > undefined value for flags. Right now this is unused, but we > > better play safe. > > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > > that regard, we should make sure to not use the flag and pad > > fields in the kernel. A corresponding kernel documentation patch > > will be submitted later. > > > > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> > > --- > > target/s390x/kvm.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) (...) > Reviewed-by: Thomas Huth <th...@redhat.com> > > IMHO that would still be fine for 2.11, too. I can queue this if another fix comes along, but I'd not push it on its own.