Re: [Qemu-devel] [PATCH] tcg: Avoid setting tcg_initialize if !CONFIG_TCG

2017-10-27 Thread Peter Maydell
On 26 October 2017 at 14:58, Richard Henderson wrote: > Fix the build for --disable-tcg. > > Fixes: 55c3ceef61fcf06fc98ddc752b7cce788ce7680b > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c| 2 ++ > target/i386/cpu.c | 2 ++ > target/mips/cpu.c | 2 ++ >

Re: [Qemu-devel] Qemu start VM in huge page without '-mem-prealloc' will get memory leak?

2017-10-27 Thread Daniel P. Berrange
On Fri, Oct 27, 2017 at 11:28:33AM +0800, Sam wrote: > After restart ovs-dpdk(which is openvswitch with dpdk lib), memory is > released. > > But problem is in product environment, I could not restart ovs-dpdk.. This is a clear bug in ovs-dpdk then - it is failing to release memory when QEMU e

Re: [Qemu-devel] [PATCH] build: allow automatic git submodule updates to be disabled

2017-10-27 Thread Daniel P. Berrange
On Fri, Oct 27, 2017 at 03:10:17PM +1100, Alexey Kardashevskiy wrote: > On 27/10/17 00:33, Philippe Mathieu-Daudé wrote: > > On 10/26/2017 10:04 AM, Daniel P. Berrange wrote: > >> Some people building QEMU use VPATH builds where the source directory is > >> on a > >> read-only volume. In such a ca

Re: [Qemu-devel] iotest 194 fails on vhdx

2017-10-27 Thread Jeff Cody
On Wed, Oct 25, 2017 at 05:06:37PM +1100, Alexey Kardashevskiy wrote: > On 25/10/17 15:29, Alexey Kardashevskiy wrote: > > Hi! > > > > The latest QEMU fails on: > > tests/qemu-iotests/check -vhdx 194 > > > Bit more details: > > 1. the assert started appearing from > https://git.qemu.org/?p=qemu

Re: [Qemu-devel] [PATCH] replication: Fix replication open fail

2017-10-27 Thread Kevin Wolf
Am 25.10.2017 um 08:51 hat Wang Guang geschrieben: > replication_child_perm request write > permissions for all child which will lead bdrv_check_perm fail. > replication_child_perm() should request write > permissions only if it is writable itself. > > Signed-off-by: Wang Guang > Signed-off-by: W

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2017-10-27 Thread Bug Watch Updater
** Changed in: fedora Status: Unknown => Won't Fix ** Changed in: fedora Importance: Unknown => High -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/586175 Title: Windows XP/2003 doesn't b

Re: [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq)

2017-10-27 Thread Daniel P. Berrange
On Mon, Oct 23, 2017 at 11:19:42AM +0200, Gerd Hoffmann wrote: > From: "Daniel P. Berrange" > > The 'Print' key is special in the AT set 1 / set 2 scancode definitions. > > An unmodified 'Print' key is supposed to send > > AT Set 1: e0 2a e0 37 (Down) e0 b7 e0 aa (Up) > AT Set 2: e0 12 e0

Re: [Qemu-devel] [PATCH 0/3]

2017-10-27 Thread Sameeh Jubran
On Fri, Oct 27, 2017 at 2:51 AM, Michael Roth wrote: > Quoting Sameeh Jubran (2017-08-13 10:58:46) > > From: Sameeh Jubran > > > > This series fixes qemu-ga's behaviour upon facing a missing serial/serial > > driver by listening to the serial device's events. > > > > For more info on why this se

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-27 Thread Cornelia Huck
On Thu, 26 Oct 2017 14:52:45 -0400 "Collin L. Walling" wrote: > The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of this, output > appears in a "stair ca

Re: [Qemu-devel] [PULL v2 00/11] Disassembler patches

2017-10-27 Thread Peter Maydell
On 26 October 2017 at 11:00, Richard Henderson wrote: > Support for Capstone, plus an arm32 fix. > > Changes since v1: > * Fixed mingw32 build in patch 11/11. > (Not re-sending patches 01-10.) > > r~ > > > The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: > > Mer

Re: [Qemu-devel] [PATCH v4 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias wrote: > Add support for continuous read out of the RDSR and READ_FSR status > registers until the chip select is deasserted. This feature is supported > by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), > Windbond, SST, Gi

Re: [Qemu-devel] [PATCH v4 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias wrote: > Add support for SST READ ID 0x90/0xAB commands for reading out the flash > manufacuter ID and device ID. > > Signed-off-by: Francisco Iglesias Acked-by: Alistair Francis Alistair > --- > hw/block/m25p80.c | 23 +

Re: [Qemu-devel] [PATCH v4 04/13] m25p80: Add support for n25q512a11 and n25q512a13

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias wrote: > Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. > > Signed-off-by: Francisco Iglesias > Acked-by: Marcin Krzemiński Reviewed-by: Alistair Francis Alistair > --- > hw/block/m25p80.c | 2 ++ > 1 file changed, 2 i

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias wrote: > Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy > QSPI) and connect Numonyx n25q512a11 flashes to it. > > Signed-off-by: Francisco Iglesias > --- > hw/arm/xlnx-zcu102.c | 23 +++ >

[Qemu-devel] [PATCH] net: detect errors from probing vnet hdr flag for TAP devices

2017-10-27 Thread Daniel P. Berrange
When QEMU sets up a tap based network device backend, it mostly ignores errors reported from various ioctl() calls it makes, assuming the TAP file descriptor is valid. This assumption can easily be violated when the user is passing in a pre-opened file descriptor. At best, the ioctls may fail with

[Qemu-devel] [PATCH] sockets: avoid crash when cleaning up sockets for an invalid FD

2017-10-27 Thread Daniel P. Berrange
If socket_listen_cleanup is passed an invalid FD, then querying the socket local address will fail. We must thus be prepared for the returned addr to be NULL Reported-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- util/qemu-sockets.c | 3 +++ 1 file changed, 3 insertions(+) d

[Qemu-devel] [PATCH 0/4] Don't write headers if BDS is INACTIVE

2017-10-27 Thread Jeff Cody
VHDX and Parallels both blindly write headers to the image file if the images are opened R/W. This causes an assert if the QEMU run state is INMIGRATE. Rather than blindly write on open, latch the first write to the image, and update the header then. Jeff Cody (4): block/vhdx.c: Don't blindly

[Qemu-devel] [PATCH 2/4] block/parallels: code movement

2017-10-27 Thread Jeff Cody
Code movement, to make subsequent patches simpler. Signed-off-by: Jeff Cody --- block/parallels.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 2b6c6e5709..fed199eccd 100644 --- a/block/parallels.c +++ b

[Qemu-devel] [PATCH 1/4] block/vhdx.c: Don't blindly update the header

2017-10-27 Thread Jeff Cody
The VHDX specification requires that before user data modification of the vhdx image, the VHDX header file and data GUIDs need to be updated. In vhdx_open(), if the image is set to RDWR, we go ahead and update the header. However, just because the image is set to RDWR does not mean we can go ahead

[Qemu-devel] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Jeff Cody
The on disk image format 'inuse' header field is updated blindly if the image is opened RDWR. This can cause problems if the QEMU runstate is set to INMIGRATE, at which point the underlying file is set to INACTIVE. This causes an assert in bdrv_co_pwritev(). Do something similar to what is done i

[Qemu-devel] [PATCH 4/4] qemu-iotests: update unsupported image formats in 194

2017-10-27 Thread Jeff Cody
Test 194 checks for 'luks' to exclude as an unsupported format, However, most formats are unsupported, due to migration blockers. Rather than specifying a blacklist of unsupported formats, whitelist supported formats (specifically, qcow2, qed, raw, dmg). Signed-off-by: Jeff Cody --- tests/qemu-

Re: [Qemu-devel] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Kevin Wolf
Am 27.10.2017 um 10:57 hat Jeff Cody geschrieben: > The on disk image format 'inuse' header field is updated blindly if the > image is opened RDWR. This can cause problems if the QEMU runstate is > set to INMIGRATE, at which point the underlying file is set to INACTIVE. > This causes an assert in

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread francisco iglesias
Dear alistair, Thank you for the review comments! I will update according them in the next version of the patch series! About your question, I might have misunderstod, but isn't the alias "qspi"? (s/"qspi{0,1}" -> s->qspi/"spi{0,1}") Best regards, Francisco Iglesias On 27 Oct 2017 10:49, "Alist

Re: [Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

2017-10-27 Thread Riku Voipio
On Thu, Oct 26, 2017 at 04:06:22PM -0500, Zach Riggle wrote: > Friendly ping :) > > I've updated the patch with v2 which addresses the style issue I'll have a look at it soon. > > *Zach Riggle* > > On Tue, Oct 24, 2017 at 10:34 PM, Zach Riggle wrote: > > > Previously, it was possible to get

Re: [Qemu-devel] [v3 2/2] tests/pxe-test: add testcase using vhost-user-bridge

2017-10-27 Thread Jens Freimann
On Thu, Oct 26, 2017 at 02:53:12PM +, Michael S. Tsirkin wrote: On Thu, Oct 26, 2017 at 02:44:25PM +0200, Jens Freimann wrote: From: Jens Freimann Add a PXE testcase tunneling traffic through vhost-user-bridge process. Create a vhost-user-bridge process and connect it to qemu via a socket.

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-27 Thread ChristianEhrhardt
As assumed s390x passed now (so a flaky test), and as outlined before armhf we just have to give up. Looking at the history an override might be the right thing to do. Other than that all looks good, waiting for the verify by Sean/Andrew now. -- You received this bug notification because you ar

Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 1/8] xen: link against xentoolcore"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > >then > > - xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > + xen_stable_libs="-lxendevicemodel $xen_stable_libs -lxentoolcore" > > Is it on purp

Re: [Qemu-devel] [PULL 00/35] Block layer patches

2017-10-27 Thread Peter Maydell
On 26 October 2017 at 14:17, Kevin Wolf wrote: > The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171025' into > staging (2017-10-25 16:38:57 +0100) > > are available in the git repository at: > > git://

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Jiri Denemark
On Thu, Oct 26, 2017 at 10:09:46 +0200, David Hildenbrand wrote: > On 25.10.2017 18:45, Marc Hartmayer wrote: > > On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand > > wrote: > >> On 25.10.2017 17:09, Boris Fiuczynski wrote: > >>> David, I disagree if your proposal is to generally tolerat

Re: [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > > xc_interface_open etc. is not going to work if we have dropped > > privilege, but xendevicemodel_shutdown will if everything is new > > enough. > >

Re: [Qemu-devel] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Jeff Cody
On Fri, Oct 27, 2017 at 11:09:19AM +0200, Kevin Wolf wrote: > Am 27.10.2017 um 10:57 hat Jeff Cody geschrieben: > > The on disk image format 'inuse' header field is updated blindly if the > > image is opened RDWR. This can cause problems if the QEMU runstate is > > set to INMIGRATE, at which point

Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all"): > On Fri, 20 Oct 2017, Ian Jackson wrote: ... > > Drop individual use of xendevicemodel_restrict and > > xenforeignmemory_restrict. These are not actually effective in this > > version of qemu, because

Re: [Qemu-devel] Crash with odd chardev setup

2017-10-27 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 25, 2017 at 07:00:14PM +0100, Dr. David Alan Gilbert wrote: > > > Hi Dan, > > > I've got a crash in head (and 2.10) which is a bit of a heisenbug; > > > I can trigger it with:

Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 7/8] os-posix: Provide new -runas : facility"): > CC'ing the maintainers (scripts/get_maintainer.pl is your friend) I don't know what your scripts/get_maintainer.pl does, but mine says: get_maintainer.pl: No maintainers found, printing recent contrib

[Qemu-devel] [PATCH v6 05/12] nbd/server: Simplify nbd_negotiate_options loop

2017-10-27 Thread Eric Blake
Instead of making each caller check whether a transmission error occurred, we can sink a common error check to the end of the loop. Signed-off-by: Eric Blake --- v6: split from length validation [Vladimir] --- nbd/server.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-

[Qemu-devel] [PATCH v6 02/12] nbd: Move nbd_errno_to_system_errno() to public header

2017-10-27 Thread Eric Blake
This is needed in preparation for structured reply handling, as we will be performing the translation from NBD error to system errno value higher in the stack at block/nbd-client.c. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 13 + n

Re: [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash"): > CC'ing the maintainers for this. Thanks, but scripts/get_maintainer.pl seems to print different information for me... (see my other mail) Ian.

[Qemu-devel] [PATCH v6 00/12] nbd minimal structured read

2017-10-27 Thread Eric Blake
I've incorporated a few more tweaks since v5, addressing the various bugs I pointed out there: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg04817.html - make sure iotests pass - split a large patch - consistently use absolute offsets - clean up awkward logic in handling option requests

[Qemu-devel] [PATCH v6 03/12] nbd: Expose constants and structs for structured read

2017-10-27 Thread Eric Blake
Upcoming patches will implement the NBD structured reply extension [1] for both client and server roles. Declare the constants, structs, and lookup routines that will be valuable whether the server or client code is backported in isolation. This includes moving one constant from an internal heade

[Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check

2017-10-27 Thread Eric Blake
Consolidate the response for a non-zero-length option payload into a new function, nbd_reject_length(). This check will also be used when introducing support for structured replies. Note that STARTTLS response differs based on time: if the connection is still unencrypted, we set fatal to true (a

[Qemu-devel] [PATCH v6 01/12] nbd: Include error names in trace messages

2017-10-27 Thread Eric Blake
NBD errors were originally sent over the wire based on Linux errno values; but not all the world is Linux, and not all platforms share the same values. Since a number isn't very easy to decipher on all platforms, update the trace messages to include the name of NBD errors being sent/received over

[Qemu-devel] [PATCH v6 07/12] nbd: Minimal structured read for server

2017-10-27 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievsk

[Qemu-devel] [PATCH v6 04/12] nbd/server: Report error for write to read-only export

2017-10-27 Thread Eric Blake
When the server is read-only, we were already reporting an error message for NBD_CMD_WRITE_ZEROES, but failed to set errp for a similar NBD_CMD_WRITE. This will matter more once structured replies allow the server to propagate the errp information back to the client. While at it, use an error mes

[Qemu-devel] [PATCH v6 08/12] nbd/server: Include human-readable message in structured errors

2017-10-27 Thread Eric Blake
The NBD spec permits including a human-readable error string if structured replies are in force, so we might as well send the client the message that we logged on any error. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- v6: add R-b v5: allow NULL msg, cast away const f

[Qemu-devel] [PATCH v6 09/12] nbd/client: refactor nbd_receive_starttls

2017-10-27 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Split out nbd_request_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v6: error message tweak [Vladimir] v5: only check length for ACK responses v4: reduce redundant traces, ty

[Qemu-devel] [PATCH v6 10/12] nbd/client: prepare nbd_receive_reply for structured reply

2017-10-27 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy In following patch nbd_receive_reply will be used both for simple and structured reply header receiving. NBDReply is altered into union of simple reply header and structured reply chunk header, simple error translation moved to block/nbd-client to be consistent

[Qemu-devel] [PATCH v6 11/12] nbd: Move nbd_read() to common header

2017-10-27 Thread Eric Blake
An upcoming change to block/nbd-client.c will want to read the tail of a structured reply chunk directly from the wire. Move this function to make it easier. Based on a patch from Vladimir Sementsov-Ogievskiy. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/blo

[Qemu-devel] [PATCH v6 12/12] nbd: Minimal structured read for client

2017-10-27 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation: for structured error only error_report error message. Note that test 83 is now more verbose, because the implementation prints more warnings about unexpected communication errors; perhaps future patches should tone things down by using t

[Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity

2017-10-27 Thread Eric Blake
Commenting these two lines is enough to avoid the change to 083.out in 12/12. That is evidence that we may want these two lines to be trace points rather than error messages; or maybe we really do like the extra verbosity in the case of an unexpected communication break. This patch does not meet

Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read

2017-10-27 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Subject: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read Message-id: 20171027104037.8319-1-ebl...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git c

[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

2017-10-27 Thread Bug Watch Updater
Launchpad has imported 5 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=623188. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-27 Thread ChristianEhrhardt
Ok, Zesty actually had an override for the arm test (had to learn the placement of those for SRUs). So only up to the verification now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title:

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 11:17 AM, francisco iglesias wrote: > Dear alistair, > > Thank you for the review comments! I will update according them in the next > version of the patch series! About your question, I might have misunderstod, > but isn't the alias "qspi"? (s/"qspi{0,1}" -> s->qspi/"spi

Re: [Qemu-devel] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Denis V. Lunev
On 10/27/2017 10:57 AM, Jeff Cody wrote: > The on disk image format 'inuse' header field is updated blindly if the > image is opened RDWR. This can cause problems if the QEMU runstate is > set to INMIGRATE, at which point the underlying file is set to INACTIVE. > This causes an assert in bdrv_co_p

[Qemu-devel] [PATCHv2 2/4] sparc32_dma: switch over to using IOMMU memory region and DMA API

2017-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/dma/sparc32_dma.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index 7d00f1a..01afb75 100644 --- a/hw/dma/sparc32_dma.c +++ b/hw/dma/sparc32_dma.c @@ -30,6 +30,7 @@ #inc

[Qemu-devel] [PATCHv2 1/4] sun4m: implement IOMMU translation using IOMMU memory region

2017-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/dma/sun4m_iommu.c | 62 ++ include/hw/sparc/sun4m.h |5 2 files changed, 67 insertions(+) diff --git a/hw/dma/sun4m_iommu.c b/hw/dma/sun4m_iommu.c index 840064b..ce21a22 100644 --- a/hw/dma/sun4m_io

[Qemu-devel] [PATCHv2 0/4] sun4m: implement memory region IOMMU translation and DMA API

2017-10-27 Thread Mark Cave-Ayland
The original sun4m IOMMU/DMA code dates from before the introduction of the QEMU memory region API (in particular IOMMU memory regions) and the DMA API. This patchset removes these sun4m-specific implementations and replaces them with the more up-to-date QEMU APIs instead. Signed-off-by: Mark Ca

[Qemu-devel] [PATCHv2 4/4] sun4m: change TYPE_SUN4M_IOMMU macro from "iommu" to "sun4m-iommu"

2017-10-27 Thread Mark Cave-Ayland
This is a legacy artifact from when the sun4m IOMMU implementation was the only IOMMU available within QEMU. Signed-off-by: Mark Cave-Ayland --- include/hw/sparc/sun4m.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/sparc/sun4m.h b/include/hw/sparc/sun4m.h ind

[Qemu-devel] [PATCHv2 3/4] sun4m_iommu: remove legacy sparc_iommu_memory_rw() function

2017-10-27 Thread Mark Cave-Ayland
With the switch to the IOMMU memory region and DMA API, this is no longer required. Signed-off-by: Mark Cave-Ayland --- hw/dma/sun4m_iommu.c | 33 - include/hw/sparc/sun4m.h | 16 2 files changed, 49 deletions(-) diff --git a/hw/dma/sun4m

Re: [Qemu-devel] [PATCH] sockets: avoid crash when cleaning up sockets for an invalid FD

2017-10-27 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > If socket_listen_cleanup is passed an invalid FD, then querying the socket > local address will fail. We must thus be prepared for the returned addr to > be NULL > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Daniel P. Berrange Revie

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Halil Pasic
On 10/25/2017 08:13 PM, Jason J. Herne wrote: > On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >> Starting a guest with >>     >> hvm >>    >>    >> >> on an IBM z14 results in >> >> "qemu-system-s390x: Some features requested in the CPU model are not >> available in the configurati

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:31 PM, Halil Pasic wrote: > > > On 10/25/2017 08:13 PM, Jason J. Herne wrote: >> On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >>> Starting a guest with >>>     >>> hvm >>>    >>>    >>> >>> on an IBM z14 results in >>> >>> "qemu-system-s390x: Some features reque

Re: [Qemu-devel] [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:31 PM, Halil Pasic wrote: gs is explicitly disabled. > > Now that I think about it, maybe the 2.9 binary is going to reject > the explicit gs flag altogether, because it's unknown. > > Isn't this a problem? No. This is exactly the _solution_ and not the problem. The target wi

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread francisco iglesias
Good day Alistair, Yes exactly! The qspi aliases on the soc (named "qspi%d") targets the spi busses on the qspi dev (named "spi%d"). I did it this way in hope that the code resembles how we connect the SST flashes to the standard spi devices. Would you like me to do this in an other way or do you

Re: [Qemu-devel] [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:45 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:31 PM, Halil Pasic wrote: > gs is explicitly disabled. >> >> Now that I think about it, maybe the 2.9 binary is going to reject >> the explicit gs flag altogether, because it's unknown. >> >> Isn't this a problem? > >

Re: [Qemu-devel] [PATCH] net: detect errors from probing vnet hdr flag for TAP devices

2017-10-27 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > When QEMU sets up a tap based network device backend, it mostly ignores errors > reported from various ioctl() calls it makes, assuming the TAP file descriptor > is valid. This assumption can easily be violated when the user is passing in a > pre-

Re: [Qemu-devel] [PATCH] net: detect errors from probing vnet hdr flag for TAP devices

2017-10-27 Thread Daniel P. Berrange
On Fri, Oct 27, 2017 at 01:59:22PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > When QEMU sets up a tap based network device backend, it mostly ignores > > errors > > reported from various ioctl() calls it makes, assuming the TAP file > > descriptor

Re: [Qemu-devel] [PATCH v6]arm: Makefiles to kinetis k64 platform

2017-10-27 Thread KONRAD Frederic
Hi, Why does this patch has a v6 prefix? And it seems some patches are missing. To send your patches I suggest you use git send-email. About this patch: Each Makefile modification should go in the patch which introduces the new model. eg: hw/char/Makefile.objs must be modified in 4/5 kinetis_k64

Re: [Qemu-devel] [PATCH v5 1/5]arm: kinetis_k64_mcg

2017-10-27 Thread KONRAD Frederic
On 10/26/2017 12:34 PM, Gabriel Costa wrote: From: Gabriel Augusto Costa This Patch include kinetis_k64_mcg.c and .h mcg means Multipurpose Clock Generator (MCG) More information about this peripheral can be found at: pag 579, K64P144M120SF5RM.pdf. Signed-off-by: Gabriel Augusto Costa ---

[Qemu-devel] [PATCH v2 1/4] build: allow setting a custom GIT binary for transparent proxying

2017-10-27 Thread Daniel P. Berrange
Some users can't run a bare 'git' command, due to need for a transparent proxying solution such as 'tsocks'. This adds an argument to configure to let users specify such a thing: ./configure --with-git="tsocks git" The submodule script is also updated to give the user a hint about using this fl

[Qemu-devel] [PATCH v2 4/4] build: don't fail if given a git submodule which does not exist

2017-10-27 Thread Daniel P. Berrange
If going back in time in git history, across a commit that introduces a new submodule, the 'git-submodule.sh' script will fail, causing rebuild to fail. This is because config-host.mak contains a GIT_SUBMODULES variable that lists a submodule that only exists in the later commit. config-host.mak w

[Qemu-devel] [PATCH v2 0/4] Various improvements to submodule handling

2017-10-27 Thread Daniel P. Berrange
I've sent a variety of improvements to submodule handling as separate patches and its getting slightly confusing. So here is a series with all patches added together. I've also included a fix that helps us go backwards in time across the introduction of a submodule. Daniel P. Berrange (4): build

[Qemu-devel] [Bug 546458] Re: kernel NULL pointer in -virtual (-server) kernel

2017-10-27 Thread Bug Watch Updater
Launchpad has imported 11 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=560114. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://hel

[Qemu-devel] [PATCH v2 2/4] build: don't create temporary files in source dir

2017-10-27 Thread Daniel P. Berrange
There are cases where users do VPATH builds with the source directory being on a read-only volume. In such a case they have to manually run the command 'git-submodule.sh ...modules...' manually ahead of time. When checking for status we should not then write into the source dir. Signed-off-by: Da

[Qemu-devel] [PATCH v2 3/4] build: allow automatic git submodule updates to be disabled

2017-10-27 Thread Daniel P. Berrange
Some people building QEMU use VPATH builds where the source directory is on a read-only volume. In such a case 'scripts/git-submodules.sh update' will always fail and users are required to run it manually themselves on their original writable source directory. While this is already supported, it i

Re: [Qemu-devel] [PATCH v5 3/5]arm: kinetis_k64_system

2017-10-27 Thread KONRAD Frederic
On 10/26/2017 12:34 PM, Gabriel Costa wrote: From: Gabriel Augusto Costa This Patch include kinetis_k64_system.c and .h sim means System Integration Module (SIM) More information about this peripheral can be found at: pag 291, K64P144M120SF5RM.pdf. Signed-off-by: Gabriel Augusto Costa ---

Re: [Qemu-devel] [PATCH v5 4/5]arm: kinetis_k64_uart

2017-10-27 Thread KONRAD Frederic
On 10/26/2017 12:34 PM, Gabriel Costa wrote: From: Gabriel Augusto Costa This Patch include kinetis_k64_uart.c and .h uart means Universal Asynchronous Receiver/Transmitter (UART) More information about this peripheral can be found at: pag 1529, K64P144M120SF5RM.pdf. Signed-off-by: Gabriel A

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Cornelia Huck
On Fri, 27 Oct 2017 14:42:57 +0200 Christian Borntraeger wrote: > Yes, we should also replace that with > > return s390_has_feat(S390_FEAT_GUARDED_STORAGE) > > I can fixup my patch or provide a 2nd one. > Consider a fixed up patch acked by me.

Re: [Qemu-devel] [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Halil Pasic
On 10/27/2017 02:57 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:31 PM, Halil Pasic wrote: >> gs is explicitly disabled. >>> >>> Now that I think about it, maybe the 2.9 binary is going to reject >>> the explicit gs flag a

Re: [Qemu-devel] [PULL 00/39] x86/cpu/numa queue, 2017-10-26

2017-10-27 Thread Peter Maydell
On 26 October 2017 at 15:03, Eduardo Habkost wrote: > (Note that master is currently broken with --disable-tcg, but I > don't want to hold the queue until this is fixed.) > > The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7: > > Merge remote-tracking branch 'remotes/rt

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Halil Pasic
On 10/27/2017 03:31 PM, Cornelia Huck wrote: > On Fri, 27 Oct 2017 14:42:57 +0200 > Christian Borntraeger wrote: > >> Yes, we should also replace that with >> >> return s390_has_feat(S390_FEAT_GUARDED_STORAGE) >> >> I can fixup my patch or provide a 2nd one. >> > > Consider a fixed up patch a

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Use tcg_gen_lookup_and_goto_ptr

2017-10-27 Thread David Gibson
On Thu, Oct 26, 2017 at 11:12:00PM +0200, David Gibson wrote: > On Thu, Oct 26, 2017 at 02:22:57PM +0200, Thomas Huth wrote: > > On 30.06.2017 20:37, Richard Henderson wrote: > > > Cc: qemu-...@nongnu.org > > > Signed-off-by: Richard Henderson > > > --- > > > target/ppc/translate.c | 23 -

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Use tcg_gen_lookup_and_goto_ptr

2017-10-27 Thread David Gibson
On Fri, Oct 27, 2017 at 03:44:22PM +0200, David Gibson wrote: > On Thu, Oct 26, 2017 at 11:12:00PM +0200, David Gibson wrote: > > On Thu, Oct 26, 2017 at 02:22:57PM +0200, Thomas Huth wrote: > > > On 30.06.2017 20:37, Richard Henderson wrote: > > > > Cc: qemu-...@nongnu.org > > > > Signed-off-by: R

Re: [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()

2017-10-27 Thread David Gibson
On Mon, Oct 23, 2017 at 10:49:15AM +0200, Gerd Hoffmann wrote: > On Fri, 2017-10-20 at 11:53 +0200, Thomas Huth wrote: > > The "cannot_instantiate_with_device_add_yet" flag has been renamed > > to "user_creatable" a while ago. > > > > Signed-off-by: Thomas Huth > > --- > >  hw/display/sm501.c | 2

Re: [Qemu-devel] [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 03:40 PM, Halil Pasic wrote: > > > On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:31 PM, Halil Pasic wrote: >>> gs is explicitly disabled. Now that I think about it, maybe th

Re: [Qemu-devel] [PULL 00/39] x86/cpu/numa queue, 2017-10-26

2017-10-27 Thread Eduardo Habkost
On Fri, Oct 27, 2017 at 02:42:11PM +0100, Peter Maydell wrote: > On 26 October 2017 at 15:03, Eduardo Habkost wrote: > > (Note that master is currently broken with --disable-tcg, but I > > don't want to hold the queue until this is fixed.) > > > > The following changes since commit ae49fbbcd8e4e9d

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-27 Thread Christian Borntraeger
On 10/26/2017 10:54 PM, Collin L. Walling wrote: > On 10/26/2017 04:48 PM, Alexander Graf wrote: >> >> On 26.10.17 22:37, Collin L. Walling wrote: >>> On 10/26/2017 04:25 PM, Alexander Graf wrote: On 26.10.17 20:52, Collin L. Walling wrote: > The sclp console in the s390 bios writes raw

Re: [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

2017-10-27 Thread KONRAD Frederic
Hi Pavel, On 10/25/2017 01:12 AM, p...@cmp.felk.cvut.cz wrote: From: Pavel Pisa The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture cleanup by Pavel Pisa (Czech Techni

[Qemu-devel] [PULL v2 00/39] x86/cpu/numa queue, 2017-10-27

2017-10-27 Thread Eduardo Habkost
Change in v2: * Include sh4-linux-user fixup sent by Igor (at: "sh4: simplify superh_cpu_class_by_name()") The following changes since commit 74d7fc7f6385158b8a5c524c61baaef1b66f3dac: tcg: Avoid setting tcg_initialize if !CONFIG_TCG (2017-10-26 17:47:36 +0100) are available in the git reposi

[Qemu-devel] [PULL v2 05/39] lm32: cleanup cpu type name composition

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov introduce LM32_CPU_TYPE_NAME macro and consistently use it to construct cpu type names. While at it replace dynamic cpu type name composition with static data. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <1507211474-

[Qemu-devel] [PULL v2 03/39] cris: cleanup cpu type name composition

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov replace ambiguous TYPE macro with a new CRIS_CPU_TYPE_NAME and use it consistently in the code. Signed-off-by: Igor Mammedov Message-Id: <1507211474-188400-7-git-send-email-imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- target/

[Qemu-devel] [PULL v2 15/39] openrisc: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1507211474-188400-19-git-send-email-imamm...@redhat.com> Acked-by: Stafford Horne Signed-off-by: Eduardo Habkost --- hw/openrisc/openrisc_sim.c | 8 ++-- 1 file changed, 2 insertions(+), 6 d

[Qemu-devel] [PULL v2 01/39] alpha: cleanup cpu type name composition

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Introduce ALPHA_CPU_TYPE_NAME macro to replace rather ununique TYPE macro that alpha uses. With new macro it will follow the same naming convention as other targets. While at it put scattered TypeInfo into one array which places type desriptions at one place and reduces code

[Qemu-devel] [PULL v2 06/39] lm32: milkymist: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <1507211474-188400-10-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/lm32/milkymist.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(

[Qemu-devel] [PULL v2 07/39] lm32: lm32_boards: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <1507211474-188400-11-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/lm32/lm32_boards.c | 14 -- 1 file changed, 4 insertions(+), 10

[Qemu-devel] [PULL v2 22/39] xtensa: sim: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1507211474-188400-26-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/xtensa/sim.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/xtensa/s

[Qemu-devel] [PULL v2 02/39] alpha: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1507211474-188400-6-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/alpha/dp264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL v2 08/39] m68k: cleanup cpu type name composition

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov use new M68K_CPU_TYPE_NAME to compose CPU type names and get rid of intermediate M68kCPUInfo/register_cpu_type() which is replaced by static TypeInfo array. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Laurent Vivier Message-Id: <1507211474-18

[Qemu-devel] [PULL v2 14/39] openrisc: cleanup cpu type name composition

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov use new OPENRISC_CPU_TYPE_NAME to compose CPU type name and get rid of intermediate OpenRISCCPUInfo/openrisc_cpu_register_types() which is replaced by static TypeInfo array. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1507211474-188400-18-g

[Qemu-devel] [PULL v2 04/39] cris: use generic cpu_model parsing

2017-10-27 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1507211474-188400-8-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/cris/axis_dev88.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/cris/

  1   2   3   >