Re: [Qemu-devel] [PATCH] docker: Don't mount ccache db if NOUSER=1

2017-09-28 Thread Fam Zheng
On Wed, 09/27 23:07, Philippe Mathieu-Daudé wrote: > On Mon, Sep 25, 2017 at 4:54 AM, Fam Zheng wrote: > > With NOUSER=1 the container runs code as root, which may create > > privileged files that will not be be accssible next time. Skip ccache > > dir mount in this case. > > > > Signed-off-by: Fa

Re: [Qemu-devel] [PATCH v4 1/5] qom: provide root container for internal objs

2017-09-28 Thread Fam Zheng
On Thu, 09/28 10:59, Peter Xu wrote: > We have object_get_objects_root() to keep user created objects, however > no place for objects that will be used internally. Create such a > container for internal objects. > > CC: Andreas Färber > CC: Markus Armbruster > CC: Paolo Bonzini > Suggested-by:

Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy

2017-09-28 Thread Fam Zheng
On Thu, 09/28 10:59, Peter Xu wrote: > From: Stefan Hajnoczi > > After iothread is enabled internally inside QEMU with GMainContext, we > may encounter this warning when destroying the iothread: > > (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll: > assertion '!SOURCE_DESTROY

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-28 Thread Peter Xu
On Thu, Sep 28, 2017 at 12:13:12PM +0530, Linu Cherian wrote: > Hi Eric, > > > On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > > This series implements the emulation code for ARM SMMUv3. > > > > Changes since v6: > > - DPDK testpmd now running on guest with 2 assigned VFs > > - Chan

Re: [Qemu-devel] ppce500 usb-ehci-pci issue on last uboot

2017-09-28 Thread luigi burdo
Hi Gerd, i had test it yesterday on Little Endian machine host (Apple Osx Sierra) the issue is present there too. Ciao Luigi hi Gerd, yes the host is a big endian but i can test it on an little endian host too and report. About xhci or ohci the uboot dont rec

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-28 Thread Mark Cave-Ayland
On 25/09/17 09:11, Dr. David Alan Gilbert wrote: > * Marcel Apfelbaum (mar...@redhat.com) wrote: >> On 23/09/2017 11:23, Mark Cave-Ayland wrote: >>> On 22/09/17 23:18, Laszlo Ersek wrote: >>> On 09/22/17 14:18, Mark Cave-Ayland wrote: > Whilst the underlying PCI bridge implementation supp

Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

2017-09-28 Thread Laszlo Ersek
On 09/27/17 12:06, Marcel Apfelbaum wrote: > Hi Laszlo, > > On 20/09/2017 14:01, Laszlo Ersek wrote: >>   We now have >> >> if (mem_pref_32_reserve != (uint32_t)-1 && >> mem_pref_64_reserve != (uint64_t)-1) { >> error_setg(errp, >> >> but after introducing the zero value, th

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-28 Thread Auger Eric
Hi Linu, Peter, On 28/09/2017 09:13, Peter Xu wrote: > On Thu, Sep 28, 2017 at 12:13:12PM +0530, Linu Cherian wrote: >> Hi Eric, >> >> >> On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: >>> This series implements the emulation code for ARM SMMUv3. >>> >>> Changes since v6: >>> - DPDK te

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-28 Thread Laszlo Ersek
On 09/28/17 09:31, Mark Cave-Ayland wrote: > On 25/09/17 09:11, Dr. David Alan Gilbert wrote: > >> * Marcel Apfelbaum (mar...@redhat.com) wrote: >>> On 23/09/2017 11:23, Mark Cave-Ayland wrote: On 22/09/17 23:18, Laszlo Ersek wrote: > On 09/22/17 14:18, Mark Cave-Ayland wrote: >>

Re: [Qemu-devel] [PATCH v7 01/20] hw/arm/smmu-common: smmu base device and datatypes

2017-09-28 Thread Auger Eric
Hi Peter, On 27/09/2017 19:38, Peter Maydell wrote: > On 1 September 2017 at 10:21, Eric Auger wrote: >> The patch introduces the smmu base device and class for the ARM >> smmu. Devices for specific versions will be derived from this >> base device. >> >> We also introduce some important datatypes

Re: [Qemu-devel] [PATCH v10 07/10] migration: calculate vCPU blocktime on dst side

2017-09-28 Thread Alexey Perevalov
On 09/21/2017 02:57 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch whe

Re: [Qemu-devel] [RFC for-2.10 2/3] pci: Allow host bridges to override PCI/PCIe hybrid device behaviour

2017-09-28 Thread David Gibson
On Wed, Apr 26, 2017 at 06:29:05PM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 28, 2017 at 01:16:50PM +1100, David Gibson wrote: > > Currently PCI/PCIe hybrid devices - that is, devices which can appear as > > either plain PCI or PCIe depending on where they're attached - will only > > appear in

Re: [Qemu-devel] ppce500 usb-ehci-pci issue on last uboot

2017-09-28 Thread Gerd Hoffmann
On Thu, 2017-09-28 at 07:27 +, luigi burdo wrote: > > Hi Gerd, > i had test it yesterday on Little Endian machine host (Apple  Osx > Sierra) > the issue is present there too. How can this be reproduced? cheers, Gerd

Re: [Qemu-devel] [SeaBIOS] Time for a seabios 1.11 release?

2017-09-28 Thread Gerd Hoffmann
On Wed, 2017-09-27 at 09:51 -0400, Kevin O'Connor wrote: > On Tue, Sep 26, 2017 at 09:33:09AM +0200, Gerd Hoffmann wrote: > >    Hi, > > > > Quite a few changes accumulated in master.  Time to plan a new > > release > > I think, so we can pick up the improvements in qemu 2.11. > > > > Comments? >

Re: [Qemu-devel] [RFC PATCH v2 11/21] ppc/xive: push the EQ data in OS event queue

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 16:34 +1000, David Gibson wrote: > > >> +if (GETFIELD(EQ_W6_FORMAT_BIT, eq->w6) == 0) { > > >> +priority = GETFIELD(EQ_W7_F0_PRIORITY, eq->w7); > > >> > > >> +/* The EQ is masked. Can this happen ? */ > > >> +if (priority == 0xff) { > > >> +

Re: [Qemu-devel] [RFC PATCH v2 13/21] ppc/xive: handle interrupt acknowledgment by the O/S

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 11:40 +0200, Cédric Le Goater wrote: > > Plus, this doesn't seem right. Shouldn't this > > recheck the CPPR against the PIPR, in case a higher priority irq has > > been delivered since the one the cpu is acking. > > If a higher priority is delivered, it means that the CPPR w

Re: [Qemu-devel] [RFC PATCH v2 14/21] ppc/xive: add support for the SET_OS_PENDING command

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 11:47 +0200, Cédric Le Goater wrote: > > > @@ -162,7 +162,14 @@ static bool spapr_xive_tm_is_readonly(uint8_t index) > > > static void spapr_xive_tm_write_special(ICPState *icp, hwaddr offset, > > > uint64_t value, unsigned size) > > > {

Re: [Qemu-devel] [RFC PATCH v2 00/21] Guest exploitation of the XIVE interrupt controller (POWER9)

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 14:33 +0200, Cédric Le Goater wrote: > > > I'm thinking maybe trying to support the CAS negotiation of interrupt > > > controller from day 1 is warping the design. A better approach might > > > be first to implement XIVE only when given a specific machine option - > > > guest

Re: [Qemu-devel] [RFC PATCH v2 07/21] ppc/xive: add MMIO handlers for the XIVE interrupt sources

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 14:54 +0200, Cédric Le Goater wrote: > On 09/19/2017 04:57 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:21PM +0200, Cédric Le Goater wrote: > > > Each interrupt source is associated with a two bit state machine > > > called an Event State Buffer (ESB) which is con

Re: [Qemu-devel] ppce500 usb-ehci-pci issue on last uboot

2017-09-28 Thread luigi burdo
Hi Gerd, >How can this be reproduced? you need to build last uboot with the ehci pci option enabled and the usb command line enabled. or just download my last e500 uboot build from here https://www.dropbox.com/s/xxlu6ivg3izlqvu/u-boot?dl=0 Run it as: qemu-system-ppc64 -M ppce500 -cpu e5

Re: [Qemu-devel] [RFC PATCH v2 07/21] ppc/xive: add MMIO handlers for the XIVE interrupt sources

2017-09-28 Thread Benjamin Herrenschmidt
On Wed, 2017-09-20 at 15:05 +0200, Cédric Le Goater wrote: > > > +/* > > > + * XIVE Interrupt Source MMIOs > > > + */ > > > +static uint64_t spapr_xive_esb_read(void *opaque, hwaddr addr, unsigned > > > size) > > > +{ > > > +sPAPRXive *xive = SPAPR_XIVE(opaque); > > > +uint32_t offset = ad

Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block driver

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 11:06:24PM +0200, Max Reitz wrote: > On 2017-09-27 14:53, Daniel P. Berrange wrote: > > This is a followup to > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html > >

Re: [Qemu-devel] [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Jan Beulich
>>> On 27.09.17 at 21:56, wrote: > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote: > Let me be more precise. I am saying that the interrupt-controller > and #interrupt-cells properties are not needed under the main interrupt > controller node. They can be removed from the tree and the Linux guest > kernel will boot per

[Qemu-devel] [PATCH v6 3/6] ui: add keycodemapdb repository as a GIT submodule

2017-09-28 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v6 6/6] ui: don't export qemu_input_event_new_key

2017-09-28 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

[Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
This patch series is an update to: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html v4: https://lists.gnu.org/archive/html/

[Qemu-devel] [PATCH v6 1/6] build: automatically handle GIT submodule checkout for dtc

2017-09-28 Thread Daniel P. Berrange
Currently if DTC is required by configure and not available in the host OS install, we exit with an error message telling the user to checkout a git submodule or install the library. This introduces automatic handling of the git submodule checkout process and enables it for dtc. This only runs if

[Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Daniel P. Berrange
When building the tarball to pass into the docker/vm test image, the code relies on the git submodules being checked out in the main checkout. ie if the developer has not run 'git submodule update --init dtc' most (all?) of the docker tests will fail due to the missing dtc package in the test imag

[Qemu-devel] [PATCH v6 4/6] ui: convert common input code to keycodemapdb

2017-09-28 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

[Qemu-devel] [PATCH v6 5/6] ui: convert key events to QKeyCodes immediately

2017-09-28 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. This allows the code processing / consuming key events to assume QKeyCode is used. The only place we accept a key number in the InputKeyEvent struct is with QMP commands sent by

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Cédric Le Goater
On 09/28/2017 10:43 AM, Benjamin Herrenschmidt wrote: > On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote: >> Let me be more precise. I am saying that the interrupt-controller >> and #interrupt-cells properties are not needed under the main interrupt >> controller node. They can be remove

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-21 at 11:35 +1000, David Gibson wrote: > > >> +_FDT(fdt_setprop_string(fdt, node, "device_type", "power-ivpe")); > > >> +_FDT(fdt_setprop(fdt, node, "reg", timas, sizeof(timas))); > > >> + > > >> +_FDT(fdt_setprop_string(fdt, node, "compatible", "ibm,power-ivpe")); > > >

Re: [Qemu-devel] [PATCH 2/5] iotests: Set up Python logging

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > Set up Python logging module instead of relying on > QEMUMachine._debug to enable debugging messages. > > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-bl...@nongnu.org > Signed-off-by: Eduardo Habkost > --- > tests/qemu-iotests/iotests.py | 3 +++

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-28 Thread Pavel Butsykin
On 27.09.2017 19:36, Max Reitz wrote: On 2017-09-27 18:27, Pavel Butsykin wrote: On 27.09.2017 19:00, Max Reitz wrote: On 2017-09-22 11:39, Pavel Butsykin wrote: Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find

Re: [Qemu-devel] [PATCH v2 1/5] pci: conventional-pci-device and pci-express-device interfaces

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Those two interfaces will be used to indicate which device types support Conventional PCI or PCI Express buses. Management software will be able to use the qom-list-types QMP command to query that information. Signed-off-by: Eduardo Habkost --- Chang

Re: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule Message-id: 20170928084430.17059-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH] linux-headers: sync against v4.14-rc1

2017-09-28 Thread Paolo Bonzini
On 27/09/2017 21:05, Dr. David Alan Gilbert wrote: > cc'ing in Paolo who I think knows more about checking this sync. It looks good to me. Paolo > Dave > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: >> Signed-off-by: Alexey Perevalov >> --- >> include/standard-headers/asm-x86/hyperv.

Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell frontends

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > The logging module will eventually replace the 'debug' parameter > in QEMUMachine and QEMUMonitorProtocol. > > Cc: Daniel P. Berrange > Signed-off-by: Eduardo Habkost > --- > tests/migration/guestperf/shell.py | 9 + > 1 file changed, 9

[Qemu-devel] [PATCH v9 3/8] tpm-backend: Initialize and free data members in it's own methods

2017-09-28 Thread Amarnath Valluri
Initialize and free TPMBackend data members in it's own instance_init() and instance_finalize methods. Took the opportunity to remove unneeded destroy() method from TpmDriverOps interface as TPMBackend is a Qemu Object, we can use object_unref() inplace of tpm_backend_destroy() to free the backend

[Qemu-devel] [PATCH v9 7/8] tpm-passthrough: move reusable code to utils

2017-09-28 Thread Amarnath Valluri
Signed-off-by: Amarnath Valluri Reviewed-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_passthrough.c | 64 hw/tpm/tpm_util.c| 25 +++ hw/tpm/tpm_util.h| 4 +++ 3 files changed, 34 insertions(+),

[Qemu-devel] [PATCH v9 1/8] tpm-backend: Remove unneeded member variable from backend class

2017-09-28 Thread Amarnath Valluri
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-off-by: Amarnath Valluri Reviewed-by: Marc-André

[Qemu-devel] [PATCH v9 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model

2017-09-28 Thread Amarnath Valluri
buffer reallocation is very unlikely to be backend specific. Hence move inside the tis. Signed-off-by: Amarnath Valluri Reviewed-by: Stefan Berger Reviewed-by: Marc-André Lureau --- backends/tpm.c | 9 - hw/tpm/tpm_passthrough.c | 12 hw/tpm/tpm_tis.c

[Qemu-devel] [PATCH v9 0/8] Provide support for the software TPM

2017-09-28 Thread Amarnath Valluri
Briefly, Theses set of patches introduces: - new TPM backend driver to support software TPM emulators(swtpm(1)). - and few supported fixes/enhancements/cleanup to existing tpm backend code. The similar idea was initiated earliar(2) by Stefan Berger(CCed) with slightly different approach, using CUS

[Qemu-devel] [PATCH v9 5/8] tmp backend: Add new api to read backend TpmInfo

2017-09-28 Thread Amarnath Valluri
TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., which shall be implemented by the derived classes to r

[Qemu-devel] [PATCH v9 2/8] tpm-backend: Move thread handling inside TPMBackend

2017-09-28 Thread Amarnath Valluri
Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_backend_int.h kind of useless, hence removed it. S

[Qemu-devel] [PATCH v9 8/8] tpm: Added support for TPM emulator

2017-09-28 Thread Amarnath Valluri
This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. QEMU talks to TPM emulator using QEMU's socket-based chardev backend device. Swtpm uses two Unix sockets for communications, one for plain TPM commands and res

[Qemu-devel] [PATCH v9 4/8] tpm-backend: Made few interface methods optional

2017-09-28 Thread Amarnath Valluri
This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Took the opportunity to remove unused methods: - tpm_backend_get_desc() - TPMDriverOps->handle_startup_error Signed-off-by: Amarnath Valluri Reviewed-by: Marc-André Lureau Review

Re: [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig()

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > Just setting level=DEBUG when debug is enabled is not enough: we > need to set up a log handler if we want debug messages generated > using logging.getLogger(...).debug() to be printed. > > This was not a problem before because logging.debug() cal

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-28 Thread Marcel Apfelbaum
On 28/09/2017 10:31, Mark Cave-Ayland wrote: On 25/09/17 09:11, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (mar...@redhat.com) wrote: On 23/09/2017 11:23, Mark Cave-Ayland wrote: On 22/09/17 23:18, Laszlo Ersek wrote: On 09/22/17 14:18, Mark Cave-Ayland wrote: Whilst the underlying P

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-28 Thread Linu Cherian
On Thu Sep 28, 2017 at 09:54:20AM +0200, Auger Eric wrote: > Hi Linu, Peter, > > On 28/09/2017 09:13, Peter Xu wrote: > > On Thu, Sep 28, 2017 at 12:13:12PM +0530, Linu Cherian wrote: > >> Hi Eric, > >> > >> > >> On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > >>> This series implemen

Re: [Qemu-devel] [PATCH v2 2/5] pci: Add interface names to hybrid PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 28/09/2017 7:08, David Gibson wrote: On Wed, Sep 27, 2017 at 04:56:32PM -0300, Eduardo Habkost wrote: The following devices support both PCI Express and Conventional PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS flag and/or conditional pcie_endpoint_cap_init() calls: * vf

Re: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 01:53:25AM -0700, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Type: series > Subject: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT > submodule > Message-id: 20170928084430.17059-

[Qemu-devel] [PATCH v3 0/2] Truncate the tail of the image file in qcow2 shrinking

2017-09-28 Thread Pavel Butsykin
Now after shrinking the qcow2 image, at the end of the image file, there might be a tail that probably will never be used. Although it will not bring any tangible benefit, we can cut the tail if it is. Yes, it will not free up disk space, but if the blocks were be allocated sequentially and the ima

[Qemu-devel] [PATCH v3 1/2] qcow2: fix return error code in qcow2_truncate()

2017-09-28 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 2174a84d1f..8a4311d338 100644 --- a/block/qcow2.c +++ b/block/qcow2.

[Qemu-devel] [PATCH v3 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-28 Thread Pavel Butsykin
Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find the last used cluster and cut the tail. Signed-off-by: Pavel Butsykin Reviewed-by: John Snow --- block/qcow2-refcount.c | 22 ++ block/qcow2.c

Re: [Qemu-devel] [PATCH v2 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Change all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE. Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Dmitry Fleytman Cc: Jason Wang Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paul Burton Cc: Paolo Bonzini Cc: Ha

Re: [Qemu-devel] [PATCH] fixup! scripts: Remove debug parameter from QEMUMonitorProtocol

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:44 Eduardo Habkost napsal(a): > On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote: >> On Wed, 09/27 10:03, Eduardo Habkost wrote: >>> @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object): >>> """ >>> self.__events = [] >>> self.__address = addres

Re: [Qemu-devel] [PATCH v2 5/5] pci: Validate interfaces on base_class_init

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Make sure we don't forget to add the Conventional PCI or PCI Express interface names on PCI device classes in the future. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * s/legacy/conventional/ * Suggested-by: Alex Williamson --- hw/pci/pc

Re: [Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI b

Re: [Qemu-devel] [PATCH v2 0/5] Mark conventional/PCIe/hybrid PCI devices using interface names

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Changes v1 -> v2: * Use "Conventional PCI" instead of "legacy PCI" * Suggested-by: Alex Williamson * Mark base-xhci as hybrid too * Reported-by: Marcel Apfelbaum * Mark pcie-pci-bridge as PCI Express only * New Conventional PCI devices: sungem,

Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Fam Zheng
On Thu, 09/28 09:44, Daniel P. Berrange wrote: > When building the tarball to pass into the docker/vm test image, > the code relies on the git submodules being checked out in the > main checkout. > > ie if the developer has not run 'git submodule update --init dtc' > most (all?) of the docker test

Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 05:44:53PM +0800, Fam Zheng wrote: > On Thu, 09/28 09:44, Daniel P. Berrange wrote: > > When building the tarball to pass into the docker/vm test image, > > the code relies on the git submodules being checked out in the > > main checkout. > > > > ie if the developer has not

[Qemu-devel] [PATCH] default-configs: Enable CONFIG_VMXNET3_PCI only on x86

2017-09-28 Thread Thomas Huth
The device can not be instantiated on many non-x86 and just prints some error messages, e.g.: $ qemu-system-ppc64 -device vmxnet3 -M g3beige [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 [vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is inc

Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy

2017-09-28 Thread Stefan Hajnoczi
On Thu, Sep 28, 2017 at 10:59:58AM +0800, Peter Xu wrote: > From: Stefan Hajnoczi > > After iothread is enabled internally inside QEMU with GMainContext, we > may encounter this warning when destroying the iothread: > > (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll: > asser

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Kevin Wolf
Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > OK but if it's useful as an hmp command, why not as a qmp command? > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and > unneccesary. T

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote: > probably, I just removed the properties under QEMU and could > boot the guest, with disks and network. As long as you don't use LSIs... > > > Do you have a DT snapshot from pHyp for me to look at ? > > > # lsprop /proc/device-tree/i

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 12:02:35 +0200 Kevin Wolf wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp command

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and > un

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp

Re: [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal iothreads

2017-09-28 Thread Stefan Hajnoczi
On Thu, Sep 28, 2017 at 10:59:53AM +0800, Peter Xu wrote: > v4: > - fix comment in patch 1 [Fam, Stefan] > - add one more patch from Stefan to fix the aio glib warning > > v3: > - pick up r-bs (one missing for Fam's on last patch) > - fix patch 1 to create isolated internal container > > v2: > -

Re: [Qemu-devel] [PATCH] default-configs: Enable CONFIG_VMXNET3_PCI only on x86

2017-09-28 Thread Dmitry Fleytman
> On 28 Sep 2017, at 12:52 PM, Thomas Huth wrote: > > The device can not be instantiated on many non-x86 and just prints > some error messages, e.g.: > > $ qemu-system-ppc64 -device vmxnet3 -M g3beige > [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 > [vmxnet3][WR][vmxn

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/27/2017 05:03 PM, Cornelia Huck wrote: > On Wed, 27 Sep 2017 15:49:27 +0100 > "Dr. David Alan Gilbert" wrote: > >> * Cornelia Huck (coh...@redhat.com) wrote: >>> On Wed, 27 Sep 2017 15:28:38 +0100 >>> "Dr. David Alan Gilbert" wrote: >>> * David Hildenbrand (da...@redhat.com) wrot

[Qemu-devel] [PATCH v5 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-09-28 Thread Aravinda Prasad
This series of patches adds support for FWNMI in PowerKVM guests. Memory error such as bit flips that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exception, if the address in error belongs to guest the

[Qemu-devel] [PATCH v5 1/6] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-09-28 Thread Aravinda Prasad
Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] (commit f9a60de3) adds functionality to invoke a private HCALL whenever OS issues instantiate-rtas with a new rtas-base. This is required as QEMU needs to know the updated rtas-base as it allocates error reporting

[Qemu-devel] [PATCH v5 3/6] Wrapper function to wait on condition for the main loop mutex

2017-09-28 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. Signed-off-by: Aravinda Prasad --- cpus.c |5 + include/qemu/main-loop.h |8

[Qemu-devel] [PATCH v5 2/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-09-28 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the same

[Qemu-devel] [PATCH v5 4/6] target/ppc: Handle NMI guest exit

2017-09-28 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in

[Qemu-devel] [PATCH v5 5/6] ppc: spapr: Enable FWNMI capability

2017-09-28 Thread Aravinda Prasad
Enable the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. Signed-off-by: Ar

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp command most of `info vir

[Qemu-devel] [PATCH v5 6/6] migration: Block migration while handling machine check

2017-09-28 Thread Aravinda Prasad
Block VM migration requests until the machine check error handling is complete as (i) these errors are specific to the source hardware and is irrelevant on the target hardware, (ii) these errors cause data corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/p

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/28/2017 12:34 PM, Christian Borntraeger wrote: > > > On 09/27/2017 05:03 PM, Cornelia Huck wrote: >> On Wed, 27 Sep 2017 15:49:27 +0100 >> "Dr. David Alan Gilbert" wrote: >> >>> * Cornelia Huck (coh...@redhat.com) wrote: On Wed, 27 Sep 2017 15:28:38 +0100 "Dr. David Alan Gilber

Re: [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig

2017-09-28 Thread Paolo Bonzini
On 27/09/2017 22:32, Eduardo Habkost wrote: > Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we > have no default config files that would be disabled using > -nodefconfig. This series cleans up the code, updates > documentation, and document -nodefconfig as deprecated. Don't forge

Re: [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 05:32:23PM -0300, Eduardo Habkost wrote: > Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we > have no default config files that would be disabled using > -nodefconfig. This series cleans up the code, updates > documentation, and document -nodefconfig as dep

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > Both -nodefconfig and -no-user-config options do the same thing > today, we only need one variable to keep track of them. What reason for picking -nodefconfig instead of -no-user-config to deprecate ? -nodefconfig predates -no-use

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 12:42:02PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > > Both -nodefconfig and -no-user-config options do the same thing > > today, we only need one variable to keep track of them. > > What reason for picking -nodefc

Re: [Qemu-devel] [PATCH v9 8/8] tpm: Added support for TPM emulator

2017-09-28 Thread Marc-André Lureau
Hi On Thu, Sep 28, 2017 at 11:20 AM, Amarnath Valluri wrote: > This change introduces a new TPM backend driver that can communicate with > swtpm(software TPM emulator) using unix domain socket interface. QEMU talks to > TPM emulator using QEMU's socket-based chardev backend device. > > Swtpm uses

[Qemu-devel] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename

2017-09-28 Thread Vladimir Sementsov-Ogievskiy
Backing may be zero after failed bdrv_attach_child in bdrv_set_backing_hd, which leads to SIGSEGV. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. We have faced into this SIGSEGV because of image locking: trying to call qemu-img commit on locked image leads to the following: Progra

Re: [Qemu-devel] [Qemu-stable] [PATCH] migration: disable auto-converge during bulk block migration

2017-09-28 Thread Peter Lieven
Am 25.09.2017 um 22:53 schrieb Michael Roth: Quoting Peter Lieven (2017-09-21 07:32:32) auto-converge and block migration currently do not play well together. During block migration the auto-converge logic detects that ram migration makes no progress and thus throttles down the vm until it nearl

[Qemu-devel] [PATCH v7 1/6] build: automatically handle GIT submodule checkout for dtc

2017-09-28 Thread Daniel P. Berrange
Currently if DTC is required by configure and not available in the host OS install, we exit with an error message telling the user to checkout a git submodule or install the library. This introduces automatic handling of the git submodule checkout process and enables it for dtc. This only runs if

[Qemu-devel] [PATCH v7 3/6] ui: add keycodemapdb repository as a GIT submodule

2017-09-28 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v7 5/6] ui: convert key events to QKeyCodes immediately

2017-09-28 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. This allows the code processing / consuming key events to assume QKeyCode is used. The only place we accept a key number in the InputKeyEvent struct is with QMP commands sent by

[Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
This patch series is an update to: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html v4: https://lists.gnu.org/archive/html/

[Qemu-devel] [PATCH v7 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Daniel P. Berrange
When building the tarball to pass into the docker/vm test image, the code relies on the git submodules being checked out in the main checkout. ie if the developer has not run 'git submodule update --init dtc' many of the docker tests will fail due to the libfdt package not being present in the tes

[Qemu-devel] [PATCH v7 6/6] ui: don't export qemu_input_event_new_key

2017-09-28 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 12:41:54 +0200 Christian Borntraeger wrote: > On 09/28/2017 12:34 PM, Christian Borntraeger wrote: > > > > > > On 09/27/2017 05:03 PM, Cornelia Huck wrote: > >> On Wed, 27 Sep 2017 15:49:27 +0100 > >> "Dr. David Alan Gilbert" wrote: > >> > >>> * Cornelia Huck (coh...@re

[Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycodemapdb

2017-09-28 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/28/2017 02:07 PM, Cornelia Huck wrote: > On Thu, 28 Sep 2017 12:41:54 +0200 > Christian Borntraeger wrote: > >> On 09/28/2017 12:34 PM, Christian Borntraeger wrote: >>> >>> >>> On 09/27/2017 05:03 PM, Cornelia Huck wrote: On Wed, 27 Sep 2017 15:49:27 +0100 "Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule Message-id: 20170928120621.30288-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 14:17:54 +0200 Christian Borntraeger wrote: > I see no point if PCI disable machines. There is no non-PCI x86 machine > besides the isapc. But this has no version whatsoever so it certainly > is not made for being migrated. > As far as I can see and we would make things much m

  1   2   >