Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-14 Thread Mark Cave-Ayland
On 14/08/17 07:51, Paolo Bonzini wrote: > On 13/08/2017 21:13, Programmingkid wrote: >> Lately I found out that Windows NT 4.0 seems to work well with the >> 486 and pentium processors. Using "-cpu 486" made installing it >> actually work. Now I am seeing another issue. When I boot Windows NT >> 4

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

2017-08-14 Thread Vladimir Sementsov-Ogievskiy
12.08.2017 01:28, Eric Blake wrote: On 08/08/2017 10:26 AM, Vladimir Sementsov-Ogievskiy wrote: Initial review, I'm still playing with this one, and will reply again on Monday. Do not communicate after the first error to avoid communicating throught s/throught/through a/ broken channel. The

Re: [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-14 Thread Igor Mammedov
On Tue, 18 Jul 2017 15:17:21 +0200 Igor Mammedov wrote: > On Tue, 18 Jul 2017 14:30:09 +0200 > Cornelia Huck wrote: > > > On Fri, 14 Jul 2017 15:52:02 +0200 > > Igor Mammedov wrote: > > > > > cpu_s390x_init() is used only *-user targets indirectly > > > via cpu_init() macro and has a hack t

Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses

2017-08-14 Thread Igor Mammedov
On Fri, 14 Jul 2017 15:51:55 +0200 Igor Mammedov wrote: > QOMfy cpu models handling introducing propper cpu types > for each cpu model. > > Signed-off-by: Igor Mammedov > --- > with this and conversion of features to properties, > it would be possible to replace cpu_sparc_init() with > cpu_gene

Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init()

2017-08-14 Thread Igor Mammedov
On Mon, 17 Jul 2017 17:23:22 +0200 Igor Mammedov wrote: > On Mon, 17 Jul 2017 17:05:15 +0200 > Andreas Färber wrote: > > > Am 17.07.2017 um 12:41 schrieb Igor Mammedov: > > > On Sat, 15 Jul 2017 08:08:58 -1000 > > > Richard Henderson wrote: > > > > > >> On 07/14/2017 03:52 AM, Igor Mamm

Re: [Qemu-devel] [PULL 0/5] Net patches

2017-08-14 Thread Jason Wang
On 2017年08月14日 14:51, Peter Maydell wrote: On 14 August 2017 at 04:33, Jason Wang wrote: The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) are available in

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-14 Thread Paolo Bonzini
On 12/08/2017 23:33, Matt Parker wrote: > This updates the current MemoryRegionOps for the bar 1 memory region > from using the old_mmio accessors to the .read and .write accessors. > > Signed-off-by: Matt Parker > --- > hw/net/rtl8139.c | 60 > +++---

[Qemu-devel] [PULL 0/1] Doc fix for QEMU 2.10-rc3

2017-08-14 Thread Paolo Bonzini
The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-08-10 18:53:39 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 1/1] qemu-doc: Fix "-net van" typo

2017-08-14 Thread Paolo Bonzini
From: Thomas Huth While Andrew S. Tanenbaum has a point by saying "Never underestimate the bandwidth of a station wagon full of tapes hurtling down the highway", we don't support that way of transportation in QEMU yet, so replace the typo with the correct word "vlan". Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH 21/28] arm: replace cpu_arm_init() with cpu_generic_init()

2017-08-14 Thread Andrew Jones
On Fri, Jul 14, 2017 at 03:52:12PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov > --- > CC: Jan Kiszka > CC: Peter Maydell > CC: Andrzej Zaborowski > CC: qemu-...@nongnu.org > --- > target/arm/cpu.h| 3 +--

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

2017-08-14 Thread Paolo Bonzini
On 13/08/2017 19:04, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/ppc/Makefile.objs | 2 +- > hw/ppc/ppc405.h | 2 + > hw/ppc/ppc405_uc.c | 241 - > hw/ppc/ppc4xx_i2c.c | 272 > +++

Re: [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-14 Thread Cornelia Huck
On Mon, 14 Aug 2017 10:03:48 +0200 Igor Mammedov wrote: > On Tue, 18 Jul 2017 15:17:21 +0200 > Igor Mammedov wrote: > > > On Tue, 18 Jul 2017 14:30:09 +0200 > > Cornelia Huck wrote: > > > > > On Fri, 14 Jul 2017 15:52:02 +0200 > > > Igor Mammedov wrote: > > > > > > > cpu_s390x_init()

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-08-14 Thread Markus Armbruster
Max Reitz writes: > On 2017-07-11 13:33, Markus Armbruster wrote: >> Max Reitz writes: >> >>> First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at >>> least not right now and in the foreseeable future). >>> You're the maintainer, so you decide, so I'll go along with it. :-)

Re: [Qemu-devel] OvmfPkg (PlatformPei?): supporting Qemu's nvdimm device

2017-08-14 Thread Igor Mammedov
On Thu, 10 Aug 2017 00:13:57 +0200 Laszlo Ersek wrote: > On 08/09/17 22:47, Rebecca Cran wrote: > > I've been investigating adding support for Qemu's nvdimm devices to > > OVMF. I was thinking such support would go into PlatformPei, but it > > looks like I can only read the ACPI NFIT in the DXE

Re: [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-14 Thread Igor Mammedov
On Mon, 14 Aug 2017 10:53:37 +0200 Cornelia Huck wrote: > On Mon, 14 Aug 2017 10:03:48 +0200 > Igor Mammedov wrote: > > > On Tue, 18 Jul 2017 15:17:21 +0200 > > Igor Mammedov wrote: > > > > > On Tue, 18 Jul 2017 14:30:09 +0200 > > > Cornelia Huck wrote: > > > > > > > On Fri, 14 Jul 20

Re: [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-14 Thread Cornelia Huck
On Mon, 14 Aug 2017 11:24:07 +0200 Igor Mammedov wrote: > I didn't look at possibility of refactoring next_cpu_id usage as > it's out of scope of this series. But from my understanding, it's been > introduced to support legacy cpu_add interface and enforce sequential > hotplug of CPUs when device

Re: [Qemu-devel] [PATCH v7 07/16] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor

2017-08-14 Thread Vladimir Sementsov-Ogievskiy
10.07.2017 19:30, Vladimir Sementsov-Ogievskiy wrote: To just release successor and unfreeze bitmap without any additional work. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev --- block/dirty-bitmap.c | 13 + include/block/dirty-bitmap.h | 2 +

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-08-14 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 03:15:59PM -0300, Eduardo Habkost wrote: > On Fri, Aug 11, 2017 at 05:44:55PM +0100, Daniel P. Berrange wrote: > > On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > > > CCing Zack Cornelius. > > > > > > On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habk

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

2017-08-14 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 12:47:44PM -0500, Eric Blake wrote: > On 08/11/2017 11:05 AM, Markus Armbruster wrote: > > We've wanted -object to support non-scalar properties for a while. > > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > > authorization API". Review led to the conclusion

[Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

2017-08-14 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-14 Thread David Gibson
On Fri, Aug 11, 2017 at 09:59:00AM +0100, Peter Maydell wrote: > On 11 August 2017 at 09:51, David Gibson wrote: > > On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: > >> On 9 August 2017 at 08:03, David Gibson > >> wrote: > >> > I haven't completed a Travis build for this, which i

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

2017-08-14 Thread Dou Liyang
I'm sorry, forgot to cc Michael S. Tsirkin At 08/14/2017 06:11 PM, Dou Liyang wrote: Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \

Re: [Qemu-devel] [PULL for-2.10 0/1] bugfix for boot-serial-test and no tcg

2017-08-14 Thread Peter Maydell
On 11 August 2017 at 15:06, Cornelia Huck wrote: > The following changes since commit 473a321122fd3c2c327a5a5d01a9a41f26f1734c: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2017-08-10 17:50:55 +0100) > > are available in the git repository at: > > git://g

[Qemu-devel] [PATCH v2 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-14 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb

2017-08-14 Thread Daniel P. Berrange
An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html The keycodemap project[1] provides a database mapping between many different keysym/keycode/scancode sets, along with a tool to generate mapping/lookup tables in various programming languages. It is already us

[Qemu-devel] [PATCH v2 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C

[Qemu-devel] [PATCH v2 07/12] input: convert the adb device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +- include/hw/input/adb-key

[Qemu-devel] [PATCH v2 03/12] ui: convert key events to QKeyCodes immediately

2017-08-14 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c ind

[Qemu-devel] [PATCH v2 08/12] char: convert the escc device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++-- include/ui/input.h | 3 +

[Qemu-devel] [PATCH v2 04/12] ui: don't export qemu_input_event_new_key

2017-08-14 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

[Qemu-devel] [PATCH v2 10/12] ui: convert the SDL2 frontend to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

[Qemu-devel] [PATCH v2 02/12] ui: convert common input code to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

[Qemu-devel] [PATCH v2 06/12] input: convert ps2 device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN -> 0xe00

[Qemu-devel] [PATCH v2 12/12] display: convert XenInput keyboard to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 133 - 1 file chang

[Qemu-devel] [PATCH v2 09/12] ui: convert cocoa frontend to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the mac_to_qkeycode_map table with automatically generated table. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 3 ++ ui/Makefile.objs | 1 + ui/cocoa.m | 129 + ui/input-keymap.c | 1 + 4 files changed, 7

[Qemu-devel] [PATCH v2 11/12] ui: convert GTK and SDL1 frontends to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
The x_keycode_to_pc_keycode and evdev_keycode_to_pc_keycode tables are replaced with automatically generated tables. In addition the X11 heuristics are improved to detect running on XQuartz and XWin X11 servers, to activate the correct OS-X and Win32 keycode maps. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb Type: series Message-id: 20170814104958.29434-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb Message-id: 20170814104958.29434-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170814104958.29434-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/12] Convert over to use keycodemapdb

Re: [Qemu-devel] [RFC PATCH 11/12] ppc4xx: Export ECB and PLB emulation

2017-08-14 Thread BALATON Zoltan
On Mon, 14 Aug 2017, David Gibson wrote: On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: These devices are found in some other ppc4xx cores too. Thanks for the quick review, hope more will follow for other patches too maybe also from others. Elsewhere in the series you move

[Qemu-devel] [PULL 0/7] Trivial patches for 2017-08-14

2017-08-14 Thread Michael Tokarev
There are just a few small thigs, I've omitted larger series for now. The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) are available in the git repository at:

[Qemu-devel] [PULL 6/7] qemu-iotests: remove comment about root privileges requirement

2017-08-14 Thread Michael Tokarev
From: Cleber Rosa The check script contains a commented out root user requirement, probably because of its xfstests heritage. This requirement doesn't apply to qemu-iotests, so it better be gone. Signed-off-by: Cleber Rosa Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- test

[Qemu-devel] [PULL 5/7] qemu-iotests: remove commented out variables

2017-08-14 Thread Michael Tokarev
From: Cleber Rosa The variables FULL_MKFS_OPTIONS and FULL_MOUNT_OPTIONS are commented out, never used, and even refer to functions that do exist. The last time these were touched was around 8 years ago, so I guess it's safe to assume outputting such information on test execution is still on the

[Qemu-devel] [PULL 3/7] qemu-doc: Fix "-net van" typo

2017-08-14 Thread Michael Tokarev
From: Thomas Huth While Andrew S. Tanenbaum has a point by saying "Never underestimate the bandwidth of a station wagon full of tapes hurtling down the highway", we don't support that way of transportation in QEMU yet, so replace the typo with the correct word "vlan". Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 2/7] libqtest: Fix typo in comments

2017-08-14 Thread Michael Tokarev
From: Eric Blake s/continuosly/continuously/ Signed-off-by: Eric Blake Reviewed-by: Jeff Cody Signed-off-by: Michael Tokarev --- tests/libqtest.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/libqtest.h b/tests/libqtest.h index 38bc1e9953..3ae570927a 10064

[Qemu-devel] [PULL 4/7] qemu-iotests: get rid of _full_imgproto_details()

2017-08-14 Thread Michael Tokarev
From: Cleber Rosa Although this function is used, its implementation does nothing besides echoing a variable name. There's no need to wrap this functionality in a function, and based on the one usage it has, it's not even required to adhere to a convention or code style. Signed-off-by: Cleber R

[Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-14 Thread Michael Tokarev
From: Thomas Huth QEMU currently abort()s if the user tries to specify the mmio_interface device without parameters: x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv: Assertion `*errp == ((void *)0)' faile

[Qemu-devel] [PULL 1/7] unicore32: abort when entering "x 0" on the monitor

2017-08-14 Thread Michael Tokarev
From: Eduardo Otubo Starting Qemu with "qemu-system-unicore32 -M puv3,accel=qtest -S -nographic" and entering "x 0 " at the monitor prompt leads to abort(): $ ./unicore32-softmmu/qemu-system-unicore32 -M puv3,accel=qtest -S -nographic QEMU 2.9.90 monitor - type 'help' for more information

Re: [Qemu-devel] [RFC PATCH 08/12] hw/ide: Emulate SiI3112 SATA controller

2017-08-14 Thread BALATON Zoltan
On Mon, 14 Aug 2017, David Gibson wrote: On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Needs a commit message: where does this controller appear? what's distinctive about it? is there a link to a datasheet or programming manual? This is just a

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

2017-08-14 Thread BALATON Zoltan
On Mon, 14 Aug 2017, Paolo Bonzini wrote: On 13/08/2017 19:04, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/ppc/Makefile.objs | 2 +- hw/ppc/ppc405.h | 2 + hw/ppc/ppc405_uc.c | 241 - hw/ppc/ppc4xx_i2c.c | 272 +

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

2017-08-14 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Aug 11, 2017 at 12:47:44PM -0500, Eric Blake wrote: >> On 08/11/2017 11:05 AM, Markus Armbruster wrote: >> > We've wanted -object to support non-scalar properties for a while. >> > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based >> > authorization

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-08-14 Thread Eduardo Habkost
On Mon, Aug 14, 2017 at 10:39:40AM +0100, Daniel P. Berrange wrote: > On Fri, Aug 11, 2017 at 03:15:59PM -0300, Eduardo Habkost wrote: > > On Fri, Aug 11, 2017 at 05:44:55PM +0100, Daniel P. Berrange wrote: > > > On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > > > > CCing Zack Co

Re: [Qemu-devel] [PULL 0/1] Doc fix for QEMU 2.10-rc3

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 09:42, Paolo Bonzini wrote: > The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-08-10 18:53:39 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn_report()

2017-08-14 Thread Markus Armbruster
Alistair Francis writes: > In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we > converted uses of error_report("warning:"... to use warn_report() > instead. This was to help standardise on a single method of printing > warnings to the user. > > There appears to have been some cases

Re: [Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 12:07, Michael Tokarev wrote: > From: Thomas Huth > > QEMU currently abort()s if the user tries to specify the mmio_interface > device without parameters: > > x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface > qemu-system-x86_64: /home/thuth/devel/qemu/util

Re: [Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-14 Thread Thomas Huth
On 14.08.2017 13:45, Peter Maydell wrote: > On 14 August 2017 at 12:07, Michael Tokarev wrote: >> From: Thomas Huth >> >> QEMU currently abort()s if the user tries to specify the mmio_interface >> device without parameters: >> >> x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface

Re: [Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 12:52, Thomas Huth wrote: > On 14.08.2017 13:45, Peter Maydell wrote: >> It seems like it should be an error to permit this to be >> created from the command line at all > That's also what thought first ... but the commit message of commit > 7cc2298c46a6afa4f4ff7e5cd262809c78

Re: [Qemu-devel] [PATCH v8 0/4] Improve error reporting

2017-08-14 Thread Markus Armbruster
Jason, did this fall through the cracks? Mao Zhongyi writes: > v8: > * PATCH 02 & 04 > -resetting the error message for the user to read. [Markus Armbruster] > -fix the indentation and commit message. [Markus Armbruster] > > v7: > * PATCH 01 > -fix the error message.[Daniel P. Be

Re: [Qemu-devel] [PATCH v8 0/4] Improve error reporting

2017-08-14 Thread Jason Wang
On 2017年08月14日 20:02, Markus Armbruster wrote: Jason, did this fall through the cracks? Unfortunately yes, consider it's rc3, I've queued this for 2.11. Thanks Mao Zhongyi writes: v8: * PATCH 02 & 04 -resetting the error message for the user to read. [Markus Armbruster] -fix th

[Qemu-devel] [PULL V2] Net patches

2017-08-14 Thread Jason Wang
The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

[Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-14 Thread Jason Wang
From: Thomas Huth The two HMP commands host_net_add and -remove have recently been marked as deprecated, too, so we should now mention them in the chapter of deprecated features. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-doc.texi | 8 1 file changed, 8 insertions(

Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-14 Thread Cornelia Huck
On Mon, 14 Aug 2017 20:09:15 +0800 Jason Wang wrote: > From: Thomas Huth > > The two HMP commands host_net_add and -remove have recently been > marked as deprecated, too, so we should now mention them in the > chapter of deprecated features. > > Signed-off-by: Thomas Huth > Signed-off-by: Jas

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

2017-08-14 Thread Manos Pitsidianakis
On Wed, Aug 09, 2017 at 05:39:42PM +0200, Kevin Wolf wrote: Am 09.08.2017 um 16:45 hat Alberto Garcia geschrieben: On Wed 09 Aug 2017 03:42:07 PM CEST, Manos Pitsidianakis wrote: > On Wed, Aug 09, 2017 at 02:36:20PM +0200, Alberto Garcia wrote: >>On Wed 09 Aug 2017 11:36:12 AM CEST, Manos Pitsid

Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-14 Thread Thomas Huth
On 14.08.2017 14:14, Cornelia Huck wrote: > On Mon, 14 Aug 2017 20:09:15 +0800 > Jason Wang wrote: > >> From: Thomas Huth >> >> The two HMP commands host_net_add and -remove have recently been >> marked as deprecated, too, so we should now mention them in the >> chapter of deprecated features. >

Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-14 Thread Jason Wang
On 2017年08月14日 20:21, Thomas Huth wrote: On 14.08.2017 14:14, Cornelia Huck wrote: On Mon, 14 Aug 2017 20:09:15 +0800 Jason Wang wrote: From: Thomas Huth The two HMP commands host_net_add and -remove have recently been marked as deprecated, too, so we should now mention them in the chapte

[Qemu-devel] [PULL V3] Net patches

2017-08-14 Thread Jason Wang
The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

[Qemu-devel] [PULL V3] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-14 Thread Jason Wang
From: Thomas Huth The two HMP commands host_net_add and -remove have recently been marked as deprecated, too, so we should now mention them in the chapter of deprecated features. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-doc.texi | 8 1 file changed, 8 insertions(

Re: [Qemu-devel] [PULL 0/7] Trivial patches for 2017-08-14

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 12:07, Michael Tokarev wrote: > There are just a few small thigs, I've omitted larger series for now. > > The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2017-08-

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

2017-08-14 Thread Eduardo Habkost
On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: > Currently, Using the fisrt node without memory on the machine makes > QEMU unhappy. With this example command line: > ... \ > -m 1024M,slots=4,maxmem=32G \ > -numa node,nodeid=0 \ > -numa node,mem=1024M,nodeid=1 \ > -numa node,

[Qemu-devel] [PATCH v3 03/12] ui: convert key events to QKeyCodes immediately

2017-08-14 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index af05f06368..64e9103a61

[Qemu-devel] [PATCH v3 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C

[Qemu-devel] [PATCH v3 07/12] input: convert the adb device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +- include/hw/input/adb-key

[Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread Daniel P. Berrange
An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html The keycodemap project[1] provides a database mapping between many different keysym/keycode/scancode sets, along with a tool to generat

[Qemu-devel] [PATCH v3 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-14 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v3 12/12] display: convert XenInput keyboard to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 133 - 1 file chang

[Qemu-devel] [PATCH v3 02/12] ui: convert common input code to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

[Qemu-devel] [PATCH v3 10/12] ui: convert the SDL2 frontend to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

[Qemu-devel] [PATCH v3 08/12] char: convert the escc device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++-- include/ui/input.h | 3 +

[Qemu-devel] [PATCH v3 04/12] ui: don't export qemu_input_event_new_key

2017-08-14 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

[Qemu-devel] [PATCH v3 11/12] ui: convert GTK and SDL1 frontends to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
The x_keycode_to_pc_keycode and evdev_keycode_to_pc_keycode tables are replaced with automatically generated tables. In addition the X11 heuristics are improved to detect running on XQuartz and XWin X11 servers, to activate the correct OS-X and Win32 keycode maps. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v3 09/12] ui: convert cocoa frontend to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the mac_to_qkeycode_map table with automatically generated table. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 3 ++ ui/Makefile.objs | 1 + ui/cocoa.m | 129 + ui/input-keymap.c | 1 + 4 files changed, 7

Re: [Qemu-devel] [PATCH v2 3/5] Convert single line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
Alistair Francis writes: > Convert all the single line uses of fprintf(stderr, "warning:"..."\n"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using this command: > find ./* -type f -exec sed

[Qemu-devel] [PATCH v3 06/12] input: convert ps2 device to keycodemapdb

2017-08-14 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN -> 0xe00

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb Type: series Message-id: 20170814124927.30134-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb Message-id: 20170814124927.30134-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170814124927.30134-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

[Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wei . yang
From: Wei Yang The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple output items(commit id: 1ecbb3d)" is introduced by Robert, the patch emits the AML filename as a zero-length string, and allows the compiler

Re: [Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-14 Thread Igor Mammedov
On Mon, 14 Aug 2017 12:45:16 +0100 Peter Maydell wrote: > On 14 August 2017 at 12:07, Michael Tokarev wrote: > > From: Thomas Huth > > > > QEMU currently abort()s if the user tries to specify the mmio_interface > > device without parameters: > > > > x86_64-softmmu/qemu-system-x86_64 -nographic

Re: [Qemu-devel] [PULL V3] Net patches

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 13:34, Jason Wang wrote: > The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2017-08-11 15:11:50 +0100) > > are available in the git repository at: > > https://gi

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
Alistair Francis writes: > Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using these commands: > find ./* -type f -exec se

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
PATCH 3/5 has the exact same subject. Why are the two separate? Alistair Francis writes: > Convert any remaining uses of fprintf(stderr, "warning:"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were chang

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread Programmingkid
> On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: > > An update of: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html > > The keycodemap project[1] provides a database mapping

Re: [Qemu-devel] [PATCH v6 11/19] migration: Start of multiple fd work

2017-08-14 Thread Daniel P. Berrange
On Mon, Aug 14, 2017 at 03:43:58PM +0200, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Tue, Aug 08, 2017 at 06:26:21PM +0200, Juan Quintela wrote: > >> We create new channels for each new thread created. We send through > >> them a string containing multifd so we are > >> sure that

Re: [Qemu-devel] [PATCH v6 11/19] migration: Start of multiple fd work

2017-08-14 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Tue, Aug 08, 2017 at 06:26:21PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. >> >> Signed-off-by: Juan Q

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-14 Thread Daniel P. Berrange
On Mon, Aug 14, 2017 at 09:39:56AM -0400, Programmingkid wrote: > > > On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: > > > > An update of: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/20

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

2017-08-14 Thread Fam Zheng
On Fri, 08/11 18:48, Kevin Wolf wrote: > The patch below implements what I was thinking of, and it seems to fix > this problem. However, you'll immediately run into the next one, which > is a message like 'Conflicts with use by ide0-hd0 as 'root', which does > not allow 'write' on #block172'. > >

Re: [Qemu-devel] [PATCH V2 for-2.10] xlnx-qspi: add a property for mmio-execution

2017-08-14 Thread Peter Maydell
On 11 August 2017 at 15:29, Edgar E. Iglesias wrote: > On Fri, Aug 11, 2017 at 09:54:12AM +0200, KONRAD Frederic wrote: >> This adds mmio-exec property to workaround the migration bug. >> When enabled the migration is blocked and will return an error. >> >> Signed-off-by: KONRAD Frederic > > Than

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

2017-08-14 Thread Paolo Bonzini
On 14/08/2017 13:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> On 13/08/2017 19:04, BALATON Zoltan wrote: >>> Signed-off-by: BALATON Zoltan >>> --- >>> hw/ppc/Makefile.objs | 2 +- >>> hw/ppc/ppc405.h | 2 + >>> hw/ppc/ppc405_uc.c | 241 >>> --

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-14 Thread Markus Armbruster
Vadim Galitsyn writes: > Command above provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amount of memory that was hot-plugged. > If target does not have CONFIG_MEM_HOTPLUG ena

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

2017-08-14 Thread Peter Maydell
On 14 August 2017 at 12:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> Can you move it to hw/i2c while you're at it? > I could if that's the preferred way but I've left it in hw/ppc because this > is not a generic device but specific to PPC SoCs and it was easier > to wo

  1   2   3   >