On 14.08.2017 13:45, Peter Maydell wrote: > On 14 August 2017 at 12:07, Michael Tokarev <m...@tls.msk.ru> wrote: >> From: Thomas Huth <th...@redhat.com> >> >> QEMU currently abort()s if the user tries to specify the mmio_interface >> device without parameters: >> >> x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface >> qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv: >> Assertion `*errp == ((void *)0)' failed. >> Aborted (core dumped) >> >> This happens because the realize function is trying to set the errp >> twice in this case. After setting an error, the realize function >> should immediately return instead. > > It seems like it should be an error to permit this to be > created from the command line at all That's also what thought first ... but the commit message of commit 7cc2298c46a6afa4f4ff7e5cd262809c782d701b says that it "can be hotplugged/hotunplugged" ? ... that's confusing ...
Frederic, I think some more comments in the header of the file would be really useful here. Thomas
