On 14 August 2017 at 12:18, BALATON Zoltan <bala...@eik.bme.hu> wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> Can you move it to hw/i2c while you're at it?
> I could if that's the preferred way but I've left it in hw/ppc because this > is not a generic device but specific to PPC SoCs and it was easier > to work with files in one dir than scattered through the tree. Should I > still move it to hw/i2c? Yeah, when you have a device that's both "type X" and "architecture Y" you can't put it both in hw/Y and hw/X, and the choice we've made is that hw/$ARCH is for: * board models * SoC container objects which just instantiate other devices and "leaf" devices go under the relevand hw/$CATEGORY (which may be hw/misc if nothing more appropriate exists). It's a little bit arbitrary, but it follows a similar practice in the Linux kernel source tree layout. thanks -- PMM