[Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-19 Thread Peng Hao
When a guest that has several hotplugged dimms is migrated, in destination host it will fail to resume. Because vhost regions of several dimms in source host are merged and in the restore stage in destination host it computes whether more than vhost slot limit before merging vhost regions of severa

Re: [Qemu-devel] [PATCH RFC v2 8/9] s390x/kvm: msi route fixup for non-pci

2017-07-19 Thread Thomas Huth
On 19.07.2017 05:16, Yi Min Zhao wrote: > > > 在 2017/7/18 下午11:22, Cornelia Huck 写道: >> On Tue, 18 Jul 2017 11:58:08 -0300 >> Philippe Mathieu-Daudé wrote: >> >>> Hi Cornelia, >>> >>> On Tue, Jul 18, 2017 at 11:24 AM, Cornelia Huck >>> wrote: If we don't provide pci, we cannot have a pci d

Re: [Qemu-devel] Hacks for building on gcc 7 / Fedora 26

2017-07-19 Thread Thomas Huth
On 18.07.2017 17:10, Eric Blake wrote: > On 07/18/2017 10:04 AM, Philippe Mathieu-Daudé wrote: >>> We should be consistent -- if we can't trust assert() to >>> be marked nonreturn, as it seems we can't, then we shouldn't >>> write new code that assumes it always is, even if today >>> it doesn't hap

[Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Markus Armbruster
QMP command { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": PWD } } behaves just like { "execute": "change-vnc-password", "arguments": { "password", "arg": PWD } } Their documentation differs, however. According to change-vnc-password's d

Re: [Qemu-devel] [PATCH 4/4] target/i386: Don't use x86_cpu_load_def() on "max" CPU model

2017-07-19 Thread Igor Mammedov
On Tue, 18 Jul 2017 21:02:06 -0300 Eduardo Habkost wrote: > On Tue, Jul 18, 2017 at 03:27:26PM +0200, Igor Mammedov wrote: > > On Wed, 12 Jul 2017 13:20:58 -0300 > > Eduardo Habkost wrote: > > > > > When commit 0bacd8b3046f ('i386: Don't set CPUClass::cpu_def on > > > "max" model') removed the

Re: [Qemu-devel] Question for iotests 188, 189 and 087

2017-07-19 Thread Jing Liu
On 2017/7/19 上午2:07, John Snow wrote: On 07/17/2017 11:01 PM, Jing Liu wrote: Hi all, Do you anybody have iotests failure: 188, 189 and 087 of the latest qemu upsteam? I just wondered if it has something wrong with my test machines because I have different results with two machines. Thank

[Qemu-devel] [PATCH V3 3/4] net/colo-compare.c: Adjust net queue pop order for performance

2017-07-19 Thread Zhang Chen
The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen --- net/

[Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-07-19 Thread Zhang Chen
In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V3: - Rebase on upstream. - Remove origin p2. - Move the "checkpoint_time_ms" to CompareState, in order to aviod multi colo-compare instance conflict. - Add "TODO comments" for reset s->checkp

[Qemu-devel] [PATCH V3 4/4] net/colo-compare.c: Fix comments and scheme

2017-07-19 Thread Zhang Chen
Signed-off-by: Zhang Chen --- net/colo-compare.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 58c3250..d10abb2 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -47,7 +47,7 @@ + CompareState ++

[Qemu-devel] [PATCH V3 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-19 Thread Zhang Chen
If colo-compare find out the first different packet that means the following packet almost is different. we needn't do a lot of checkpoint in this time, so we set the no-need-checkpoint peroid, default just set 3 second. Signed-off-by: Zhang Chen --- net/colo-compare.c | 21 -

[Qemu-devel] [PATCH V3 2/4] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-07-19 Thread Zhang Chen
When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the option field. Signed-off-by: Zhang Chen --- net/colo-com

Re: [Qemu-devel] [PATCH RFC v2 8/9] s390x/kvm: msi route fixup for non-pci

2017-07-19 Thread Cornelia Huck
On Wed, 19 Jul 2017 09:09:11 +0200 Thomas Huth wrote: > On 19.07.2017 05:16, Yi Min Zhao wrote: > > > > > > 在 2017/7/18 下午11:22, Cornelia Huck 写道: > >> On Tue, 18 Jul 2017 11:58:08 -0300 > >> Philippe Mathieu-Daudé wrote: > >> > >>> Hi Cornelia, > >>> > >>> On Tue, Jul 18, 2017 at 11:24 AM

[Qemu-devel] [PATCH] error: Revert unwanted change of warning messages

2017-07-19 Thread Markus Armbruster
Commit 97f4030 changed warning messages from timestamp-if-enabled progname ":" location "warning: " message to "warning: " timestamp-if-enabled progname ":" location message This regressed qemu-iotests 051. Put "warning: " right back where it was, along with "info: ". Reported-by: Kev

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Wed, 19 Jul 2017 12:25:53 +0800 (CST) wrote: > >On Mon, 17 Jul 2017 21:49:37 -0400 > > >Yi Wang wrote: > > > > > >> Add [vcpu] index support for hmp command "info lapic", which is > > >> useful when debugging ipi and so on. Current behavior is not > > >> changed when the parameter isn't

Re: [Qemu-devel] [PATCH RFC v2 7/9] s390x/pci: fence off instructions for non-pci

2017-07-19 Thread Cornelia Huck
[restored cc: list] On Wed, 19 Jul 2017 11:21:30 +0800 Yi Min Zhao wrote: > 在 2017/7/18 下午10:24, Cornelia Huck 写道: > > If a guest running on a machine without zpci issues a pci instruction, > > throw them an exception. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/kvm.c | 54

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Tue, 18 Jul 2017 20:26:50 -0300 Eduardo Habkost wrote: > On Tue, Jul 18, 2017 at 04:54:17PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jul 2017 21:49:37 -0400 > > Yi Wang wrote: > > > > > Add [vcpu] index support for hmp command "info lapic", which is > > > useful when debugging ipi and so o

Re: [Qemu-devel] [PATCH RFC v2 2/9] s390x/pci: add stubs

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > Some non-pci code calls into zpci code. Provide some stubs for builds > without pci. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/Makefile.objs | 3 +- > hw/s390x/s390-pci-stub.c | 74 > > 2 fil

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-19 Thread Igor Mammedov
On Wed, 19 Jul 2017 23:17:32 +0800 Peng Hao wrote: > When a guest that has several hotplugged dimms is migrated, in > destination host it will fail to resume. Because vhost regions of > several dimms in source host are merged and in the restore stage > in destination host it computes whether more

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-19 Thread Fam Zheng
On Tue, 07/18 10:42, Daniel P. Berrange wrote: > On Tue, Jul 18, 2017 at 10:37:30AM +0100, Peter Maydell wrote: > > On 18 July 2017 at 10:11, Thomas Huth wrote: > > > Could the test be rewritten to provide a proper timeout handling > > > instead? Tests should clearly fail after a while instead of

Re: [Qemu-devel] [PATCH RFC v2 0/9] s390x: zPCI detangling

2017-07-19 Thread Cornelia Huck
On Tue, 18 Jul 2017 12:18:56 -0700 (PDT) no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH RFC v2 0/9

Re: [Qemu-devel] [PATCH RFC v2 3/9] s390x: chsc nt2 events are pci-only

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > The nt2 event class is pci-only - don't look for events if pci is > not in the active cpu model. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-pci-bus.c | 4 ++-- > hw/s390x/s390-pci-bus.h | 4 ++-- > hw/s390x/s390-pci-stub.c | 4 ++-- >

Re: [Qemu-devel] [PATCH RFC v2 5/9] s390x/ccw: create s390 phb conditionally

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > Don't create the s390 pci host bridge if we do not provide the zpci > facility. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-virtio-ccw.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Cornelia Huck
On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: > On 07/18/2017 04:24 PM, Cornelia Huck wrote: > > Only set the zpci and aen feature bits on builds that actually > > support pci. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/kvm.c | 2 ++ > > 1 file changed, 2 i

Re: [Qemu-devel] [PATCH RFC v2 6/9] s390x/sclp: properly guard pci-specific functions

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > If we do not provide zpci, pci reconfiguration via sclp is not available > either. Don't indicate it in the sclp facilities and return an invalid > command if the guest tries to issue pci configure/deconfigure. > > Signed-off-by: Cornelia Huck > --- >

Re: [Qemu-devel] [PATCH RFC v2 3/9] s390x: chsc nt2 events are pci-only

2017-07-19 Thread Cornelia Huck
On Wed, 19 Jul 2017 09:57:47 +0200 Thomas Huth wrote: > Hmm, since you're having wrapper functions for these now anyway, I > wonder whether it would be more elegant to make > pci_chsc_sei_nt2_get_event() and pci_chsc_sei_nt2_have_event() function > pointers in the S390pciState object instead. The

Re: [Qemu-devel] [PULL 1/2] util/aio-win32: Only select on what we are actually waiting for

2017-07-19 Thread Alistair Francis
On Mon, Jul 17, 2017 at 7:23 PM, Paolo Bonzini wrote: >> +if (io_read) { >> +bitmask |= FD_READ | FD_ACCEPT | FD_CLOSE; >> +} >> + >> +if (io_write) { >> +bitmask |= FD_WRITE | FD_CONNECT; >> +} >> + >> event = event_notifier_get_han

Re: [Qemu-devel] [PATCH RFC v2 7/9] s390x/pci: fence off instructions for non-pci

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > If a guest running on a machine without zpci issues a pci instruction, > throw them an exception. > > Signed-off-by: Cornelia Huck > --- > target/s390x/kvm.c | 54 > +- > 1 file changed, 41 insertion

Re: [Qemu-devel] [PATCH] error: Revert unwanted change of warning messages

2017-07-19 Thread Alistair Francis
On Wed, Jul 19, 2017 at 9:33 AM, Markus Armbruster wrote: > Commit 97f4030 changed warning messages from > > timestamp-if-enabled progname ":" location "warning: " message > > to > > "warning: " timestamp-if-enabled progname ":" location message > > This regressed qemu-iotests 051. Put "w

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Dr. David Alan Gilbert
* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: > Hi Eduardo, > > Thank you for your reply! > > >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > > >> Add [vcpu] index support for hmp command "info lapic", which is > > >> useful when debugging ipi and so on. Current behavior is n

Re: [Qemu-devel] [PULL v1 00/18] Merge crypto 201/07/18

2017-07-19 Thread Peter Maydell
On 18 July 2017 at 11:25, Daniel P. Berrange wrote: > The following changes since commit 6c6076662d98c068059983d411cb2a8987ba5670: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-07-14 12:16:09 +0100) > > are available in the git repository at: > > gi

[Qemu-devel] 答复: Re: [PATCH] vhost: fix a migration failed because ofvhost region merge

2017-07-19 Thread peng.hao2
发件人: 收件人:彭浩10096742 抄送人: 王业超10154425 日 期 :2017年07月19日 15:51 主 题 :Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because ofvhost region merge On Wed, 19 Jul 2017 23:17:32 +0800 Peng Hao wrote: > When a guest that has several hotplugged dimms is migrated, in > destination host it wi

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-19 Thread Michal Hocko
On Tue 18-07-17 10:12:14, Wei Wang wrote: [...] > Probably I should have included the introduction of the usages in > the log. Hope it is not too later to explain here: Yes this should have been described in the cover. > Live migration needs to transfer the VM's memory from the source > machine

[Qemu-devel] [PATCH] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-07-19 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu --- qga/commands-posix.c | 72 +++- qga/qapi-sc

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-19 Thread Peter Maydell
On 18 July 2017 at 23:01, Eric Blake wrote: > On 07/18/2017 11:26 AM, Peter Maydell wrote: >> On OpenBSD the compiler warns: >> bsd-user/main.c:622:21: warning: variable 'sig' set but not used >> [-Wunused-but-set-variable] >> >> This is because a lot of the signal delivery code is #if-0'd >> out

Re: [Qemu-devel] [PULL v1 00/18] Merge crypto 201/07/18

2017-07-19 Thread Daniel P. Berrange
On Wed, Jul 19, 2017 at 09:11:17AM +0100, Peter Maydell wrote: > On 18 July 2017 at 11:25, Daniel P. Berrange wrote: > > The following changes since commit 6c6076662d98c068059983d411cb2a8987ba5670: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (2017-0

Re: [Qemu-devel] [PULL 00/16] Migration

2017-07-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > no-re...@patchew.org wrote: > > Hi, > > > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it > > locally. > > > cc: unrecognized

Re: [Qemu-devel] [PATCH v2] qapi: Fix error handling code on alternate conflict

2017-07-19 Thread Markus Armbruster
Eduardo Habkost writes: > The conflict check added by commit c0644771 ("qapi: Reject > alternates that can't work with keyval_parse()") doesn't work > with the following declaration: > > { 'alternate': 'Alt', > 'data': { 'one': 'bool', > 'two': 'str' } } > > It crashes with: >

Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default

2017-07-19 Thread Daniel P. Berrange
On Tue, Jul 18, 2017 at 09:24:08PM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> migrate-set-parameters sets migration parameters according to is > >> arguments like this: > >> > >> * Present means "set the parameter

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

2017-07-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge Message-id: 1500477452-59643-1-git-

Re: [Qemu-devel] [PULL v1 00/18] Merge crypto 201/07/18

2017-07-19 Thread Daniel P. Berrange
On Wed, Jul 19, 2017 at 09:28:01AM +0100, Daniel P. Berrange wrote: > On Wed, Jul 19, 2017 at 09:11:17AM +0100, Peter Maydell wrote: > > On 18 July 2017 at 11:25, Daniel P. Berrange wrote: > > > The following changes since commit > > > 6c6076662d98c068059983d411cb2a8987ba5670: > > > > > > Merge

Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge

2017-07-19 Thread Stefan Hajnoczi
On Thu, Jul 13, 2017 at 01:33:43AM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 11:13:05PM +0200, Jens Freimann wrote: > > On Wed, Jul 12, 2017 at 06:10:05PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jul 12, 2017 at 11:41:46AM +0200, Jens Freimann wrote: > > > > This implements a

[Qemu-devel] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

2017-07-19 Thread Kevin Wolf
Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet, it shouldn't be affected by added nodes. This is true as far

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread wang.yi59
>* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: >> Hi Eduardo, >> >> Thank you for your reply! >> >> >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: >> >> >> Add [vcpu] index support for hmp command "info lapic", which is >> >> >> useful when debugging ipi and so on. C

Re: [Qemu-devel] [PATCH RFC v2 7/9] s390x/pci: fence off instructions for non-pci

2017-07-19 Thread Cornelia Huck
On Wed, 19 Jul 2017 10:07:53 +0200 Thomas Huth wrote: > On 18.07.2017 16:24, Cornelia Huck wrote: > > If a guest running on a machine without zpci issues a pci instruction, > > throw them an exception. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/kvm.c | 54 > > ++

[Qemu-devel] [FIX PATCH] spapr: Fix QEMU abort during memory unplug

2017-07-19 Thread Bharata B Rao
Commit 0cffce56 (hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState) introduced a new way to track pending LMBs of DIMM device that is marked for removal. Since this commit we can hit the assert in spapr_pending_dimm_unplugs_add() in the following situation: - DIMM device removal fai

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set the zpci and aen feature bits on builds that actually support pci. Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 2 ++ 1 f

Re: [Qemu-devel] [PATCH 0/14] target/mips: Add Enhanced Virtual Addressing (EVA) support

2017-07-19 Thread James Hogan
On Tue, Jul 18, 2017 at 02:21:20PM -0700, no-re...@patchew.org wrote: > Checking PATCH 2/14: target/mips: Fix TLBWI shadow flush for EHINV, XI, RI... > ERROR: space prohibited after that '&' (ctx:WxW) > #44: FILE: target/mips/op_helper.c:2045: > +XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1; >

[Qemu-devel] [PULL v2 04/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for builtin-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/cipher-builtin.c | 101 ++-- 1 file change

[Qemu-devel] [PULL v2 02/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for gcrypt-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/cipher-gcrypt.c | 50 +- 1 file changed

[Qemu-devel] [PULL v2 00/18] Merge crypto 201/07/18

2017-07-19 Thread Daniel P. Berrange
The following changes since commit 6887dc6700ccb7820d8a9d370f421ee361c748e8: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20170718' into staging (2017-07-18 21:13:48 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2017-07-18-2

[Qemu-devel] [PULL v2 08/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" 1) Fix a handle-leak problem in qcrypto_hmac_new(), didn't free ctx->handle if gcry_mac_setkey fails. 2) Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for gcrypt-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. B

[Qemu-devel] [PULL v2 01/18] crypto: cipher: introduce context free function

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Refactors the qcrypto_cipher_free(), splits it into two parts. One is gcrypt/nettle__cipher_free_ctx() to free the special context. This makes code more clear, what's more, it would be used by the later patch. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-of

[Qemu-devel] [PULL v2 18/18] tests: crypto: add hmac speed benchmark support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add a hmac speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-hmac" directly. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- tests/.gitignore | 1 + tests/M

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Wed, 19 Jul 2017 16:48:23 +0800 (CST) wrote: > >* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: > > > >> Hi Eduardo, > > >> > > >> Thank you for your reply! > > >> > > >> >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > > >> > > >> >> Add [vcpu] index s

[Qemu-devel] [PULL v2 03/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for nettle-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/cipher-nettle.c | 41 + 1 file changed, 29 inse

[Qemu-devel] [PULL v2 06/18] crypto: hash: add hash driver framework

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" 1) makes the public APIs in hash-nettle/gcrypt/glib static, and rename them with "nettle/gcrypt/glib" prefix. 2) introduces hash framework, including QCryptoHashDriver and new public APIs. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P.

[Qemu-devel] [PULL v2 07/18] crypto: hmac: move crypto/hmac.h into include/crypto/

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Moves crypto/hmac.h into include/crypto/, likes cipher.h and hash.h Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- {crypto => include/crypto}/hmac.h | 0 1 file changed, 0 insertions(+), 0 d

[Qemu-devel] [PULL v2 05/18] crypto: cipher: add cipher driver framework

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" 1) makes the public APIs in cipher-nettle/gcrypt/builtin static, and rename them with "nettle/gcrypt/builtin" prefix. 2) introduces cipher framework, including QCryptoCipherDriver and new public APIs. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-b

[Qemu-devel] [PULL v2 09/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for nettle-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-nettle.c | 34 -- 1 file changed, 24 insertions(+), 10

[Qemu-devel] [PULL v2 15/18] crypto: hmac: add af_alg-backend hmac support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Adds afalg-backend hmac support: introduces some private APIs firstly, and then intergrates them into qcrypto_hmac_afalg_driver. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hash-afalg.c | 104 +--

[Qemu-devel] [PULL v2 10/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for glib-backend impls. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-glib.c | 34 -- 1 file changed, 24 insertions(+), 10 del

[Qemu-devel] [PULL v2 13/18] crypto: cipher: add afalg-backend cipher support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Adds afalg-backend cipher support: introduces some private APIs firstly, and then intergrates them into qcrypto_cipher_afalg_driver. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs | 1 + crypto/afalgpriv.h| 9 ++ crypto

[Qemu-devel] [PULL v2 11/18] crypto: hmac: add hmac driver framework

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" 1) makes the public APIs in hmac-nettle/gcrypt/glib static, and rename them with "nettle/gcrypt/glib" prefix. 2) introduces hmac framework, including QCryptoHmacDriver and new public APIs. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto

[Qemu-devel] [PULL v2 16/18] tests: crypto: add cipher speed benchmark support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Now we have two qcrypto backends, libiary-backend and afalg-backend, but which one is faster? This patch add a cipher speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-cipher" directly. Signed-off-by: Lon

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午5:24, Cornelia Huck 写道: On Wed, 19 Jul 2017 16:56:18 +0800 Yi Min Zhao wrote: 在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set the zpci and aen feature bits on buil

[Qemu-devel] [PULL v2 12/18] crypto: introduce some common functions for af_alg backend

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" The AF_ALG socket family is the userspace interface for linux crypto API, this patch adds af_alg family support and some common functions for af_alg backend. It'll be used by afalg-backend crypto latter. Signed-off-by: Longpeng(Mike) Maintainer: modified to report an err

Re: [Qemu-devel] [PULL v1 00/18] Merge crypto 201/07/18

2017-07-19 Thread Daniel P. Berrange
On Wed, Jul 19, 2017 at 09:11:17AM +0100, Peter Maydell wrote: > On 18 July 2017 at 11:25, Daniel P. Berrange wrote: > > The following changes since commit 6c6076662d98c068059983d411cb2a8987ba5670: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (2017-0

[Qemu-devel] [PULL v2 14/18] crypto: hash: add afalg-backend hash support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Adds afalg-backend hash support: introduces some private APIs firstly, and then intergrates them into qcrypto_hash_afalg_driver. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs | 1 + crypto/afalgpriv.h | 1 + crypto/hash-a

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Cornelia Huck
On Wed, 19 Jul 2017 16:56:18 +0800 Yi Min Zhao wrote: > 在 2017/7/19 下午4:00, Cornelia Huck 写道: > > On Tue, 18 Jul 2017 21:56:26 +0200 > > Christian Borntraeger wrote: > > > >> On 07/18/2017 04:24 PM, Cornelia Huck wrote: > >>> Only set the zpci and aen feature bits on builds that actually > >

Re: [Qemu-devel] [PATCH v2 00/45] tcg: support for multiple TCG contexts

2017-07-19 Thread Alex Bennée
Richard Henderson writes: > On 07/18/2017 02:22 PM, jiang.bi...@zte.com.cn wrote: >> Seeing your work on multiple TCG, it seems that it has some kind of >> connection with the MTTCG feature, >> >> but I do not figure out how they are connected in detail. >> >> Could you pls help to confirm the

[Qemu-devel] [PULL v2 17/18] tests: crypto: add hash speed benchmark support

2017-07-19 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add a hash speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-hash" directly. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- tests/.gitignore | 1 + tests/M

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

2017-07-19 Thread Manos Pitsidianakis
On Wed, Jul 19, 2017 at 10:44:47AM +0200, Kevin Wolf wrote: Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet,

Re: [Qemu-devel] [PATCH] error: Revert unwanted change of warning messages

2017-07-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] error: Revert unwanted change of warning messages Message-id: 1500449614-16811-1-git-send-email-

[Qemu-devel] [qemu-trace] how to add trace easily?

2017-07-19 Thread Sam
Hi all, I'm debugging qemu start up process, I want to add a log in 'io_mem_init' function in exce.c as bellow: > static void io_mem_init(void) > { > ADD_LOG_HERE_TO_RECORD_TIME(); > memory_region_init_io(&io_mem_rom, NULL, &unassigned_mem_ops, NULL, > NULL, UINT64_MAX); > memory_regi

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午5:27, Yi Min Zhao 写道: 在 2017/7/19 下午5:24, Cornelia Huck 写道: On Wed, 19 Jul 2017 16:56:18 +0800 Yi Min Zhao wrote: 在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set t

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

2017-07-19 Thread Kevin Wolf
[ Cc: qemu-stable ] Am 19.07.2017 um 11:21 hat Manos Pitsidianakis geschrieben: > On Wed, Jul 19, 2017 at 10:44:47AM +0200, Kevin Wolf wrote: > >Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > >nodes above the top layer of mirror and commit block jobs. The > >assumption

Re: [Qemu-devel] [PULL v1 0/1] Merge I/O 2017/07/18

2017-07-19 Thread Peter Maydell
On 18 July 2017 at 11:32, Daniel P. Berrange wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: > > git:/

[Qemu-devel] [PATCH v1 3/5] target/s390x: introduce (test|set)_be_bit

2017-07-19 Thread David Hildenbrand
Using ordinary bitmap operations to set/test bits does not work properly on architectures !s390x. Let's drop (test|set)_bit_inv and introduce (test|set)_be_bit instead. These functions work on uint8_t array, not on unsigned longs arrays and are for now only used in the context of CPU features. Sig

[Qemu-devel] [PATCH v1 4/5] s390x/kvm: better comment regarding zPCI feature availability

2017-07-19 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- target/s390x/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index fe02315..3d0b7b3 100644 --- a/target/s390x/kvm.c +++ b/target/s390x/kvm.c @@ -2661,7 +2661,7 @@ void kvm_s390_get_host_cpu_mode

[Qemu-devel] [PATCH v1 0/5] target/s390x: cpu model cleanups + improvements

2017-07-19 Thread David Hildenbrand
We want to reuse e.g. s390_get_feat_block() in tcg. Turns out, that set_bit_inv() doesn't work as expected on other architectures (if we want to expose the uint8_t[] based data to the VM later), so let's fix that. Some other minor cleanups, including better baselining support if one of the MSA sub

Re: [Qemu-devel] [PATCH v1 4/5] s390x/kvm: better comment regarding zPCI feature availability

2017-07-19 Thread Christian Borntraeger
On 07/19/2017 11:50 AM, David Hildenbrand wrote: > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > target/s390x/kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > index fe02315..3d0b7b3 100644 > ---

[Qemu-devel] [PATCH v1 5/5] target/s390x: improve baselining if certain base features are missing

2017-07-19 Thread David Hildenbrand
There are certain features that we put into base models, but that are not relevant for the actual search. The most famous example are MSA subfunctions that might be disabled on certain real hardware out there. While the kvm host model detection will usually detect the correct model on such machine

[Qemu-devel] [PATCH v1 1/5] target/s390x: drop BE_BIT()

2017-07-19 Thread David Hildenbrand
Unused and broken, let's just get rid of it. Signed-off-by: David Hildenbrand --- target/s390x/cpu_features.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h index 14bc311..770435e 100644 --- a/target/s390x/cpu_features.h +++ b/target/

[Qemu-devel] [PATCH v1 2/5] target/s390x: indicate query subfunction in s390_fill_feat_block

2017-07-19 Thread David Hildenbrand
We'll have to do the same for TCG, so let's just move it in there. Signed-off-by: David Hildenbrand --- target/s390x/cpu_features.c | 31 ++- target/s390x/kvm.c | 13 - 2 files changed, 26 insertions(+), 18 deletions(-) diff --git a/target/s390x/

Re: [Qemu-devel] [PATCH v1 1/5] target/s390x: drop BE_BIT()

2017-07-19 Thread Christian Borntraeger
On 07/19/2017 11:50 AM, David Hildenbrand wrote: > Unused and broken, let's just get rid of it. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > target/s390x/cpu_features.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/s390x/cpu_features.h b/targe

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Marc-André Lureau
Hi On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster wrote: > QMP command > > { "execute": "change", > "arguments": { "device": "vnc", "target": "password", "arg": PWD } } > > behaves just like > > { "execute": "change-vnc-password", > "arguments": { "password", "arg": PWD }

[Qemu-devel] [PATCH v5 0/2 (for 2.10] Document deprecated features & support lifecycle

2017-07-19 Thread Daniel P. Berrange
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg00651.html v4: https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-19 Thread Daniel P. Berrange
There is currently no explicit guidance on the duration of support for features such as versioned machine types, which have a finite useful lifespan. Thus apps / users cannot predict how much time they might be able to use a feature for, before it is removed (if ever). This adds a new appendix tha

[Qemu-devel] [PATCH v5 2/2 (for 2.10)] docs: document deprecated features in appendix

2017-07-19 Thread Daniel P. Berrange
The deprecation of features in QEMU is totally adhoc currently, with no way for the user to get a list of what is deprecated in each release. This adds an appendix to the doc that records when each deprecation was made and provides text explaining what to use instead, if anything. Since there has

Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-07-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance Message-id: 1500449399-19107-1-git-send-email-zhangchen.f...@cn.fujitsu.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 1/14] target/mips: Fix MIPS64 MFC0 UserLocal on BE host

2017-07-19 Thread Aurelien Jarno
On 2017-07-18 12:55, James Hogan wrote: > Using MFC0 to read CP0_UserLocal uses tcg_gen_ld32s_tl, however > CP0_UserLocal is a target_ulong. On a big endian host with a MIPS64 > target this reads and sign extends the more significant half of the > 64-bit register. > > Fix this by using ld_tl to lo

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2017-07-19 Thread Imatimba
I can confirm the same behavior with a Ryzen 7 1700. Host Arch Linux x64 Kernel 4.11.9, Guest Windows 10 Pro. Running with -cpu host and -smp 8,sockets=1,cores=4,threads=2. Attached the logs of the host and results of the output of msinfo32 and "WMIC CPU Get NumberOfCores,NumberOfLogicalProcessors

Re: [Qemu-devel] host side todo list for virtio rdma

2017-07-19 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > Here are some thoughts on bits that are still missing to get a working > virtio-rdma, with some suggestions. These are very preliminary but I > feel I kept these in my head (and discussed offline) for too long. All > of the below is just my personal h

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-19 Thread Liu, Yi L
On Mon, Jul 17, 2017 at 04:45:15PM -0600, Alex Williamson wrote: > On Mon, 17 Jul 2017 10:58:41 + > "Liu, Yi L" wrote: > > > Hi Alex, > > > > Pls refer to the response inline. > > > > > -Original Message- > > > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On >

Re: [Qemu-devel] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

2017-07-19 Thread Peter Krempa
On Wed, Jul 19, 2017 at 10:44:47 +0200, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer

Re: [Qemu-devel] [PATCH v1 2/5] target/s390x: indicate query subfunction in s390_fill_feat_block

2017-07-19 Thread Christian Borntraeger
On 07/19/2017 11:50 AM, David Hildenbrand wrote: > We'll have to do the same for TCG, so let's just move it in there. > > Signed-off-by: David Hildenbrand looks sane. Reviewed-by: Christian Borntraeger > --- > target/s390x/cpu_features.c | 31 ++- > target/s390x/k

Re: [Qemu-devel] [PULL 00/21] Block layer patches

2017-07-19 Thread Peter Maydell
On 18 July 2017 at 15:17, Kevin Wolf wrote: > The following changes since commit 718d7f4f9cf772e5784093d8e6085680a235acdb: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-07-18 13:09:51 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH v1 3/5] target/s390x: introduce (test|set)_be_bit

2017-07-19 Thread Christian Borntraeger
On 07/19/2017 11:50 AM, David Hildenbrand wrote: > Using ordinary bitmap operations to set/test bits does not work properly > on architectures !s390x. Let's drop (test|set)_bit_inv and introduce > (test|set)_be_bit instead. These functions work on uint8_t array, not on > unsigned longs arrays and a

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Thomas Huth
On 18.07.2017 16:24, Cornelia Huck wrote: > Only set the zpci and aen feature bits on builds that actually > support pci. > > Signed-off-by: Cornelia Huck > --- > target/s390x/kvm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > index 831492

[Qemu-devel] [Bug 1333216] Re: Xen 4.4 with qemu 1.6.2 VGA passthru NVIDIA

2017-07-19 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? If so, have you already tried to report it to the folks from the Xen project? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

  1   2   3   4   >